hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

ALSA: pcm: snd_interval_step: drop the min parameter 

The min parameter was not used by any caller.  And if it were used,
underflows in the calculations could lead to incorrect results.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
This commit is contained in:
Clemens Ladisch 2014-09-07 21:43:07 +02:00 committed by Takashi Iwai
parent d89c6c0c91
commit 0f519b6221
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sound/core/pcm_lib.c
View File

@ -1113,16 +1113,16 @@ int snd_interval_list(struct snd_interval *i, unsigned int count,
EXPORT_SYMBOL(snd_interval_list); EXPORT_SYMBOL(snd_interval_list);
static int snd_interval_step(struct snd_interval *i, unsigned int min, unsigned int step) static int snd_interval_step(struct snd_interval *i, unsigned int step)
{ {
unsigned int n; unsigned int n;
int changed = 0; int changed = 0;
n = (i->min - min) % step; n = i->min % step;
if (n != 0 || i->openmin) { if (n != 0 || i->openmin) {
i->min += step - n; i->min += step - n;
changed = 1; changed = 1;
} }
n = (i->max - min) % step; n = i->max % step;
if (n != 0 || i->openmax) { if (n != 0 || i->openmax) {
i->max -= n; i->max -= n;
changed = 1; changed = 1;
@ -1427,7 +1427,7 @@ static int snd_pcm_hw_rule_step(struct snd_pcm_hw_params *params,
struct snd_pcm_hw_rule *rule) struct snd_pcm_hw_rule *rule)
{ {
unsigned long step = (unsigned long) rule->private; unsigned long step = (unsigned long) rule->private;
return snd_interval_step(hw_param_interval(params, rule->var), 0, step); return snd_interval_step(hw_param_interval(params, rule->var), step);
} }
/** /**