hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

checkpatch: don't ask for asm/file.h to linux/file.h unconditionally 

Currently checkpatch warns when asm/file.h is included and linux/file.h
exists.  That conversion can be made when linux/file.h includes asm/file.h
which is not always the case.(See signal.h)

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Cc: Andy Whitcroft <apw@canonical.com>
Acked-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Fabian Frederick 2015-04-16 12:44:25 -07:00 committed by Linus Torvalds
parent ab7e23f344
commit 0e212e0a72
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
scripts/checkpatch.pl
View File

@ -4242,7 +4242,8 @@ sub process {
} }
} }
#warn if <asm/foo.h> is #included and <linux/foo.h> is available (uses RAW line) # warn if <asm/foo.h> is #included and <linux/foo.h> is available and includes
# itself <asm/foo.h> (uses RAW line)
if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) { if ($tree && $rawline =~ m{^.\s*\#\s*include\s*\<asm\/(.*)\.h\>}) {
my $file = "$1.h"; my $file = "$1.h";
my $checkfile = "include/linux/$file"; my $checkfile = "include/linux/$file";
@ -4250,12 +4251,15 @@ sub process {
$realfile ne $checkfile && $realfile ne $checkfile &&
$1 !~ /$allowed_asm_includes/) $1 !~ /$allowed_asm_includes/)
{ {
if ($realfile =~ m{^arch/}) { my $asminclude = `grep -Ec "#include\\s+<asm/$file>" $root/$checkfile`;
CHK("ARCH_INCLUDE_LINUX", if ($asminclude > 0) {
"Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr); if ($realfile =~ m{^arch/}) {
} else { CHK("ARCH_INCLUDE_LINUX",
WARN("INCLUDE_LINUX", "Consider using #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
"Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr); } else {
WARN("INCLUDE_LINUX",
"Use #include <linux/$file> instead of <asm/$file>\n" . $herecurr);
}
} }
} }
} }