hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[media] cec-funcs.h: add length checks 

Add msg->len sanity checks to fix static checker warning:

	include/linux/cec-funcs.h:1154 cec_ops_set_osd_string()
	warn: setting length 'msg->len - 3' to negative one

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
This commit is contained in:
Hans Verkuil 2016-07-06 05:49:26 -03:00 committed by Mauro Carvalho Chehab
parent 5bb2399a4f
commit 0cb1f1e44c
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
include/linux/cec-funcs.h
View File

@ -788,7 +788,7 @@ static inline void cec_msg_set_timer_program_title(struct cec_msg *msg,
static inline void cec_ops_set_timer_program_title(const struct cec_msg *msg,
char *prog_title)
{
unsigned int len = msg->len - 2;
unsigned int len = msg->len > 2 ? msg->len - 2 : 0;
if (len > 14)
len = 14;
@ -1167,7 +1167,7 @@ static inline void cec_ops_set_osd_string(const struct cec_msg *msg,
__u8 *disp_ctl,
char *osd)
{
unsigned int len = msg->len - 3;
unsigned int len = msg->len > 3 ? msg->len - 3 : 0;
*disp_ctl = msg->msg[2];
if (len > 13)
@ -1192,7 +1192,7 @@ static inline void cec_msg_set_osd_name(struct cec_msg *msg, const char *name)
static inline void cec_ops_set_osd_name(const struct cec_msg *msg,
char *name)
{
unsigned int len = msg->len - 2;
unsigned int len = msg->len > 2 ? msg->len - 2 : 0;
if (len > 14)
len = 14;