hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

orangefs: Adjust three checks for null pointers 

MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written !…

Thus fix affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>
This commit is contained in:
Markus Elfring 2017-08-17 21:35:16 +02:00 committed by Mike Marshall
parent 5e273a0e06
commit 0b08273c8a
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
fs/orangefs/acl.c
View File

@ -35,7 +35,7 @@ struct posix_acl *orangefs_get_acl(struct inode *inode, int type)
* I don't do that for now. * I don't do that for now.
*/ */
value = kmalloc(ORANGEFS_MAX_XATTR_VALUELEN, GFP_KERNEL); value = kmalloc(ORANGEFS_MAX_XATTR_VALUELEN, GFP_KERNEL);
if (value == NULL) if (!value)
return ERR_PTR(-ENOMEM); return ERR_PTR(-ENOMEM);
gossip_debug(GOSSIP_ACL_DEBUG, gossip_debug(GOSSIP_ACL_DEBUG,

4
fs/orangefs/xattr.c
View File

@ -239,7 +239,7 @@ int orangefs_inode_setxattr(struct inode *inode, const char *name,
internal_flag = convert_to_internal_xattr_flags(flags); internal_flag = convert_to_internal_xattr_flags(flags);
/* This is equivalent to a removexattr */ /* This is equivalent to a removexattr */
if (size == 0 && value == NULL) { if (size == 0 && !value) {
gossip_debug(GOSSIP_XATTR_DEBUG, gossip_debug(GOSSIP_XATTR_DEBUG,
"removing xattr (%s)\n", "removing xattr (%s)\n",
name); name);
@ -311,7 +311,7 @@ ssize_t orangefs_listxattr(struct dentry *dentry, char *buffer, size_t size)
int i = 0; int i = 0;
int returned_count = 0; int returned_count = 0;
if (size > 0 && buffer == NULL) { if (size > 0 && !buffer) {
gossip_err("%s: bogus NULL pointers\n", __func__); gossip_err("%s: bogus NULL pointers\n", __func__);
return -EINVAL; return -EINVAL;
} }