drm/i915: Don't leak framebuffer_references if drm_framebuffer_init() fails
Don't increment obj->framebuffer_references until we know we actually managed to create the framebuffer. Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> Link: http://patchwork.freedesktop.org/patch/msgid/1452777736-4909-2-git-send-email-ville.syrjala@linux.intel.com
This commit is contained in:
parent
013dd9e038
commit
0b05e1e0c9
|
@ -14905,7 +14905,6 @@ static int intel_framebuffer_init(struct drm_device *dev,
|
|||
|
||||
drm_helper_mode_fill_fb_struct(&intel_fb->base, mode_cmd);
|
||||
intel_fb->obj = obj;
|
||||
intel_fb->obj->framebuffer_references++;
|
||||
|
||||
ret = drm_framebuffer_init(dev, &intel_fb->base, &intel_fb_funcs);
|
||||
if (ret) {
|
||||
|
@ -14913,6 +14912,8 @@ static int intel_framebuffer_init(struct drm_device *dev,
|
|||
return ret;
|
||||
}
|
||||
|
||||
intel_fb->obj->framebuffer_references++;
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue