Coccicheck: Remove memcpy to struct assignment test
The Coccinelle script scripts/coccinelle/misc/memcpy-assign.cocci look for opportunities to replace a call to memcpy by a struct assignment. This patch removes memcpy-assign.cocci as it is not clear that this convention has an impact on the generated code. Signed-off-by: Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by: Michal Marek <mmarek@suse.cz>
This commit is contained in:
parent
ae63b2d7bd
commit
0a830dad5e
|
@ -1,103 +0,0 @@
|
||||||
//
|
|
||||||
// Replace memcpy with struct assignment.
|
|
||||||
//
|
|
||||||
// Confidence: High
|
|
||||||
// Copyright: (C) 2012 Peter Senna Tschudin, INRIA/LIP6. GPLv2.
|
|
||||||
// URL: http://coccinelle.lip6.fr/
|
|
||||||
// Comments:
|
|
||||||
// Options: --no-includes --include-headers
|
|
||||||
|
|
||||||
virtual patch
|
|
||||||
virtual report
|
|
||||||
virtual context
|
|
||||||
virtual org
|
|
||||||
|
|
||||||
@r1 depends on !patch@
|
|
||||||
identifier struct_name;
|
|
||||||
struct struct_name to;
|
|
||||||
struct struct_name from;
|
|
||||||
struct struct_name *top;
|
|
||||||
struct struct_name *fromp;
|
|
||||||
position p;
|
|
||||||
@@
|
|
||||||
memcpy@p(\(&(to)\|top\), \(&(from)\|fromp\), \(sizeof(to)\|sizeof(from)\|sizeof(struct struct_name)\|sizeof(*top)\|sizeof(*fromp)\))
|
|
||||||
|
|
||||||
@script:python depends on report@
|
|
||||||
p << r1.p;
|
|
||||||
@@
|
|
||||||
coccilib.report.print_report(p[0],"Replace memcpy with struct assignment")
|
|
||||||
|
|
||||||
@depends on context@
|
|
||||||
position r1.p;
|
|
||||||
@@
|
|
||||||
*memcpy@p(...);
|
|
||||||
|
|
||||||
@script:python depends on org@
|
|
||||||
p << r1.p;
|
|
||||||
@@
|
|
||||||
cocci.print_main("Replace memcpy with struct assignment",p)
|
|
||||||
|
|
||||||
@depends on patch@
|
|
||||||
identifier struct_name;
|
|
||||||
struct struct_name to;
|
|
||||||
struct struct_name from;
|
|
||||||
@@
|
|
||||||
(
|
|
||||||
-memcpy(&(to), &(from), sizeof(to));
|
|
||||||
+to = from;
|
|
||||||
|
|
|
||||||
-memcpy(&(to), &(from), sizeof(from));
|
|
||||||
+to = from;
|
|
||||||
|
|
|
||||||
-memcpy(&(to), &(from), sizeof(struct struct_name));
|
|
||||||
+to = from;
|
|
||||||
)
|
|
||||||
|
|
||||||
@depends on patch@
|
|
||||||
identifier struct_name;
|
|
||||||
struct struct_name to;
|
|
||||||
struct struct_name *from;
|
|
||||||
@@
|
|
||||||
(
|
|
||||||
-memcpy(&(to), from, sizeof(to));
|
|
||||||
+to = *from;
|
|
||||||
|
|
|
||||||
-memcpy(&(to), from, sizeof(*from));
|
|
||||||
+to = *from;
|
|
||||||
|
|
|
||||||
-memcpy(&(to), from, sizeof(struct struct_name));
|
|
||||||
+to = *from;
|
|
||||||
)
|
|
||||||
|
|
||||||
@depends on patch@
|
|
||||||
identifier struct_name;
|
|
||||||
struct struct_name *to;
|
|
||||||
struct struct_name from;
|
|
||||||
@@
|
|
||||||
(
|
|
||||||
-memcpy(to, &(from), sizeof(*to));
|
|
||||||
+ *to = from;
|
|
||||||
|
|
|
||||||
-memcpy(to, &(from), sizeof(from));
|
|
||||||
+ *to = from;
|
|
||||||
|
|
|
||||||
-memcpy(to, &(from), sizeof(struct struct_name));
|
|
||||||
+ *to = from;
|
|
||||||
)
|
|
||||||
|
|
||||||
@depends on patch@
|
|
||||||
identifier struct_name;
|
|
||||||
struct struct_name *to;
|
|
||||||
struct struct_name *from;
|
|
||||||
@@
|
|
||||||
(
|
|
||||||
-memcpy(to, from, sizeof(*to));
|
|
||||||
+ *to = *from;
|
|
||||||
|
|
|
||||||
-memcpy(to, from, sizeof(*from));
|
|
||||||
+ *to = *from;
|
|
||||||
|
|
|
||||||
-memcpy(to, from, sizeof(struct struct_name));
|
|
||||||
+ *to = *from;
|
|
||||||
)
|
|
||||||
|
|
Loading…
Reference in New Issue