GFS2: mark the journal idle to fix ro mounts
When gfs2 was mounted read-only and then unmounted, it was writing a header block to the journal in the syncing gfs2_log_flush() call from kill_sb(). This is because the journal was not being marked as idle until the first log header was written out, and on a read-only mount there never was a log header written out. Since the journal was not marked idle, gfs2_log_flush() was writing out a header lock to make sure it was empty during the sync. Not only did this cause IO to a read-only filesystem, but the journalling isn't completely initialized on read-only mounts, and so gfs2 was writing out the wrong sequence number in the log header. Now, the journal is marked idle on mount, and gfs2_log_flush() won't write out anything until there starts being transactions to flush. Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com> Signed-off-by: Bob Peterson <rpeterso@redhat.com> Acked-by: Steven Whitehouse <swhiteho@redhat.com>
This commit is contained in:
parent
0166b197c2
commit
086cc672e1
|
@ -756,6 +756,7 @@ static int init_journal(struct gfs2_sbd *sdp, int undo)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
sdp->sd_log_idle = 1;
|
||||||
set_bit(SDF_JOURNAL_CHECKED, &sdp->sd_flags);
|
set_bit(SDF_JOURNAL_CHECKED, &sdp->sd_flags);
|
||||||
gfs2_glock_dq_uninit(&ji_gh);
|
gfs2_glock_dq_uninit(&ji_gh);
|
||||||
jindex = 0;
|
jindex = 0;
|
||||||
|
|
Loading…
Reference in New Issue