drm/i915: Don't store the max cursor width/height in the crtc
Those values are, global, only used in one function and already stored in mode_config.cursor_{width,height}. As a result, this initialization code has been moved from the crtc_init() function to the global modeset_init() one. I also renamed CURSOR_{WIDTH,HEIGHT} to MAX_CURSOR_{WIDTH,HEIGHT} to be more accurate about what these value really are. Cc: Sagar Kamble <sagar.a.kamble@intel.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Cc: Imre Deak <imre.deak@intel.com> Signed-off-by: Damien Lespiau <damien.lespiau@intel.com> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
parent
4e6e1a545f
commit
068be56163
|
@ -10559,16 +10559,6 @@ static void intel_crtc_init(struct drm_device *dev, int pipe)
|
|||
|
||||
drm_crtc_init(dev, &intel_crtc->base, &intel_crtc_funcs);
|
||||
|
||||
if (IS_GEN2(dev)) {
|
||||
intel_crtc->max_cursor_width = GEN2_CURSOR_WIDTH;
|
||||
intel_crtc->max_cursor_height = GEN2_CURSOR_HEIGHT;
|
||||
} else {
|
||||
intel_crtc->max_cursor_width = CURSOR_WIDTH;
|
||||
intel_crtc->max_cursor_height = CURSOR_HEIGHT;
|
||||
}
|
||||
dev->mode_config.cursor_width = intel_crtc->max_cursor_width;
|
||||
dev->mode_config.cursor_height = intel_crtc->max_cursor_height;
|
||||
|
||||
drm_mode_crtc_set_gamma_size(&intel_crtc->base, 256);
|
||||
for (i = 0; i < 256; i++) {
|
||||
intel_crtc->lut_r[i] = i;
|
||||
|
@ -11319,6 +11309,15 @@ void intel_modeset_init(struct drm_device *dev)
|
|||
dev->mode_config.max_width = 8192;
|
||||
dev->mode_config.max_height = 8192;
|
||||
}
|
||||
|
||||
if (IS_GEN2(dev)) {
|
||||
dev->mode_config.cursor_width = GEN2_CURSOR_WIDTH;
|
||||
dev->mode_config.cursor_height = GEN2_CURSOR_HEIGHT;
|
||||
} else {
|
||||
dev->mode_config.cursor_width = MAX_CURSOR_WIDTH;
|
||||
dev->mode_config.cursor_height = MAX_CURSOR_HEIGHT;
|
||||
}
|
||||
|
||||
dev->mode_config.fb_base = dev_priv->gtt.mappable_base;
|
||||
|
||||
DRM_DEBUG_KMS("%d display pipe%s available.\n",
|
||||
|
|
|
@ -81,8 +81,8 @@
|
|||
/* Maximum cursor sizes */
|
||||
#define GEN2_CURSOR_WIDTH 64
|
||||
#define GEN2_CURSOR_HEIGHT 64
|
||||
#define CURSOR_WIDTH 256
|
||||
#define CURSOR_HEIGHT 256
|
||||
#define MAX_CURSOR_WIDTH 256
|
||||
#define MAX_CURSOR_HEIGHT 256
|
||||
|
||||
#define INTEL_I2C_BUS_DVO 1
|
||||
#define INTEL_I2C_BUS_SDVO 2
|
||||
|
@ -373,7 +373,6 @@ struct intel_crtc {
|
|||
uint32_t cursor_addr;
|
||||
int16_t cursor_x, cursor_y;
|
||||
int16_t cursor_width, cursor_height;
|
||||
int16_t max_cursor_width, max_cursor_height;
|
||||
bool cursor_visible;
|
||||
|
||||
struct intel_plane_config plane_config;
|
||||
|
|
Loading…
Reference in New Issue