hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

kdb: Use KDB_REPEAT_* values as flags 

The actual values of KDB_REPEAT_* enum values and overall logic stayed
the same, but we now treat the values as flags.

This makes it possible to add other flags and combine them, plus makes
the code a lot simpler and shorter. But functionality-wise, there should
be no changes.

Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Signed-off-by: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
This commit is contained in:
Anton Vorontsov 2014-11-06 14:36:43 +00:00 committed by Jason Wessel
parent 42c884c10b
commit 04bb171e7a
2 changed files with 9 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
include/linux/kdb.h
View File

@ -15,8 +15,8 @@
typedef enum { typedef enum {
KDB_REPEAT_NONE = 0, /* Do not repeat this command */ KDB_REPEAT_NONE = 0, /* Do not repeat this command */
KDB_REPEAT_NO_ARGS, /* Repeat the command without arguments */ KDB_REPEAT_NO_ARGS = 0x1, /* Repeat the command w/o arguments */
KDB_REPEAT_WITH_ARGS, /* Repeat the command including its arguments */ KDB_REPEAT_WITH_ARGS = 0x2, /* Repeat the command w/ its arguments */
} kdb_cmdflags_t; } kdb_cmdflags_t;
typedef int (*kdb_func_t)(int, const char **); typedef int (*kdb_func_t)(int, const char **);

21
kernel/debug/kdb/kdb_main.c
View File

@ -1008,20 +1008,13 @@ int kdb_parse(const char *cmdstr)
if (result && ignore_errors && result > KDB_CMD_GO) if (result && ignore_errors && result > KDB_CMD_GO)
result = 0; result = 0;
KDB_STATE_CLEAR(CMD); KDB_STATE_CLEAR(CMD);
switch (tp->cmd_flags) {
case KDB_REPEAT_NONE: if (tp->cmd_flags & KDB_REPEAT_WITH_ARGS)
argc = 0; return result;
if (argv[0])
*(argv[0]) = '\0'; argc = tp->cmd_flags & KDB_REPEAT_NO_ARGS ? 1 : 0;
break; if (argv[argc])
case KDB_REPEAT_NO_ARGS: *(argv[argc]) = '\0';
argc = 1;
if (argv[1])
*(argv[1]) = '\0';
break;
case KDB_REPEAT_WITH_ARGS:
break;
}
return result; return result;
} }