PCI: use proper call to driver_create_file
Don't try to call the "raw" sysfs_create_file when we already have a helper function to do this kind of work for us. Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
This commit is contained in:
parent
2344c6de6b
commit
03d43b19b9
|
@ -96,17 +96,21 @@ pci_create_newid_file(struct pci_driver *drv)
|
||||||
{
|
{
|
||||||
int error = 0;
|
int error = 0;
|
||||||
if (drv->probe != NULL)
|
if (drv->probe != NULL)
|
||||||
error = sysfs_create_file(&drv->driver.kobj,
|
error = driver_create_file(&drv->driver, &driver_attr_new_id);
|
||||||
&driver_attr_new_id.attr);
|
|
||||||
return error;
|
return error;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
static void pci_remove_newid_file(struct pci_driver *drv)
|
||||||
|
{
|
||||||
|
driver_remove_file(&drv->driver, &driver_attr_new_id);
|
||||||
|
}
|
||||||
#else /* !CONFIG_HOTPLUG */
|
#else /* !CONFIG_HOTPLUG */
|
||||||
static inline void pci_free_dynids(struct pci_driver *drv) {}
|
static inline void pci_free_dynids(struct pci_driver *drv) {}
|
||||||
static inline int pci_create_newid_file(struct pci_driver *drv)
|
static inline int pci_create_newid_file(struct pci_driver *drv)
|
||||||
{
|
{
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
static inline void pci_remove_newid_file(struct pci_driver *drv) {}
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
/**
|
/**
|
||||||
|
@ -447,6 +451,7 @@ int __pci_register_driver(struct pci_driver *drv, struct module *owner,
|
||||||
void
|
void
|
||||||
pci_unregister_driver(struct pci_driver *drv)
|
pci_unregister_driver(struct pci_driver *drv)
|
||||||
{
|
{
|
||||||
|
pci_remove_newid_file(drv);
|
||||||
driver_unregister(&drv->driver);
|
driver_unregister(&drv->driver);
|
||||||
pci_free_dynids(drv);
|
pci_free_dynids(drv);
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue