hollalinux
/
linux-sg2042
mirror of https://github.com/sophgo/linux-riscv.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

iio: ltr501: Fix proximity threshold boundary check 

Currently, proximity sensor boundary check is done
inside the switch block but outside the case
statement.Since this code will never get executed,
moved the check outside the switch case statement.

   867          case IIO_PROXIMITY:
   868                  switch (dir) {
   // Following line has been moved outside the switch block.
   869                  if (val > LTR501_PS_THRESH_MASK)
   870                          return -EINVAL;
   871                  case IIO_EV_DIR_RISING:

Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
This commit is contained in:
Kuppuswamy Sathyanarayanan 2015-05-15 16:42:56 -07:00 committed by Jonathan Cameron
parent f2c714a0a2
commit 01e537f733
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
drivers/iio/light/ltr501.c
View File

@ -865,9 +865,9 @@ static int ltr501_write_thresh(struct iio_dev *indio_dev,
return -EINVAL; return -EINVAL;
} }
case IIO_PROXIMITY: case IIO_PROXIMITY:
switch (dir) {
if (val > LTR501_PS_THRESH_MASK) if (val > LTR501_PS_THRESH_MASK)
return -EINVAL; return -EINVAL;
switch (dir) {
case IIO_EV_DIR_RISING: case IIO_EV_DIR_RISING:
mutex_lock(&data->lock_ps); mutex_lock(&data->lock_ps);
ret = regmap_bulk_write(data->regmap, ret = regmap_bulk_write(data->regmap,