net: bridge: fix br_vlan_get_{pvid,info} return values

These two functions return the regular -EINVAL failure in the normal
code path, but return a nonstandard '-1' error otherwise, which gets
interpreted as -EPERM.

Let's change it to -EINVAL for the dummy functions as well.

Fixes: 4d4fd36126 ("net: bridge: Publish bridge accessor functions")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Arnd Bergmann 2018-07-06 14:44:02 +02:00 committed by David S. Miller
parent 843789f6dd
commit 000244d3dc
1 changed files with 2 additions and 2 deletions

View File

@ -105,13 +105,13 @@ static inline bool br_vlan_enabled(const struct net_device *dev)
static inline int br_vlan_get_pvid(const struct net_device *dev, u16 *p_pvid) static inline int br_vlan_get_pvid(const struct net_device *dev, u16 *p_pvid)
{ {
return -1; return -EINVAL;
} }
static inline int br_vlan_get_info(const struct net_device *dev, u16 vid, static inline int br_vlan_get_info(const struct net_device *dev, u16 vid,
struct bridge_vlan_info *p_vinfo) struct bridge_vlan_info *p_vinfo)
{ {
return -1; return -EINVAL;
} }
#endif #endif