License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 22:07:57 +08:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
2017-01-17 21:03:22 +08:00
|
|
|
#ifndef BLK_MQ_SCHED_H
|
|
|
|
|
#define BLK_MQ_SCHED_H
|
|
|
|
|
|
|
|
|
|
#include "blk-mq.h"
|
|
|
|
|
#include "blk-mq-tag.h"
|
|
|
|
|
|
blk-mq: Use request queue-wide tags for tagset-wide sbitmap
The tags used for an IO scheduler are currently per hctx.
As such, when q->nr_hw_queues grows, so does the request queue total IO
scheduler tag depth.
This may cause problems for SCSI MQ HBAs whose total driver depth is
fixed.
Ming and Yanhui report higher CPU usage and lower throughput in scenarios
where the fixed total driver tag depth is appreciably lower than the total
scheduler tag depth:
https://lore.kernel.org/linux-block/440dfcfc-1a2c-bd98-1161-cec4d78c6dfc@huawei.com/T/#mc0d6d4f95275a2743d1c8c3e4dc9ff6c9aa3a76b
In that scenario, since the scheduler tag is got first, much contention
is introduced since a driver tag may not be available after we have got
the sched tag.
Improve this scenario by introducing request queue-wide tags for when
a tagset-wide sbitmap is used. The static sched requests are still
allocated per hctx, as requests are initialised per hctx, as in
blk_mq_init_request(..., hctx_idx, ...) ->
set->ops->init_request(.., hctx_idx, ...).
For simplicity of resizing the request queue sbitmap when updating the
request queue depth, just init at the max possible size, so we don't need
to deal with the possibly with swapping out a new sbitmap for old if
we need to grow.
Signed-off-by: John Garry <john.garry@huawei.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/1620907258-30910-3-git-send-email-john.garry@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2021-05-13 20:00:58 +08:00
|
|
|
#define MAX_SCHED_RQ (16 * BLKDEV_MAX_RQ)
|
|
|
|
|
|
2018-11-20 09:52:34 +08:00
|
|
|
void blk_mq_sched_assign_ioc(struct request *rq);
|
2017-01-17 21:03:22 +08:00
|
|
|
|
2017-02-04 00:48:28 +08:00
|
|
|
bool blk_mq_sched_try_merge(struct request_queue *q, struct bio *bio,
|
2019-06-06 18:29:01 +08:00
|
|
|
unsigned int nr_segs, struct request **merged_request);
|
|
|
|
|
bool __blk_mq_sched_bio_merge(struct request_queue *q, struct bio *bio,
|
|
|
|
|
unsigned int nr_segs);
|
2021-06-23 17:36:34 +08:00
|
|
|
bool blk_mq_sched_try_insert_merge(struct request_queue *q, struct request *rq,
|
|
|
|
|
struct list_head *free);
|
2018-12-17 14:14:05 +08:00
|
|
|
void blk_mq_sched_mark_restart_hctx(struct blk_mq_hw_ctx *hctx);
|
2017-04-08 02:40:09 +08:00
|
|
|
void blk_mq_sched_restart(struct blk_mq_hw_ctx *hctx);
|
2017-01-17 21:03:22 +08:00
|
|
|
|
2017-01-27 16:00:47 +08:00
|
|
|
void blk_mq_sched_insert_request(struct request *rq, bool at_head,
|
2018-01-18 00:25:58 +08:00
|
|
|
bool run_queue, bool async);
|
2018-10-31 01:31:51 +08:00
|
|
|
void blk_mq_sched_insert_requests(struct blk_mq_hw_ctx *hctx,
|
2017-01-27 16:00:47 +08:00
|
|
|
struct blk_mq_ctx *ctx,
|
|
|
|
|
struct list_head *list, bool run_queue_async);
|
|
|
|
|
|
2017-01-17 21:03:22 +08:00
|
|
|
void blk_mq_sched_dispatch_requests(struct blk_mq_hw_ctx *hctx);
|
|
|
|
|
|
2017-04-06 03:01:30 +08:00
|
|
|
int blk_mq_init_sched(struct request_queue *q, struct elevator_type *e);
|
2017-04-07 22:52:27 +08:00
|
|
|
void blk_mq_exit_sched(struct request_queue *q, struct elevator_queue *e);
|
block: free sched's request pool in blk_cleanup_queue
In theory, IO scheduler belongs to request queue, and the request pool
of sched tags belongs to the request queue too.
However, the current tags allocation interfaces are re-used for both
driver tags and sched tags, and driver tags is definitely host wide,
and doesn't belong to any request queue, same with its request pool.
So we need tagset instance for freeing request of sched tags.
Meantime, blk_mq_free_tag_set() often follows blk_cleanup_queue() in case
of non-BLK_MQ_F_TAG_SHARED, this way requires that request pool of sched
tags to be freed before calling blk_mq_free_tag_set().
Commit 47cdee29ef9d94e ("block: move blk_exit_queue into __blk_release_queue")
moves blk_exit_queue into __blk_release_queue for simplying the fast
path in generic_make_request(), then causes oops during freeing requests
of sched tags in __blk_release_queue().
Fix the above issue by move freeing request pool of sched tags into
blk_cleanup_queue(), this way is safe becasue queue has been frozen and no any
in-queue requests at that time. Freeing sched tags has to be kept in queue's
release handler becasue there might be un-completed dispatch activity
which might refer to sched tags.
Cc: Bart Van Assche <bvanassche@acm.org>
Cc: Christoph Hellwig <hch@lst.de>
Fixes: 47cdee29ef9d94e485eb08f962c74943023a5271 ("block: move blk_exit_queue into __blk_release_queue")
Tested-by: Yi Zhang <yi.zhang@redhat.com>
Reported-by: kernel test robot <rong.a.chen@intel.com>
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
2019-06-04 21:08:02 +08:00
|
|
|
void blk_mq_sched_free_requests(struct request_queue *q);
|
2017-01-17 21:03:22 +08:00
|
|
|
|
|
|
|
|
static inline bool
|
2019-06-06 18:29:01 +08:00
|
|
|
blk_mq_sched_bio_merge(struct request_queue *q, struct bio *bio,
|
|
|
|
|
unsigned int nr_segs)
|
2017-01-17 21:03:22 +08:00
|
|
|
{
|
2017-05-26 19:53:20 +08:00
|
|
|
if (blk_queue_nomerges(q) || !bio_mergeable(bio))
|
2017-01-17 21:03:22 +08:00
|
|
|
return false;
|
|
|
|
|
|
2019-06-06 18:29:01 +08:00
|
|
|
return __blk_mq_sched_bio_merge(q, bio, nr_segs);
|
2017-01-17 21:03:22 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static inline bool
|
|
|
|
|
blk_mq_sched_allow_merge(struct request_queue *q, struct request *rq,
|
|
|
|
|
struct bio *bio)
|
|
|
|
|
{
|
|
|
|
|
struct elevator_queue *e = q->elevator;
|
|
|
|
|
|
2018-11-02 06:41:41 +08:00
|
|
|
if (e && e->type->ops.allow_merge)
|
|
|
|
|
return e->type->ops.allow_merge(q, rq, bio);
|
2017-01-17 21:03:22 +08:00
|
|
|
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
|
2018-09-28 06:55:51 +08:00
|
|
|
static inline void blk_mq_sched_completed_request(struct request *rq, u64 now)
|
2017-01-17 21:03:22 +08:00
|
|
|
{
|
2017-04-14 16:00:01 +08:00
|
|
|
struct elevator_queue *e = rq->q->elevator;
|
2017-01-17 21:03:22 +08:00
|
|
|
|
2018-11-02 06:41:41 +08:00
|
|
|
if (e && e->type->ops.completed_request)
|
|
|
|
|
e->type->ops.completed_request(rq, now);
|
2017-01-17 21:03:22 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static inline void blk_mq_sched_requeue_request(struct request *rq)
|
|
|
|
|
{
|
|
|
|
|
struct request_queue *q = rq->q;
|
|
|
|
|
struct elevator_queue *e = q->elevator;
|
|
|
|
|
|
2020-09-09 04:46:37 +08:00
|
|
|
if ((rq->rq_flags & RQF_ELVPRIV) && e && e->type->ops.requeue_request)
|
2018-11-02 06:41:41 +08:00
|
|
|
e->type->ops.requeue_request(rq);
|
2017-01-17 21:03:22 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static inline bool blk_mq_sched_has_work(struct blk_mq_hw_ctx *hctx)
|
|
|
|
|
{
|
|
|
|
|
struct elevator_queue *e = hctx->queue->elevator;
|
|
|
|
|
|
2018-11-02 06:41:41 +08:00
|
|
|
if (e && e->type->ops.has_work)
|
|
|
|
|
return e->type->ops.has_work(hctx);
|
2017-01-17 21:03:22 +08:00
|
|
|
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static inline bool blk_mq_sched_needs_restart(struct blk_mq_hw_ctx *hctx)
|
|
|
|
|
{
|
|
|
|
|
return test_bit(BLK_MQ_S_SCHED_RESTART, &hctx->state);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#endif
|