2019-06-04 16:11:33 +08:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
|
* linux/kernel/compat.c
|
|
|
|
|
*
|
|
|
|
|
* Kernel compatibililty routines for e.g. 32 bit syscall support
|
|
|
|
|
* on 64 bit kernels.
|
|
|
|
|
*
|
|
|
|
|
* Copyright (C) 2002-2003 Stephen Rothwell, IBM Corporation
|
|
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#include <linux/linkage.h>
|
|
|
|
|
#include <linux/compat.h>
|
|
|
|
|
#include <linux/errno.h>
|
|
|
|
|
#include <linux/time.h>
|
|
|
|
|
#include <linux/signal.h>
|
|
|
|
|
#include <linux/sched.h> /* for MAX_SCHEDULE_TIMEOUT */
|
|
|
|
|
#include <linux/syscalls.h>
|
|
|
|
|
#include <linux/unistd.h>
|
|
|
|
|
#include <linux/security.h>
|
2011-05-27 04:00:52 +08:00
|
|
|
#include <linux/export.h>
|
2006-06-23 17:03:56 +08:00
|
|
|
#include <linux/migrate.h>
|
2006-09-29 17:00:28 +08:00
|
|
|
#include <linux/posix-timers.h>
|
timers: fix itimer/many thread hang
Overview
This patch reworks the handling of POSIX CPU timers, including the
ITIMER_PROF, ITIMER_VIRT timers and rlimit handling. It was put together
with the help of Roland McGrath, the owner and original writer of this code.
The problem we ran into, and the reason for this rework, has to do with using
a profiling timer in a process with a large number of threads. It appears
that the performance of the old implementation of run_posix_cpu_timers() was
at least O(n*3) (where "n" is the number of threads in a process) or worse.
Everything is fine with an increasing number of threads until the time taken
for that routine to run becomes the same as or greater than the tick time, at
which point things degrade rather quickly.
This patch fixes bug 9906, "Weird hang with NPTL and SIGPROF."
Code Changes
This rework corrects the implementation of run_posix_cpu_timers() to make it
run in constant time for a particular machine. (Performance may vary between
one machine and another depending upon whether the kernel is built as single-
or multiprocessor and, in the latter case, depending upon the number of
running processors.) To do this, at each tick we now update fields in
signal_struct as well as task_struct. The run_posix_cpu_timers() function
uses those fields to make its decisions.
We define a new structure, "task_cputime," to contain user, system and
scheduler times and use these in appropriate places:
struct task_cputime {
cputime_t utime;
cputime_t stime;
unsigned long long sum_exec_runtime;
};
This is included in the structure "thread_group_cputime," which is a new
substructure of signal_struct and which varies for uniprocessor versus
multiprocessor kernels. For uniprocessor kernels, it uses "task_cputime" as
a simple substructure, while for multiprocessor kernels it is a pointer:
struct thread_group_cputime {
struct task_cputime totals;
};
struct thread_group_cputime {
struct task_cputime *totals;
};
We also add a new task_cputime substructure directly to signal_struct, to
cache the earliest expiration of process-wide timers, and task_cputime also
replaces the it_*_expires fields of task_struct (used for earliest expiration
of thread timers). The "thread_group_cputime" structure contains process-wide
timers that are updated via account_user_time() and friends. In the non-SMP
case the structure is a simple aggregator; unfortunately in the SMP case that
simplicity was not achievable due to cache-line contention between CPUs (in
one measured case performance was actually _worse_ on a 16-cpu system than
the same test on a 4-cpu system, due to this contention). For SMP, the
thread_group_cputime counters are maintained as a per-cpu structure allocated
using alloc_percpu(). The timer functions update only the timer field in
the structure corresponding to the running CPU, obtained using per_cpu_ptr().
We define a set of inline functions in sched.h that we use to maintain the
thread_group_cputime structure and hide the differences between UP and SMP
implementations from the rest of the kernel. The thread_group_cputime_init()
function initializes the thread_group_cputime structure for the given task.
The thread_group_cputime_alloc() is a no-op for UP; for SMP it calls the
out-of-line function thread_group_cputime_alloc_smp() to allocate and fill
in the per-cpu structures and fields. The thread_group_cputime_free()
function, also a no-op for UP, in SMP frees the per-cpu structures. The
thread_group_cputime_clone_thread() function (also a UP no-op) for SMP calls
thread_group_cputime_alloc() if the per-cpu structures haven't yet been
allocated. The thread_group_cputime() function fills the task_cputime
structure it is passed with the contents of the thread_group_cputime fields;
in UP it's that simple but in SMP it must also safely check that tsk->signal
is non-NULL (if it is it just uses the appropriate fields of task_struct) and,
if so, sums the per-cpu values for each online CPU. Finally, the three
functions account_group_user_time(), account_group_system_time() and
account_group_exec_runtime() are used by timer functions to update the
respective fields of the thread_group_cputime structure.
Non-SMP operation is trivial and will not be mentioned further.
The per-cpu structure is always allocated when a task creates its first new
thread, via a call to thread_group_cputime_clone_thread() from copy_signal().
It is freed at process exit via a call to thread_group_cputime_free() from
cleanup_signal().
All functions that formerly summed utime/stime/sum_sched_runtime values from
from all threads in the thread group now use thread_group_cputime() to
snapshot the values in the thread_group_cputime structure or the values in
the task structure itself if the per-cpu structure hasn't been allocated.
Finally, the code in kernel/posix-cpu-timers.c has changed quite a bit.
The run_posix_cpu_timers() function has been split into a fast path and a
slow path; the former safely checks whether there are any expired thread
timers and, if not, just returns, while the slow path does the heavy lifting.
With the dedicated thread group fields, timers are no longer "rebalanced" and
the process_timer_rebalance() function and related code has gone away. All
summing loops are gone and all code that used them now uses the
thread_group_cputime() inline. When process-wide timers are set, the new
task_cputime structure in signal_struct is used to cache the earliest
expiration; this is checked in the fast path.
Performance
The fix appears not to add significant overhead to existing operations. It
generally performs the same as the current code except in two cases, one in
which it performs slightly worse (Case 5 below) and one in which it performs
very significantly better (Case 2 below). Overall it's a wash except in those
two cases.
I've since done somewhat more involved testing on a dual-core Opteron system.
Case 1: With no itimer running, for a test with 100,000 threads, the fixed
kernel took 1428.5 seconds, 513 seconds more than the unfixed system,
all of which was spent in the system. There were twice as many
voluntary context switches with the fix as without it.
Case 2: With an itimer running at .01 second ticks and 4000 threads (the most
an unmodified kernel can handle), the fixed kernel ran the test in
eight percent of the time (5.8 seconds as opposed to 70 seconds) and
had better tick accuracy (.012 seconds per tick as opposed to .023
seconds per tick).
Case 3: A 4000-thread test with an initial timer tick of .01 second and an
interval of 10,000 seconds (i.e. a timer that ticks only once) had
very nearly the same performance in both cases: 6.3 seconds elapsed
for the fixed kernel versus 5.5 seconds for the unfixed kernel.
With fewer threads (eight in these tests), the Case 1 test ran in essentially
the same time on both the modified and unmodified kernels (5.2 seconds versus
5.8 seconds). The Case 2 test ran in about the same time as well, 5.9 seconds
versus 5.4 seconds but again with much better tick accuracy, .013 seconds per
tick versus .025 seconds per tick for the unmodified kernel.
Since the fix affected the rlimit code, I also tested soft and hard CPU limits.
Case 4: With a hard CPU limit of 20 seconds and eight threads (and an itimer
running), the modified kernel was very slightly favored in that while
it killed the process in 19.997 seconds of CPU time (5.002 seconds of
wall time), only .003 seconds of that was system time, the rest was
user time. The unmodified kernel killed the process in 20.001 seconds
of CPU (5.014 seconds of wall time) of which .016 seconds was system
time. Really, though, the results were too close to call. The results
were essentially the same with no itimer running.
Case 5: With a soft limit of 20 seconds and a hard limit of 2000 seconds
(where the hard limit would never be reached) and an itimer running,
the modified kernel exhibited worse tick accuracy than the unmodified
kernel: .050 seconds/tick versus .028 seconds/tick. Otherwise,
performance was almost indistinguishable. With no itimer running this
test exhibited virtually identical behavior and times in both cases.
In times past I did some limited performance testing. those results are below.
On a four-cpu Opteron system without this fix, a sixteen-thread test executed
in 3569.991 seconds, of which user was 3568.435s and system was 1.556s. On
the same system with the fix, user and elapsed time were about the same, but
system time dropped to 0.007 seconds. Performance with eight, four and one
thread were comparable. Interestingly, the timer ticks with the fix seemed
more accurate: The sixteen-thread test with the fix received 149543 ticks
for 0.024 seconds per tick, while the same test without the fix received 58720
for 0.061 seconds per tick. Both cases were configured for an interval of
0.01 seconds. Again, the other tests were comparable. Each thread in this
test computed the primes up to 25,000,000.
I also did a test with a large number of threads, 100,000 threads, which is
impossible without the fix. In this case each thread computed the primes only
up to 10,000 (to make the runtime manageable). System time dominated, at
1546.968 seconds out of a total 2176.906 seconds (giving a user time of
629.938s). It received 147651 ticks for 0.015 seconds per tick, still quite
accurate. There is obviously no comparable test without the fix.
Signed-off-by: Frank Mayhar <fmayhar@google.com>
Cc: Roland McGrath <roland@redhat.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2008-09-13 00:54:39 +08:00
|
|
|
#include <linux/times.h>
|
2009-01-07 06:41:02 +08:00
|
|
|
#include <linux/ptrace.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 16:04:11 +08:00
|
|
|
#include <linux/gfp.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2016-12-25 03:46:01 +08:00
|
|
|
#include <linux/uaccess.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2011-05-10 01:12:30 +08:00
|
|
|
#ifdef __ARCH_WANT_SYS_SIGPROCMASK
|
|
|
|
|
|
2012-05-10 21:04:36 +08:00
|
|
|
/*
|
|
|
|
|
* sys_sigprocmask SIG_SETMASK sets the first (compat) word of the
|
|
|
|
|
* blocked set of signals to the supplied signal set
|
|
|
|
|
*/
|
|
|
|
|
static inline void compat_sig_setmask(sigset_t *blocked, compat_sigset_word set)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2012-05-10 21:04:36 +08:00
|
|
|
memcpy(blocked->sig, &set, sizeof(set));
|
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-11-26 08:41:01 +08:00
|
|
|
COMPAT_SYSCALL_DEFINE3(sigprocmask, int, how,
|
|
|
|
|
compat_old_sigset_t __user *, nset,
|
|
|
|
|
compat_old_sigset_t __user *, oset)
|
2012-05-10 21:04:36 +08:00
|
|
|
{
|
|
|
|
|
old_sigset_t old_set, new_set;
|
|
|
|
|
sigset_t new_blocked;
|
|
|
|
|
|
|
|
|
|
old_set = current->blocked.sig[0];
|
|
|
|
|
|
|
|
|
|
if (nset) {
|
|
|
|
|
if (get_user(new_set, nset))
|
|
|
|
|
return -EFAULT;
|
|
|
|
|
new_set &= ~(sigmask(SIGKILL) | sigmask(SIGSTOP));
|
|
|
|
|
|
|
|
|
|
new_blocked = current->blocked;
|
|
|
|
|
|
|
|
|
|
switch (how) {
|
|
|
|
|
case SIG_BLOCK:
|
|
|
|
|
sigaddsetmask(&new_blocked, new_set);
|
|
|
|
|
break;
|
|
|
|
|
case SIG_UNBLOCK:
|
|
|
|
|
sigdelsetmask(&new_blocked, new_set);
|
|
|
|
|
break;
|
|
|
|
|
case SIG_SETMASK:
|
|
|
|
|
compat_sig_setmask(&new_blocked, new_set);
|
|
|
|
|
break;
|
|
|
|
|
default:
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
set_current_blocked(&new_blocked);
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
if (oset) {
|
|
|
|
|
if (put_user(old_set, oset))
|
|
|
|
|
return -EFAULT;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
return 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
2011-05-10 01:12:30 +08:00
|
|
|
#endif
|
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
int put_compat_rusage(const struct rusage *r, struct compat_rusage __user *ru)
|
|
|
|
|
{
|
2017-05-31 18:39:31 +08:00
|
|
|
struct compat_rusage r32;
|
|
|
|
|
memset(&r32, 0, sizeof(r32));
|
|
|
|
|
r32.ru_utime.tv_sec = r->ru_utime.tv_sec;
|
|
|
|
|
r32.ru_utime.tv_usec = r->ru_utime.tv_usec;
|
|
|
|
|
r32.ru_stime.tv_sec = r->ru_stime.tv_sec;
|
|
|
|
|
r32.ru_stime.tv_usec = r->ru_stime.tv_usec;
|
|
|
|
|
r32.ru_maxrss = r->ru_maxrss;
|
|
|
|
|
r32.ru_ixrss = r->ru_ixrss;
|
|
|
|
|
r32.ru_idrss = r->ru_idrss;
|
|
|
|
|
r32.ru_isrss = r->ru_isrss;
|
|
|
|
|
r32.ru_minflt = r->ru_minflt;
|
|
|
|
|
r32.ru_majflt = r->ru_majflt;
|
|
|
|
|
r32.ru_nswap = r->ru_nswap;
|
|
|
|
|
r32.ru_inblock = r->ru_inblock;
|
|
|
|
|
r32.ru_oublock = r->ru_oublock;
|
|
|
|
|
r32.ru_msgsnd = r->ru_msgsnd;
|
|
|
|
|
r32.ru_msgrcv = r->ru_msgrcv;
|
|
|
|
|
r32.ru_nsignals = r->ru_nsignals;
|
|
|
|
|
r32.ru_nvcsw = r->ru_nvcsw;
|
|
|
|
|
r32.ru_nivcsw = r->ru_nivcsw;
|
|
|
|
|
if (copy_to_user(ru, &r32, sizeof(r32)))
|
2005-04-17 06:20:36 +08:00
|
|
|
return -EFAULT;
|
|
|
|
|
return 0;
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static int compat_get_user_cpu_mask(compat_ulong_t __user *user_mask_ptr,
|
2009-01-01 07:42:24 +08:00
|
|
|
unsigned len, struct cpumask *new_mask)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
|
unsigned long *k;
|
|
|
|
|
|
2009-01-01 07:42:24 +08:00
|
|
|
if (len < cpumask_size())
|
|
|
|
|
memset(new_mask, 0, cpumask_size());
|
|
|
|
|
else if (len > cpumask_size())
|
|
|
|
|
len = cpumask_size();
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-01-01 07:42:24 +08:00
|
|
|
k = cpumask_bits(new_mask);
|
2005-04-17 06:20:36 +08:00
|
|
|
return compat_get_bitmap(k, user_mask_ptr, len * 8);
|
|
|
|
|
}
|
|
|
|
|
|
2014-03-03 23:11:13 +08:00
|
|
|
COMPAT_SYSCALL_DEFINE3(sched_setaffinity, compat_pid_t, pid,
|
|
|
|
|
unsigned int, len,
|
|
|
|
|
compat_ulong_t __user *, user_mask_ptr)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2009-01-01 07:42:24 +08:00
|
|
|
cpumask_var_t new_mask;
|
2005-04-17 06:20:36 +08:00
|
|
|
int retval;
|
|
|
|
|
|
2009-01-01 07:42:24 +08:00
|
|
|
if (!alloc_cpumask_var(&new_mask, GFP_KERNEL))
|
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
|
|
retval = compat_get_user_cpu_mask(user_mask_ptr, len, new_mask);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (retval)
|
2009-01-01 07:42:24 +08:00
|
|
|
goto out;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-01-01 07:42:24 +08:00
|
|
|
retval = sched_setaffinity(pid, new_mask);
|
|
|
|
|
out:
|
|
|
|
|
free_cpumask_var(new_mask);
|
|
|
|
|
return retval;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
2014-03-03 23:11:13 +08:00
|
|
|
COMPAT_SYSCALL_DEFINE3(sched_getaffinity, compat_pid_t, pid, unsigned int, len,
|
|
|
|
|
compat_ulong_t __user *, user_mask_ptr)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
|
int ret;
|
2009-01-01 07:42:24 +08:00
|
|
|
cpumask_var_t mask;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-05-19 08:37:41 +08:00
|
|
|
if ((len * BITS_PER_BYTE) < nr_cpu_ids)
|
|
|
|
|
return -EINVAL;
|
|
|
|
|
if (len & (sizeof(compat_ulong_t)-1))
|
2005-04-17 06:20:36 +08:00
|
|
|
return -EINVAL;
|
|
|
|
|
|
2009-01-01 07:42:24 +08:00
|
|
|
if (!alloc_cpumask_var(&mask, GFP_KERNEL))
|
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
|
|
ret = sched_getaffinity(pid, mask);
|
2010-05-19 08:37:41 +08:00
|
|
|
if (ret == 0) {
|
2018-02-07 07:39:37 +08:00
|
|
|
unsigned int retlen = min(len, cpumask_size());
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-05-19 08:37:41 +08:00
|
|
|
if (compat_put_bitmap(user_mask_ptr, cpumask_bits(mask), retlen * 8))
|
|
|
|
|
ret = -EFAULT;
|
|
|
|
|
else
|
|
|
|
|
ret = retlen;
|
|
|
|
|
}
|
2009-01-01 07:42:24 +08:00
|
|
|
free_cpumask_var(mask);
|
2010-05-19 08:37:41 +08:00
|
|
|
|
2009-01-01 07:42:24 +08:00
|
|
|
return ret;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/*
|
|
|
|
|
* We currently only need the following fields from the sigevent
|
|
|
|
|
* structure: sigev_value, sigev_signo, sig_notify and (sometimes
|
|
|
|
|
* sigev_notify_thread_id). The others are handled in user mode.
|
|
|
|
|
* We also assume that copying sigev_value.sival_int is sufficient
|
|
|
|
|
* to keep all the bits of sigev_value.sival_ptr intact.
|
|
|
|
|
*/
|
|
|
|
|
int get_compat_sigevent(struct sigevent *event,
|
|
|
|
|
const struct compat_sigevent __user *u_event)
|
|
|
|
|
{
|
2005-04-17 06:24:01 +08:00
|
|
|
memset(event, 0, sizeof(*event));
|
Remove 'type' argument from access_ok() function
Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument
of the user address range verification function since we got rid of the
old racy i386-only code to walk page tables by hand.
It existed because the original 80386 would not honor the write protect
bit when in kernel mode, so you had to do COW by hand before doing any
user access. But we haven't supported that in a long time, and these
days the 'type' argument is a purely historical artifact.
A discussion about extending 'user_access_begin()' to do the range
checking resulted this patch, because there is no way we're going to
move the old VERIFY_xyz interface to that model. And it's best done at
the end of the merge window when I've done most of my merges, so let's
just get this done once and for all.
This patch was mostly done with a sed-script, with manual fix-ups for
the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form.
There were a couple of notable cases:
- csky still had the old "verify_area()" name as an alias.
- the iter_iov code had magical hardcoded knowledge of the actual
values of VERIFY_{READ,WRITE} (not that they mattered, since nothing
really used it)
- microblaze used the type argument for a debug printout
but other than those oddities this should be a total no-op patch.
I tried to fix up all architectures, did fairly extensive grepping for
access_ok() uses, and the changes are trivial, but I may have missed
something. Any missed conversion should be trivially fixable, though.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-01-04 10:57:57 +08:00
|
|
|
return (!access_ok(u_event, sizeof(*u_event)) ||
|
2005-04-17 06:20:36 +08:00
|
|
|
__get_user(event->sigev_value.sival_int,
|
|
|
|
|
&u_event->sigev_value.sival_int) ||
|
|
|
|
|
__get_user(event->sigev_signo, &u_event->sigev_signo) ||
|
|
|
|
|
__get_user(event->sigev_notify, &u_event->sigev_notify) ||
|
|
|
|
|
__get_user(event->sigev_notify_thread_id,
|
|
|
|
|
&u_event->sigev_notify_thread_id))
|
|
|
|
|
? -EFAULT : 0;
|
|
|
|
|
}
|
|
|
|
|
|
2006-10-29 01:38:46 +08:00
|
|
|
long compat_get_bitmap(unsigned long *mask, const compat_ulong_t __user *umask,
|
2005-04-17 06:20:36 +08:00
|
|
|
unsigned long bitmap_size)
|
|
|
|
|
{
|
|
|
|
|
unsigned long nr_compat_longs;
|
|
|
|
|
|
|
|
|
|
/* align bitmap up to nearest compat_long_t boundary */
|
|
|
|
|
bitmap_size = ALIGN(bitmap_size, BITS_PER_COMPAT_LONG);
|
2017-05-30 12:29:38 +08:00
|
|
|
nr_compat_longs = BITS_TO_COMPAT_LONGS(bitmap_size);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2020-04-03 15:20:51 +08:00
|
|
|
if (!user_read_access_begin(umask, bitmap_size / 8))
|
2005-04-17 06:20:36 +08:00
|
|
|
return -EFAULT;
|
|
|
|
|
|
2017-05-30 12:29:38 +08:00
|
|
|
while (nr_compat_longs > 1) {
|
|
|
|
|
compat_ulong_t l1, l2;
|
|
|
|
|
unsafe_get_user(l1, umask++, Efault);
|
|
|
|
|
unsafe_get_user(l2, umask++, Efault);
|
|
|
|
|
*mask++ = ((unsigned long)l2 << BITS_PER_COMPAT_LONG) | l1;
|
|
|
|
|
nr_compat_longs -= 2;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2017-05-30 12:29:38 +08:00
|
|
|
if (nr_compat_longs)
|
|
|
|
|
unsafe_get_user(*mask, umask++, Efault);
|
2020-04-03 15:20:51 +08:00
|
|
|
user_read_access_end();
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
2017-05-30 12:29:38 +08:00
|
|
|
|
|
|
|
|
Efault:
|
2020-04-03 15:20:51 +08:00
|
|
|
user_read_access_end();
|
2017-05-30 12:29:38 +08:00
|
|
|
return -EFAULT;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
long compat_put_bitmap(compat_ulong_t __user *umask, unsigned long *mask,
|
|
|
|
|
unsigned long bitmap_size)
|
|
|
|
|
{
|
|
|
|
|
unsigned long nr_compat_longs;
|
|
|
|
|
|
|
|
|
|
/* align bitmap up to nearest compat_long_t boundary */
|
|
|
|
|
bitmap_size = ALIGN(bitmap_size, BITS_PER_COMPAT_LONG);
|
2017-05-30 12:29:38 +08:00
|
|
|
nr_compat_longs = BITS_TO_COMPAT_LONGS(bitmap_size);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2020-04-03 15:20:51 +08:00
|
|
|
if (!user_write_access_begin(umask, bitmap_size / 8))
|
2005-04-17 06:20:36 +08:00
|
|
|
return -EFAULT;
|
|
|
|
|
|
2017-05-30 12:29:38 +08:00
|
|
|
while (nr_compat_longs > 1) {
|
|
|
|
|
unsigned long m = *mask++;
|
|
|
|
|
unsafe_put_user((compat_ulong_t)m, umask++, Efault);
|
|
|
|
|
unsafe_put_user(m >> BITS_PER_COMPAT_LONG, umask++, Efault);
|
|
|
|
|
nr_compat_longs -= 2;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2017-05-30 12:29:38 +08:00
|
|
|
if (nr_compat_longs)
|
|
|
|
|
unsafe_put_user((compat_ulong_t)*mask, umask++, Efault);
|
2020-04-03 15:20:51 +08:00
|
|
|
user_write_access_end();
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
2017-05-30 12:29:38 +08:00
|
|
|
Efault:
|
2020-04-03 15:20:51 +08:00
|
|
|
user_write_access_end();
|
2017-05-30 12:29:38 +08:00
|
|
|
return -EFAULT;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
2017-09-04 09:45:17 +08:00
|
|
|
int
|
|
|
|
|
get_compat_sigset(sigset_t *set, const compat_sigset_t __user *compat)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2017-09-04 09:45:17 +08:00
|
|
|
#ifdef __BIG_ENDIAN
|
|
|
|
|
compat_sigset_t v;
|
|
|
|
|
if (copy_from_user(&v, compat, sizeof(compat_sigset_t)))
|
|
|
|
|
return -EFAULT;
|
2005-04-17 06:20:36 +08:00
|
|
|
switch (_NSIG_WORDS) {
|
2017-09-04 09:45:17 +08:00
|
|
|
case 4: set->sig[3] = v.sig[6] | (((long)v.sig[7]) << 32 );
|
2019-05-15 13:23:52 +08:00
|
|
|
/* fall through */
|
2017-09-04 09:45:17 +08:00
|
|
|
case 3: set->sig[2] = v.sig[4] | (((long)v.sig[5]) << 32 );
|
2019-05-15 13:23:52 +08:00
|
|
|
/* fall through */
|
2017-09-04 09:45:17 +08:00
|
|
|
case 2: set->sig[1] = v.sig[2] | (((long)v.sig[3]) << 32 );
|
2019-05-15 13:23:52 +08:00
|
|
|
/* fall through */
|
2017-09-04 09:45:17 +08:00
|
|
|
case 1: set->sig[0] = v.sig[0] | (((long)v.sig[1]) << 32 );
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2017-09-04 09:45:17 +08:00
|
|
|
#else
|
|
|
|
|
if (copy_from_user(set, compat, sizeof(compat_sigset_t)))
|
|
|
|
|
return -EFAULT;
|
|
|
|
|
#endif
|
|
|
|
|
return 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2017-09-04 09:45:17 +08:00
|
|
|
EXPORT_SYMBOL_GPL(get_compat_sigset);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2010-09-08 07:16:18 +08:00
|
|
|
/*
|
|
|
|
|
* Allocate user-space memory for the duration of a single system call,
|
|
|
|
|
* in order to marshall parameters inside a compat thunk.
|
|
|
|
|
*/
|
|
|
|
|
void __user *compat_alloc_user_space(unsigned long len)
|
|
|
|
|
{
|
|
|
|
|
void __user *ptr;
|
|
|
|
|
|
|
|
|
|
/* If len would occupy more than half of the entire compat space... */
|
|
|
|
|
if (unlikely(len > (((compat_uptr_t)~0) >> 1)))
|
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
|
|
ptr = arch_compat_alloc_user_space(len);
|
|
|
|
|
|
Remove 'type' argument from access_ok() function
Nobody has actually used the type (VERIFY_READ vs VERIFY_WRITE) argument
of the user address range verification function since we got rid of the
old racy i386-only code to walk page tables by hand.
It existed because the original 80386 would not honor the write protect
bit when in kernel mode, so you had to do COW by hand before doing any
user access. But we haven't supported that in a long time, and these
days the 'type' argument is a purely historical artifact.
A discussion about extending 'user_access_begin()' to do the range
checking resulted this patch, because there is no way we're going to
move the old VERIFY_xyz interface to that model. And it's best done at
the end of the merge window when I've done most of my merges, so let's
just get this done once and for all.
This patch was mostly done with a sed-script, with manual fix-ups for
the cases that weren't of the trivial 'access_ok(VERIFY_xyz' form.
There were a couple of notable cases:
- csky still had the old "verify_area()" name as an alias.
- the iter_iov code had magical hardcoded knowledge of the actual
values of VERIFY_{READ,WRITE} (not that they mattered, since nothing
really used it)
- microblaze used the type argument for a debug printout
but other than those oddities this should be a total no-op patch.
I tried to fix up all architectures, did fairly extensive grepping for
access_ok() uses, and the changes are trivial, but I may have missed
something. Any missed conversion should be trivially fixable, though.
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2019-01-04 10:57:57 +08:00
|
|
|
if (unlikely(!access_ok(ptr, len)))
|
2010-09-08 07:16:18 +08:00
|
|
|
return NULL;
|
|
|
|
|
|
|
|
|
|
return ptr;
|
|
|
|
|
}
|
|
|
|
|
EXPORT_SYMBOL_GPL(compat_alloc_user_space);
|