2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* Network block device - make block devices work over TCP
|
|
|
|
*
|
|
|
|
* Note that you can not swap over this thing, yet. Seems to work but
|
|
|
|
* deadlocks sometimes - you can not swap over TCP in general.
|
|
|
|
*
|
2010-07-18 20:27:13 +08:00
|
|
|
* Copyright 1997-2000, 2008 Pavel Machek <pavel@ucw.cz>
|
2005-04-17 06:20:36 +08:00
|
|
|
* Parts copyright 2001 Steven Whitehouse <steve@chygwyn.com>
|
|
|
|
*
|
2006-06-25 20:47:42 +08:00
|
|
|
* This file is released under GPLv2 or later.
|
2005-04-17 06:20:36 +08:00
|
|
|
*
|
2006-06-25 20:47:42 +08:00
|
|
|
* (part of code stolen from loop.c)
|
2005-04-17 06:20:36 +08:00
|
|
|
*/
|
|
|
|
|
|
|
|
#include <linux/major.h>
|
|
|
|
|
|
|
|
#include <linux/blkdev.h>
|
|
|
|
#include <linux/module.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/sched.h>
|
|
|
|
#include <linux/fs.h>
|
|
|
|
#include <linux/bio.h>
|
|
|
|
#include <linux/stat.h>
|
|
|
|
#include <linux/errno.h>
|
|
|
|
#include <linux/file.h>
|
|
|
|
#include <linux/ioctl.h>
|
2010-06-02 20:28:52 +08:00
|
|
|
#include <linux/mutex.h>
|
2006-01-06 16:09:47 +08:00
|
|
|
#include <linux/compiler.h>
|
|
|
|
#include <linux/err.h>
|
|
|
|
#include <linux/kernel.h>
|
include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.
percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.
http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.
* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.
* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.
The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.
2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.
3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.
4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.
5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.
6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).
* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig
8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.
Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.
Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-24 16:04:11 +08:00
|
|
|
#include <linux/slab.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
#include <net/sock.h>
|
2007-11-13 10:10:39 +08:00
|
|
|
#include <linux/net.h>
|
2008-04-29 16:02:46 +08:00
|
|
|
#include <linux/kthread.h>
|
2015-04-02 16:11:37 +08:00
|
|
|
#include <linux/types.h>
|
2015-08-17 14:20:06 +08:00
|
|
|
#include <linux/debugfs.h>
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
#include <asm/uaccess.h>
|
|
|
|
#include <asm/types.h>
|
|
|
|
|
|
|
|
#include <linux/nbd.h>
|
|
|
|
|
2015-04-02 16:11:35 +08:00
|
|
|
struct nbd_device {
|
2015-08-17 14:20:09 +08:00
|
|
|
u32 flags;
|
2015-04-02 16:11:35 +08:00
|
|
|
struct socket * sock; /* If == NULL, device is not ready, yet */
|
|
|
|
int magic;
|
|
|
|
|
|
|
|
spinlock_t queue_lock;
|
|
|
|
struct list_head queue_head; /* Requests waiting result */
|
|
|
|
struct request *active_req;
|
|
|
|
wait_queue_head_t active_wq;
|
|
|
|
struct list_head waiting_queue; /* Requests to be sent */
|
|
|
|
wait_queue_head_t waiting_wq;
|
|
|
|
|
|
|
|
struct mutex tx_lock;
|
|
|
|
struct gendisk *disk;
|
|
|
|
int blksize;
|
2015-04-02 16:11:37 +08:00
|
|
|
loff_t bytesize;
|
2015-04-02 16:11:35 +08:00
|
|
|
int xmit_timeout;
|
2015-08-17 14:20:07 +08:00
|
|
|
bool disconnect; /* a disconnect has been requested by user */
|
2015-08-17 14:20:00 +08:00
|
|
|
|
|
|
|
struct timer_list timeout_timer;
|
2015-10-07 02:03:54 +08:00
|
|
|
spinlock_t tasks_lock;
|
2015-08-17 14:20:00 +08:00
|
|
|
struct task_struct *task_recv;
|
|
|
|
struct task_struct *task_send;
|
2015-08-17 14:20:06 +08:00
|
|
|
|
|
|
|
#if IS_ENABLED(CONFIG_DEBUG_FS)
|
|
|
|
struct dentry *dbg_dir;
|
|
|
|
#endif
|
2015-04-02 16:11:35 +08:00
|
|
|
};
|
|
|
|
|
2015-08-17 14:20:06 +08:00
|
|
|
#if IS_ENABLED(CONFIG_DEBUG_FS)
|
|
|
|
static struct dentry *nbd_dbg_dir;
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#define nbd_name(nbd) ((nbd)->disk->disk_name)
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
#define NBD_MAGIC 0x68797548
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2006-07-01 19:36:36 +08:00
|
|
|
static unsigned int nbds_max = 16;
|
2008-02-08 20:21:51 +08:00
|
|
|
static struct nbd_device *nbd_dev;
|
NBD: add partition support
Permit the use of partitions with network block devices (NBD).
A new parameter is introduced to define how many partition we want to be able
to manage per network block device. This parameter is "max_part".
For instance, to manage 63 partitions / loop device, we will do:
[on the server side]
# nbd-server 1234 /dev/sdb
[on the client side]
# modprobe nbd max_part=63
# ls -l /dev/nbd*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:14 /dev/nbd0
brw-rw---- 1 root disk 43, 64 2008-03-25 11:11 /dev/nbd1
brw-rw---- 1 root disk 43, 640 2008-03-25 11:11 /dev/nbd10
brw-rw---- 1 root disk 43, 704 2008-03-25 11:11 /dev/nbd11
brw-rw---- 1 root disk 43, 768 2008-03-25 11:11 /dev/nbd12
brw-rw---- 1 root disk 43, 832 2008-03-25 11:11 /dev/nbd13
brw-rw---- 1 root disk 43, 896 2008-03-25 11:11 /dev/nbd14
brw-rw---- 1 root disk 43, 960 2008-03-25 11:11 /dev/nbd15
brw-rw---- 1 root disk 43, 128 2008-03-25 11:11 /dev/nbd2
brw-rw---- 1 root disk 43, 192 2008-03-25 11:11 /dev/nbd3
brw-rw---- 1 root disk 43, 256 2008-03-25 11:11 /dev/nbd4
brw-rw---- 1 root disk 43, 320 2008-03-25 11:11 /dev/nbd5
brw-rw---- 1 root disk 43, 384 2008-03-25 11:11 /dev/nbd6
brw-rw---- 1 root disk 43, 448 2008-03-25 11:11 /dev/nbd7
brw-rw---- 1 root disk 43, 512 2008-03-25 11:11 /dev/nbd8
brw-rw---- 1 root disk 43, 576 2008-03-25 11:11 /dev/nbd9
# nbd-client localhost 1234 /dev/nbd0
Negotiation: ..size = 80418240KB
bs=1024, sz=80418240
-------NOTE, RFC: partition table is not automatically read.
The driver sets bdev->bd_invalidated to 1 to force the read of the partition
table of the device, but this is done only on an open of the device.
So we have to do a "touch /dev/nbdX" or something like that.
It can't be done from the nbd-client or nbd driver because at this
level we can't ask to read the partition table and to serve the request
at the same time (-> deadlock)
If someone has a better idea, I'm open to any suggestion.
-------NOTE, RFC
# fdisk -l /dev/nbd0
Disk /dev/nbd0: 82.3 GB, 82348277760 bytes
255 heads, 63 sectors/track, 10011 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Device Boot Start End Blocks Id System
/dev/nbd0p1 * 1 9965 80043831 83 Linux
/dev/nbd0p2 9966 10011 369495 5 Extended
/dev/nbd0p5 9966 10011 369463+ 82 Linux swap / Solaris
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
brw-rw---- 1 root disk 43, 1 2008-03-25 11:16 /dev/nbd0p1
brw-rw---- 1 root disk 43, 2 2008-03-25 11:16 /dev/nbd0p2
brw-rw---- 1 root disk 43, 5 2008-03-25 11:16 /dev/nbd0p5
# mount /dev/nbd0p1 /mnt
# ls /mnt
bin dev initrd lost+found opt sbin sys var
boot etc initrd.img media proc selinux tmp vmlinuz
cdrom home lib mnt root srv usr
# umount /mnt
# nbd-client -d /dev/nbd0
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
-------NOTE
On "nbd-client -d", we can do an iocl(BLKRRPART) to update partition table:
as the size of the device is 0, we don't have to serve the partition manager
request (-> no deadlock).
-------NOTE
Signed-off-by: Paul Clements <paul.clements@steeleye.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-29 16:02:51 +08:00
|
|
|
static int max_part;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
/*
|
|
|
|
* Use just one lock (or at most 1 per NIC). Two arguments for this:
|
|
|
|
* 1. Each NIC is essentially a synchronization point for all servers
|
|
|
|
* accessed through that NIC so there's no need to have more locks
|
|
|
|
* than NICs anyway.
|
|
|
|
* 2. More locks lead to more "Dirty cache line bouncing" which will slow
|
|
|
|
* down each lock to the point where they're actually slower than just
|
|
|
|
* a single lock.
|
|
|
|
* Thanks go to Jens Axboe and Al Viro for their LKML emails explaining this!
|
|
|
|
*/
|
|
|
|
static DEFINE_SPINLOCK(nbd_lock);
|
|
|
|
|
2015-04-02 16:11:38 +08:00
|
|
|
static inline struct device *nbd_to_dev(struct nbd_device *nbd)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2015-04-02 16:11:38 +08:00
|
|
|
return disk_to_dev(nbd->disk);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static const char *nbdcmd_to_ascii(int cmd)
|
|
|
|
{
|
|
|
|
switch (cmd) {
|
|
|
|
case NBD_CMD_READ: return "read";
|
|
|
|
case NBD_CMD_WRITE: return "write";
|
|
|
|
case NBD_CMD_DISC: return "disconnect";
|
nbd: support FLUSH requests
Currently, the NBD device does not accept flush requests from the Linux
block layer. If the NBD server opened the target with neither O_SYNC nor
O_DSYNC, however, the device will be effectively backed by a writeback
cache. Without issuing flushes properly, operation of the NBD device will
not be safe against power losses.
The NBD protocol has support for both a cache flush command and a FUA
command flag; the server will also pass a flag to note its support for
these features. This patch adds support for the cache flush command and
flag. In the kernel, we receive the flags via the NBD_SET_FLAGS ioctl,
and map NBD_FLAG_SEND_FLUSH to the argument of blk_queue_flush. When the
flag is active the block layer will send REQ_FLUSH requests, which we
translate to NBD_CMD_FLUSH commands.
FUA support is not included in this patch because all free software
servers implement it with a full fdatasync; thus it has no advantage over
supporting flush only. Because I [Paolo] cannot really benchmark it in a
realistic scenario, I cannot tell if it is a good idea or not. It is also
not clear if it is valid for an NBD server to support FUA but not flush.
The Linux block layer gives a warning for this combination, the NBD
protocol documentation says nothing about it.
The patch also fixes a small problem in the handling of flags: nbd->flags
must be cleared at the end of NBD_DO_IT, but the driver was not doing
that. The bug manifests itself as follows. Suppose you two different
client/server pairs to start the NBD device. Suppose also that the first
client supports NBD_SET_FLAGS, and the first server sends
NBD_FLAG_SEND_FLUSH; the second pair instead does neither of these two
things. Before this patch, the second invocation of NBD_DO_IT will use a
stale value of nbd->flags, and the second server will issue an error every
time it receives an NBD_CMD_FLUSH command.
This bug is pre-existing, but it becomes much more important after this
patch; flush failures make the device pretty much unusable, unlike
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bligh <alex@alex.org.uk>
Acked-by: Paul Clements <Paul.Clements@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:05:23 +08:00
|
|
|
case NBD_CMD_FLUSH: return "flush";
|
2012-10-05 08:16:18 +08:00
|
|
|
case NBD_CMD_TRIM: return "trim/discard";
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
return "invalid";
|
|
|
|
}
|
|
|
|
|
2015-04-02 16:11:38 +08:00
|
|
|
static void nbd_end_request(struct nbd_device *nbd, struct request *req)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2007-12-12 06:44:06 +08:00
|
|
|
int error = req->errors ? -EIO : 0;
|
2007-07-24 15:28:11 +08:00
|
|
|
struct request_queue *q = req->q;
|
2005-04-17 06:20:36 +08:00
|
|
|
unsigned long flags;
|
|
|
|
|
2015-04-02 16:11:38 +08:00
|
|
|
dev_dbg(nbd_to_dev(nbd), "request %p: %s\n", req,
|
|
|
|
error ? "failed" : "done");
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
spin_lock_irqsave(q->queue_lock, flags);
|
2009-05-07 21:24:45 +08:00
|
|
|
__blk_end_request_all(req, error);
|
2005-04-17 06:20:36 +08:00
|
|
|
spin_unlock_irqrestore(q->queue_lock, flags);
|
|
|
|
}
|
|
|
|
|
2015-04-02 16:11:39 +08:00
|
|
|
/*
|
|
|
|
* Forcibly shutdown the socket causing all listeners to error
|
|
|
|
*/
|
2015-08-17 14:20:01 +08:00
|
|
|
static void sock_shutdown(struct nbd_device *nbd)
|
2007-10-17 14:27:37 +08:00
|
|
|
{
|
2015-08-17 14:20:02 +08:00
|
|
|
if (!nbd->sock)
|
|
|
|
return;
|
|
|
|
|
|
|
|
dev_warn(disk_to_dev(nbd->disk), "shutting down socket\n");
|
|
|
|
kernel_sock_shutdown(nbd->sock, SHUT_RDWR);
|
|
|
|
nbd->sock = NULL;
|
|
|
|
del_timer_sync(&nbd->timeout_timer);
|
2007-10-17 14:27:37 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void nbd_xmit_timeout(unsigned long arg)
|
|
|
|
{
|
2015-08-17 14:20:00 +08:00
|
|
|
struct nbd_device *nbd = (struct nbd_device *)arg;
|
2015-10-07 02:03:54 +08:00
|
|
|
unsigned long flags;
|
2015-08-17 14:20:00 +08:00
|
|
|
|
|
|
|
if (list_empty(&nbd->queue_head))
|
|
|
|
return;
|
|
|
|
|
2015-08-17 14:20:07 +08:00
|
|
|
nbd->disconnect = true;
|
2015-08-17 14:20:00 +08:00
|
|
|
|
2015-10-07 02:03:54 +08:00
|
|
|
spin_lock_irqsave(&nbd->tasks_lock, flags);
|
|
|
|
|
|
|
|
if (nbd->task_recv)
|
|
|
|
force_sig(SIGKILL, nbd->task_recv);
|
2007-10-17 14:27:37 +08:00
|
|
|
|
2015-10-07 02:03:54 +08:00
|
|
|
if (nbd->task_send)
|
2015-08-17 14:20:00 +08:00
|
|
|
force_sig(SIGKILL, nbd->task_send);
|
|
|
|
|
2015-10-07 02:03:54 +08:00
|
|
|
spin_unlock_irqrestore(&nbd->tasks_lock, flags);
|
|
|
|
|
2015-08-17 14:20:00 +08:00
|
|
|
dev_err(nbd_to_dev(nbd), "Connection timed out, killed receiver and sender, shutting down connection\n");
|
2007-10-17 14:27:37 +08:00
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* Send or receive packet.
|
|
|
|
*/
|
2012-03-29 05:42:51 +08:00
|
|
|
static int sock_xmit(struct nbd_device *nbd, int send, void *buf, int size,
|
2005-04-17 06:20:36 +08:00
|
|
|
int msg_flags)
|
|
|
|
{
|
2012-03-29 05:42:51 +08:00
|
|
|
struct socket *sock = nbd->sock;
|
2005-04-17 06:20:36 +08:00
|
|
|
int result;
|
|
|
|
struct msghdr msg;
|
|
|
|
struct kvec iov;
|
2007-07-16 14:41:32 +08:00
|
|
|
sigset_t blocked, oldset;
|
2012-08-01 07:44:32 +08:00
|
|
|
unsigned long pflags = current->flags;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-04-03 04:04:47 +08:00
|
|
|
if (unlikely(!sock)) {
|
2012-03-29 05:42:51 +08:00
|
|
|
dev_err(disk_to_dev(nbd->disk),
|
2011-08-19 20:48:22 +08:00
|
|
|
"Attempted %s on closed socket in sock_xmit\n",
|
|
|
|
(send ? "send" : "recv"));
|
2008-04-03 04:04:47 +08:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/* Allow interception of SIGKILL only
|
|
|
|
* Don't allow other signals to interrupt the transmission */
|
2007-07-16 14:41:32 +08:00
|
|
|
siginitsetinv(&blocked, sigmask(SIGKILL));
|
|
|
|
sigprocmask(SIG_SETMASK, &blocked, &oldset);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-08-01 07:44:32 +08:00
|
|
|
current->flags |= PF_MEMALLOC;
|
2005-04-17 06:20:36 +08:00
|
|
|
do {
|
2012-08-01 07:44:32 +08:00
|
|
|
sock->sk->sk_allocation = GFP_NOIO | __GFP_MEMALLOC;
|
2005-04-17 06:20:36 +08:00
|
|
|
iov.iov_base = buf;
|
|
|
|
iov.iov_len = size;
|
|
|
|
msg.msg_name = NULL;
|
|
|
|
msg.msg_namelen = 0;
|
|
|
|
msg.msg_control = NULL;
|
|
|
|
msg.msg_controllen = 0;
|
|
|
|
msg.msg_flags = msg_flags | MSG_NOSIGNAL;
|
|
|
|
|
2015-08-17 14:20:00 +08:00
|
|
|
if (send)
|
2005-04-17 06:20:36 +08:00
|
|
|
result = kernel_sendmsg(sock, &msg, &iov, 1, size);
|
2015-08-17 14:20:00 +08:00
|
|
|
else
|
2011-05-28 20:44:46 +08:00
|
|
|
result = kernel_recvmsg(sock, &msg, &iov, 1, size,
|
|
|
|
msg.msg_flags);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
|
|
|
if (result <= 0) {
|
|
|
|
if (result == 0)
|
|
|
|
result = -EPIPE; /* short read */
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
size -= result;
|
|
|
|
buf += result;
|
|
|
|
} while (size > 0);
|
|
|
|
|
2007-07-16 14:41:32 +08:00
|
|
|
sigprocmask(SIG_SETMASK, &oldset, NULL);
|
2012-08-01 07:44:32 +08:00
|
|
|
tsk_restore_flags(current, pflags, PF_MEMALLOC);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2015-08-17 14:20:00 +08:00
|
|
|
if (!send && nbd->xmit_timeout)
|
|
|
|
mod_timer(&nbd->timeout_timer, jiffies + nbd->xmit_timeout);
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
static inline int sock_send_bvec(struct nbd_device *nbd, struct bio_vec *bvec,
|
2005-04-17 06:20:36 +08:00
|
|
|
int flags)
|
|
|
|
{
|
|
|
|
int result;
|
|
|
|
void *kaddr = kmap(bvec->bv_page);
|
2012-03-29 05:42:51 +08:00
|
|
|
result = sock_xmit(nbd, 1, kaddr + bvec->bv_offset,
|
|
|
|
bvec->bv_len, flags);
|
2005-04-17 06:20:36 +08:00
|
|
|
kunmap(bvec->bv_page);
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2007-10-17 14:27:37 +08:00
|
|
|
/* always call with the tx_lock held */
|
2012-03-29 05:42:51 +08:00
|
|
|
static int nbd_send_req(struct nbd_device *nbd, struct request *req)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2007-09-25 18:35:59 +08:00
|
|
|
int result, flags;
|
2005-04-17 06:20:36 +08:00
|
|
|
struct nbd_request request;
|
2009-05-07 21:24:45 +08:00
|
|
|
unsigned long size = blk_rq_bytes(req);
|
2015-04-18 04:37:21 +08:00
|
|
|
u32 type;
|
|
|
|
|
|
|
|
if (req->cmd_type == REQ_TYPE_DRV_PRIV)
|
|
|
|
type = NBD_CMD_DISC;
|
|
|
|
else if (req->cmd_flags & REQ_DISCARD)
|
|
|
|
type = NBD_CMD_TRIM;
|
|
|
|
else if (req->cmd_flags & REQ_FLUSH)
|
|
|
|
type = NBD_CMD_FLUSH;
|
|
|
|
else if (rq_data_dir(req) == WRITE)
|
|
|
|
type = NBD_CMD_WRITE;
|
|
|
|
else
|
|
|
|
type = NBD_CMD_READ;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2014-06-07 05:38:30 +08:00
|
|
|
memset(&request, 0, sizeof(request));
|
2005-04-17 06:20:36 +08:00
|
|
|
request.magic = htonl(NBD_REQUEST_MAGIC);
|
2015-04-18 04:37:21 +08:00
|
|
|
request.type = htonl(type);
|
|
|
|
if (type != NBD_CMD_FLUSH && type != NBD_CMD_DISC) {
|
nbd: support FLUSH requests
Currently, the NBD device does not accept flush requests from the Linux
block layer. If the NBD server opened the target with neither O_SYNC nor
O_DSYNC, however, the device will be effectively backed by a writeback
cache. Without issuing flushes properly, operation of the NBD device will
not be safe against power losses.
The NBD protocol has support for both a cache flush command and a FUA
command flag; the server will also pass a flag to note its support for
these features. This patch adds support for the cache flush command and
flag. In the kernel, we receive the flags via the NBD_SET_FLAGS ioctl,
and map NBD_FLAG_SEND_FLUSH to the argument of blk_queue_flush. When the
flag is active the block layer will send REQ_FLUSH requests, which we
translate to NBD_CMD_FLUSH commands.
FUA support is not included in this patch because all free software
servers implement it with a full fdatasync; thus it has no advantage over
supporting flush only. Because I [Paolo] cannot really benchmark it in a
realistic scenario, I cannot tell if it is a good idea or not. It is also
not clear if it is valid for an NBD server to support FUA but not flush.
The Linux block layer gives a warning for this combination, the NBD
protocol documentation says nothing about it.
The patch also fixes a small problem in the handling of flags: nbd->flags
must be cleared at the end of NBD_DO_IT, but the driver was not doing
that. The bug manifests itself as follows. Suppose you two different
client/server pairs to start the NBD device. Suppose also that the first
client supports NBD_SET_FLAGS, and the first server sends
NBD_FLAG_SEND_FLUSH; the second pair instead does neither of these two
things. Before this patch, the second invocation of NBD_DO_IT will use a
stale value of nbd->flags, and the second server will issue an error every
time it receives an NBD_CMD_FLUSH command.
This bug is pre-existing, but it becomes much more important after this
patch; flush failures make the device pretty much unusable, unlike
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bligh <alex@alex.org.uk>
Acked-by: Paul Clements <Paul.Clements@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:05:23 +08:00
|
|
|
request.from = cpu_to_be64((u64)blk_rq_pos(req) << 9);
|
|
|
|
request.len = htonl(size);
|
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
memcpy(request.handle, &req, sizeof(req));
|
|
|
|
|
2015-04-02 16:11:38 +08:00
|
|
|
dev_dbg(nbd_to_dev(nbd), "request %p: sending control (%s@%llu,%uB)\n",
|
2015-04-18 04:37:21 +08:00
|
|
|
req, nbdcmd_to_ascii(type),
|
2015-04-02 16:11:38 +08:00
|
|
|
(unsigned long long)blk_rq_pos(req) << 9, blk_rq_bytes(req));
|
2012-03-29 05:42:51 +08:00
|
|
|
result = sock_xmit(nbd, 1, &request, sizeof(request),
|
2015-04-18 04:37:21 +08:00
|
|
|
(type == NBD_CMD_WRITE) ? MSG_MORE : 0);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (result <= 0) {
|
2012-03-29 05:42:51 +08:00
|
|
|
dev_err(disk_to_dev(nbd->disk),
|
2011-08-19 20:48:22 +08:00
|
|
|
"Send control failed (result %d)\n", result);
|
2015-04-02 16:11:40 +08:00
|
|
|
return -EIO;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2015-04-18 04:37:21 +08:00
|
|
|
if (type == NBD_CMD_WRITE) {
|
2007-09-25 18:35:59 +08:00
|
|
|
struct req_iterator iter;
|
2013-11-24 09:19:00 +08:00
|
|
|
struct bio_vec bvec;
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* we are really probing at internals to determine
|
|
|
|
* whether to set MSG_MORE or not...
|
|
|
|
*/
|
2007-09-25 18:35:59 +08:00
|
|
|
rq_for_each_segment(bvec, req, iter) {
|
2007-08-16 19:43:12 +08:00
|
|
|
flags = 0;
|
2013-08-08 05:26:21 +08:00
|
|
|
if (!rq_iter_last(bvec, iter))
|
2007-08-16 19:43:12 +08:00
|
|
|
flags = MSG_MORE;
|
2015-04-02 16:11:38 +08:00
|
|
|
dev_dbg(nbd_to_dev(nbd), "request %p: sending %d bytes data\n",
|
|
|
|
req, bvec.bv_len);
|
2013-11-24 09:19:00 +08:00
|
|
|
result = sock_send_bvec(nbd, &bvec, flags);
|
2007-08-16 19:43:12 +08:00
|
|
|
if (result <= 0) {
|
2012-03-29 05:42:51 +08:00
|
|
|
dev_err(disk_to_dev(nbd->disk),
|
2011-08-19 20:48:22 +08:00
|
|
|
"Send data failed (result %d)\n",
|
|
|
|
result);
|
2015-04-02 16:11:40 +08:00
|
|
|
return -EIO;
|
2007-08-16 19:43:12 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
static struct request *nbd_find_request(struct nbd_device *nbd,
|
2007-10-17 14:26:14 +08:00
|
|
|
struct request *xreq)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
2007-10-17 14:26:14 +08:00
|
|
|
struct request *req, *tmp;
|
2006-01-06 16:09:47 +08:00
|
|
|
int err;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
err = wait_event_interruptible(nbd->active_wq, nbd->active_req != xreq);
|
2006-01-06 16:09:47 +08:00
|
|
|
if (unlikely(err))
|
2015-04-02 16:11:41 +08:00
|
|
|
return ERR_PTR(err);
|
2006-01-06 16:09:47 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
spin_lock(&nbd->queue_lock);
|
|
|
|
list_for_each_entry_safe(req, tmp, &nbd->queue_head, queuelist) {
|
2005-04-17 06:20:36 +08:00
|
|
|
if (req != xreq)
|
|
|
|
continue;
|
|
|
|
list_del_init(&req->queuelist);
|
2012-03-29 05:42:51 +08:00
|
|
|
spin_unlock(&nbd->queue_lock);
|
2005-04-17 06:20:36 +08:00
|
|
|
return req;
|
|
|
|
}
|
2012-03-29 05:42:51 +08:00
|
|
|
spin_unlock(&nbd->queue_lock);
|
2006-01-06 16:09:47 +08:00
|
|
|
|
2015-04-02 16:11:41 +08:00
|
|
|
return ERR_PTR(-ENOENT);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
static inline int sock_recv_bvec(struct nbd_device *nbd, struct bio_vec *bvec)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
int result;
|
|
|
|
void *kaddr = kmap(bvec->bv_page);
|
2012-03-29 05:42:51 +08:00
|
|
|
result = sock_xmit(nbd, 0, kaddr + bvec->bv_offset, bvec->bv_len,
|
2005-04-17 06:20:36 +08:00
|
|
|
MSG_WAITALL);
|
|
|
|
kunmap(bvec->bv_page);
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* NULL returned = something went wrong, inform userspace */
|
2012-03-29 05:42:51 +08:00
|
|
|
static struct request *nbd_read_stat(struct nbd_device *nbd)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
int result;
|
|
|
|
struct nbd_reply reply;
|
|
|
|
struct request *req;
|
|
|
|
|
|
|
|
reply.magic = 0;
|
2012-03-29 05:42:51 +08:00
|
|
|
result = sock_xmit(nbd, 0, &reply, sizeof(reply), MSG_WAITALL);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (result <= 0) {
|
2012-03-29 05:42:51 +08:00
|
|
|
dev_err(disk_to_dev(nbd->disk),
|
2011-08-19 20:48:22 +08:00
|
|
|
"Receive control failed (result %d)\n", result);
|
2015-08-17 14:20:03 +08:00
|
|
|
return ERR_PTR(result);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2006-07-30 18:03:31 +08:00
|
|
|
|
|
|
|
if (ntohl(reply.magic) != NBD_REPLY_MAGIC) {
|
2012-03-29 05:42:51 +08:00
|
|
|
dev_err(disk_to_dev(nbd->disk), "Wrong magic (0x%lx)\n",
|
2006-07-30 18:03:31 +08:00
|
|
|
(unsigned long)ntohl(reply.magic));
|
2015-08-17 14:20:03 +08:00
|
|
|
return ERR_PTR(-EPROTO);
|
2006-07-30 18:03:31 +08:00
|
|
|
}
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
req = nbd_find_request(nbd, *(struct request **)reply.handle);
|
2008-04-29 16:03:09 +08:00
|
|
|
if (IS_ERR(req)) {
|
2006-01-06 16:09:47 +08:00
|
|
|
result = PTR_ERR(req);
|
|
|
|
if (result != -ENOENT)
|
2015-08-17 14:20:03 +08:00
|
|
|
return ERR_PTR(result);
|
2006-01-06 16:09:47 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
dev_err(disk_to_dev(nbd->disk), "Unexpected reply (%p)\n",
|
2011-08-19 20:48:22 +08:00
|
|
|
reply.handle);
|
2015-08-17 14:20:03 +08:00
|
|
|
return ERR_PTR(-EBADR);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (ntohl(reply.error)) {
|
2012-03-29 05:42:51 +08:00
|
|
|
dev_err(disk_to_dev(nbd->disk), "Other side returned error (%d)\n",
|
2011-08-19 20:48:22 +08:00
|
|
|
ntohl(reply.error));
|
2005-04-17 06:20:36 +08:00
|
|
|
req->errors++;
|
|
|
|
return req;
|
|
|
|
}
|
|
|
|
|
2015-04-02 16:11:38 +08:00
|
|
|
dev_dbg(nbd_to_dev(nbd), "request %p: got reply\n", req);
|
2015-04-18 04:37:21 +08:00
|
|
|
if (rq_data_dir(req) != WRITE) {
|
2007-09-25 18:35:59 +08:00
|
|
|
struct req_iterator iter;
|
2013-11-24 09:19:00 +08:00
|
|
|
struct bio_vec bvec;
|
2007-09-25 18:35:59 +08:00
|
|
|
|
|
|
|
rq_for_each_segment(bvec, req, iter) {
|
2013-11-24 09:19:00 +08:00
|
|
|
result = sock_recv_bvec(nbd, &bvec);
|
2007-08-16 19:43:12 +08:00
|
|
|
if (result <= 0) {
|
2012-03-29 05:42:51 +08:00
|
|
|
dev_err(disk_to_dev(nbd->disk), "Receive data failed (result %d)\n",
|
2011-08-19 20:48:22 +08:00
|
|
|
result);
|
2007-08-16 19:43:12 +08:00
|
|
|
req->errors++;
|
|
|
|
return req;
|
|
|
|
}
|
2015-04-02 16:11:38 +08:00
|
|
|
dev_dbg(nbd_to_dev(nbd), "request %p: got %d bytes data\n",
|
|
|
|
req, bvec.bv_len);
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return req;
|
|
|
|
}
|
|
|
|
|
2007-05-22 04:08:01 +08:00
|
|
|
static ssize_t pid_show(struct device *dev,
|
|
|
|
struct device_attribute *attr, char *buf)
|
2006-12-07 12:40:53 +08:00
|
|
|
{
|
2007-05-22 04:08:01 +08:00
|
|
|
struct gendisk *disk = dev_to_disk(dev);
|
2015-08-17 14:20:05 +08:00
|
|
|
struct nbd_device *nbd = (struct nbd_device *)disk->private_data;
|
2007-05-22 04:08:01 +08:00
|
|
|
|
2015-08-17 14:20:05 +08:00
|
|
|
return sprintf(buf, "%d\n", task_pid_nr(nbd->task_recv));
|
2006-12-07 12:40:53 +08:00
|
|
|
}
|
|
|
|
|
2007-05-22 04:08:01 +08:00
|
|
|
static struct device_attribute pid_attr = {
|
2008-10-19 11:28:50 +08:00
|
|
|
.attr = { .name = "pid", .mode = S_IRUGO},
|
2006-12-07 12:40:53 +08:00
|
|
|
.show = pid_show,
|
|
|
|
};
|
|
|
|
|
2015-08-17 14:20:08 +08:00
|
|
|
static int nbd_thread_recv(struct nbd_device *nbd)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct request *req;
|
2007-05-09 17:33:36 +08:00
|
|
|
int ret;
|
2015-10-07 02:03:54 +08:00
|
|
|
unsigned long flags;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
BUG_ON(nbd->magic != NBD_MAGIC);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-08-01 07:44:32 +08:00
|
|
|
sk_set_memalloc(nbd->sock->sk);
|
2015-08-17 14:20:05 +08:00
|
|
|
|
2015-10-07 02:03:54 +08:00
|
|
|
spin_lock_irqsave(&nbd->tasks_lock, flags);
|
2015-08-17 14:20:05 +08:00
|
|
|
nbd->task_recv = current;
|
2015-10-07 02:03:54 +08:00
|
|
|
spin_unlock_irqrestore(&nbd->tasks_lock, flags);
|
2015-08-17 14:20:05 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
ret = device_create_file(disk_to_dev(nbd->disk), &pid_attr);
|
2007-05-09 17:33:36 +08:00
|
|
|
if (ret) {
|
2012-03-29 05:42:51 +08:00
|
|
|
dev_err(disk_to_dev(nbd->disk), "device_create_file failed!\n");
|
2015-10-07 02:03:54 +08:00
|
|
|
|
|
|
|
spin_lock_irqsave(&nbd->tasks_lock, flags);
|
2015-08-17 14:20:05 +08:00
|
|
|
nbd->task_recv = NULL;
|
2015-10-07 02:03:54 +08:00
|
|
|
spin_unlock_irqrestore(&nbd->tasks_lock, flags);
|
|
|
|
|
2007-05-09 17:33:36 +08:00
|
|
|
return ret;
|
|
|
|
}
|
2006-12-07 12:40:53 +08:00
|
|
|
|
2015-08-17 14:20:03 +08:00
|
|
|
while (1) {
|
|
|
|
req = nbd_read_stat(nbd);
|
|
|
|
if (IS_ERR(req)) {
|
|
|
|
ret = PTR_ERR(req);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2015-04-02 16:11:38 +08:00
|
|
|
nbd_end_request(nbd, req);
|
2015-08-17 14:20:03 +08:00
|
|
|
}
|
2006-12-07 12:40:53 +08:00
|
|
|
|
2015-08-17 14:20:05 +08:00
|
|
|
device_remove_file(disk_to_dev(nbd->disk), &pid_attr);
|
|
|
|
|
2015-10-07 02:03:54 +08:00
|
|
|
spin_lock_irqsave(&nbd->tasks_lock, flags);
|
2015-08-17 14:20:00 +08:00
|
|
|
nbd->task_recv = NULL;
|
2015-10-07 02:03:54 +08:00
|
|
|
spin_unlock_irqrestore(&nbd->tasks_lock, flags);
|
2015-08-17 14:20:00 +08:00
|
|
|
|
|
|
|
if (signal_pending(current)) {
|
2015-11-07 08:32:22 +08:00
|
|
|
ret = kernel_dequeue_signal(NULL);
|
2015-08-17 14:20:00 +08:00
|
|
|
dev_warn(nbd_to_dev(nbd), "pid %d, %s, got signal %d\n",
|
|
|
|
task_pid_nr(current), current->comm, ret);
|
2015-08-17 14:20:01 +08:00
|
|
|
mutex_lock(&nbd->tx_lock);
|
|
|
|
sock_shutdown(nbd);
|
|
|
|
mutex_unlock(&nbd->tx_lock);
|
2015-08-17 14:20:00 +08:00
|
|
|
ret = -ETIMEDOUT;
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
static void nbd_clear_que(struct nbd_device *nbd)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct request *req;
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
BUG_ON(nbd->magic != NBD_MAGIC);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2006-01-06 16:09:47 +08:00
|
|
|
/*
|
2012-03-29 05:42:51 +08:00
|
|
|
* Because we have set nbd->sock to NULL under the tx_lock, all
|
2006-01-06 16:09:47 +08:00
|
|
|
* modifications to the list must have completed by now. For
|
|
|
|
* the same reason, the active_req must be NULL.
|
|
|
|
*
|
|
|
|
* As a consequence, we don't need to take the spin lock while
|
|
|
|
* purging the list here.
|
|
|
|
*/
|
2012-03-29 05:42:51 +08:00
|
|
|
BUG_ON(nbd->sock);
|
|
|
|
BUG_ON(nbd->active_req);
|
2006-01-06 16:09:47 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
while (!list_empty(&nbd->queue_head)) {
|
|
|
|
req = list_entry(nbd->queue_head.next, struct request,
|
2006-01-06 16:09:47 +08:00
|
|
|
queuelist);
|
|
|
|
list_del_init(&req->queuelist);
|
|
|
|
req->errors++;
|
2015-04-02 16:11:38 +08:00
|
|
|
nbd_end_request(nbd, req);
|
2006-01-06 16:09:47 +08:00
|
|
|
}
|
2012-09-18 05:09:02 +08:00
|
|
|
|
|
|
|
while (!list_empty(&nbd->waiting_queue)) {
|
|
|
|
req = list_entry(nbd->waiting_queue.next, struct request,
|
|
|
|
queuelist);
|
|
|
|
list_del_init(&req->queuelist);
|
|
|
|
req->errors++;
|
2015-04-02 16:11:38 +08:00
|
|
|
nbd_end_request(nbd, req);
|
2012-09-18 05:09:02 +08:00
|
|
|
}
|
2015-08-17 14:20:04 +08:00
|
|
|
dev_dbg(disk_to_dev(nbd->disk), "queue cleared\n");
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2007-10-17 14:27:37 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
static void nbd_handle_req(struct nbd_device *nbd, struct request *req)
|
2008-04-29 16:02:46 +08:00
|
|
|
{
|
2010-08-08 00:17:56 +08:00
|
|
|
if (req->cmd_type != REQ_TYPE_FS)
|
2008-04-29 16:02:46 +08:00
|
|
|
goto error_out;
|
|
|
|
|
2015-04-18 04:37:21 +08:00
|
|
|
if (rq_data_dir(req) == WRITE &&
|
|
|
|
(nbd->flags & NBD_FLAG_READ_ONLY)) {
|
|
|
|
dev_err(disk_to_dev(nbd->disk),
|
|
|
|
"Write on read-only\n");
|
|
|
|
goto error_out;
|
nbd: support FLUSH requests
Currently, the NBD device does not accept flush requests from the Linux
block layer. If the NBD server opened the target with neither O_SYNC nor
O_DSYNC, however, the device will be effectively backed by a writeback
cache. Without issuing flushes properly, operation of the NBD device will
not be safe against power losses.
The NBD protocol has support for both a cache flush command and a FUA
command flag; the server will also pass a flag to note its support for
these features. This patch adds support for the cache flush command and
flag. In the kernel, we receive the flags via the NBD_SET_FLAGS ioctl,
and map NBD_FLAG_SEND_FLUSH to the argument of blk_queue_flush. When the
flag is active the block layer will send REQ_FLUSH requests, which we
translate to NBD_CMD_FLUSH commands.
FUA support is not included in this patch because all free software
servers implement it with a full fdatasync; thus it has no advantage over
supporting flush only. Because I [Paolo] cannot really benchmark it in a
realistic scenario, I cannot tell if it is a good idea or not. It is also
not clear if it is valid for an NBD server to support FUA but not flush.
The Linux block layer gives a warning for this combination, the NBD
protocol documentation says nothing about it.
The patch also fixes a small problem in the handling of flags: nbd->flags
must be cleared at the end of NBD_DO_IT, but the driver was not doing
that. The bug manifests itself as follows. Suppose you two different
client/server pairs to start the NBD device. Suppose also that the first
client supports NBD_SET_FLAGS, and the first server sends
NBD_FLAG_SEND_FLUSH; the second pair instead does neither of these two
things. Before this patch, the second invocation of NBD_DO_IT will use a
stale value of nbd->flags, and the second server will issue an error every
time it receives an NBD_CMD_FLUSH command.
This bug is pre-existing, but it becomes much more important after this
patch; flush failures make the device pretty much unusable, unlike
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bligh <alex@alex.org.uk>
Acked-by: Paul Clements <Paul.Clements@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:05:23 +08:00
|
|
|
}
|
|
|
|
|
2008-04-29 16:02:46 +08:00
|
|
|
req->errors = 0;
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
mutex_lock(&nbd->tx_lock);
|
|
|
|
if (unlikely(!nbd->sock)) {
|
|
|
|
mutex_unlock(&nbd->tx_lock);
|
|
|
|
dev_err(disk_to_dev(nbd->disk),
|
2011-08-19 20:48:22 +08:00
|
|
|
"Attempted send on closed socket\n");
|
2009-04-03 07:58:42 +08:00
|
|
|
goto error_out;
|
2008-04-29 16:02:46 +08:00
|
|
|
}
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd->active_req = req;
|
2008-04-29 16:02:46 +08:00
|
|
|
|
2015-08-17 14:20:00 +08:00
|
|
|
if (nbd->xmit_timeout && list_empty_careful(&nbd->queue_head))
|
|
|
|
mod_timer(&nbd->timeout_timer, jiffies + nbd->xmit_timeout);
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
if (nbd_send_req(nbd, req) != 0) {
|
|
|
|
dev_err(disk_to_dev(nbd->disk), "Request send failed\n");
|
2008-04-29 16:02:46 +08:00
|
|
|
req->errors++;
|
2015-04-02 16:11:38 +08:00
|
|
|
nbd_end_request(nbd, req);
|
2008-04-29 16:02:46 +08:00
|
|
|
} else {
|
2012-03-29 05:42:51 +08:00
|
|
|
spin_lock(&nbd->queue_lock);
|
2012-07-31 14:47:13 +08:00
|
|
|
list_add_tail(&req->queuelist, &nbd->queue_head);
|
2012-03-29 05:42:51 +08:00
|
|
|
spin_unlock(&nbd->queue_lock);
|
2008-04-29 16:02:46 +08:00
|
|
|
}
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd->active_req = NULL;
|
|
|
|
mutex_unlock(&nbd->tx_lock);
|
|
|
|
wake_up_all(&nbd->active_wq);
|
2008-04-29 16:02:46 +08:00
|
|
|
|
|
|
|
return;
|
|
|
|
|
|
|
|
error_out:
|
|
|
|
req->errors++;
|
2015-04-02 16:11:38 +08:00
|
|
|
nbd_end_request(nbd, req);
|
2008-04-29 16:02:46 +08:00
|
|
|
}
|
|
|
|
|
2015-08-17 14:20:08 +08:00
|
|
|
static int nbd_thread_send(void *data)
|
2008-04-29 16:02:46 +08:00
|
|
|
{
|
2012-03-29 05:42:51 +08:00
|
|
|
struct nbd_device *nbd = data;
|
2008-04-29 16:02:46 +08:00
|
|
|
struct request *req;
|
2015-10-07 02:03:54 +08:00
|
|
|
unsigned long flags;
|
2008-04-29 16:02:46 +08:00
|
|
|
|
2015-10-07 02:03:54 +08:00
|
|
|
spin_lock_irqsave(&nbd->tasks_lock, flags);
|
2015-08-17 14:20:00 +08:00
|
|
|
nbd->task_send = current;
|
2015-10-07 02:03:54 +08:00
|
|
|
spin_unlock_irqrestore(&nbd->tasks_lock, flags);
|
2015-08-17 14:20:00 +08:00
|
|
|
|
2014-03-11 18:09:12 +08:00
|
|
|
set_user_nice(current, MIN_NICE);
|
2012-03-29 05:42:51 +08:00
|
|
|
while (!kthread_should_stop() || !list_empty(&nbd->waiting_queue)) {
|
2008-04-29 16:02:46 +08:00
|
|
|
/* wait for something to do */
|
2012-03-29 05:42:51 +08:00
|
|
|
wait_event_interruptible(nbd->waiting_wq,
|
2008-04-29 16:02:46 +08:00
|
|
|
kthread_should_stop() ||
|
2012-03-29 05:42:51 +08:00
|
|
|
!list_empty(&nbd->waiting_queue));
|
2008-04-29 16:02:46 +08:00
|
|
|
|
2015-08-17 14:20:00 +08:00
|
|
|
if (signal_pending(current)) {
|
2015-11-07 08:32:22 +08:00
|
|
|
int ret = kernel_dequeue_signal(NULL);
|
2015-08-17 14:20:00 +08:00
|
|
|
|
|
|
|
dev_warn(nbd_to_dev(nbd), "pid %d, %s, got signal %d\n",
|
|
|
|
task_pid_nr(current), current->comm, ret);
|
2015-08-17 14:20:01 +08:00
|
|
|
mutex_lock(&nbd->tx_lock);
|
|
|
|
sock_shutdown(nbd);
|
|
|
|
mutex_unlock(&nbd->tx_lock);
|
2015-08-17 14:20:00 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2008-04-29 16:02:46 +08:00
|
|
|
/* extract request */
|
2012-03-29 05:42:51 +08:00
|
|
|
if (list_empty(&nbd->waiting_queue))
|
2008-04-29 16:02:46 +08:00
|
|
|
continue;
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
spin_lock_irq(&nbd->queue_lock);
|
|
|
|
req = list_entry(nbd->waiting_queue.next, struct request,
|
2008-04-29 16:02:46 +08:00
|
|
|
queuelist);
|
|
|
|
list_del_init(&req->queuelist);
|
2012-03-29 05:42:51 +08:00
|
|
|
spin_unlock_irq(&nbd->queue_lock);
|
2008-04-29 16:02:46 +08:00
|
|
|
|
|
|
|
/* handle request */
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd_handle_req(nbd, req);
|
2008-04-29 16:02:46 +08:00
|
|
|
}
|
2015-08-17 14:20:00 +08:00
|
|
|
|
2015-10-07 02:03:54 +08:00
|
|
|
spin_lock_irqsave(&nbd->tasks_lock, flags);
|
2015-08-17 14:20:00 +08:00
|
|
|
nbd->task_send = NULL;
|
2015-10-07 02:03:54 +08:00
|
|
|
spin_unlock_irqrestore(&nbd->tasks_lock, flags);
|
|
|
|
|
|
|
|
/* Clear maybe pending signals */
|
2015-11-07 08:32:22 +08:00
|
|
|
if (signal_pending(current))
|
|
|
|
kernel_dequeue_signal(NULL);
|
2015-08-17 14:20:00 +08:00
|
|
|
|
2008-04-29 16:02:46 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* We always wait for result of write, for now. It would be nice to make it optional
|
|
|
|
* in future
|
2012-03-29 05:42:51 +08:00
|
|
|
* if ((rq_data_dir(req) == WRITE) && (nbd->flags & NBD_WRITE_NOCHK))
|
2005-04-17 06:20:36 +08:00
|
|
|
* { printk( "Warning: Ignoring result!\n"); nbd_end_request( req ); }
|
|
|
|
*/
|
|
|
|
|
2015-08-17 14:20:08 +08:00
|
|
|
static void nbd_request_handler(struct request_queue *q)
|
2013-02-28 09:05:28 +08:00
|
|
|
__releases(q->queue_lock) __acquires(q->queue_lock)
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
struct request *req;
|
|
|
|
|
2009-05-08 10:54:16 +08:00
|
|
|
while ((req = blk_fetch_request(q)) != NULL) {
|
2012-03-29 05:42:51 +08:00
|
|
|
struct nbd_device *nbd;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2008-04-29 16:02:46 +08:00
|
|
|
spin_unlock_irq(q->queue_lock);
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd = req->rq_disk->private_data;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
BUG_ON(nbd->magic != NBD_MAGIC);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2015-04-02 16:11:38 +08:00
|
|
|
dev_dbg(nbd_to_dev(nbd), "request %p: dequeued (flags=%x)\n",
|
|
|
|
req, req->cmd_type);
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
if (unlikely(!nbd->sock)) {
|
|
|
|
dev_err(disk_to_dev(nbd->disk),
|
2011-08-19 20:48:22 +08:00
|
|
|
"Attempted send on closed socket\n");
|
2009-02-12 05:04:45 +08:00
|
|
|
req->errors++;
|
2015-04-02 16:11:38 +08:00
|
|
|
nbd_end_request(nbd, req);
|
2009-02-12 05:04:45 +08:00
|
|
|
spin_lock_irq(q->queue_lock);
|
|
|
|
continue;
|
|
|
|
}
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
spin_lock_irq(&nbd->queue_lock);
|
|
|
|
list_add_tail(&req->queuelist, &nbd->waiting_queue);
|
|
|
|
spin_unlock_irq(&nbd->queue_lock);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
wake_up(&nbd->waiting_wq);
|
2006-01-06 16:09:47 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
spin_lock_irq(q->queue_lock);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-08-17 14:20:06 +08:00
|
|
|
static int nbd_dev_dbg_init(struct nbd_device *nbd);
|
|
|
|
static void nbd_dev_dbg_close(struct nbd_device *nbd);
|
|
|
|
|
2009-04-03 07:58:41 +08:00
|
|
|
/* Must be called with tx_lock held */
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
static int __nbd_ioctl(struct block_device *bdev, struct nbd_device *nbd,
|
2009-04-03 07:58:41 +08:00
|
|
|
unsigned int cmd, unsigned long arg)
|
|
|
|
{
|
2005-04-17 06:20:36 +08:00
|
|
|
switch (cmd) {
|
2009-04-03 07:58:41 +08:00
|
|
|
case NBD_DISCONNECT: {
|
|
|
|
struct request sreq;
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
dev_info(disk_to_dev(nbd->disk), "NBD_DISCONNECT\n");
|
2013-02-28 09:05:25 +08:00
|
|
|
if (!nbd->sock)
|
|
|
|
return -EINVAL;
|
2009-04-03 07:58:41 +08:00
|
|
|
|
2013-02-28 09:05:25 +08:00
|
|
|
mutex_unlock(&nbd->tx_lock);
|
|
|
|
fsync_bdev(bdev);
|
|
|
|
mutex_lock(&nbd->tx_lock);
|
2008-04-29 15:54:37 +08:00
|
|
|
blk_rq_init(NULL, &sreq);
|
2015-04-18 04:37:16 +08:00
|
|
|
sreq.cmd_type = REQ_TYPE_DRV_PRIV;
|
2013-02-28 09:05:25 +08:00
|
|
|
|
|
|
|
/* Check again after getting mutex back. */
|
2012-03-29 05:42:51 +08:00
|
|
|
if (!nbd->sock)
|
2005-04-17 06:20:36 +08:00
|
|
|
return -EINVAL;
|
2013-02-28 09:05:25 +08:00
|
|
|
|
2015-08-17 14:20:07 +08:00
|
|
|
nbd->disconnect = true;
|
2013-07-04 06:09:04 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd_send_req(nbd, &sreq);
|
2013-07-04 06:09:04 +08:00
|
|
|
return 0;
|
2009-04-03 07:58:41 +08:00
|
|
|
}
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2009-04-03 07:58:41 +08:00
|
|
|
case NBD_CLEAR_SOCK: {
|
2014-03-06 09:41:36 +08:00
|
|
|
struct socket *sock = nbd->sock;
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd->sock = NULL;
|
|
|
|
nbd_clear_que(nbd);
|
|
|
|
BUG_ON(!list_empty(&nbd->queue_head));
|
2012-09-18 05:09:02 +08:00
|
|
|
BUG_ON(!list_empty(&nbd->waiting_queue));
|
2013-02-28 09:05:25 +08:00
|
|
|
kill_bdev(bdev);
|
2014-03-06 09:41:36 +08:00
|
|
|
if (sock)
|
|
|
|
sockfd_put(sock);
|
2009-04-03 07:58:41 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
case NBD_SET_SOCK: {
|
2014-03-06 09:41:36 +08:00
|
|
|
struct socket *sock;
|
|
|
|
int err;
|
|
|
|
if (nbd->sock)
|
2005-04-17 06:20:36 +08:00
|
|
|
return -EBUSY;
|
2014-03-06 09:41:36 +08:00
|
|
|
sock = sockfd_lookup(arg, &err);
|
|
|
|
if (sock) {
|
|
|
|
nbd->sock = sock;
|
|
|
|
if (max_part > 0)
|
|
|
|
bdev->bd_invalidated = 1;
|
2015-08-17 14:20:07 +08:00
|
|
|
nbd->disconnect = false; /* we're connected now */
|
2014-03-06 09:41:36 +08:00
|
|
|
return 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
2009-04-03 07:58:41 +08:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
case NBD_SET_BLKSIZE:
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd->blksize = arg;
|
|
|
|
nbd->bytesize &= ~(nbd->blksize-1);
|
|
|
|
bdev->bd_inode->i_size = nbd->bytesize;
|
|
|
|
set_blocksize(bdev, nbd->blksize);
|
|
|
|
set_capacity(nbd->disk, nbd->bytesize >> 9);
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
2009-04-03 07:58:41 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
case NBD_SET_SIZE:
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd->bytesize = arg & ~(nbd->blksize-1);
|
|
|
|
bdev->bd_inode->i_size = nbd->bytesize;
|
|
|
|
set_blocksize(bdev, nbd->blksize);
|
|
|
|
set_capacity(nbd->disk, nbd->bytesize >> 9);
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
2009-04-03 07:58:41 +08:00
|
|
|
|
2007-10-17 14:27:37 +08:00
|
|
|
case NBD_SET_TIMEOUT:
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd->xmit_timeout = arg * HZ;
|
2015-08-17 14:20:00 +08:00
|
|
|
if (arg)
|
|
|
|
mod_timer(&nbd->timeout_timer,
|
|
|
|
jiffies + nbd->xmit_timeout);
|
|
|
|
else
|
|
|
|
del_timer_sync(&nbd->timeout_timer);
|
|
|
|
|
2007-10-17 14:27:37 +08:00
|
|
|
return 0;
|
2009-04-03 07:58:41 +08:00
|
|
|
|
2012-10-05 08:16:15 +08:00
|
|
|
case NBD_SET_FLAGS:
|
|
|
|
nbd->flags = arg;
|
|
|
|
return 0;
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
case NBD_SET_SIZE_BLOCKS:
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd->bytesize = ((u64) arg) * nbd->blksize;
|
|
|
|
bdev->bd_inode->i_size = nbd->bytesize;
|
|
|
|
set_blocksize(bdev, nbd->blksize);
|
|
|
|
set_capacity(nbd->disk, nbd->bytesize >> 9);
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
2009-04-03 07:58:41 +08:00
|
|
|
|
|
|
|
case NBD_DO_IT: {
|
|
|
|
struct task_struct *thread;
|
2014-03-06 09:41:36 +08:00
|
|
|
struct socket *sock;
|
2009-04-03 07:58:41 +08:00
|
|
|
int error;
|
|
|
|
|
2015-08-17 14:20:05 +08:00
|
|
|
if (nbd->task_recv)
|
2009-01-16 05:51:03 +08:00
|
|
|
return -EBUSY;
|
2014-03-06 09:41:36 +08:00
|
|
|
if (!nbd->sock)
|
2005-04-17 06:20:36 +08:00
|
|
|
return -EINVAL;
|
2009-04-03 07:58:41 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
mutex_unlock(&nbd->tx_lock);
|
2009-04-03 07:58:41 +08:00
|
|
|
|
2013-02-28 09:05:26 +08:00
|
|
|
if (nbd->flags & NBD_FLAG_READ_ONLY)
|
|
|
|
set_device_ro(bdev, true);
|
2012-10-05 08:16:18 +08:00
|
|
|
if (nbd->flags & NBD_FLAG_SEND_TRIM)
|
|
|
|
queue_flag_set_unlocked(QUEUE_FLAG_DISCARD,
|
|
|
|
nbd->disk->queue);
|
nbd: support FLUSH requests
Currently, the NBD device does not accept flush requests from the Linux
block layer. If the NBD server opened the target with neither O_SYNC nor
O_DSYNC, however, the device will be effectively backed by a writeback
cache. Without issuing flushes properly, operation of the NBD device will
not be safe against power losses.
The NBD protocol has support for both a cache flush command and a FUA
command flag; the server will also pass a flag to note its support for
these features. This patch adds support for the cache flush command and
flag. In the kernel, we receive the flags via the NBD_SET_FLAGS ioctl,
and map NBD_FLAG_SEND_FLUSH to the argument of blk_queue_flush. When the
flag is active the block layer will send REQ_FLUSH requests, which we
translate to NBD_CMD_FLUSH commands.
FUA support is not included in this patch because all free software
servers implement it with a full fdatasync; thus it has no advantage over
supporting flush only. Because I [Paolo] cannot really benchmark it in a
realistic scenario, I cannot tell if it is a good idea or not. It is also
not clear if it is valid for an NBD server to support FUA but not flush.
The Linux block layer gives a warning for this combination, the NBD
protocol documentation says nothing about it.
The patch also fixes a small problem in the handling of flags: nbd->flags
must be cleared at the end of NBD_DO_IT, but the driver was not doing
that. The bug manifests itself as follows. Suppose you two different
client/server pairs to start the NBD device. Suppose also that the first
client supports NBD_SET_FLAGS, and the first server sends
NBD_FLAG_SEND_FLUSH; the second pair instead does neither of these two
things. Before this patch, the second invocation of NBD_DO_IT will use a
stale value of nbd->flags, and the second server will issue an error every
time it receives an NBD_CMD_FLUSH command.
This bug is pre-existing, but it becomes much more important after this
patch; flush failures make the device pretty much unusable, unlike
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bligh <alex@alex.org.uk>
Acked-by: Paul Clements <Paul.Clements@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:05:23 +08:00
|
|
|
if (nbd->flags & NBD_FLAG_SEND_FLUSH)
|
|
|
|
blk_queue_flush(nbd->disk->queue, REQ_FLUSH);
|
|
|
|
else
|
|
|
|
blk_queue_flush(nbd->disk->queue, 0);
|
2012-10-05 08:16:18 +08:00
|
|
|
|
2015-08-17 14:20:08 +08:00
|
|
|
thread = kthread_run(nbd_thread_send, nbd, "%s",
|
2015-08-17 14:20:06 +08:00
|
|
|
nbd_name(nbd));
|
2009-04-03 07:58:41 +08:00
|
|
|
if (IS_ERR(thread)) {
|
2012-03-29 05:42:51 +08:00
|
|
|
mutex_lock(&nbd->tx_lock);
|
2008-04-29 16:02:46 +08:00
|
|
|
return PTR_ERR(thread);
|
2009-04-03 07:58:41 +08:00
|
|
|
}
|
2015-04-02 16:11:36 +08:00
|
|
|
|
2015-08-17 14:20:06 +08:00
|
|
|
nbd_dev_dbg_init(nbd);
|
2015-08-17 14:20:08 +08:00
|
|
|
error = nbd_thread_recv(nbd);
|
2015-08-17 14:20:06 +08:00
|
|
|
nbd_dev_dbg_close(nbd);
|
2008-04-29 16:02:46 +08:00
|
|
|
kthread_stop(thread);
|
2009-04-03 07:58:41 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
mutex_lock(&nbd->tx_lock);
|
2015-08-17 14:20:03 +08:00
|
|
|
|
2015-08-17 14:20:01 +08:00
|
|
|
sock_shutdown(nbd);
|
2014-03-06 09:41:36 +08:00
|
|
|
sock = nbd->sock;
|
|
|
|
nbd->sock = NULL;
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd_clear_que(nbd);
|
2013-02-28 09:05:25 +08:00
|
|
|
kill_bdev(bdev);
|
2012-10-05 08:16:18 +08:00
|
|
|
queue_flag_clear_unlocked(QUEUE_FLAG_DISCARD, nbd->disk->queue);
|
2013-02-28 09:05:26 +08:00
|
|
|
set_device_ro(bdev, false);
|
2014-03-06 09:41:36 +08:00
|
|
|
if (sock)
|
|
|
|
sockfd_put(sock);
|
nbd: support FLUSH requests
Currently, the NBD device does not accept flush requests from the Linux
block layer. If the NBD server opened the target with neither O_SYNC nor
O_DSYNC, however, the device will be effectively backed by a writeback
cache. Without issuing flushes properly, operation of the NBD device will
not be safe against power losses.
The NBD protocol has support for both a cache flush command and a FUA
command flag; the server will also pass a flag to note its support for
these features. This patch adds support for the cache flush command and
flag. In the kernel, we receive the flags via the NBD_SET_FLAGS ioctl,
and map NBD_FLAG_SEND_FLUSH to the argument of blk_queue_flush. When the
flag is active the block layer will send REQ_FLUSH requests, which we
translate to NBD_CMD_FLUSH commands.
FUA support is not included in this patch because all free software
servers implement it with a full fdatasync; thus it has no advantage over
supporting flush only. Because I [Paolo] cannot really benchmark it in a
realistic scenario, I cannot tell if it is a good idea or not. It is also
not clear if it is valid for an NBD server to support FUA but not flush.
The Linux block layer gives a warning for this combination, the NBD
protocol documentation says nothing about it.
The patch also fixes a small problem in the handling of flags: nbd->flags
must be cleared at the end of NBD_DO_IT, but the driver was not doing
that. The bug manifests itself as follows. Suppose you two different
client/server pairs to start the NBD device. Suppose also that the first
client supports NBD_SET_FLAGS, and the first server sends
NBD_FLAG_SEND_FLUSH; the second pair instead does neither of these two
things. Before this patch, the second invocation of NBD_DO_IT will use a
stale value of nbd->flags, and the second server will issue an error every
time it receives an NBD_CMD_FLUSH command.
This bug is pre-existing, but it becomes much more important after this
patch; flush failures make the device pretty much unusable, unlike
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Alex Bligh <alex@alex.org.uk>
Acked-by: Paul Clements <Paul.Clements@steeleye.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2013-02-28 09:05:23 +08:00
|
|
|
nbd->flags = 0;
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd->bytesize = 0;
|
2008-03-02 22:33:33 +08:00
|
|
|
bdev->bd_inode->i_size = 0;
|
2012-03-29 05:42:51 +08:00
|
|
|
set_capacity(nbd->disk, 0);
|
NBD: add partition support
Permit the use of partitions with network block devices (NBD).
A new parameter is introduced to define how many partition we want to be able
to manage per network block device. This parameter is "max_part".
For instance, to manage 63 partitions / loop device, we will do:
[on the server side]
# nbd-server 1234 /dev/sdb
[on the client side]
# modprobe nbd max_part=63
# ls -l /dev/nbd*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:14 /dev/nbd0
brw-rw---- 1 root disk 43, 64 2008-03-25 11:11 /dev/nbd1
brw-rw---- 1 root disk 43, 640 2008-03-25 11:11 /dev/nbd10
brw-rw---- 1 root disk 43, 704 2008-03-25 11:11 /dev/nbd11
brw-rw---- 1 root disk 43, 768 2008-03-25 11:11 /dev/nbd12
brw-rw---- 1 root disk 43, 832 2008-03-25 11:11 /dev/nbd13
brw-rw---- 1 root disk 43, 896 2008-03-25 11:11 /dev/nbd14
brw-rw---- 1 root disk 43, 960 2008-03-25 11:11 /dev/nbd15
brw-rw---- 1 root disk 43, 128 2008-03-25 11:11 /dev/nbd2
brw-rw---- 1 root disk 43, 192 2008-03-25 11:11 /dev/nbd3
brw-rw---- 1 root disk 43, 256 2008-03-25 11:11 /dev/nbd4
brw-rw---- 1 root disk 43, 320 2008-03-25 11:11 /dev/nbd5
brw-rw---- 1 root disk 43, 384 2008-03-25 11:11 /dev/nbd6
brw-rw---- 1 root disk 43, 448 2008-03-25 11:11 /dev/nbd7
brw-rw---- 1 root disk 43, 512 2008-03-25 11:11 /dev/nbd8
brw-rw---- 1 root disk 43, 576 2008-03-25 11:11 /dev/nbd9
# nbd-client localhost 1234 /dev/nbd0
Negotiation: ..size = 80418240KB
bs=1024, sz=80418240
-------NOTE, RFC: partition table is not automatically read.
The driver sets bdev->bd_invalidated to 1 to force the read of the partition
table of the device, but this is done only on an open of the device.
So we have to do a "touch /dev/nbdX" or something like that.
It can't be done from the nbd-client or nbd driver because at this
level we can't ask to read the partition table and to serve the request
at the same time (-> deadlock)
If someone has a better idea, I'm open to any suggestion.
-------NOTE, RFC
# fdisk -l /dev/nbd0
Disk /dev/nbd0: 82.3 GB, 82348277760 bytes
255 heads, 63 sectors/track, 10011 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Device Boot Start End Blocks Id System
/dev/nbd0p1 * 1 9965 80043831 83 Linux
/dev/nbd0p2 9966 10011 369495 5 Extended
/dev/nbd0p5 9966 10011 369463+ 82 Linux swap / Solaris
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
brw-rw---- 1 root disk 43, 1 2008-03-25 11:16 /dev/nbd0p1
brw-rw---- 1 root disk 43, 2 2008-03-25 11:16 /dev/nbd0p2
brw-rw---- 1 root disk 43, 5 2008-03-25 11:16 /dev/nbd0p5
# mount /dev/nbd0p1 /mnt
# ls /mnt
bin dev initrd lost+found opt sbin sys var
boot etc initrd.img media proc selinux tmp vmlinuz
cdrom home lib mnt root srv usr
# umount /mnt
# nbd-client -d /dev/nbd0
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
-------NOTE
On "nbd-client -d", we can do an iocl(BLKRRPART) to update partition table:
as the size of the device is 0, we don't have to serve the partition manager
request (-> no deadlock).
-------NOTE
Signed-off-by: Paul Clements <paul.clements@steeleye.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-29 16:02:51 +08:00
|
|
|
if (max_part > 0)
|
2015-05-06 12:26:25 +08:00
|
|
|
blkdev_reread_part(bdev);
|
2013-07-04 06:09:04 +08:00
|
|
|
if (nbd->disconnect) /* user requested, ignore socket errors */
|
|
|
|
return 0;
|
2015-08-17 14:20:03 +08:00
|
|
|
return error;
|
2009-04-03 07:58:41 +08:00
|
|
|
}
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
case NBD_CLEAR_QUE:
|
2006-01-06 16:09:47 +08:00
|
|
|
/*
|
|
|
|
* This is for compatibility only. The queue is always cleared
|
|
|
|
* by NBD_DO_IT or NBD_CLEAR_SOCK.
|
|
|
|
*/
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
2009-04-03 07:58:41 +08:00
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
case NBD_PRINT_DEBUG:
|
2012-03-29 05:42:51 +08:00
|
|
|
dev_info(disk_to_dev(nbd->disk),
|
2011-08-19 20:48:28 +08:00
|
|
|
"next = %p, prev = %p, head = %p\n",
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd->queue_head.next, nbd->queue_head.prev,
|
|
|
|
&nbd->queue_head);
|
2005-04-17 06:20:36 +08:00
|
|
|
return 0;
|
|
|
|
}
|
2009-04-03 07:58:41 +08:00
|
|
|
return -ENOTTY;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int nbd_ioctl(struct block_device *bdev, fmode_t mode,
|
|
|
|
unsigned int cmd, unsigned long arg)
|
|
|
|
{
|
2012-03-29 05:42:51 +08:00
|
|
|
struct nbd_device *nbd = bdev->bd_disk->private_data;
|
2009-04-03 07:58:41 +08:00
|
|
|
int error;
|
|
|
|
|
|
|
|
if (!capable(CAP_SYS_ADMIN))
|
|
|
|
return -EPERM;
|
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
BUG_ON(nbd->magic != NBD_MAGIC);
|
2009-04-03 07:58:41 +08:00
|
|
|
|
2012-03-29 05:42:51 +08:00
|
|
|
mutex_lock(&nbd->tx_lock);
|
|
|
|
error = __nbd_ioctl(bdev, nbd, cmd, arg);
|
|
|
|
mutex_unlock(&nbd->tx_lock);
|
2009-04-03 07:58:41 +08:00
|
|
|
|
|
|
|
return error;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
2009-09-22 08:01:13 +08:00
|
|
|
static const struct block_device_operations nbd_fops =
|
2005-04-17 06:20:36 +08:00
|
|
|
{
|
|
|
|
.owner = THIS_MODULE,
|
2010-07-08 16:18:46 +08:00
|
|
|
.ioctl = nbd_ioctl,
|
2005-04-17 06:20:36 +08:00
|
|
|
};
|
|
|
|
|
2015-08-17 14:20:06 +08:00
|
|
|
#if IS_ENABLED(CONFIG_DEBUG_FS)
|
|
|
|
|
|
|
|
static int nbd_dbg_tasks_show(struct seq_file *s, void *unused)
|
|
|
|
{
|
|
|
|
struct nbd_device *nbd = s->private;
|
|
|
|
|
|
|
|
if (nbd->task_recv)
|
|
|
|
seq_printf(s, "recv: %d\n", task_pid_nr(nbd->task_recv));
|
|
|
|
if (nbd->task_send)
|
|
|
|
seq_printf(s, "send: %d\n", task_pid_nr(nbd->task_send));
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int nbd_dbg_tasks_open(struct inode *inode, struct file *file)
|
|
|
|
{
|
|
|
|
return single_open(file, nbd_dbg_tasks_show, inode->i_private);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct file_operations nbd_dbg_tasks_ops = {
|
|
|
|
.open = nbd_dbg_tasks_open,
|
|
|
|
.read = seq_read,
|
|
|
|
.llseek = seq_lseek,
|
|
|
|
.release = single_release,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int nbd_dbg_flags_show(struct seq_file *s, void *unused)
|
|
|
|
{
|
|
|
|
struct nbd_device *nbd = s->private;
|
|
|
|
u32 flags = nbd->flags;
|
|
|
|
|
|
|
|
seq_printf(s, "Hex: 0x%08x\n\n", flags);
|
|
|
|
|
|
|
|
seq_puts(s, "Known flags:\n");
|
|
|
|
|
|
|
|
if (flags & NBD_FLAG_HAS_FLAGS)
|
|
|
|
seq_puts(s, "NBD_FLAG_HAS_FLAGS\n");
|
|
|
|
if (flags & NBD_FLAG_READ_ONLY)
|
|
|
|
seq_puts(s, "NBD_FLAG_READ_ONLY\n");
|
|
|
|
if (flags & NBD_FLAG_SEND_FLUSH)
|
|
|
|
seq_puts(s, "NBD_FLAG_SEND_FLUSH\n");
|
|
|
|
if (flags & NBD_FLAG_SEND_TRIM)
|
|
|
|
seq_puts(s, "NBD_FLAG_SEND_TRIM\n");
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int nbd_dbg_flags_open(struct inode *inode, struct file *file)
|
|
|
|
{
|
|
|
|
return single_open(file, nbd_dbg_flags_show, inode->i_private);
|
|
|
|
}
|
|
|
|
|
|
|
|
static const struct file_operations nbd_dbg_flags_ops = {
|
|
|
|
.open = nbd_dbg_flags_open,
|
|
|
|
.read = seq_read,
|
|
|
|
.llseek = seq_lseek,
|
|
|
|
.release = single_release,
|
|
|
|
};
|
|
|
|
|
|
|
|
static int nbd_dev_dbg_init(struct nbd_device *nbd)
|
|
|
|
{
|
|
|
|
struct dentry *dir;
|
|
|
|
struct dentry *f;
|
|
|
|
|
|
|
|
dir = debugfs_create_dir(nbd_name(nbd), nbd_dbg_dir);
|
|
|
|
if (IS_ERR_OR_NULL(dir)) {
|
|
|
|
dev_err(nbd_to_dev(nbd), "Failed to create debugfs dir for '%s' (%ld)\n",
|
|
|
|
nbd_name(nbd), PTR_ERR(dir));
|
|
|
|
return PTR_ERR(dir);
|
|
|
|
}
|
|
|
|
nbd->dbg_dir = dir;
|
|
|
|
|
|
|
|
f = debugfs_create_file("tasks", 0444, dir, nbd, &nbd_dbg_tasks_ops);
|
|
|
|
if (IS_ERR_OR_NULL(f)) {
|
|
|
|
dev_err(nbd_to_dev(nbd), "Failed to create debugfs file 'tasks', %ld\n",
|
|
|
|
PTR_ERR(f));
|
|
|
|
return PTR_ERR(f);
|
|
|
|
}
|
|
|
|
|
|
|
|
f = debugfs_create_u64("size_bytes", 0444, dir, &nbd->bytesize);
|
|
|
|
if (IS_ERR_OR_NULL(f)) {
|
|
|
|
dev_err(nbd_to_dev(nbd), "Failed to create debugfs file 'size_bytes', %ld\n",
|
|
|
|
PTR_ERR(f));
|
|
|
|
return PTR_ERR(f);
|
|
|
|
}
|
|
|
|
|
|
|
|
f = debugfs_create_u32("timeout", 0444, dir, &nbd->xmit_timeout);
|
|
|
|
if (IS_ERR_OR_NULL(f)) {
|
|
|
|
dev_err(nbd_to_dev(nbd), "Failed to create debugfs file 'timeout', %ld\n",
|
|
|
|
PTR_ERR(f));
|
|
|
|
return PTR_ERR(f);
|
|
|
|
}
|
|
|
|
|
|
|
|
f = debugfs_create_u32("blocksize", 0444, dir, &nbd->blksize);
|
|
|
|
if (IS_ERR_OR_NULL(f)) {
|
|
|
|
dev_err(nbd_to_dev(nbd), "Failed to create debugfs file 'blocksize', %ld\n",
|
|
|
|
PTR_ERR(f));
|
|
|
|
return PTR_ERR(f);
|
|
|
|
}
|
|
|
|
|
|
|
|
f = debugfs_create_file("flags", 0444, dir, &nbd, &nbd_dbg_flags_ops);
|
|
|
|
if (IS_ERR_OR_NULL(f)) {
|
|
|
|
dev_err(nbd_to_dev(nbd), "Failed to create debugfs file 'flags', %ld\n",
|
|
|
|
PTR_ERR(f));
|
|
|
|
return PTR_ERR(f);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void nbd_dev_dbg_close(struct nbd_device *nbd)
|
|
|
|
{
|
|
|
|
debugfs_remove_recursive(nbd->dbg_dir);
|
|
|
|
}
|
|
|
|
|
|
|
|
static int nbd_dbg_init(void)
|
|
|
|
{
|
|
|
|
struct dentry *dbg_dir;
|
|
|
|
|
|
|
|
dbg_dir = debugfs_create_dir("nbd", NULL);
|
|
|
|
if (IS_ERR(dbg_dir))
|
|
|
|
return PTR_ERR(dbg_dir);
|
|
|
|
|
|
|
|
nbd_dbg_dir = dbg_dir;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void nbd_dbg_close(void)
|
|
|
|
{
|
|
|
|
debugfs_remove_recursive(nbd_dbg_dir);
|
|
|
|
}
|
|
|
|
|
|
|
|
#else /* IS_ENABLED(CONFIG_DEBUG_FS) */
|
|
|
|
|
|
|
|
static int nbd_dev_dbg_init(struct nbd_device *nbd)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void nbd_dev_dbg_close(struct nbd_device *nbd)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
static int nbd_dbg_init(void)
|
|
|
|
{
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void nbd_dbg_close(void)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif
|
|
|
|
|
2005-04-17 06:20:36 +08:00
|
|
|
/*
|
|
|
|
* And here should be modules and kernel interface
|
|
|
|
* (Just smiley confuses emacs :-)
|
|
|
|
*/
|
|
|
|
|
|
|
|
static int __init nbd_init(void)
|
|
|
|
{
|
|
|
|
int err = -ENOMEM;
|
|
|
|
int i;
|
NBD: add partition support
Permit the use of partitions with network block devices (NBD).
A new parameter is introduced to define how many partition we want to be able
to manage per network block device. This parameter is "max_part".
For instance, to manage 63 partitions / loop device, we will do:
[on the server side]
# nbd-server 1234 /dev/sdb
[on the client side]
# modprobe nbd max_part=63
# ls -l /dev/nbd*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:14 /dev/nbd0
brw-rw---- 1 root disk 43, 64 2008-03-25 11:11 /dev/nbd1
brw-rw---- 1 root disk 43, 640 2008-03-25 11:11 /dev/nbd10
brw-rw---- 1 root disk 43, 704 2008-03-25 11:11 /dev/nbd11
brw-rw---- 1 root disk 43, 768 2008-03-25 11:11 /dev/nbd12
brw-rw---- 1 root disk 43, 832 2008-03-25 11:11 /dev/nbd13
brw-rw---- 1 root disk 43, 896 2008-03-25 11:11 /dev/nbd14
brw-rw---- 1 root disk 43, 960 2008-03-25 11:11 /dev/nbd15
brw-rw---- 1 root disk 43, 128 2008-03-25 11:11 /dev/nbd2
brw-rw---- 1 root disk 43, 192 2008-03-25 11:11 /dev/nbd3
brw-rw---- 1 root disk 43, 256 2008-03-25 11:11 /dev/nbd4
brw-rw---- 1 root disk 43, 320 2008-03-25 11:11 /dev/nbd5
brw-rw---- 1 root disk 43, 384 2008-03-25 11:11 /dev/nbd6
brw-rw---- 1 root disk 43, 448 2008-03-25 11:11 /dev/nbd7
brw-rw---- 1 root disk 43, 512 2008-03-25 11:11 /dev/nbd8
brw-rw---- 1 root disk 43, 576 2008-03-25 11:11 /dev/nbd9
# nbd-client localhost 1234 /dev/nbd0
Negotiation: ..size = 80418240KB
bs=1024, sz=80418240
-------NOTE, RFC: partition table is not automatically read.
The driver sets bdev->bd_invalidated to 1 to force the read of the partition
table of the device, but this is done only on an open of the device.
So we have to do a "touch /dev/nbdX" or something like that.
It can't be done from the nbd-client or nbd driver because at this
level we can't ask to read the partition table and to serve the request
at the same time (-> deadlock)
If someone has a better idea, I'm open to any suggestion.
-------NOTE, RFC
# fdisk -l /dev/nbd0
Disk /dev/nbd0: 82.3 GB, 82348277760 bytes
255 heads, 63 sectors/track, 10011 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Device Boot Start End Blocks Id System
/dev/nbd0p1 * 1 9965 80043831 83 Linux
/dev/nbd0p2 9966 10011 369495 5 Extended
/dev/nbd0p5 9966 10011 369463+ 82 Linux swap / Solaris
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
brw-rw---- 1 root disk 43, 1 2008-03-25 11:16 /dev/nbd0p1
brw-rw---- 1 root disk 43, 2 2008-03-25 11:16 /dev/nbd0p2
brw-rw---- 1 root disk 43, 5 2008-03-25 11:16 /dev/nbd0p5
# mount /dev/nbd0p1 /mnt
# ls /mnt
bin dev initrd lost+found opt sbin sys var
boot etc initrd.img media proc selinux tmp vmlinuz
cdrom home lib mnt root srv usr
# umount /mnt
# nbd-client -d /dev/nbd0
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
-------NOTE
On "nbd-client -d", we can do an iocl(BLKRRPART) to update partition table:
as the size of the device is 0, we don't have to serve the partition manager
request (-> no deadlock).
-------NOTE
Signed-off-by: Paul Clements <paul.clements@steeleye.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-29 16:02:51 +08:00
|
|
|
int part_shift;
|
2005-04-17 06:20:36 +08:00
|
|
|
|
2006-03-25 19:07:04 +08:00
|
|
|
BUILD_BUG_ON(sizeof(struct nbd_request) != 28);
|
2005-04-17 06:20:36 +08:00
|
|
|
|
NBD: add partition support
Permit the use of partitions with network block devices (NBD).
A new parameter is introduced to define how many partition we want to be able
to manage per network block device. This parameter is "max_part".
For instance, to manage 63 partitions / loop device, we will do:
[on the server side]
# nbd-server 1234 /dev/sdb
[on the client side]
# modprobe nbd max_part=63
# ls -l /dev/nbd*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:14 /dev/nbd0
brw-rw---- 1 root disk 43, 64 2008-03-25 11:11 /dev/nbd1
brw-rw---- 1 root disk 43, 640 2008-03-25 11:11 /dev/nbd10
brw-rw---- 1 root disk 43, 704 2008-03-25 11:11 /dev/nbd11
brw-rw---- 1 root disk 43, 768 2008-03-25 11:11 /dev/nbd12
brw-rw---- 1 root disk 43, 832 2008-03-25 11:11 /dev/nbd13
brw-rw---- 1 root disk 43, 896 2008-03-25 11:11 /dev/nbd14
brw-rw---- 1 root disk 43, 960 2008-03-25 11:11 /dev/nbd15
brw-rw---- 1 root disk 43, 128 2008-03-25 11:11 /dev/nbd2
brw-rw---- 1 root disk 43, 192 2008-03-25 11:11 /dev/nbd3
brw-rw---- 1 root disk 43, 256 2008-03-25 11:11 /dev/nbd4
brw-rw---- 1 root disk 43, 320 2008-03-25 11:11 /dev/nbd5
brw-rw---- 1 root disk 43, 384 2008-03-25 11:11 /dev/nbd6
brw-rw---- 1 root disk 43, 448 2008-03-25 11:11 /dev/nbd7
brw-rw---- 1 root disk 43, 512 2008-03-25 11:11 /dev/nbd8
brw-rw---- 1 root disk 43, 576 2008-03-25 11:11 /dev/nbd9
# nbd-client localhost 1234 /dev/nbd0
Negotiation: ..size = 80418240KB
bs=1024, sz=80418240
-------NOTE, RFC: partition table is not automatically read.
The driver sets bdev->bd_invalidated to 1 to force the read of the partition
table of the device, but this is done only on an open of the device.
So we have to do a "touch /dev/nbdX" or something like that.
It can't be done from the nbd-client or nbd driver because at this
level we can't ask to read the partition table and to serve the request
at the same time (-> deadlock)
If someone has a better idea, I'm open to any suggestion.
-------NOTE, RFC
# fdisk -l /dev/nbd0
Disk /dev/nbd0: 82.3 GB, 82348277760 bytes
255 heads, 63 sectors/track, 10011 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Device Boot Start End Blocks Id System
/dev/nbd0p1 * 1 9965 80043831 83 Linux
/dev/nbd0p2 9966 10011 369495 5 Extended
/dev/nbd0p5 9966 10011 369463+ 82 Linux swap / Solaris
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
brw-rw---- 1 root disk 43, 1 2008-03-25 11:16 /dev/nbd0p1
brw-rw---- 1 root disk 43, 2 2008-03-25 11:16 /dev/nbd0p2
brw-rw---- 1 root disk 43, 5 2008-03-25 11:16 /dev/nbd0p5
# mount /dev/nbd0p1 /mnt
# ls /mnt
bin dev initrd lost+found opt sbin sys var
boot etc initrd.img media proc selinux tmp vmlinuz
cdrom home lib mnt root srv usr
# umount /mnt
# nbd-client -d /dev/nbd0
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
-------NOTE
On "nbd-client -d", we can do an iocl(BLKRRPART) to update partition table:
as the size of the device is 0, we don't have to serve the partition manager
request (-> no deadlock).
-------NOTE
Signed-off-by: Paul Clements <paul.clements@steeleye.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-29 16:02:51 +08:00
|
|
|
if (max_part < 0) {
|
2011-08-19 20:48:28 +08:00
|
|
|
printk(KERN_ERR "nbd: max_part must be >= 0\n");
|
NBD: add partition support
Permit the use of partitions with network block devices (NBD).
A new parameter is introduced to define how many partition we want to be able
to manage per network block device. This parameter is "max_part".
For instance, to manage 63 partitions / loop device, we will do:
[on the server side]
# nbd-server 1234 /dev/sdb
[on the client side]
# modprobe nbd max_part=63
# ls -l /dev/nbd*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:14 /dev/nbd0
brw-rw---- 1 root disk 43, 64 2008-03-25 11:11 /dev/nbd1
brw-rw---- 1 root disk 43, 640 2008-03-25 11:11 /dev/nbd10
brw-rw---- 1 root disk 43, 704 2008-03-25 11:11 /dev/nbd11
brw-rw---- 1 root disk 43, 768 2008-03-25 11:11 /dev/nbd12
brw-rw---- 1 root disk 43, 832 2008-03-25 11:11 /dev/nbd13
brw-rw---- 1 root disk 43, 896 2008-03-25 11:11 /dev/nbd14
brw-rw---- 1 root disk 43, 960 2008-03-25 11:11 /dev/nbd15
brw-rw---- 1 root disk 43, 128 2008-03-25 11:11 /dev/nbd2
brw-rw---- 1 root disk 43, 192 2008-03-25 11:11 /dev/nbd3
brw-rw---- 1 root disk 43, 256 2008-03-25 11:11 /dev/nbd4
brw-rw---- 1 root disk 43, 320 2008-03-25 11:11 /dev/nbd5
brw-rw---- 1 root disk 43, 384 2008-03-25 11:11 /dev/nbd6
brw-rw---- 1 root disk 43, 448 2008-03-25 11:11 /dev/nbd7
brw-rw---- 1 root disk 43, 512 2008-03-25 11:11 /dev/nbd8
brw-rw---- 1 root disk 43, 576 2008-03-25 11:11 /dev/nbd9
# nbd-client localhost 1234 /dev/nbd0
Negotiation: ..size = 80418240KB
bs=1024, sz=80418240
-------NOTE, RFC: partition table is not automatically read.
The driver sets bdev->bd_invalidated to 1 to force the read of the partition
table of the device, but this is done only on an open of the device.
So we have to do a "touch /dev/nbdX" or something like that.
It can't be done from the nbd-client or nbd driver because at this
level we can't ask to read the partition table and to serve the request
at the same time (-> deadlock)
If someone has a better idea, I'm open to any suggestion.
-------NOTE, RFC
# fdisk -l /dev/nbd0
Disk /dev/nbd0: 82.3 GB, 82348277760 bytes
255 heads, 63 sectors/track, 10011 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Device Boot Start End Blocks Id System
/dev/nbd0p1 * 1 9965 80043831 83 Linux
/dev/nbd0p2 9966 10011 369495 5 Extended
/dev/nbd0p5 9966 10011 369463+ 82 Linux swap / Solaris
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
brw-rw---- 1 root disk 43, 1 2008-03-25 11:16 /dev/nbd0p1
brw-rw---- 1 root disk 43, 2 2008-03-25 11:16 /dev/nbd0p2
brw-rw---- 1 root disk 43, 5 2008-03-25 11:16 /dev/nbd0p5
# mount /dev/nbd0p1 /mnt
# ls /mnt
bin dev initrd lost+found opt sbin sys var
boot etc initrd.img media proc selinux tmp vmlinuz
cdrom home lib mnt root srv usr
# umount /mnt
# nbd-client -d /dev/nbd0
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
-------NOTE
On "nbd-client -d", we can do an iocl(BLKRRPART) to update partition table:
as the size of the device is 0, we don't have to serve the partition manager
request (-> no deadlock).
-------NOTE
Signed-off-by: Paul Clements <paul.clements@steeleye.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-29 16:02:51 +08:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
part_shift = 0;
|
2011-05-28 20:44:46 +08:00
|
|
|
if (max_part > 0) {
|
NBD: add partition support
Permit the use of partitions with network block devices (NBD).
A new parameter is introduced to define how many partition we want to be able
to manage per network block device. This parameter is "max_part".
For instance, to manage 63 partitions / loop device, we will do:
[on the server side]
# nbd-server 1234 /dev/sdb
[on the client side]
# modprobe nbd max_part=63
# ls -l /dev/nbd*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:14 /dev/nbd0
brw-rw---- 1 root disk 43, 64 2008-03-25 11:11 /dev/nbd1
brw-rw---- 1 root disk 43, 640 2008-03-25 11:11 /dev/nbd10
brw-rw---- 1 root disk 43, 704 2008-03-25 11:11 /dev/nbd11
brw-rw---- 1 root disk 43, 768 2008-03-25 11:11 /dev/nbd12
brw-rw---- 1 root disk 43, 832 2008-03-25 11:11 /dev/nbd13
brw-rw---- 1 root disk 43, 896 2008-03-25 11:11 /dev/nbd14
brw-rw---- 1 root disk 43, 960 2008-03-25 11:11 /dev/nbd15
brw-rw---- 1 root disk 43, 128 2008-03-25 11:11 /dev/nbd2
brw-rw---- 1 root disk 43, 192 2008-03-25 11:11 /dev/nbd3
brw-rw---- 1 root disk 43, 256 2008-03-25 11:11 /dev/nbd4
brw-rw---- 1 root disk 43, 320 2008-03-25 11:11 /dev/nbd5
brw-rw---- 1 root disk 43, 384 2008-03-25 11:11 /dev/nbd6
brw-rw---- 1 root disk 43, 448 2008-03-25 11:11 /dev/nbd7
brw-rw---- 1 root disk 43, 512 2008-03-25 11:11 /dev/nbd8
brw-rw---- 1 root disk 43, 576 2008-03-25 11:11 /dev/nbd9
# nbd-client localhost 1234 /dev/nbd0
Negotiation: ..size = 80418240KB
bs=1024, sz=80418240
-------NOTE, RFC: partition table is not automatically read.
The driver sets bdev->bd_invalidated to 1 to force the read of the partition
table of the device, but this is done only on an open of the device.
So we have to do a "touch /dev/nbdX" or something like that.
It can't be done from the nbd-client or nbd driver because at this
level we can't ask to read the partition table and to serve the request
at the same time (-> deadlock)
If someone has a better idea, I'm open to any suggestion.
-------NOTE, RFC
# fdisk -l /dev/nbd0
Disk /dev/nbd0: 82.3 GB, 82348277760 bytes
255 heads, 63 sectors/track, 10011 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Device Boot Start End Blocks Id System
/dev/nbd0p1 * 1 9965 80043831 83 Linux
/dev/nbd0p2 9966 10011 369495 5 Extended
/dev/nbd0p5 9966 10011 369463+ 82 Linux swap / Solaris
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
brw-rw---- 1 root disk 43, 1 2008-03-25 11:16 /dev/nbd0p1
brw-rw---- 1 root disk 43, 2 2008-03-25 11:16 /dev/nbd0p2
brw-rw---- 1 root disk 43, 5 2008-03-25 11:16 /dev/nbd0p5
# mount /dev/nbd0p1 /mnt
# ls /mnt
bin dev initrd lost+found opt sbin sys var
boot etc initrd.img media proc selinux tmp vmlinuz
cdrom home lib mnt root srv usr
# umount /mnt
# nbd-client -d /dev/nbd0
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
-------NOTE
On "nbd-client -d", we can do an iocl(BLKRRPART) to update partition table:
as the size of the device is 0, we don't have to serve the partition manager
request (-> no deadlock).
-------NOTE
Signed-off-by: Paul Clements <paul.clements@steeleye.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-29 16:02:51 +08:00
|
|
|
part_shift = fls(max_part);
|
|
|
|
|
2011-05-28 20:44:46 +08:00
|
|
|
/*
|
|
|
|
* Adjust max_part according to part_shift as it is exported
|
|
|
|
* to user space so that user can know the max number of
|
|
|
|
* partition kernel should be able to manage.
|
|
|
|
*
|
|
|
|
* Note that -1 is required because partition 0 is reserved
|
|
|
|
* for the whole disk.
|
|
|
|
*/
|
|
|
|
max_part = (1UL << part_shift) - 1;
|
|
|
|
}
|
|
|
|
|
2011-05-28 20:44:46 +08:00
|
|
|
if ((1UL << part_shift) > DISK_MAX_PARTS)
|
|
|
|
return -EINVAL;
|
|
|
|
|
|
|
|
if (nbds_max > 1UL << (MINORBITS - part_shift))
|
|
|
|
return -EINVAL;
|
|
|
|
|
2015-01-27 20:38:22 +08:00
|
|
|
nbd_dev = kcalloc(nbds_max, sizeof(*nbd_dev), GFP_KERNEL);
|
|
|
|
if (!nbd_dev)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2005-05-01 23:59:07 +08:00
|
|
|
for (i = 0; i < nbds_max; i++) {
|
NBD: add partition support
Permit the use of partitions with network block devices (NBD).
A new parameter is introduced to define how many partition we want to be able
to manage per network block device. This parameter is "max_part".
For instance, to manage 63 partitions / loop device, we will do:
[on the server side]
# nbd-server 1234 /dev/sdb
[on the client side]
# modprobe nbd max_part=63
# ls -l /dev/nbd*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:14 /dev/nbd0
brw-rw---- 1 root disk 43, 64 2008-03-25 11:11 /dev/nbd1
brw-rw---- 1 root disk 43, 640 2008-03-25 11:11 /dev/nbd10
brw-rw---- 1 root disk 43, 704 2008-03-25 11:11 /dev/nbd11
brw-rw---- 1 root disk 43, 768 2008-03-25 11:11 /dev/nbd12
brw-rw---- 1 root disk 43, 832 2008-03-25 11:11 /dev/nbd13
brw-rw---- 1 root disk 43, 896 2008-03-25 11:11 /dev/nbd14
brw-rw---- 1 root disk 43, 960 2008-03-25 11:11 /dev/nbd15
brw-rw---- 1 root disk 43, 128 2008-03-25 11:11 /dev/nbd2
brw-rw---- 1 root disk 43, 192 2008-03-25 11:11 /dev/nbd3
brw-rw---- 1 root disk 43, 256 2008-03-25 11:11 /dev/nbd4
brw-rw---- 1 root disk 43, 320 2008-03-25 11:11 /dev/nbd5
brw-rw---- 1 root disk 43, 384 2008-03-25 11:11 /dev/nbd6
brw-rw---- 1 root disk 43, 448 2008-03-25 11:11 /dev/nbd7
brw-rw---- 1 root disk 43, 512 2008-03-25 11:11 /dev/nbd8
brw-rw---- 1 root disk 43, 576 2008-03-25 11:11 /dev/nbd9
# nbd-client localhost 1234 /dev/nbd0
Negotiation: ..size = 80418240KB
bs=1024, sz=80418240
-------NOTE, RFC: partition table is not automatically read.
The driver sets bdev->bd_invalidated to 1 to force the read of the partition
table of the device, but this is done only on an open of the device.
So we have to do a "touch /dev/nbdX" or something like that.
It can't be done from the nbd-client or nbd driver because at this
level we can't ask to read the partition table and to serve the request
at the same time (-> deadlock)
If someone has a better idea, I'm open to any suggestion.
-------NOTE, RFC
# fdisk -l /dev/nbd0
Disk /dev/nbd0: 82.3 GB, 82348277760 bytes
255 heads, 63 sectors/track, 10011 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Device Boot Start End Blocks Id System
/dev/nbd0p1 * 1 9965 80043831 83 Linux
/dev/nbd0p2 9966 10011 369495 5 Extended
/dev/nbd0p5 9966 10011 369463+ 82 Linux swap / Solaris
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
brw-rw---- 1 root disk 43, 1 2008-03-25 11:16 /dev/nbd0p1
brw-rw---- 1 root disk 43, 2 2008-03-25 11:16 /dev/nbd0p2
brw-rw---- 1 root disk 43, 5 2008-03-25 11:16 /dev/nbd0p5
# mount /dev/nbd0p1 /mnt
# ls /mnt
bin dev initrd lost+found opt sbin sys var
boot etc initrd.img media proc selinux tmp vmlinuz
cdrom home lib mnt root srv usr
# umount /mnt
# nbd-client -d /dev/nbd0
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
-------NOTE
On "nbd-client -d", we can do an iocl(BLKRRPART) to update partition table:
as the size of the device is 0, we don't have to serve the partition manager
request (-> no deadlock).
-------NOTE
Signed-off-by: Paul Clements <paul.clements@steeleye.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-29 16:02:51 +08:00
|
|
|
struct gendisk *disk = alloc_disk(1 << part_shift);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (!disk)
|
|
|
|
goto out;
|
|
|
|
nbd_dev[i].disk = disk;
|
|
|
|
/*
|
|
|
|
* The new linux 2.5 block layer implementation requires
|
|
|
|
* every gendisk to have its very own request_queue struct.
|
|
|
|
* These structs are big so we dynamically allocate them.
|
|
|
|
*/
|
2015-08-17 14:20:08 +08:00
|
|
|
disk->queue = blk_init_queue(nbd_request_handler, &nbd_lock);
|
2005-04-17 06:20:36 +08:00
|
|
|
if (!disk->queue) {
|
|
|
|
put_disk(disk);
|
|
|
|
goto out;
|
|
|
|
}
|
2008-10-31 17:06:37 +08:00
|
|
|
/*
|
|
|
|
* Tell the block layer that we are not a rotational device
|
|
|
|
*/
|
|
|
|
queue_flag_set_unlocked(QUEUE_FLAG_NONROT, disk->queue);
|
2014-10-05 00:55:32 +08:00
|
|
|
queue_flag_clear_unlocked(QUEUE_FLAG_ADD_RANDOM, disk->queue);
|
2012-10-05 08:16:18 +08:00
|
|
|
disk->queue->limits.discard_granularity = 512;
|
2015-07-14 22:15:12 +08:00
|
|
|
blk_queue_max_discard_sectors(disk->queue, UINT_MAX);
|
2012-10-05 08:16:18 +08:00
|
|
|
disk->queue->limits.discard_zeroes_data = 0;
|
2013-05-01 06:28:28 +08:00
|
|
|
blk_queue_max_hw_sectors(disk->queue, 65536);
|
|
|
|
disk->queue->limits.max_sectors = 256;
|
2005-04-17 06:20:36 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
if (register_blkdev(NBD_MAJOR, "nbd")) {
|
|
|
|
err = -EIO;
|
|
|
|
goto out;
|
|
|
|
}
|
|
|
|
|
|
|
|
printk(KERN_INFO "nbd: registered device at major %d\n", NBD_MAJOR);
|
|
|
|
|
2015-08-17 14:20:06 +08:00
|
|
|
nbd_dbg_init();
|
|
|
|
|
2005-05-01 23:59:07 +08:00
|
|
|
for (i = 0; i < nbds_max; i++) {
|
2005-04-17 06:20:36 +08:00
|
|
|
struct gendisk *disk = nbd_dev[i].disk;
|
2012-03-29 05:42:51 +08:00
|
|
|
nbd_dev[i].magic = NBD_MAGIC;
|
2008-04-29 16:02:46 +08:00
|
|
|
INIT_LIST_HEAD(&nbd_dev[i].waiting_queue);
|
2005-04-17 06:20:36 +08:00
|
|
|
spin_lock_init(&nbd_dev[i].queue_lock);
|
2015-10-07 02:03:54 +08:00
|
|
|
spin_lock_init(&nbd_dev[i].tasks_lock);
|
2005-04-17 06:20:36 +08:00
|
|
|
INIT_LIST_HEAD(&nbd_dev[i].queue_head);
|
2006-03-23 19:00:38 +08:00
|
|
|
mutex_init(&nbd_dev[i].tx_lock);
|
2015-08-17 14:20:00 +08:00
|
|
|
init_timer(&nbd_dev[i].timeout_timer);
|
|
|
|
nbd_dev[i].timeout_timer.function = nbd_xmit_timeout;
|
|
|
|
nbd_dev[i].timeout_timer.data = (unsigned long)&nbd_dev[i];
|
2006-01-06 16:09:47 +08:00
|
|
|
init_waitqueue_head(&nbd_dev[i].active_wq);
|
2008-04-29 16:02:46 +08:00
|
|
|
init_waitqueue_head(&nbd_dev[i].waiting_wq);
|
2005-04-17 06:20:36 +08:00
|
|
|
nbd_dev[i].blksize = 1024;
|
2007-10-17 14:27:36 +08:00
|
|
|
nbd_dev[i].bytesize = 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
disk->major = NBD_MAJOR;
|
NBD: add partition support
Permit the use of partitions with network block devices (NBD).
A new parameter is introduced to define how many partition we want to be able
to manage per network block device. This parameter is "max_part".
For instance, to manage 63 partitions / loop device, we will do:
[on the server side]
# nbd-server 1234 /dev/sdb
[on the client side]
# modprobe nbd max_part=63
# ls -l /dev/nbd*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:14 /dev/nbd0
brw-rw---- 1 root disk 43, 64 2008-03-25 11:11 /dev/nbd1
brw-rw---- 1 root disk 43, 640 2008-03-25 11:11 /dev/nbd10
brw-rw---- 1 root disk 43, 704 2008-03-25 11:11 /dev/nbd11
brw-rw---- 1 root disk 43, 768 2008-03-25 11:11 /dev/nbd12
brw-rw---- 1 root disk 43, 832 2008-03-25 11:11 /dev/nbd13
brw-rw---- 1 root disk 43, 896 2008-03-25 11:11 /dev/nbd14
brw-rw---- 1 root disk 43, 960 2008-03-25 11:11 /dev/nbd15
brw-rw---- 1 root disk 43, 128 2008-03-25 11:11 /dev/nbd2
brw-rw---- 1 root disk 43, 192 2008-03-25 11:11 /dev/nbd3
brw-rw---- 1 root disk 43, 256 2008-03-25 11:11 /dev/nbd4
brw-rw---- 1 root disk 43, 320 2008-03-25 11:11 /dev/nbd5
brw-rw---- 1 root disk 43, 384 2008-03-25 11:11 /dev/nbd6
brw-rw---- 1 root disk 43, 448 2008-03-25 11:11 /dev/nbd7
brw-rw---- 1 root disk 43, 512 2008-03-25 11:11 /dev/nbd8
brw-rw---- 1 root disk 43, 576 2008-03-25 11:11 /dev/nbd9
# nbd-client localhost 1234 /dev/nbd0
Negotiation: ..size = 80418240KB
bs=1024, sz=80418240
-------NOTE, RFC: partition table is not automatically read.
The driver sets bdev->bd_invalidated to 1 to force the read of the partition
table of the device, but this is done only on an open of the device.
So we have to do a "touch /dev/nbdX" or something like that.
It can't be done from the nbd-client or nbd driver because at this
level we can't ask to read the partition table and to serve the request
at the same time (-> deadlock)
If someone has a better idea, I'm open to any suggestion.
-------NOTE, RFC
# fdisk -l /dev/nbd0
Disk /dev/nbd0: 82.3 GB, 82348277760 bytes
255 heads, 63 sectors/track, 10011 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Device Boot Start End Blocks Id System
/dev/nbd0p1 * 1 9965 80043831 83 Linux
/dev/nbd0p2 9966 10011 369495 5 Extended
/dev/nbd0p5 9966 10011 369463+ 82 Linux swap / Solaris
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
brw-rw---- 1 root disk 43, 1 2008-03-25 11:16 /dev/nbd0p1
brw-rw---- 1 root disk 43, 2 2008-03-25 11:16 /dev/nbd0p2
brw-rw---- 1 root disk 43, 5 2008-03-25 11:16 /dev/nbd0p5
# mount /dev/nbd0p1 /mnt
# ls /mnt
bin dev initrd lost+found opt sbin sys var
boot etc initrd.img media proc selinux tmp vmlinuz
cdrom home lib mnt root srv usr
# umount /mnt
# nbd-client -d /dev/nbd0
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
-------NOTE
On "nbd-client -d", we can do an iocl(BLKRRPART) to update partition table:
as the size of the device is 0, we don't have to serve the partition manager
request (-> no deadlock).
-------NOTE
Signed-off-by: Paul Clements <paul.clements@steeleye.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-29 16:02:51 +08:00
|
|
|
disk->first_minor = i << part_shift;
|
2005-04-17 06:20:36 +08:00
|
|
|
disk->fops = &nbd_fops;
|
|
|
|
disk->private_data = &nbd_dev[i];
|
|
|
|
sprintf(disk->disk_name, "nbd%d", i);
|
2007-10-17 14:27:36 +08:00
|
|
|
set_capacity(disk, 0);
|
2005-04-17 06:20:36 +08:00
|
|
|
add_disk(disk);
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
out:
|
|
|
|
while (i--) {
|
|
|
|
blk_cleanup_queue(nbd_dev[i].disk->queue);
|
|
|
|
put_disk(nbd_dev[i].disk);
|
|
|
|
}
|
2008-08-21 05:09:07 +08:00
|
|
|
kfree(nbd_dev);
|
2005-04-17 06:20:36 +08:00
|
|
|
return err;
|
|
|
|
}
|
|
|
|
|
|
|
|
static void __exit nbd_cleanup(void)
|
|
|
|
{
|
|
|
|
int i;
|
2015-08-17 14:20:06 +08:00
|
|
|
|
|
|
|
nbd_dbg_close();
|
|
|
|
|
2005-05-01 23:59:07 +08:00
|
|
|
for (i = 0; i < nbds_max; i++) {
|
2005-04-17 06:20:36 +08:00
|
|
|
struct gendisk *disk = nbd_dev[i].disk;
|
2005-05-01 23:59:07 +08:00
|
|
|
nbd_dev[i].magic = 0;
|
2005-04-17 06:20:36 +08:00
|
|
|
if (disk) {
|
|
|
|
del_gendisk(disk);
|
|
|
|
blk_cleanup_queue(disk->queue);
|
|
|
|
put_disk(disk);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
unregister_blkdev(NBD_MAJOR, "nbd");
|
2008-08-21 05:09:07 +08:00
|
|
|
kfree(nbd_dev);
|
2005-04-17 06:20:36 +08:00
|
|
|
printk(KERN_INFO "nbd: unregistered device at major %d\n", NBD_MAJOR);
|
|
|
|
}
|
|
|
|
|
|
|
|
module_init(nbd_init);
|
|
|
|
module_exit(nbd_cleanup);
|
|
|
|
|
|
|
|
MODULE_DESCRIPTION("Network Block Device");
|
|
|
|
MODULE_LICENSE("GPL");
|
|
|
|
|
2005-05-01 23:59:07 +08:00
|
|
|
module_param(nbds_max, int, 0444);
|
NBD: add partition support
Permit the use of partitions with network block devices (NBD).
A new parameter is introduced to define how many partition we want to be able
to manage per network block device. This parameter is "max_part".
For instance, to manage 63 partitions / loop device, we will do:
[on the server side]
# nbd-server 1234 /dev/sdb
[on the client side]
# modprobe nbd max_part=63
# ls -l /dev/nbd*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:14 /dev/nbd0
brw-rw---- 1 root disk 43, 64 2008-03-25 11:11 /dev/nbd1
brw-rw---- 1 root disk 43, 640 2008-03-25 11:11 /dev/nbd10
brw-rw---- 1 root disk 43, 704 2008-03-25 11:11 /dev/nbd11
brw-rw---- 1 root disk 43, 768 2008-03-25 11:11 /dev/nbd12
brw-rw---- 1 root disk 43, 832 2008-03-25 11:11 /dev/nbd13
brw-rw---- 1 root disk 43, 896 2008-03-25 11:11 /dev/nbd14
brw-rw---- 1 root disk 43, 960 2008-03-25 11:11 /dev/nbd15
brw-rw---- 1 root disk 43, 128 2008-03-25 11:11 /dev/nbd2
brw-rw---- 1 root disk 43, 192 2008-03-25 11:11 /dev/nbd3
brw-rw---- 1 root disk 43, 256 2008-03-25 11:11 /dev/nbd4
brw-rw---- 1 root disk 43, 320 2008-03-25 11:11 /dev/nbd5
brw-rw---- 1 root disk 43, 384 2008-03-25 11:11 /dev/nbd6
brw-rw---- 1 root disk 43, 448 2008-03-25 11:11 /dev/nbd7
brw-rw---- 1 root disk 43, 512 2008-03-25 11:11 /dev/nbd8
brw-rw---- 1 root disk 43, 576 2008-03-25 11:11 /dev/nbd9
# nbd-client localhost 1234 /dev/nbd0
Negotiation: ..size = 80418240KB
bs=1024, sz=80418240
-------NOTE, RFC: partition table is not automatically read.
The driver sets bdev->bd_invalidated to 1 to force the read of the partition
table of the device, but this is done only on an open of the device.
So we have to do a "touch /dev/nbdX" or something like that.
It can't be done from the nbd-client or nbd driver because at this
level we can't ask to read the partition table and to serve the request
at the same time (-> deadlock)
If someone has a better idea, I'm open to any suggestion.
-------NOTE, RFC
# fdisk -l /dev/nbd0
Disk /dev/nbd0: 82.3 GB, 82348277760 bytes
255 heads, 63 sectors/track, 10011 cylinders
Units = cylinders of 16065 * 512 = 8225280 bytes
Device Boot Start End Blocks Id System
/dev/nbd0p1 * 1 9965 80043831 83 Linux
/dev/nbd0p2 9966 10011 369495 5 Extended
/dev/nbd0p5 9966 10011 369463+ 82 Linux swap / Solaris
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
brw-rw---- 1 root disk 43, 1 2008-03-25 11:16 /dev/nbd0p1
brw-rw---- 1 root disk 43, 2 2008-03-25 11:16 /dev/nbd0p2
brw-rw---- 1 root disk 43, 5 2008-03-25 11:16 /dev/nbd0p5
# mount /dev/nbd0p1 /mnt
# ls /mnt
bin dev initrd lost+found opt sbin sys var
boot etc initrd.img media proc selinux tmp vmlinuz
cdrom home lib mnt root srv usr
# umount /mnt
# nbd-client -d /dev/nbd0
# ls -l /dev/nbd0*
brw-rw---- 1 root disk 43, 0 2008-03-25 11:16 /dev/nbd0
-------NOTE
On "nbd-client -d", we can do an iocl(BLKRRPART) to update partition table:
as the size of the device is 0, we don't have to serve the partition manager
request (-> no deadlock).
-------NOTE
Signed-off-by: Paul Clements <paul.clements@steeleye.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-04-29 16:02:51 +08:00
|
|
|
MODULE_PARM_DESC(nbds_max, "number of network block devices to initialize (default: 16)");
|
|
|
|
module_param(max_part, int, 0444);
|
|
|
|
MODULE_PARM_DESC(max_part, "number of partitions per device (default: 0)");
|