2011-12-26 17:49:52 +08:00
|
|
|
/*
|
|
|
|
* Copyright (c) 2012 Samsung Electronics Co., Ltd.
|
|
|
|
* http://www.samsung.com
|
2010-05-24 11:28:19 +08:00
|
|
|
*
|
|
|
|
* Copyright (C) 2010 Samsung Electronics Co. Ltd.
|
|
|
|
* Jaswinder Singh <jassi.brar@samsung.com>
|
|
|
|
*
|
|
|
|
* This program is free software; you can redistribute it and/or modify
|
|
|
|
* it under the terms of the GNU General Public License as published by
|
|
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
|
|
* (at your option) any later version.
|
|
|
|
*/
|
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
#include <linux/kernel.h>
|
2010-05-24 11:28:19 +08:00
|
|
|
#include <linux/io.h>
|
|
|
|
#include <linux/init.h>
|
|
|
|
#include <linux/slab.h>
|
|
|
|
#include <linux/module.h>
|
2011-12-26 17:49:52 +08:00
|
|
|
#include <linux/string.h>
|
|
|
|
#include <linux/delay.h>
|
|
|
|
#include <linux/interrupt.h>
|
|
|
|
#include <linux/dma-mapping.h>
|
2010-05-24 11:28:19 +08:00
|
|
|
#include <linux/dmaengine.h>
|
|
|
|
#include <linux/amba/bus.h>
|
2011-09-02 08:44:30 +08:00
|
|
|
#include <linux/scatterlist.h>
|
2011-10-24 17:43:31 +08:00
|
|
|
#include <linux/of.h>
|
2013-02-14 11:40:06 +08:00
|
|
|
#include <linux/of_dma.h>
|
2013-03-04 17:06:27 +08:00
|
|
|
#include <linux/err.h>
|
2014-11-14 16:48:57 +08:00
|
|
|
#include <linux/pm_runtime.h>
|
2018-04-19 08:31:06 +08:00
|
|
|
#include <linux/bug.h>
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2012-03-07 06:34:26 +08:00
|
|
|
#include "dmaengine.h"
|
2011-12-26 17:49:52 +08:00
|
|
|
#define PL330_MAX_CHAN 8
|
|
|
|
#define PL330_MAX_IRQS 32
|
|
|
|
#define PL330_MAX_PERI 32
|
2016-01-22 19:06:51 +08:00
|
|
|
#define PL330_MAX_BURST 16
|
2011-12-26 17:49:52 +08:00
|
|
|
|
2016-01-22 19:06:46 +08:00
|
|
|
#define PL330_QUIRK_BROKEN_NO_FLUSHP BIT(0)
|
|
|
|
|
2014-07-07 02:32:19 +08:00
|
|
|
enum pl330_cachectrl {
|
|
|
|
CCTRL0, /* Noncacheable and nonbufferable */
|
|
|
|
CCTRL1, /* Bufferable only */
|
|
|
|
CCTRL2, /* Cacheable, but do not allocate */
|
|
|
|
CCTRL3, /* Cacheable and bufferable, but do not allocate */
|
|
|
|
INVALID1, /* AWCACHE = 0x1000 */
|
|
|
|
INVALID2,
|
|
|
|
CCTRL6, /* Cacheable write-through, allocate on writes only */
|
|
|
|
CCTRL7, /* Cacheable write-back, allocate on writes only */
|
2011-12-26 17:49:52 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
enum pl330_byteswap {
|
|
|
|
SWAP_NO,
|
|
|
|
SWAP_2,
|
|
|
|
SWAP_4,
|
|
|
|
SWAP_8,
|
|
|
|
SWAP_16,
|
|
|
|
};
|
|
|
|
|
|
|
|
/* Register and Bit field Definitions */
|
|
|
|
#define DS 0x0
|
|
|
|
#define DS_ST_STOP 0x0
|
|
|
|
#define DS_ST_EXEC 0x1
|
|
|
|
#define DS_ST_CMISS 0x2
|
|
|
|
#define DS_ST_UPDTPC 0x3
|
|
|
|
#define DS_ST_WFE 0x4
|
|
|
|
#define DS_ST_ATBRR 0x5
|
|
|
|
#define DS_ST_QBUSY 0x6
|
|
|
|
#define DS_ST_WFP 0x7
|
|
|
|
#define DS_ST_KILL 0x8
|
|
|
|
#define DS_ST_CMPLT 0x9
|
|
|
|
#define DS_ST_FLTCMP 0xe
|
|
|
|
#define DS_ST_FAULT 0xf
|
|
|
|
|
|
|
|
#define DPC 0x4
|
|
|
|
#define INTEN 0x20
|
|
|
|
#define ES 0x24
|
|
|
|
#define INTSTATUS 0x28
|
|
|
|
#define INTCLR 0x2c
|
|
|
|
#define FSM 0x30
|
|
|
|
#define FSC 0x34
|
|
|
|
#define FTM 0x38
|
|
|
|
|
|
|
|
#define _FTC 0x40
|
|
|
|
#define FTC(n) (_FTC + (n)*0x4)
|
|
|
|
|
|
|
|
#define _CS 0x100
|
|
|
|
#define CS(n) (_CS + (n)*0x8)
|
|
|
|
#define CS_CNS (1 << 21)
|
|
|
|
|
|
|
|
#define _CPC 0x104
|
|
|
|
#define CPC(n) (_CPC + (n)*0x8)
|
|
|
|
|
|
|
|
#define _SA 0x400
|
|
|
|
#define SA(n) (_SA + (n)*0x20)
|
|
|
|
|
|
|
|
#define _DA 0x404
|
|
|
|
#define DA(n) (_DA + (n)*0x20)
|
|
|
|
|
|
|
|
#define _CC 0x408
|
|
|
|
#define CC(n) (_CC + (n)*0x20)
|
|
|
|
|
|
|
|
#define CC_SRCINC (1 << 0)
|
|
|
|
#define CC_DSTINC (1 << 14)
|
|
|
|
#define CC_SRCPRI (1 << 8)
|
|
|
|
#define CC_DSTPRI (1 << 22)
|
|
|
|
#define CC_SRCNS (1 << 9)
|
|
|
|
#define CC_DSTNS (1 << 23)
|
|
|
|
#define CC_SRCIA (1 << 10)
|
|
|
|
#define CC_DSTIA (1 << 24)
|
|
|
|
#define CC_SRCBRSTLEN_SHFT 4
|
|
|
|
#define CC_DSTBRSTLEN_SHFT 18
|
|
|
|
#define CC_SRCBRSTSIZE_SHFT 1
|
|
|
|
#define CC_DSTBRSTSIZE_SHFT 15
|
|
|
|
#define CC_SRCCCTRL_SHFT 11
|
|
|
|
#define CC_SRCCCTRL_MASK 0x7
|
|
|
|
#define CC_DSTCCTRL_SHFT 25
|
|
|
|
#define CC_DRCCCTRL_MASK 0x7
|
|
|
|
#define CC_SWAP_SHFT 28
|
|
|
|
|
|
|
|
#define _LC0 0x40c
|
|
|
|
#define LC0(n) (_LC0 + (n)*0x20)
|
|
|
|
|
|
|
|
#define _LC1 0x410
|
|
|
|
#define LC1(n) (_LC1 + (n)*0x20)
|
|
|
|
|
|
|
|
#define DBGSTATUS 0xd00
|
|
|
|
#define DBG_BUSY (1 << 0)
|
|
|
|
|
|
|
|
#define DBGCMD 0xd04
|
|
|
|
#define DBGINST0 0xd08
|
|
|
|
#define DBGINST1 0xd0c
|
|
|
|
|
|
|
|
#define CR0 0xe00
|
|
|
|
#define CR1 0xe04
|
|
|
|
#define CR2 0xe08
|
|
|
|
#define CR3 0xe0c
|
|
|
|
#define CR4 0xe10
|
|
|
|
#define CRD 0xe14
|
|
|
|
|
|
|
|
#define PERIPH_ID 0xfe0
|
2011-12-26 17:55:47 +08:00
|
|
|
#define PERIPH_REV_SHIFT 20
|
|
|
|
#define PERIPH_REV_MASK 0xf
|
|
|
|
#define PERIPH_REV_R0P0 0
|
|
|
|
#define PERIPH_REV_R1P0 1
|
|
|
|
#define PERIPH_REV_R1P1 2
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
#define CR0_PERIPH_REQ_SET (1 << 0)
|
|
|
|
#define CR0_BOOT_EN_SET (1 << 1)
|
|
|
|
#define CR0_BOOT_MAN_NS (1 << 2)
|
|
|
|
#define CR0_NUM_CHANS_SHIFT 4
|
|
|
|
#define CR0_NUM_CHANS_MASK 0x7
|
|
|
|
#define CR0_NUM_PERIPH_SHIFT 12
|
|
|
|
#define CR0_NUM_PERIPH_MASK 0x1f
|
|
|
|
#define CR0_NUM_EVENTS_SHIFT 17
|
|
|
|
#define CR0_NUM_EVENTS_MASK 0x1f
|
|
|
|
|
|
|
|
#define CR1_ICACHE_LEN_SHIFT 0
|
|
|
|
#define CR1_ICACHE_LEN_MASK 0x7
|
|
|
|
#define CR1_NUM_ICACHELINES_SHIFT 4
|
|
|
|
#define CR1_NUM_ICACHELINES_MASK 0xf
|
|
|
|
|
|
|
|
#define CRD_DATA_WIDTH_SHIFT 0
|
|
|
|
#define CRD_DATA_WIDTH_MASK 0x7
|
|
|
|
#define CRD_WR_CAP_SHIFT 4
|
|
|
|
#define CRD_WR_CAP_MASK 0x7
|
|
|
|
#define CRD_WR_Q_DEP_SHIFT 8
|
|
|
|
#define CRD_WR_Q_DEP_MASK 0xf
|
|
|
|
#define CRD_RD_CAP_SHIFT 12
|
|
|
|
#define CRD_RD_CAP_MASK 0x7
|
|
|
|
#define CRD_RD_Q_DEP_SHIFT 16
|
|
|
|
#define CRD_RD_Q_DEP_MASK 0xf
|
|
|
|
#define CRD_DATA_BUFF_SHIFT 20
|
|
|
|
#define CRD_DATA_BUFF_MASK 0x3ff
|
|
|
|
|
|
|
|
#define PART 0x330
|
|
|
|
#define DESIGNER 0x41
|
|
|
|
#define REVISION 0x0
|
|
|
|
#define INTEG_CFG 0x0
|
|
|
|
#define PERIPH_ID_VAL ((PART << 0) | (DESIGNER << 12))
|
|
|
|
|
|
|
|
#define PL330_STATE_STOPPED (1 << 0)
|
|
|
|
#define PL330_STATE_EXECUTING (1 << 1)
|
|
|
|
#define PL330_STATE_WFE (1 << 2)
|
|
|
|
#define PL330_STATE_FAULTING (1 << 3)
|
|
|
|
#define PL330_STATE_COMPLETING (1 << 4)
|
|
|
|
#define PL330_STATE_WFP (1 << 5)
|
|
|
|
#define PL330_STATE_KILLING (1 << 6)
|
|
|
|
#define PL330_STATE_FAULT_COMPLETING (1 << 7)
|
|
|
|
#define PL330_STATE_CACHEMISS (1 << 8)
|
|
|
|
#define PL330_STATE_UPDTPC (1 << 9)
|
|
|
|
#define PL330_STATE_ATBARRIER (1 << 10)
|
|
|
|
#define PL330_STATE_QUEUEBUSY (1 << 11)
|
|
|
|
#define PL330_STATE_INVALID (1 << 15)
|
|
|
|
|
|
|
|
#define PL330_STABLE_STATES (PL330_STATE_STOPPED | PL330_STATE_EXECUTING \
|
|
|
|
| PL330_STATE_WFE | PL330_STATE_FAULTING)
|
|
|
|
|
|
|
|
#define CMD_DMAADDH 0x54
|
|
|
|
#define CMD_DMAEND 0x00
|
|
|
|
#define CMD_DMAFLUSHP 0x35
|
|
|
|
#define CMD_DMAGO 0xa0
|
|
|
|
#define CMD_DMALD 0x04
|
|
|
|
#define CMD_DMALDP 0x25
|
|
|
|
#define CMD_DMALP 0x20
|
|
|
|
#define CMD_DMALPEND 0x28
|
|
|
|
#define CMD_DMAKILL 0x01
|
|
|
|
#define CMD_DMAMOV 0xbc
|
|
|
|
#define CMD_DMANOP 0x18
|
|
|
|
#define CMD_DMARMB 0x12
|
|
|
|
#define CMD_DMASEV 0x34
|
|
|
|
#define CMD_DMAST 0x08
|
|
|
|
#define CMD_DMASTP 0x29
|
|
|
|
#define CMD_DMASTZ 0x0c
|
|
|
|
#define CMD_DMAWFE 0x36
|
|
|
|
#define CMD_DMAWFP 0x30
|
|
|
|
#define CMD_DMAWMB 0x13
|
|
|
|
|
|
|
|
#define SZ_DMAADDH 3
|
|
|
|
#define SZ_DMAEND 1
|
|
|
|
#define SZ_DMAFLUSHP 2
|
|
|
|
#define SZ_DMALD 1
|
|
|
|
#define SZ_DMALDP 2
|
|
|
|
#define SZ_DMALP 2
|
|
|
|
#define SZ_DMALPEND 2
|
|
|
|
#define SZ_DMAKILL 1
|
|
|
|
#define SZ_DMAMOV 6
|
|
|
|
#define SZ_DMANOP 1
|
|
|
|
#define SZ_DMARMB 1
|
|
|
|
#define SZ_DMASEV 2
|
|
|
|
#define SZ_DMAST 1
|
|
|
|
#define SZ_DMASTP 2
|
|
|
|
#define SZ_DMASTZ 1
|
|
|
|
#define SZ_DMAWFE 2
|
|
|
|
#define SZ_DMAWFP 2
|
|
|
|
#define SZ_DMAWMB 1
|
|
|
|
#define SZ_DMAGO 6
|
|
|
|
|
|
|
|
#define BRST_LEN(ccr) ((((ccr) >> CC_SRCBRSTLEN_SHFT) & 0xf) + 1)
|
|
|
|
#define BRST_SIZE(ccr) (1 << (((ccr) >> CC_SRCBRSTSIZE_SHFT) & 0x7))
|
|
|
|
|
|
|
|
#define BYTE_TO_BURST(b, ccr) ((b) / BRST_SIZE(ccr) / BRST_LEN(ccr))
|
|
|
|
#define BURST_TO_BYTE(c, ccr) ((c) * BRST_SIZE(ccr) * BRST_LEN(ccr))
|
|
|
|
|
|
|
|
/*
|
|
|
|
* With 256 bytes, we can do more than 2.5MB and 5MB xfers per req
|
|
|
|
* at 1byte/burst for P<->M and M<->M respectively.
|
|
|
|
* For typical scenario, at 1word/burst, 10MB and 20MB xfers per req
|
|
|
|
* should be enough for P<->M and M<->M respectively.
|
|
|
|
*/
|
|
|
|
#define MCODE_BUFF_PER_REQ 256
|
|
|
|
|
|
|
|
/* Use this _only_ to wait on transient states */
|
|
|
|
#define UNTIL(t, s) while (!(_state(t) & (s))) cpu_relax();
|
|
|
|
|
|
|
|
#ifdef PL330_DEBUG_MCGEN
|
|
|
|
static unsigned cmd_line;
|
|
|
|
#define PL330_DBGCMD_DUMP(off, x...) do { \
|
|
|
|
printk("%x:", cmd_line); \
|
|
|
|
printk(x); \
|
|
|
|
cmd_line += off; \
|
|
|
|
} while (0)
|
|
|
|
#define PL330_DBGMC_START(addr) (cmd_line = addr)
|
|
|
|
#else
|
|
|
|
#define PL330_DBGCMD_DUMP(off, x...) do {} while (0)
|
|
|
|
#define PL330_DBGMC_START(addr) do {} while (0)
|
|
|
|
#endif
|
|
|
|
|
|
|
|
/* The number of default descriptors */
|
2012-03-07 06:34:26 +08:00
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
#define NR_DEFAULT_DESC 16
|
|
|
|
|
2014-11-14 16:48:57 +08:00
|
|
|
/* Delay for runtime PM autosuspend, ms */
|
|
|
|
#define PL330_AUTOSUSPEND_DELAY 20
|
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
/* Populated by the PL330 core driver for DMA API driver's info */
|
|
|
|
struct pl330_config {
|
|
|
|
u32 periph_id;
|
|
|
|
#define DMAC_MODE_NS (1 << 0)
|
|
|
|
unsigned int mode;
|
|
|
|
unsigned int data_bus_width:10; /* In number of bits */
|
2014-11-07 01:20:12 +08:00
|
|
|
unsigned int data_buf_dep:11;
|
2011-12-26 17:49:52 +08:00
|
|
|
unsigned int num_chan:4;
|
|
|
|
unsigned int num_peri:6;
|
|
|
|
u32 peri_ns;
|
|
|
|
unsigned int num_events:6;
|
|
|
|
u32 irq_ns;
|
|
|
|
};
|
|
|
|
|
|
|
|
/**
|
|
|
|
* Request Configuration.
|
|
|
|
* The PL330 core does not modify this and uses the last
|
|
|
|
* working configuration if the request doesn't provide any.
|
|
|
|
*
|
|
|
|
* The Client may want to provide this info only for the
|
|
|
|
* first request and a request with new settings.
|
|
|
|
*/
|
|
|
|
struct pl330_reqcfg {
|
|
|
|
/* Address Incrementing */
|
|
|
|
unsigned dst_inc:1;
|
|
|
|
unsigned src_inc:1;
|
|
|
|
|
|
|
|
/*
|
|
|
|
* For now, the SRC & DST protection levels
|
|
|
|
* and burst size/length are assumed same.
|
|
|
|
*/
|
|
|
|
bool nonsecure;
|
|
|
|
bool privileged;
|
|
|
|
bool insnaccess;
|
|
|
|
unsigned brst_len:5;
|
|
|
|
unsigned brst_size:3; /* in power of 2 */
|
|
|
|
|
2014-07-07 02:32:19 +08:00
|
|
|
enum pl330_cachectrl dcctl;
|
|
|
|
enum pl330_cachectrl scctl;
|
2011-12-26 17:49:52 +08:00
|
|
|
enum pl330_byteswap swap;
|
2011-12-26 17:55:47 +08:00
|
|
|
struct pl330_config *pcfg;
|
2011-12-26 17:49:52 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
/*
|
|
|
|
* One cycle of DMAC operation.
|
|
|
|
* There may be more than one xfer in a request.
|
|
|
|
*/
|
|
|
|
struct pl330_xfer {
|
|
|
|
u32 src_addr;
|
|
|
|
u32 dst_addr;
|
|
|
|
/* Size to xfer */
|
|
|
|
u32 bytes;
|
|
|
|
};
|
|
|
|
|
|
|
|
/* The xfer callbacks are made with one of these arguments. */
|
|
|
|
enum pl330_op_err {
|
|
|
|
/* The all xfers in the request were success. */
|
|
|
|
PL330_ERR_NONE,
|
|
|
|
/* If req aborted due to global error. */
|
|
|
|
PL330_ERR_ABORT,
|
|
|
|
/* If req failed due to problem with Channel. */
|
|
|
|
PL330_ERR_FAIL,
|
|
|
|
};
|
|
|
|
|
|
|
|
enum dmamov_dst {
|
|
|
|
SAR = 0,
|
|
|
|
CCR,
|
|
|
|
DAR,
|
|
|
|
};
|
|
|
|
|
|
|
|
enum pl330_dst {
|
|
|
|
SRC = 0,
|
|
|
|
DST,
|
|
|
|
};
|
|
|
|
|
|
|
|
enum pl330_cond {
|
|
|
|
SINGLE,
|
|
|
|
BURST,
|
|
|
|
ALWAYS,
|
|
|
|
};
|
|
|
|
|
2014-07-07 02:32:30 +08:00
|
|
|
struct dma_pl330_desc;
|
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
struct _pl330_req {
|
|
|
|
u32 mc_bus;
|
|
|
|
void *mc_cpu;
|
2014-07-07 02:32:30 +08:00
|
|
|
struct dma_pl330_desc *desc;
|
2011-12-26 17:49:52 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
/* ToBeDone for tasklet */
|
|
|
|
struct _pl330_tbd {
|
|
|
|
bool reset_dmac;
|
|
|
|
bool reset_mngr;
|
|
|
|
u8 reset_chan;
|
|
|
|
};
|
|
|
|
|
|
|
|
/* A DMAC Thread */
|
|
|
|
struct pl330_thread {
|
|
|
|
u8 id;
|
|
|
|
int ev;
|
|
|
|
/* If the channel is not yet acquired by any client */
|
|
|
|
bool free;
|
|
|
|
/* Parent DMAC */
|
|
|
|
struct pl330_dmac *dmac;
|
|
|
|
/* Only two at a time */
|
|
|
|
struct _pl330_req req[2];
|
|
|
|
/* Index of the last enqueued request */
|
|
|
|
unsigned lstenq;
|
|
|
|
/* Index of the last submitted request or -1 if the DMA is stopped */
|
|
|
|
int req_running;
|
|
|
|
};
|
|
|
|
|
|
|
|
enum pl330_dmac_state {
|
|
|
|
UNINIT,
|
|
|
|
INIT,
|
|
|
|
DYING,
|
|
|
|
};
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
enum desc_status {
|
|
|
|
/* In the DMAC pool */
|
|
|
|
FREE,
|
|
|
|
/*
|
2012-08-04 22:37:53 +08:00
|
|
|
* Allocated to some channel during prep_xxx
|
2010-05-24 11:28:19 +08:00
|
|
|
* Also may be sitting on the work_list.
|
|
|
|
*/
|
|
|
|
PREP,
|
|
|
|
/*
|
|
|
|
* Sitting on the work_list and already submitted
|
|
|
|
* to the PL330 core. Not more than two descriptors
|
|
|
|
* of a channel can be BUSY at any time.
|
|
|
|
*/
|
|
|
|
BUSY,
|
|
|
|
/*
|
|
|
|
* Sitting on the channel work_list but xfer done
|
|
|
|
* by PL330 core
|
|
|
|
*/
|
|
|
|
DONE,
|
|
|
|
};
|
|
|
|
|
|
|
|
struct dma_pl330_chan {
|
|
|
|
/* Schedule desc completion */
|
|
|
|
struct tasklet_struct task;
|
|
|
|
|
|
|
|
/* DMA-Engine Channel */
|
|
|
|
struct dma_chan chan;
|
|
|
|
|
2014-01-12 03:08:38 +08:00
|
|
|
/* List of submitted descriptors */
|
|
|
|
struct list_head submitted_list;
|
|
|
|
/* List of issued descriptors */
|
2010-05-24 11:28:19 +08:00
|
|
|
struct list_head work_list;
|
2013-08-28 02:34:05 +08:00
|
|
|
/* List of completed descriptors */
|
|
|
|
struct list_head completed_list;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
/* Pointer to the DMAC that manages this channel,
|
|
|
|
* NULL if the channel is available to be acquired.
|
|
|
|
* As the parent, this DMAC also provides descriptors
|
|
|
|
* to the channel.
|
|
|
|
*/
|
2014-07-07 02:32:29 +08:00
|
|
|
struct pl330_dmac *dmac;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
/* To protect channel manipulation */
|
|
|
|
spinlock_t lock;
|
|
|
|
|
2014-07-07 02:32:26 +08:00
|
|
|
/*
|
|
|
|
* Hardware channel thread of PL330 DMAC. NULL if the channel is
|
|
|
|
* available.
|
2010-05-24 11:28:19 +08:00
|
|
|
*/
|
2014-07-07 02:32:26 +08:00
|
|
|
struct pl330_thread *thread;
|
2011-09-02 08:44:30 +08:00
|
|
|
|
|
|
|
/* For D-to-M and M-to-D channels */
|
|
|
|
int burst_sz; /* the peripheral fifo width */
|
2011-09-02 08:44:31 +08:00
|
|
|
int burst_len; /* the number of burst */
|
2017-05-19 22:06:44 +08:00
|
|
|
phys_addr_t fifo_addr;
|
|
|
|
/* DMA-mapped view of the FIFO; may differ if an IOMMU is present */
|
|
|
|
dma_addr_t fifo_dma;
|
|
|
|
enum dma_data_direction dir;
|
2011-09-02 08:44:33 +08:00
|
|
|
|
|
|
|
/* for cyclic capability */
|
|
|
|
bool cyclic;
|
2016-12-16 18:39:11 +08:00
|
|
|
|
|
|
|
/* for runtime pm tracking */
|
|
|
|
bool active;
|
2010-05-24 11:28:19 +08:00
|
|
|
};
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
struct pl330_dmac {
|
2010-05-24 11:28:19 +08:00
|
|
|
/* DMA-Engine Device */
|
|
|
|
struct dma_device ddma;
|
|
|
|
|
2013-11-25 23:07:46 +08:00
|
|
|
/* Holds info about sg limitations */
|
|
|
|
struct device_dma_parameters dma_parms;
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
/* Pool of descriptors available for the DMAC's channels */
|
|
|
|
struct list_head desc_pool;
|
|
|
|
/* To protect desc_pool manipulation */
|
|
|
|
spinlock_t pool_lock;
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
/* Size of MicroCode buffers for each channel. */
|
|
|
|
unsigned mcbufsz;
|
|
|
|
/* ioremap'ed address of PL330 registers. */
|
|
|
|
void __iomem *base;
|
|
|
|
/* Populated by the PL330 core driver during pl330_add */
|
|
|
|
struct pl330_config pcfg;
|
|
|
|
|
|
|
|
spinlock_t lock;
|
|
|
|
/* Maximum possible events/irqs */
|
|
|
|
int events[32];
|
|
|
|
/* BUS address of MicroCode buffer */
|
|
|
|
dma_addr_t mcode_bus;
|
|
|
|
/* CPU address of MicroCode buffer */
|
|
|
|
void *mcode_cpu;
|
|
|
|
/* List of all Channel threads */
|
|
|
|
struct pl330_thread *channels;
|
|
|
|
/* Pointer to the MANAGER thread */
|
|
|
|
struct pl330_thread *manager;
|
|
|
|
/* To handle bad news in interrupt */
|
|
|
|
struct tasklet_struct tasks;
|
|
|
|
struct _pl330_tbd dmac_tbd;
|
|
|
|
/* State of DMAC operation */
|
|
|
|
enum pl330_dmac_state state;
|
|
|
|
/* Holds list of reqs with due callbacks */
|
|
|
|
struct list_head req_done;
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
/* Peripheral channels connected to this DMAC */
|
2014-01-12 03:08:39 +08:00
|
|
|
unsigned int num_peripherals;
|
2011-07-26 05:05:04 +08:00
|
|
|
struct dma_pl330_chan *peripherals; /* keep at end */
|
2016-01-22 19:06:46 +08:00
|
|
|
int quirks;
|
|
|
|
};
|
|
|
|
|
|
|
|
static struct pl330_of_quirks {
|
|
|
|
char *quirk;
|
|
|
|
int id;
|
|
|
|
} of_quirks[] = {
|
|
|
|
{
|
|
|
|
.quirk = "arm,pl330-broken-no-flushp",
|
|
|
|
.id = PL330_QUIRK_BROKEN_NO_FLUSHP,
|
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
};
|
|
|
|
|
|
|
|
struct dma_pl330_desc {
|
|
|
|
/* To attach to a queue as child */
|
|
|
|
struct list_head node;
|
|
|
|
|
|
|
|
/* Descriptor for the DMA Engine API */
|
|
|
|
struct dma_async_tx_descriptor txd;
|
|
|
|
|
|
|
|
/* Xfer for PL330 core */
|
|
|
|
struct pl330_xfer px;
|
|
|
|
|
|
|
|
struct pl330_reqcfg rqcfg;
|
|
|
|
|
|
|
|
enum desc_status status;
|
|
|
|
|
2015-02-11 20:23:17 +08:00
|
|
|
int bytes_requested;
|
|
|
|
bool last;
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
/* The channel which currently holds this desc */
|
|
|
|
struct dma_pl330_chan *pchan;
|
2014-07-07 02:32:30 +08:00
|
|
|
|
|
|
|
enum dma_transfer_direction rqtype;
|
|
|
|
/* Index of peripheral for the xfer. */
|
|
|
|
unsigned peri:5;
|
|
|
|
/* Hook to attach to DMAC's list of reqs with due callback */
|
|
|
|
struct list_head rqd;
|
|
|
|
};
|
|
|
|
|
|
|
|
struct _xfer_spec {
|
|
|
|
u32 ccr;
|
|
|
|
struct dma_pl330_desc *desc;
|
2010-05-24 11:28:19 +08:00
|
|
|
};
|
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
static inline bool _queue_full(struct pl330_thread *thrd)
|
|
|
|
{
|
2014-07-07 02:32:31 +08:00
|
|
|
return thrd->req[0].desc != NULL && thrd->req[1].desc != NULL;
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static inline bool is_manager(struct pl330_thread *thrd)
|
|
|
|
{
|
2014-07-07 02:32:28 +08:00
|
|
|
return thrd->dmac->manager == thrd;
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* If manager of the thread is in Non-Secure mode */
|
|
|
|
static inline bool _manager_ns(struct pl330_thread *thrd)
|
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
return (thrd->dmac->pcfg.mode & DMAC_MODE_NS) ? true : false;
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
|
|
|
|
2011-12-26 17:55:47 +08:00
|
|
|
static inline u32 get_revision(u32 periph_id)
|
|
|
|
{
|
|
|
|
return (periph_id >> PERIPH_REV_SHIFT) & PERIPH_REV_MASK;
|
|
|
|
}
|
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
static inline u32 _emit_END(unsigned dry_run, u8 buf[])
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMAEND;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMAEND;
|
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMAEND, "\tDMAEND\n");
|
|
|
|
|
|
|
|
return SZ_DMAEND;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _emit_FLUSHP(unsigned dry_run, u8 buf[], u8 peri)
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMAFLUSHP;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMAFLUSHP;
|
|
|
|
|
|
|
|
peri &= 0x1f;
|
|
|
|
peri <<= 3;
|
|
|
|
buf[1] = peri;
|
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMAFLUSHP, "\tDMAFLUSHP %u\n", peri >> 3);
|
|
|
|
|
|
|
|
return SZ_DMAFLUSHP;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _emit_LD(unsigned dry_run, u8 buf[], enum pl330_cond cond)
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMALD;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMALD;
|
|
|
|
|
|
|
|
if (cond == SINGLE)
|
|
|
|
buf[0] |= (0 << 1) | (1 << 0);
|
|
|
|
else if (cond == BURST)
|
|
|
|
buf[0] |= (1 << 1) | (1 << 0);
|
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMALD, "\tDMALD%c\n",
|
|
|
|
cond == SINGLE ? 'S' : (cond == BURST ? 'B' : 'A'));
|
|
|
|
|
|
|
|
return SZ_DMALD;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _emit_LDP(unsigned dry_run, u8 buf[],
|
|
|
|
enum pl330_cond cond, u8 peri)
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMALDP;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMALDP;
|
|
|
|
|
|
|
|
if (cond == BURST)
|
|
|
|
buf[0] |= (1 << 1);
|
|
|
|
|
|
|
|
peri &= 0x1f;
|
|
|
|
peri <<= 3;
|
|
|
|
buf[1] = peri;
|
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMALDP, "\tDMALDP%c %u\n",
|
|
|
|
cond == SINGLE ? 'S' : 'B', peri >> 3);
|
|
|
|
|
|
|
|
return SZ_DMALDP;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _emit_LP(unsigned dry_run, u8 buf[],
|
|
|
|
unsigned loop, u8 cnt)
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMALP;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMALP;
|
|
|
|
|
|
|
|
if (loop)
|
|
|
|
buf[0] |= (1 << 1);
|
|
|
|
|
|
|
|
cnt--; /* DMAC increments by 1 internally */
|
|
|
|
buf[1] = cnt;
|
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMALP, "\tDMALP_%c %u\n", loop ? '1' : '0', cnt);
|
|
|
|
|
|
|
|
return SZ_DMALP;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct _arg_LPEND {
|
|
|
|
enum pl330_cond cond;
|
|
|
|
bool forever;
|
|
|
|
unsigned loop;
|
|
|
|
u8 bjump;
|
|
|
|
};
|
|
|
|
|
|
|
|
static inline u32 _emit_LPEND(unsigned dry_run, u8 buf[],
|
|
|
|
const struct _arg_LPEND *arg)
|
|
|
|
{
|
|
|
|
enum pl330_cond cond = arg->cond;
|
|
|
|
bool forever = arg->forever;
|
|
|
|
unsigned loop = arg->loop;
|
|
|
|
u8 bjump = arg->bjump;
|
|
|
|
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMALPEND;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMALPEND;
|
|
|
|
|
|
|
|
if (loop)
|
|
|
|
buf[0] |= (1 << 2);
|
|
|
|
|
|
|
|
if (!forever)
|
|
|
|
buf[0] |= (1 << 4);
|
|
|
|
|
|
|
|
if (cond == SINGLE)
|
|
|
|
buf[0] |= (0 << 1) | (1 << 0);
|
|
|
|
else if (cond == BURST)
|
|
|
|
buf[0] |= (1 << 1) | (1 << 0);
|
|
|
|
|
|
|
|
buf[1] = bjump;
|
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMALPEND, "\tDMALP%s%c_%c bjmpto_%x\n",
|
|
|
|
forever ? "FE" : "END",
|
|
|
|
cond == SINGLE ? 'S' : (cond == BURST ? 'B' : 'A'),
|
|
|
|
loop ? '1' : '0',
|
|
|
|
bjump);
|
|
|
|
|
|
|
|
return SZ_DMALPEND;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _emit_KILL(unsigned dry_run, u8 buf[])
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMAKILL;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMAKILL;
|
|
|
|
|
|
|
|
return SZ_DMAKILL;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _emit_MOV(unsigned dry_run, u8 buf[],
|
|
|
|
enum dmamov_dst dst, u32 val)
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMAMOV;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMAMOV;
|
|
|
|
buf[1] = dst;
|
2016-12-07 21:17:40 +08:00
|
|
|
buf[2] = val;
|
|
|
|
buf[3] = val >> 8;
|
|
|
|
buf[4] = val >> 16;
|
|
|
|
buf[5] = val >> 24;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMAMOV, "\tDMAMOV %s 0x%x\n",
|
|
|
|
dst == SAR ? "SAR" : (dst == DAR ? "DAR" : "CCR"), val);
|
|
|
|
|
|
|
|
return SZ_DMAMOV;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _emit_RMB(unsigned dry_run, u8 buf[])
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMARMB;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMARMB;
|
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMARMB, "\tDMARMB\n");
|
|
|
|
|
|
|
|
return SZ_DMARMB;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _emit_SEV(unsigned dry_run, u8 buf[], u8 ev)
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMASEV;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMASEV;
|
|
|
|
|
|
|
|
ev &= 0x1f;
|
|
|
|
ev <<= 3;
|
|
|
|
buf[1] = ev;
|
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMASEV, "\tDMASEV %u\n", ev >> 3);
|
|
|
|
|
|
|
|
return SZ_DMASEV;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _emit_ST(unsigned dry_run, u8 buf[], enum pl330_cond cond)
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMAST;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMAST;
|
|
|
|
|
|
|
|
if (cond == SINGLE)
|
|
|
|
buf[0] |= (0 << 1) | (1 << 0);
|
|
|
|
else if (cond == BURST)
|
|
|
|
buf[0] |= (1 << 1) | (1 << 0);
|
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMAST, "\tDMAST%c\n",
|
|
|
|
cond == SINGLE ? 'S' : (cond == BURST ? 'B' : 'A'));
|
|
|
|
|
|
|
|
return SZ_DMAST;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _emit_STP(unsigned dry_run, u8 buf[],
|
|
|
|
enum pl330_cond cond, u8 peri)
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMASTP;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMASTP;
|
|
|
|
|
|
|
|
if (cond == BURST)
|
|
|
|
buf[0] |= (1 << 1);
|
|
|
|
|
|
|
|
peri &= 0x1f;
|
|
|
|
peri <<= 3;
|
|
|
|
buf[1] = peri;
|
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMASTP, "\tDMASTP%c %u\n",
|
|
|
|
cond == SINGLE ? 'S' : 'B', peri >> 3);
|
|
|
|
|
|
|
|
return SZ_DMASTP;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _emit_WFP(unsigned dry_run, u8 buf[],
|
|
|
|
enum pl330_cond cond, u8 peri)
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMAWFP;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMAWFP;
|
|
|
|
|
|
|
|
if (cond == SINGLE)
|
|
|
|
buf[0] |= (0 << 1) | (0 << 0);
|
|
|
|
else if (cond == BURST)
|
|
|
|
buf[0] |= (1 << 1) | (0 << 0);
|
|
|
|
else
|
|
|
|
buf[0] |= (0 << 1) | (1 << 0);
|
|
|
|
|
|
|
|
peri &= 0x1f;
|
|
|
|
peri <<= 3;
|
|
|
|
buf[1] = peri;
|
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMAWFP, "\tDMAWFP%c %u\n",
|
|
|
|
cond == SINGLE ? 'S' : (cond == BURST ? 'B' : 'P'), peri >> 3);
|
|
|
|
|
|
|
|
return SZ_DMAWFP;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _emit_WMB(unsigned dry_run, u8 buf[])
|
|
|
|
{
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMAWMB;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMAWMB;
|
|
|
|
|
|
|
|
PL330_DBGCMD_DUMP(SZ_DMAWMB, "\tDMAWMB\n");
|
|
|
|
|
|
|
|
return SZ_DMAWMB;
|
|
|
|
}
|
|
|
|
|
|
|
|
struct _arg_GO {
|
|
|
|
u8 chan;
|
|
|
|
u32 addr;
|
|
|
|
unsigned ns;
|
|
|
|
};
|
|
|
|
|
|
|
|
static inline u32 _emit_GO(unsigned dry_run, u8 buf[],
|
|
|
|
const struct _arg_GO *arg)
|
|
|
|
{
|
|
|
|
u8 chan = arg->chan;
|
|
|
|
u32 addr = arg->addr;
|
|
|
|
unsigned ns = arg->ns;
|
|
|
|
|
|
|
|
if (dry_run)
|
|
|
|
return SZ_DMAGO;
|
|
|
|
|
|
|
|
buf[0] = CMD_DMAGO;
|
|
|
|
buf[0] |= (ns << 1);
|
|
|
|
buf[1] = chan & 0x7;
|
2016-12-07 21:17:40 +08:00
|
|
|
buf[2] = addr;
|
|
|
|
buf[3] = addr >> 8;
|
|
|
|
buf[4] = addr >> 16;
|
|
|
|
buf[5] = addr >> 24;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
return SZ_DMAGO;
|
|
|
|
}
|
|
|
|
|
|
|
|
#define msecs_to_loops(t) (loops_per_jiffy / 1000 * HZ * t)
|
|
|
|
|
|
|
|
/* Returns Time-Out */
|
|
|
|
static bool _until_dmac_idle(struct pl330_thread *thrd)
|
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
void __iomem *regs = thrd->dmac->base;
|
2011-12-26 17:49:52 +08:00
|
|
|
unsigned long loops = msecs_to_loops(5);
|
|
|
|
|
|
|
|
do {
|
|
|
|
/* Until Manager is Idle */
|
|
|
|
if (!(readl(regs + DBGSTATUS) & DBG_BUSY))
|
|
|
|
break;
|
|
|
|
|
|
|
|
cpu_relax();
|
|
|
|
} while (--loops);
|
|
|
|
|
|
|
|
if (!loops)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void _execute_DBGINSN(struct pl330_thread *thrd,
|
|
|
|
u8 insn[], bool as_manager)
|
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
void __iomem *regs = thrd->dmac->base;
|
2011-12-26 17:49:52 +08:00
|
|
|
u32 val;
|
|
|
|
|
|
|
|
val = (insn[0] << 16) | (insn[1] << 24);
|
|
|
|
if (!as_manager) {
|
|
|
|
val |= (1 << 0);
|
|
|
|
val |= (thrd->id << 8); /* Channel Number */
|
|
|
|
}
|
|
|
|
writel(val, regs + DBGINST0);
|
|
|
|
|
2015-03-16 19:52:43 +08:00
|
|
|
val = le32_to_cpu(*((__le32 *)&insn[2]));
|
2011-12-26 17:49:52 +08:00
|
|
|
writel(val, regs + DBGINST1);
|
|
|
|
|
|
|
|
/* If timed out due to halted state-machine */
|
|
|
|
if (_until_dmac_idle(thrd)) {
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_err(thrd->dmac->ddma.dev, "DMAC halted!\n");
|
2011-12-26 17:49:52 +08:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Get going */
|
|
|
|
writel(0, regs + DBGCMD);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _state(struct pl330_thread *thrd)
|
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
void __iomem *regs = thrd->dmac->base;
|
2011-12-26 17:49:52 +08:00
|
|
|
u32 val;
|
|
|
|
|
|
|
|
if (is_manager(thrd))
|
|
|
|
val = readl(regs + DS) & 0xf;
|
|
|
|
else
|
|
|
|
val = readl(regs + CS(thrd->id)) & 0xf;
|
|
|
|
|
|
|
|
switch (val) {
|
|
|
|
case DS_ST_STOP:
|
|
|
|
return PL330_STATE_STOPPED;
|
|
|
|
case DS_ST_EXEC:
|
|
|
|
return PL330_STATE_EXECUTING;
|
|
|
|
case DS_ST_CMISS:
|
|
|
|
return PL330_STATE_CACHEMISS;
|
|
|
|
case DS_ST_UPDTPC:
|
|
|
|
return PL330_STATE_UPDTPC;
|
|
|
|
case DS_ST_WFE:
|
|
|
|
return PL330_STATE_WFE;
|
|
|
|
case DS_ST_FAULT:
|
|
|
|
return PL330_STATE_FAULTING;
|
|
|
|
case DS_ST_ATBRR:
|
|
|
|
if (is_manager(thrd))
|
|
|
|
return PL330_STATE_INVALID;
|
|
|
|
else
|
|
|
|
return PL330_STATE_ATBARRIER;
|
|
|
|
case DS_ST_QBUSY:
|
|
|
|
if (is_manager(thrd))
|
|
|
|
return PL330_STATE_INVALID;
|
|
|
|
else
|
|
|
|
return PL330_STATE_QUEUEBUSY;
|
|
|
|
case DS_ST_WFP:
|
|
|
|
if (is_manager(thrd))
|
|
|
|
return PL330_STATE_INVALID;
|
|
|
|
else
|
|
|
|
return PL330_STATE_WFP;
|
|
|
|
case DS_ST_KILL:
|
|
|
|
if (is_manager(thrd))
|
|
|
|
return PL330_STATE_INVALID;
|
|
|
|
else
|
|
|
|
return PL330_STATE_KILLING;
|
|
|
|
case DS_ST_CMPLT:
|
|
|
|
if (is_manager(thrd))
|
|
|
|
return PL330_STATE_INVALID;
|
|
|
|
else
|
|
|
|
return PL330_STATE_COMPLETING;
|
|
|
|
case DS_ST_FLTCMP:
|
|
|
|
if (is_manager(thrd))
|
|
|
|
return PL330_STATE_INVALID;
|
|
|
|
else
|
|
|
|
return PL330_STATE_FAULT_COMPLETING;
|
|
|
|
default:
|
|
|
|
return PL330_STATE_INVALID;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void _stop(struct pl330_thread *thrd)
|
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
void __iomem *regs = thrd->dmac->base;
|
2011-12-26 17:49:52 +08:00
|
|
|
u8 insn[6] = {0, 0, 0, 0, 0, 0};
|
|
|
|
|
|
|
|
if (_state(thrd) == PL330_STATE_FAULT_COMPLETING)
|
|
|
|
UNTIL(thrd, PL330_STATE_FAULTING | PL330_STATE_KILLING);
|
|
|
|
|
|
|
|
/* Return if nothing needs to be done */
|
|
|
|
if (_state(thrd) == PL330_STATE_COMPLETING
|
|
|
|
|| _state(thrd) == PL330_STATE_KILLING
|
|
|
|
|| _state(thrd) == PL330_STATE_STOPPED)
|
|
|
|
return;
|
|
|
|
|
|
|
|
_emit_KILL(0, insn);
|
|
|
|
|
|
|
|
/* Stop generating interrupts for SEV */
|
|
|
|
writel(readl(regs + INTEN) & ~(1 << thrd->ev), regs + INTEN);
|
|
|
|
|
|
|
|
_execute_DBGINSN(thrd, insn, is_manager(thrd));
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Start doing req 'idx' of thread 'thrd' */
|
|
|
|
static bool _trigger(struct pl330_thread *thrd)
|
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
void __iomem *regs = thrd->dmac->base;
|
2011-12-26 17:49:52 +08:00
|
|
|
struct _pl330_req *req;
|
2014-07-07 02:32:30 +08:00
|
|
|
struct dma_pl330_desc *desc;
|
2011-12-26 17:49:52 +08:00
|
|
|
struct _arg_GO go;
|
|
|
|
unsigned ns;
|
|
|
|
u8 insn[6] = {0, 0, 0, 0, 0, 0};
|
|
|
|
int idx;
|
|
|
|
|
|
|
|
/* Return if already ACTIVE */
|
|
|
|
if (_state(thrd) != PL330_STATE_STOPPED)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
idx = 1 - thrd->lstenq;
|
2014-07-07 02:32:31 +08:00
|
|
|
if (thrd->req[idx].desc != NULL) {
|
2011-12-26 17:49:52 +08:00
|
|
|
req = &thrd->req[idx];
|
2014-07-07 02:32:31 +08:00
|
|
|
} else {
|
2011-12-26 17:49:52 +08:00
|
|
|
idx = thrd->lstenq;
|
2014-07-07 02:32:31 +08:00
|
|
|
if (thrd->req[idx].desc != NULL)
|
2011-12-26 17:49:52 +08:00
|
|
|
req = &thrd->req[idx];
|
|
|
|
else
|
|
|
|
req = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Return if no request */
|
2014-07-07 02:32:31 +08:00
|
|
|
if (!req)
|
2011-12-26 17:49:52 +08:00
|
|
|
return true;
|
|
|
|
|
dmaengine: pl330: fix bug that cause start the same descs in cyclic
This bug will cause NULL pointer after commit dfac17, and cause
wrong package in I2S DMA transfer before commit dfac17.
Tested on RK3288-pinky2 board.
Detail:
I2S DMA transfer(sound/core/pcm_dmaengine.c):
dmaengine_pcm_prepare_and_submit -->
dmaengine_prep_dma_cyclic -->
pl330_prep_dma_cyclic -->
the case:
1. pl330_submit_req(desc0): thrd->req[0].desc = desc0, thrd->lstenq = 0
2. pl330_submit_req(desc1): thrd->req[1].desc = desc1, thrd->lstenq = 1
3. _start(desc0) by submit_req: thrd->req_running = 0
because: idx = 1 - thrd->lstenq = 0
4. pl330_update(desc0 OK): thrd->req[0].desc = NULL, desc0 to req_done list
because: idx = active = thrd->req_running = 0
5. _start(desc1) by pl330_update: thrd->req_running = 1
because:
idx = 1 - thrd->lstenq = 0, but thrd->req[0].desc == NULL,
so:
idx = thrd->lstenq = 1
6. pl330_submit_req(desc2): thrd->req[0].desc = desc2, thrd->lstenq = 0
7. _start(desc1) by submit_req: thrd->req_running = 1
because: idx = 1 - thrd->lstenq = 1
Note: _start started the same descs
_start should start desc2 here, NOT desc1
8. pl330_update(desc1 OK): thrd->req[1].desc = NULL, desc1 to req_done list
because: idx = active = thrd->req_running = 1
9. _start(desc2) by pl330_update : thrd->req_running = 0
because: idx = 1 - thrd->lstenq = 0
10.pl330_update(desc1 OK, NOT desc2): thrd->req[0].desc = NULL,
desc2 to req_done list
because: idx = active = thrd->req_running = 0
11.pl330_submit_req(desc3): thrd->req[0].desc = desc3, thrd->lstenq = 0
12.pl330_submit_req(desc4): thrd->req[1].desc = desc4, thrd->lstenq = 1
13._start(desc3) by submit_req: thrd->req_running = 0
because: idx = 1 - thrd->lstenq = 0
14.pl330_update(desc2 OK NOT desc3): thrd->req[0].desc = NULL
desc3 to req_done list
because: idx = active = thrd->req_running = 0
15._start(desc4) by pl330_update: thrd->req_running = 1
because:
idx = 1 - thrd->lstenq = 0, but thrd->req[0].desc == NULL,
so:
idx = thrd->lstenq = 1
16.pl330_submit_req(desc5): thrd->req[0].desc = desc5, thrd->lstenq = 0
17._start(desc4) by submit_req: thrd->req_running = 1
because: idx = 1 - thrd->lstenq = 1
18.pl330_update(desc3 OK NOT desc4): thrd->req[1].desc = NULL
desc4 to req_done list
because: idx = active = thrd->req_running = 1
19._start(desc4) by pl330_update: thrd->req_running = 0
because:
idx = 1 - thrd->lstenq = 1, but thrd->req[1].desc == NULL,
so:
idx = thrd->lstenq = 0
20.pl330_update(desc4 OK): thrd->req[0].desc = NULL, desc5 to req_done list
because: idx = active = thrd->req_running = 0
21.pl330_update(desc4 OK):
1) before commit dfac17(set req_running -1 in pl330_update/mark_free()):
because: active = -1, abort
result: desc0-desc5's callback are all called,
but step 10 and step 18 go wrong.
2) before commit dfac17:
idx = active = thrd->req_runnig = 0 -->
descdone = thrd->req[0] = NULL -->
list_add_tail(&descdone->rqd, &pl330->req_done); -->
got NULL pointer!!!
Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2014-12-08 19:28:20 +08:00
|
|
|
/* Return if req is running */
|
|
|
|
if (idx == thrd->req_running)
|
|
|
|
return true;
|
|
|
|
|
2014-07-07 02:32:30 +08:00
|
|
|
desc = req->desc;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
2014-07-07 02:32:30 +08:00
|
|
|
ns = desc->rqcfg.nonsecure ? 1 : 0;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
/* See 'Abort Sources' point-4 at Page 2-25 */
|
|
|
|
if (_manager_ns(thrd) && !ns)
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_info(thrd->dmac->ddma.dev, "%s:%d Recipe for ABORT!\n",
|
2011-12-26 17:49:52 +08:00
|
|
|
__func__, __LINE__);
|
|
|
|
|
|
|
|
go.chan = thrd->id;
|
|
|
|
go.addr = req->mc_bus;
|
|
|
|
go.ns = ns;
|
|
|
|
_emit_GO(0, insn, &go);
|
|
|
|
|
|
|
|
/* Set to generate interrupts for SEV */
|
|
|
|
writel(readl(regs + INTEN) | (1 << thrd->ev), regs + INTEN);
|
|
|
|
|
|
|
|
/* Only manager can execute GO */
|
|
|
|
_execute_DBGINSN(thrd, insn, true);
|
|
|
|
|
|
|
|
thrd->req_running = idx;
|
|
|
|
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool _start(struct pl330_thread *thrd)
|
|
|
|
{
|
|
|
|
switch (_state(thrd)) {
|
|
|
|
case PL330_STATE_FAULT_COMPLETING:
|
|
|
|
UNTIL(thrd, PL330_STATE_FAULTING | PL330_STATE_KILLING);
|
|
|
|
|
|
|
|
if (_state(thrd) == PL330_STATE_KILLING)
|
|
|
|
UNTIL(thrd, PL330_STATE_STOPPED)
|
|
|
|
|
|
|
|
case PL330_STATE_FAULTING:
|
|
|
|
_stop(thrd);
|
|
|
|
|
|
|
|
case PL330_STATE_KILLING:
|
|
|
|
case PL330_STATE_COMPLETING:
|
|
|
|
UNTIL(thrd, PL330_STATE_STOPPED)
|
|
|
|
|
|
|
|
case PL330_STATE_STOPPED:
|
|
|
|
return _trigger(thrd);
|
|
|
|
|
|
|
|
case PL330_STATE_WFP:
|
|
|
|
case PL330_STATE_QUEUEBUSY:
|
|
|
|
case PL330_STATE_ATBARRIER:
|
|
|
|
case PL330_STATE_UPDTPC:
|
|
|
|
case PL330_STATE_CACHEMISS:
|
|
|
|
case PL330_STATE_EXECUTING:
|
|
|
|
return true;
|
|
|
|
|
|
|
|
case PL330_STATE_WFE: /* For RESUME, nothing yet */
|
|
|
|
default:
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline int _ldst_memtomem(unsigned dry_run, u8 buf[],
|
|
|
|
const struct _xfer_spec *pxs, int cyc)
|
|
|
|
{
|
|
|
|
int off = 0;
|
2014-07-07 02:32:30 +08:00
|
|
|
struct pl330_config *pcfg = pxs->desc->rqcfg.pcfg;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
2011-12-26 17:55:47 +08:00
|
|
|
/* check lock-up free version */
|
|
|
|
if (get_revision(pcfg->periph_id) >= PERIPH_REV_R1P0) {
|
|
|
|
while (cyc--) {
|
|
|
|
off += _emit_LD(dry_run, &buf[off], ALWAYS);
|
|
|
|
off += _emit_ST(dry_run, &buf[off], ALWAYS);
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
while (cyc--) {
|
|
|
|
off += _emit_LD(dry_run, &buf[off], ALWAYS);
|
|
|
|
off += _emit_RMB(dry_run, &buf[off]);
|
|
|
|
off += _emit_ST(dry_run, &buf[off], ALWAYS);
|
|
|
|
off += _emit_WMB(dry_run, &buf[off]);
|
|
|
|
}
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return off;
|
|
|
|
}
|
|
|
|
|
2018-04-19 08:31:06 +08:00
|
|
|
static u32 _emit_load(unsigned int dry_run, u8 buf[],
|
|
|
|
enum pl330_cond cond, enum dma_transfer_direction direction,
|
|
|
|
u8 peri)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
|
|
|
int off = 0;
|
2016-01-22 19:06:44 +08:00
|
|
|
|
2018-04-19 08:31:06 +08:00
|
|
|
switch (direction) {
|
|
|
|
case DMA_MEM_TO_MEM:
|
|
|
|
/* fall through */
|
|
|
|
case DMA_MEM_TO_DEV:
|
|
|
|
off += _emit_LD(dry_run, &buf[off], cond);
|
|
|
|
break;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
2018-04-19 08:31:06 +08:00
|
|
|
case DMA_DEV_TO_MEM:
|
|
|
|
if (cond == ALWAYS) {
|
|
|
|
off += _emit_LDP(dry_run, &buf[off], SINGLE,
|
|
|
|
peri);
|
|
|
|
off += _emit_LDP(dry_run, &buf[off], BURST,
|
|
|
|
peri);
|
|
|
|
} else {
|
|
|
|
off += _emit_LDP(dry_run, &buf[off], cond,
|
|
|
|
peri);
|
|
|
|
}
|
|
|
|
break;
|
2016-01-22 19:06:46 +08:00
|
|
|
|
2018-04-19 08:31:06 +08:00
|
|
|
default:
|
|
|
|
/* this code should be unreachable */
|
|
|
|
WARN_ON(1);
|
|
|
|
break;
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return off;
|
|
|
|
}
|
|
|
|
|
2018-04-19 08:31:06 +08:00
|
|
|
static inline u32 _emit_store(unsigned int dry_run, u8 buf[],
|
|
|
|
enum pl330_cond cond, enum dma_transfer_direction direction,
|
|
|
|
u8 peri)
|
|
|
|
{
|
|
|
|
int off = 0;
|
|
|
|
|
|
|
|
switch (direction) {
|
|
|
|
case DMA_MEM_TO_MEM:
|
|
|
|
/* fall through */
|
|
|
|
case DMA_DEV_TO_MEM:
|
|
|
|
off += _emit_ST(dry_run, &buf[off], cond);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case DMA_MEM_TO_DEV:
|
|
|
|
if (cond == ALWAYS) {
|
|
|
|
off += _emit_STP(dry_run, &buf[off], SINGLE,
|
|
|
|
peri);
|
|
|
|
off += _emit_STP(dry_run, &buf[off], BURST,
|
|
|
|
peri);
|
|
|
|
} else {
|
|
|
|
off += _emit_STP(dry_run, &buf[off], cond,
|
|
|
|
peri);
|
|
|
|
}
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
/* this code should be unreachable */
|
|
|
|
WARN_ON(1);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return off;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline int _ldst_peripheral(struct pl330_dmac *pl330,
|
2016-01-22 19:06:46 +08:00
|
|
|
unsigned dry_run, u8 buf[],
|
2018-04-19 08:31:06 +08:00
|
|
|
const struct _xfer_spec *pxs, int cyc,
|
|
|
|
enum pl330_cond cond)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
|
|
|
int off = 0;
|
2016-01-22 19:06:44 +08:00
|
|
|
|
2016-01-22 19:06:46 +08:00
|
|
|
if (pl330->quirks & PL330_QUIRK_BROKEN_NO_FLUSHP)
|
|
|
|
cond = BURST;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
2018-04-19 08:31:06 +08:00
|
|
|
/*
|
|
|
|
* do FLUSHP at beginning to clear any stale dma requests before the
|
|
|
|
* first WFP.
|
|
|
|
*/
|
|
|
|
if (!(pl330->quirks & PL330_QUIRK_BROKEN_NO_FLUSHP))
|
|
|
|
off += _emit_FLUSHP(dry_run, &buf[off], pxs->desc->peri);
|
2011-12-26 17:49:52 +08:00
|
|
|
while (cyc--) {
|
2016-01-22 19:06:44 +08:00
|
|
|
off += _emit_WFP(dry_run, &buf[off], cond, pxs->desc->peri);
|
2018-04-19 08:31:06 +08:00
|
|
|
off += _emit_load(dry_run, &buf[off], cond, pxs->desc->rqtype,
|
|
|
|
pxs->desc->peri);
|
|
|
|
off += _emit_store(dry_run, &buf[off], cond, pxs->desc->rqtype,
|
|
|
|
pxs->desc->peri);
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return off;
|
|
|
|
}
|
|
|
|
|
2016-01-22 19:06:46 +08:00
|
|
|
static int _bursts(struct pl330_dmac *pl330, unsigned dry_run, u8 buf[],
|
2011-12-26 17:49:52 +08:00
|
|
|
const struct _xfer_spec *pxs, int cyc)
|
|
|
|
{
|
|
|
|
int off = 0;
|
2018-04-19 08:31:06 +08:00
|
|
|
enum pl330_cond cond = BRST_LEN(pxs->ccr) > 1 ? BURST : SINGLE;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
2014-07-07 02:32:30 +08:00
|
|
|
switch (pxs->desc->rqtype) {
|
2014-07-07 02:32:18 +08:00
|
|
|
case DMA_MEM_TO_DEV:
|
2018-04-19 08:31:06 +08:00
|
|
|
/* fall through */
|
2014-07-07 02:32:18 +08:00
|
|
|
case DMA_DEV_TO_MEM:
|
2018-04-19 08:31:06 +08:00
|
|
|
off += _ldst_peripheral(pl330, dry_run, &buf[off], pxs, cyc,
|
|
|
|
cond);
|
2011-12-26 17:49:52 +08:00
|
|
|
break;
|
2018-04-19 08:31:06 +08:00
|
|
|
|
2014-07-07 02:32:18 +08:00
|
|
|
case DMA_MEM_TO_MEM:
|
2011-12-26 17:49:52 +08:00
|
|
|
off += _ldst_memtomem(dry_run, &buf[off], pxs, cyc);
|
|
|
|
break;
|
2018-04-19 08:31:06 +08:00
|
|
|
|
|
|
|
default:
|
|
|
|
/* this code should be unreachable */
|
|
|
|
WARN_ON(1);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return off;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* transfer dregs with single transfers to peripheral, or a reduced size burst
|
|
|
|
* for mem-to-mem.
|
|
|
|
*/
|
|
|
|
static int _dregs(struct pl330_dmac *pl330, unsigned int dry_run, u8 buf[],
|
|
|
|
const struct _xfer_spec *pxs, int transfer_length)
|
|
|
|
{
|
|
|
|
int off = 0;
|
|
|
|
int dregs_ccr;
|
|
|
|
|
|
|
|
if (transfer_length == 0)
|
|
|
|
return off;
|
|
|
|
|
|
|
|
switch (pxs->desc->rqtype) {
|
|
|
|
case DMA_MEM_TO_DEV:
|
|
|
|
/* fall through */
|
|
|
|
case DMA_DEV_TO_MEM:
|
|
|
|
off += _ldst_peripheral(pl330, dry_run, &buf[off], pxs,
|
|
|
|
transfer_length, SINGLE);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case DMA_MEM_TO_MEM:
|
|
|
|
dregs_ccr = pxs->ccr;
|
|
|
|
dregs_ccr &= ~((0xf << CC_SRCBRSTLEN_SHFT) |
|
|
|
|
(0xf << CC_DSTBRSTLEN_SHFT));
|
|
|
|
dregs_ccr |= (((transfer_length - 1) & 0xf) <<
|
|
|
|
CC_SRCBRSTLEN_SHFT);
|
|
|
|
dregs_ccr |= (((transfer_length - 1) & 0xf) <<
|
|
|
|
CC_DSTBRSTLEN_SHFT);
|
|
|
|
off += _emit_MOV(dry_run, &buf[off], CCR, dregs_ccr);
|
|
|
|
off += _ldst_memtomem(dry_run, &buf[off], pxs, 1);
|
|
|
|
break;
|
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
default:
|
2018-04-19 08:31:06 +08:00
|
|
|
/* this code should be unreachable */
|
|
|
|
WARN_ON(1);
|
2011-12-26 17:49:52 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return off;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Returns bytes consumed and updates bursts */
|
2016-01-22 19:06:46 +08:00
|
|
|
static inline int _loop(struct pl330_dmac *pl330, unsigned dry_run, u8 buf[],
|
2011-12-26 17:49:52 +08:00
|
|
|
unsigned long *bursts, const struct _xfer_spec *pxs)
|
|
|
|
{
|
|
|
|
int cyc, cycmax, szlp, szlpend, szbrst, off;
|
|
|
|
unsigned lcnt0, lcnt1, ljmp0, ljmp1;
|
|
|
|
struct _arg_LPEND lpend;
|
|
|
|
|
2015-07-24 00:04:49 +08:00
|
|
|
if (*bursts == 1)
|
2016-01-22 19:06:44 +08:00
|
|
|
return _bursts(pl330, dry_run, buf, pxs, 1);
|
2015-07-24 00:04:49 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
/* Max iterations possible in DMALP is 256 */
|
|
|
|
if (*bursts >= 256*256) {
|
|
|
|
lcnt1 = 256;
|
|
|
|
lcnt0 = 256;
|
|
|
|
cyc = *bursts / lcnt1 / lcnt0;
|
|
|
|
} else if (*bursts > 256) {
|
|
|
|
lcnt1 = 256;
|
|
|
|
lcnt0 = *bursts / lcnt1;
|
|
|
|
cyc = 1;
|
|
|
|
} else {
|
|
|
|
lcnt1 = *bursts;
|
|
|
|
lcnt0 = 0;
|
|
|
|
cyc = 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
szlp = _emit_LP(1, buf, 0, 0);
|
2016-01-22 19:06:46 +08:00
|
|
|
szbrst = _bursts(pl330, 1, buf, pxs, 1);
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
lpend.cond = ALWAYS;
|
|
|
|
lpend.forever = false;
|
|
|
|
lpend.loop = 0;
|
|
|
|
lpend.bjump = 0;
|
|
|
|
szlpend = _emit_LPEND(1, buf, &lpend);
|
|
|
|
|
|
|
|
if (lcnt0) {
|
|
|
|
szlp *= 2;
|
|
|
|
szlpend *= 2;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Max bursts that we can unroll due to limit on the
|
|
|
|
* size of backward jump that can be encoded in DMALPEND
|
|
|
|
* which is 8-bits and hence 255
|
|
|
|
*/
|
|
|
|
cycmax = (255 - (szlp + szlpend)) / szbrst;
|
|
|
|
|
|
|
|
cyc = (cycmax < cyc) ? cycmax : cyc;
|
|
|
|
|
|
|
|
off = 0;
|
|
|
|
|
|
|
|
if (lcnt0) {
|
|
|
|
off += _emit_LP(dry_run, &buf[off], 0, lcnt0);
|
|
|
|
ljmp0 = off;
|
|
|
|
}
|
|
|
|
|
|
|
|
off += _emit_LP(dry_run, &buf[off], 1, lcnt1);
|
|
|
|
ljmp1 = off;
|
|
|
|
|
2016-01-22 19:06:46 +08:00
|
|
|
off += _bursts(pl330, dry_run, &buf[off], pxs, cyc);
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
lpend.cond = ALWAYS;
|
|
|
|
lpend.forever = false;
|
|
|
|
lpend.loop = 1;
|
|
|
|
lpend.bjump = off - ljmp1;
|
|
|
|
off += _emit_LPEND(dry_run, &buf[off], &lpend);
|
|
|
|
|
|
|
|
if (lcnt0) {
|
|
|
|
lpend.cond = ALWAYS;
|
|
|
|
lpend.forever = false;
|
|
|
|
lpend.loop = 0;
|
|
|
|
lpend.bjump = off - ljmp0;
|
|
|
|
off += _emit_LPEND(dry_run, &buf[off], &lpend);
|
|
|
|
}
|
|
|
|
|
|
|
|
*bursts = lcnt1 * cyc;
|
|
|
|
if (lcnt0)
|
|
|
|
*bursts *= lcnt0;
|
|
|
|
|
|
|
|
return off;
|
|
|
|
}
|
|
|
|
|
2016-01-22 19:06:46 +08:00
|
|
|
static inline int _setup_loops(struct pl330_dmac *pl330,
|
|
|
|
unsigned dry_run, u8 buf[],
|
|
|
|
const struct _xfer_spec *pxs)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
2014-07-07 02:32:30 +08:00
|
|
|
struct pl330_xfer *x = &pxs->desc->px;
|
2011-12-26 17:49:52 +08:00
|
|
|
u32 ccr = pxs->ccr;
|
|
|
|
unsigned long c, bursts = BYTE_TO_BURST(x->bytes, ccr);
|
2018-04-19 08:31:06 +08:00
|
|
|
int num_dregs = (x->bytes - BURST_TO_BYTE(bursts, ccr)) /
|
|
|
|
BRST_SIZE(ccr);
|
2011-12-26 17:49:52 +08:00
|
|
|
int off = 0;
|
|
|
|
|
|
|
|
while (bursts) {
|
|
|
|
c = bursts;
|
2016-01-22 19:06:46 +08:00
|
|
|
off += _loop(pl330, dry_run, &buf[off], &c, pxs);
|
2011-12-26 17:49:52 +08:00
|
|
|
bursts -= c;
|
|
|
|
}
|
2018-04-19 08:31:06 +08:00
|
|
|
off += _dregs(pl330, dry_run, &buf[off], pxs, num_dregs);
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
return off;
|
|
|
|
}
|
|
|
|
|
2016-01-22 19:06:46 +08:00
|
|
|
static inline int _setup_xfer(struct pl330_dmac *pl330,
|
|
|
|
unsigned dry_run, u8 buf[],
|
|
|
|
const struct _xfer_spec *pxs)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
2014-07-07 02:32:30 +08:00
|
|
|
struct pl330_xfer *x = &pxs->desc->px;
|
2011-12-26 17:49:52 +08:00
|
|
|
int off = 0;
|
|
|
|
|
|
|
|
/* DMAMOV SAR, x->src_addr */
|
|
|
|
off += _emit_MOV(dry_run, &buf[off], SAR, x->src_addr);
|
|
|
|
/* DMAMOV DAR, x->dst_addr */
|
|
|
|
off += _emit_MOV(dry_run, &buf[off], DAR, x->dst_addr);
|
|
|
|
|
|
|
|
/* Setup Loop(s) */
|
2016-01-22 19:06:46 +08:00
|
|
|
off += _setup_loops(pl330, dry_run, &buf[off], pxs);
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
return off;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* A req is a sequence of one or more xfer units.
|
|
|
|
* Returns the number of bytes taken to setup the MC for the req.
|
|
|
|
*/
|
2016-01-22 19:06:46 +08:00
|
|
|
static int _setup_req(struct pl330_dmac *pl330, unsigned dry_run,
|
|
|
|
struct pl330_thread *thrd, unsigned index,
|
|
|
|
struct _xfer_spec *pxs)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
|
|
|
struct _pl330_req *req = &thrd->req[index];
|
|
|
|
u8 *buf = req->mc_cpu;
|
|
|
|
int off = 0;
|
|
|
|
|
|
|
|
PL330_DBGMC_START(req->mc_bus);
|
|
|
|
|
|
|
|
/* DMAMOV CCR, ccr */
|
|
|
|
off += _emit_MOV(dry_run, &buf[off], CCR, pxs->ccr);
|
|
|
|
|
2016-01-22 19:06:46 +08:00
|
|
|
off += _setup_xfer(pl330, dry_run, &buf[off], pxs);
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
/* DMASEV peripheral/event */
|
|
|
|
off += _emit_SEV(dry_run, &buf[off], thrd->ev);
|
|
|
|
/* DMAEND */
|
|
|
|
off += _emit_END(dry_run, &buf[off]);
|
|
|
|
|
|
|
|
return off;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline u32 _prepare_ccr(const struct pl330_reqcfg *rqc)
|
|
|
|
{
|
|
|
|
u32 ccr = 0;
|
|
|
|
|
|
|
|
if (rqc->src_inc)
|
|
|
|
ccr |= CC_SRCINC;
|
|
|
|
|
|
|
|
if (rqc->dst_inc)
|
|
|
|
ccr |= CC_DSTINC;
|
|
|
|
|
|
|
|
/* We set same protection levels for Src and DST for now */
|
|
|
|
if (rqc->privileged)
|
|
|
|
ccr |= CC_SRCPRI | CC_DSTPRI;
|
|
|
|
if (rqc->nonsecure)
|
|
|
|
ccr |= CC_SRCNS | CC_DSTNS;
|
|
|
|
if (rqc->insnaccess)
|
|
|
|
ccr |= CC_SRCIA | CC_DSTIA;
|
|
|
|
|
|
|
|
ccr |= (((rqc->brst_len - 1) & 0xf) << CC_SRCBRSTLEN_SHFT);
|
|
|
|
ccr |= (((rqc->brst_len - 1) & 0xf) << CC_DSTBRSTLEN_SHFT);
|
|
|
|
|
|
|
|
ccr |= (rqc->brst_size << CC_SRCBRSTSIZE_SHFT);
|
|
|
|
ccr |= (rqc->brst_size << CC_DSTBRSTSIZE_SHFT);
|
|
|
|
|
|
|
|
ccr |= (rqc->scctl << CC_SRCCCTRL_SHFT);
|
|
|
|
ccr |= (rqc->dcctl << CC_DSTCCTRL_SHFT);
|
|
|
|
|
|
|
|
ccr |= (rqc->swap << CC_SWAP_SHFT);
|
|
|
|
|
|
|
|
return ccr;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Submit a list of xfers after which the client wants notification.
|
|
|
|
* Client is not notified after each xfer unit, just once after all
|
|
|
|
* xfer units are done or some error occurs.
|
|
|
|
*/
|
2014-07-07 02:32:30 +08:00
|
|
|
static int pl330_submit_req(struct pl330_thread *thrd,
|
|
|
|
struct dma_pl330_desc *desc)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
struct pl330_dmac *pl330 = thrd->dmac;
|
2011-12-26 17:49:52 +08:00
|
|
|
struct _xfer_spec xs;
|
|
|
|
unsigned long flags;
|
|
|
|
unsigned idx;
|
|
|
|
u32 ccr;
|
|
|
|
int ret = 0;
|
|
|
|
|
2018-04-19 08:31:06 +08:00
|
|
|
switch (desc->rqtype) {
|
|
|
|
case DMA_MEM_TO_DEV:
|
|
|
|
break;
|
|
|
|
|
|
|
|
case DMA_DEV_TO_MEM:
|
|
|
|
break;
|
|
|
|
|
|
|
|
case DMA_MEM_TO_MEM:
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
return -ENOTSUPP;
|
|
|
|
}
|
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
if (pl330->state == DYING
|
|
|
|
|| pl330->dmac_tbd.reset_chan & (1 << thrd->id)) {
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_info(thrd->dmac->ddma.dev, "%s:%d\n",
|
2011-12-26 17:49:52 +08:00
|
|
|
__func__, __LINE__);
|
|
|
|
return -EAGAIN;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* If request for non-existing peripheral */
|
2014-07-07 02:32:30 +08:00
|
|
|
if (desc->rqtype != DMA_MEM_TO_MEM &&
|
|
|
|
desc->peri >= pl330->pcfg.num_peri) {
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_info(thrd->dmac->ddma.dev,
|
2011-12-26 17:49:52 +08:00
|
|
|
"%s:%d Invalid peripheral(%u)!\n",
|
2014-07-07 02:32:30 +08:00
|
|
|
__func__, __LINE__, desc->peri);
|
2011-12-26 17:49:52 +08:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
|
|
|
|
|
|
|
spin_lock_irqsave(&pl330->lock, flags);
|
|
|
|
|
|
|
|
if (_queue_full(thrd)) {
|
|
|
|
ret = -EAGAIN;
|
|
|
|
goto xfer_exit;
|
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:30 +08:00
|
|
|
/* Prefer Secure Channel */
|
|
|
|
if (!_manager_ns(thrd))
|
|
|
|
desc->rqcfg.nonsecure = 0;
|
|
|
|
else
|
|
|
|
desc->rqcfg.nonsecure = 1;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
2014-07-07 02:32:30 +08:00
|
|
|
ccr = _prepare_ccr(&desc->rqcfg);
|
2011-12-26 17:49:52 +08:00
|
|
|
|
2014-07-07 02:32:31 +08:00
|
|
|
idx = thrd->req[0].desc == NULL ? 0 : 1;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
xs.ccr = ccr;
|
2014-07-07 02:32:30 +08:00
|
|
|
xs.desc = desc;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
/* First dry run to check if req is acceptable */
|
2016-01-22 19:06:46 +08:00
|
|
|
ret = _setup_req(pl330, 1, thrd, idx, &xs);
|
2011-12-26 17:49:52 +08:00
|
|
|
if (ret < 0)
|
|
|
|
goto xfer_exit;
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
if (ret > pl330->mcbufsz / 2) {
|
2015-06-04 05:26:41 +08:00
|
|
|
dev_info(pl330->ddma.dev, "%s:%d Try increasing mcbufsz (%i/%i)\n",
|
|
|
|
__func__, __LINE__, ret, pl330->mcbufsz / 2);
|
2011-12-26 17:49:52 +08:00
|
|
|
ret = -ENOMEM;
|
|
|
|
goto xfer_exit;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Hook the request */
|
|
|
|
thrd->lstenq = idx;
|
2014-07-07 02:32:30 +08:00
|
|
|
thrd->req[idx].desc = desc;
|
2016-01-22 19:06:46 +08:00
|
|
|
_setup_req(pl330, 0, thrd, idx, &xs);
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
ret = 0;
|
|
|
|
|
|
|
|
xfer_exit:
|
|
|
|
spin_unlock_irqrestore(&pl330->lock, flags);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:30 +08:00
|
|
|
static void dma_pl330_rqcb(struct dma_pl330_desc *desc, enum pl330_op_err err)
|
2014-07-07 02:32:25 +08:00
|
|
|
{
|
2014-07-19 09:21:47 +08:00
|
|
|
struct dma_pl330_chan *pch;
|
2014-07-07 02:32:25 +08:00
|
|
|
unsigned long flags;
|
|
|
|
|
2014-07-19 09:21:47 +08:00
|
|
|
if (!desc)
|
|
|
|
return;
|
|
|
|
|
|
|
|
pch = desc->pchan;
|
|
|
|
|
2014-07-07 02:32:25 +08:00
|
|
|
/* If desc aborted */
|
|
|
|
if (!pch)
|
|
|
|
return;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&pch->lock, flags);
|
|
|
|
|
|
|
|
desc->status = DONE;
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&pch->lock, flags);
|
|
|
|
|
|
|
|
tasklet_schedule(&pch->task);
|
|
|
|
}
|
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
static void pl330_dotask(unsigned long data)
|
|
|
|
{
|
|
|
|
struct pl330_dmac *pl330 = (struct pl330_dmac *) data;
|
|
|
|
unsigned long flags;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&pl330->lock, flags);
|
|
|
|
|
|
|
|
/* The DMAC itself gone nuts */
|
|
|
|
if (pl330->dmac_tbd.reset_dmac) {
|
|
|
|
pl330->state = DYING;
|
|
|
|
/* Reset the manager too */
|
|
|
|
pl330->dmac_tbd.reset_mngr = true;
|
|
|
|
/* Clear the reset flag */
|
|
|
|
pl330->dmac_tbd.reset_dmac = false;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (pl330->dmac_tbd.reset_mngr) {
|
|
|
|
_stop(pl330->manager);
|
|
|
|
/* Reset all channels */
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330->dmac_tbd.reset_chan = (1 << pl330->pcfg.num_chan) - 1;
|
2011-12-26 17:49:52 +08:00
|
|
|
/* Clear the reset flag */
|
|
|
|
pl330->dmac_tbd.reset_mngr = false;
|
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
for (i = 0; i < pl330->pcfg.num_chan; i++) {
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
if (pl330->dmac_tbd.reset_chan & (1 << i)) {
|
|
|
|
struct pl330_thread *thrd = &pl330->channels[i];
|
2014-07-07 02:32:29 +08:00
|
|
|
void __iomem *regs = pl330->base;
|
2011-12-26 17:49:52 +08:00
|
|
|
enum pl330_op_err err;
|
|
|
|
|
|
|
|
_stop(thrd);
|
|
|
|
|
|
|
|
if (readl(regs + FSC) & (1 << thrd->id))
|
|
|
|
err = PL330_ERR_FAIL;
|
|
|
|
else
|
|
|
|
err = PL330_ERR_ABORT;
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&pl330->lock, flags);
|
2014-07-07 02:32:30 +08:00
|
|
|
dma_pl330_rqcb(thrd->req[1 - thrd->lstenq].desc, err);
|
|
|
|
dma_pl330_rqcb(thrd->req[thrd->lstenq].desc, err);
|
2011-12-26 17:49:52 +08:00
|
|
|
spin_lock_irqsave(&pl330->lock, flags);
|
|
|
|
|
2014-07-07 02:32:30 +08:00
|
|
|
thrd->req[0].desc = NULL;
|
|
|
|
thrd->req[1].desc = NULL;
|
2014-07-07 02:32:31 +08:00
|
|
|
thrd->req_running = -1;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
/* Clear the reset flag */
|
|
|
|
pl330->dmac_tbd.reset_chan &= ~(1 << i);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&pl330->lock, flags);
|
|
|
|
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Returns 1 if state was updated, 0 otherwise */
|
2014-07-07 02:32:29 +08:00
|
|
|
static int pl330_update(struct pl330_dmac *pl330)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
dmaengine: pl330: fix a race condition in case of threaded irqs
When booting up with "threadirqs" in command line, all irq handlers of the DMA
controller pl330 will be threaded forcedly. These threads will race for the same
list, pl330->req_done.
Before the callback, the spinlock was released. And after it, the spinlock was
taken. This opened an race window where another threaded irq handler could steal
the spinlock and be permitted to delete entries of the list, pl330->req_done.
If the later deleted an entry that was still referred to by the former, there would
be a kernel panic when the former was scheduled and tried to get the next sibling
of the deleted entry.
The scenario could be depicted as below:
Thread: T1 pl330->req_done Thread: T2
| | |
| -A-B-C-D- |
Locked | |
| | Waiting
Del A | |
| -B-C-D- |
Unlocked | |
| | Locked
Waiting | |
| | Del B
| | |
| -C-D- Unlocked
Waiting | |
|
Locked
|
get C via B
\
- Kernel panic
The kernel panic looked like as below:
Unable to handle kernel paging request at virtual address dead000000000108
pgd = ffffff8008c9e000
[dead000000000108] *pgd=000000027fffe003, *pud=000000027fffe003, *pmd=0000000000000000
Internal error: Oops: 96000044 [#1] PREEMPT SMP
Modules linked in:
CPU: 0 PID: 85 Comm: irq/59-66330000 Not tainted 4.8.24-WR9.0.0.12_standard #2
Hardware name: Broadcom NS2 SVK (DT)
task: ffffffc1f5cc3c00 task.stack: ffffffc1f5ce0000
PC is at pl330_irq_handler+0x27c/0x390
LR is at pl330_irq_handler+0x2a8/0x390
pc : [<ffffff80084cb694>] lr : [<ffffff80084cb6c0>] pstate: 800001c5
sp : ffffffc1f5ce3d00
x29: ffffffc1f5ce3d00 x28: 0000000000000140
x27: ffffffc1f5c530b0 x26: dead000000000100
x25: dead000000000200 x24: 0000000000418958
x23: 0000000000000001 x22: ffffffc1f5ccd668
x21: ffffffc1f5ccd590 x20: ffffffc1f5ccd418
x19: dead000000000060 x18: 0000000000000001
x17: 0000000000000007 x16: 0000000000000001
x15: ffffffffffffffff x14: ffffffffffffffff
x13: ffffffffffffffff x12: 0000000000000000
x11: 0000000000000001 x10: 0000000000000840
x9 : ffffffc1f5ce0000 x8 : ffffffc1f5cc3338
x7 : ffffff8008ce2020 x6 : 0000000000000000
x5 : 0000000000000000 x4 : 0000000000000001
x3 : dead000000000200 x2 : dead000000000100
x1 : 0000000000000140 x0 : ffffffc1f5ccd590
Process irq/59-66330000 (pid: 85, stack limit = 0xffffffc1f5ce0020)
Stack: (0xffffffc1f5ce3d00 to 0xffffffc1f5ce4000)
3d00: ffffffc1f5ce3d80 ffffff80080f09d0 ffffffc1f5ca0c00 ffffffc1f6f7c600
3d20: ffffffc1f5ce0000 ffffffc1f6f7c600 ffffffc1f5ca0c00 ffffff80080f0998
3d40: ffffffc1f5ce0000 ffffff80080f0000 0000000000000000 0000000000000000
3d60: ffffff8008ce202c ffffff8008ce2020 ffffffc1f5ccd668 ffffffc1f5c530b0
3d80: ffffffc1f5ce3db0 ffffff80080f0d70 ffffffc1f5ca0c40 0000000000000001
3da0: ffffffc1f5ce0000 ffffff80080f0cfc ffffffc1f5ce3e20 ffffff80080bf4f8
3dc0: ffffffc1f5ca0c80 ffffff8008bf3798 ffffff8008955528 ffffffc1f5ca0c00
3de0: ffffff80080f0c30 0000000000000000 0000000000000000 0000000000000000
3e00: 0000000000000000 0000000000000000 0000000000000000 ffffff80080f0b68
3e20: 0000000000000000 ffffff8008083690 ffffff80080bf420 ffffffc1f5ca0c80
3e40: 0000000000000000 0000000000000000 0000000000000000 ffffff80080cb648
3e60: ffffff8008b1c780 0000000000000000 0000000000000000 ffffffc1f5ca0c00
3e80: ffffffc100000000 ffffff8000000000 ffffffc1f5ce3e90 ffffffc1f5ce3e90
3ea0: 0000000000000000 ffffff8000000000 ffffffc1f5ce3eb0 ffffffc1f5ce3eb0
3ec0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3ee0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3f00: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3f20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3f40: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3f60: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3f80: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3fa0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3fc0: 0000000000000000 0000000000000005 0000000000000000 0000000000000000
3fe0: 0000000000000000 0000000000000000 0000000275ce3ff0 0000000275ce3ff8
Call trace:
Exception stack(0xffffffc1f5ce3b30 to 0xffffffc1f5ce3c60)
3b20: dead000000000060 0000008000000000
3b40: ffffffc1f5ce3d00 ffffff80084cb694 0000000000000008 0000000000000e88
3b60: ffffffc1f5ce3bb0 ffffff80080dac68 ffffffc1f5ce3b90 ffffff8008826fe4
3b80: 00000000000001c0 00000000000001c0 ffffffc1f5ce3bb0 ffffff800848dfcc
3ba0: 0000000000020000 ffffff8008b15ae4 ffffffc1f5ce3c00 ffffff800808f000
3bc0: 0000000000000010 ffffff80088377f0 ffffffc1f5ccd590 0000000000000140
3be0: dead000000000100 dead000000000200 0000000000000001 0000000000000000
3c00: 0000000000000000 ffffff8008ce2020 ffffffc1f5cc3338 ffffffc1f5ce0000
3c20: 0000000000000840 0000000000000001 0000000000000000 ffffffffffffffff
3c40: ffffffffffffffff ffffffffffffffff 0000000000000001 0000000000000007
[<ffffff80084cb694>] pl330_irq_handler+0x27c/0x390
[<ffffff80080f09d0>] irq_forced_thread_fn+0x38/0x88
[<ffffff80080f0d70>] irq_thread+0x140/0x200
[<ffffff80080bf4f8>] kthread+0xd8/0xf0
[<ffffff8008083690>] ret_from_fork+0x10/0x40
Code: f2a00838 f9405763 aa1c03e1 aa1503e0 (f9000443)
---[ end trace f50005726d31199c ]---
Kernel panic - not syncing: Fatal exception in interrupt
SMP: stopping secondary CPUs
SMP: failed to stop secondary CPUs 0-1
Kernel Offset: disabled
Memory Limit: none
---[ end Kernel panic - not syncing: Fatal exception in interrupt
To fix this, re-start with the list-head after dropping the lock then
re-takeing it.
Reviewed-by: Frank Mori Hess <fmh6jj@gmail.com>
Tested-by: Frank Mori Hess <fmh6jj@gmail.com>
Signed-off-by: Qi Hou <qi.hou@windriver.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2018-03-06 09:13:37 +08:00
|
|
|
struct dma_pl330_desc *descdone;
|
2011-12-26 17:49:52 +08:00
|
|
|
unsigned long flags;
|
|
|
|
void __iomem *regs;
|
|
|
|
u32 val;
|
|
|
|
int id, ev, ret = 0;
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
regs = pl330->base;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
spin_lock_irqsave(&pl330->lock, flags);
|
|
|
|
|
|
|
|
val = readl(regs + FSM) & 0x1;
|
|
|
|
if (val)
|
|
|
|
pl330->dmac_tbd.reset_mngr = true;
|
|
|
|
else
|
|
|
|
pl330->dmac_tbd.reset_mngr = false;
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
val = readl(regs + FSC) & ((1 << pl330->pcfg.num_chan) - 1);
|
2011-12-26 17:49:52 +08:00
|
|
|
pl330->dmac_tbd.reset_chan |= val;
|
|
|
|
if (val) {
|
|
|
|
int i = 0;
|
2014-07-07 02:32:29 +08:00
|
|
|
while (i < pl330->pcfg.num_chan) {
|
2011-12-26 17:49:52 +08:00
|
|
|
if (val & (1 << i)) {
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_info(pl330->ddma.dev,
|
2011-12-26 17:49:52 +08:00
|
|
|
"Reset Channel-%d\t CS-%x FTC-%x\n",
|
|
|
|
i, readl(regs + CS(i)),
|
|
|
|
readl(regs + FTC(i)));
|
|
|
|
_stop(&pl330->channels[i]);
|
|
|
|
}
|
|
|
|
i++;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Check which event happened i.e, thread notified */
|
|
|
|
val = readl(regs + ES);
|
2014-07-07 02:32:29 +08:00
|
|
|
if (pl330->pcfg.num_events < 32
|
|
|
|
&& val & ~((1 << pl330->pcfg.num_events) - 1)) {
|
2011-12-26 17:49:52 +08:00
|
|
|
pl330->dmac_tbd.reset_dmac = true;
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_err(pl330->ddma.dev, "%s:%d Unexpected!\n", __func__,
|
|
|
|
__LINE__);
|
2011-12-26 17:49:52 +08:00
|
|
|
ret = 1;
|
|
|
|
goto updt_exit;
|
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
for (ev = 0; ev < pl330->pcfg.num_events; ev++) {
|
2011-12-26 17:49:52 +08:00
|
|
|
if (val & (1 << ev)) { /* Event occurred */
|
|
|
|
struct pl330_thread *thrd;
|
|
|
|
u32 inten = readl(regs + INTEN);
|
|
|
|
int active;
|
|
|
|
|
|
|
|
/* Clear the event */
|
|
|
|
if (inten & (1 << ev))
|
|
|
|
writel(1 << ev, regs + INTCLR);
|
|
|
|
|
|
|
|
ret = 1;
|
|
|
|
|
|
|
|
id = pl330->events[ev];
|
|
|
|
|
|
|
|
thrd = &pl330->channels[id];
|
|
|
|
|
|
|
|
active = thrd->req_running;
|
|
|
|
if (active == -1) /* Aborted */
|
|
|
|
continue;
|
|
|
|
|
2012-06-13 22:07:00 +08:00
|
|
|
/* Detach the req */
|
2014-07-07 02:32:30 +08:00
|
|
|
descdone = thrd->req[active].desc;
|
|
|
|
thrd->req[active].desc = NULL;
|
2012-06-13 22:07:00 +08:00
|
|
|
|
dmaengine: pl330: fix bug that cause start the same descs in cyclic
This bug will cause NULL pointer after commit dfac17, and cause
wrong package in I2S DMA transfer before commit dfac17.
Tested on RK3288-pinky2 board.
Detail:
I2S DMA transfer(sound/core/pcm_dmaengine.c):
dmaengine_pcm_prepare_and_submit -->
dmaengine_prep_dma_cyclic -->
pl330_prep_dma_cyclic -->
the case:
1. pl330_submit_req(desc0): thrd->req[0].desc = desc0, thrd->lstenq = 0
2. pl330_submit_req(desc1): thrd->req[1].desc = desc1, thrd->lstenq = 1
3. _start(desc0) by submit_req: thrd->req_running = 0
because: idx = 1 - thrd->lstenq = 0
4. pl330_update(desc0 OK): thrd->req[0].desc = NULL, desc0 to req_done list
because: idx = active = thrd->req_running = 0
5. _start(desc1) by pl330_update: thrd->req_running = 1
because:
idx = 1 - thrd->lstenq = 0, but thrd->req[0].desc == NULL,
so:
idx = thrd->lstenq = 1
6. pl330_submit_req(desc2): thrd->req[0].desc = desc2, thrd->lstenq = 0
7. _start(desc1) by submit_req: thrd->req_running = 1
because: idx = 1 - thrd->lstenq = 1
Note: _start started the same descs
_start should start desc2 here, NOT desc1
8. pl330_update(desc1 OK): thrd->req[1].desc = NULL, desc1 to req_done list
because: idx = active = thrd->req_running = 1
9. _start(desc2) by pl330_update : thrd->req_running = 0
because: idx = 1 - thrd->lstenq = 0
10.pl330_update(desc1 OK, NOT desc2): thrd->req[0].desc = NULL,
desc2 to req_done list
because: idx = active = thrd->req_running = 0
11.pl330_submit_req(desc3): thrd->req[0].desc = desc3, thrd->lstenq = 0
12.pl330_submit_req(desc4): thrd->req[1].desc = desc4, thrd->lstenq = 1
13._start(desc3) by submit_req: thrd->req_running = 0
because: idx = 1 - thrd->lstenq = 0
14.pl330_update(desc2 OK NOT desc3): thrd->req[0].desc = NULL
desc3 to req_done list
because: idx = active = thrd->req_running = 0
15._start(desc4) by pl330_update: thrd->req_running = 1
because:
idx = 1 - thrd->lstenq = 0, but thrd->req[0].desc == NULL,
so:
idx = thrd->lstenq = 1
16.pl330_submit_req(desc5): thrd->req[0].desc = desc5, thrd->lstenq = 0
17._start(desc4) by submit_req: thrd->req_running = 1
because: idx = 1 - thrd->lstenq = 1
18.pl330_update(desc3 OK NOT desc4): thrd->req[1].desc = NULL
desc4 to req_done list
because: idx = active = thrd->req_running = 1
19._start(desc4) by pl330_update: thrd->req_running = 0
because:
idx = 1 - thrd->lstenq = 1, but thrd->req[1].desc == NULL,
so:
idx = thrd->lstenq = 0
20.pl330_update(desc4 OK): thrd->req[0].desc = NULL, desc5 to req_done list
because: idx = active = thrd->req_running = 0
21.pl330_update(desc4 OK):
1) before commit dfac17(set req_running -1 in pl330_update/mark_free()):
because: active = -1, abort
result: desc0-desc5's callback are all called,
but step 10 and step 18 go wrong.
2) before commit dfac17:
idx = active = thrd->req_runnig = 0 -->
descdone = thrd->req[0] = NULL -->
list_add_tail(&descdone->rqd, &pl330->req_done); -->
got NULL pointer!!!
Signed-off-by: Addy Ke <addy.ke@rock-chips.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2014-12-08 19:28:20 +08:00
|
|
|
thrd->req_running = -1;
|
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
/* Get going again ASAP */
|
|
|
|
_start(thrd);
|
|
|
|
|
|
|
|
/* For now, just make a list of callbacks to be done */
|
2014-07-07 02:32:30 +08:00
|
|
|
list_add_tail(&descdone->rqd, &pl330->req_done);
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Now that we are in no hurry, do the callbacks */
|
dmaengine: pl330: fix a race condition in case of threaded irqs
When booting up with "threadirqs" in command line, all irq handlers of the DMA
controller pl330 will be threaded forcedly. These threads will race for the same
list, pl330->req_done.
Before the callback, the spinlock was released. And after it, the spinlock was
taken. This opened an race window where another threaded irq handler could steal
the spinlock and be permitted to delete entries of the list, pl330->req_done.
If the later deleted an entry that was still referred to by the former, there would
be a kernel panic when the former was scheduled and tried to get the next sibling
of the deleted entry.
The scenario could be depicted as below:
Thread: T1 pl330->req_done Thread: T2
| | |
| -A-B-C-D- |
Locked | |
| | Waiting
Del A | |
| -B-C-D- |
Unlocked | |
| | Locked
Waiting | |
| | Del B
| | |
| -C-D- Unlocked
Waiting | |
|
Locked
|
get C via B
\
- Kernel panic
The kernel panic looked like as below:
Unable to handle kernel paging request at virtual address dead000000000108
pgd = ffffff8008c9e000
[dead000000000108] *pgd=000000027fffe003, *pud=000000027fffe003, *pmd=0000000000000000
Internal error: Oops: 96000044 [#1] PREEMPT SMP
Modules linked in:
CPU: 0 PID: 85 Comm: irq/59-66330000 Not tainted 4.8.24-WR9.0.0.12_standard #2
Hardware name: Broadcom NS2 SVK (DT)
task: ffffffc1f5cc3c00 task.stack: ffffffc1f5ce0000
PC is at pl330_irq_handler+0x27c/0x390
LR is at pl330_irq_handler+0x2a8/0x390
pc : [<ffffff80084cb694>] lr : [<ffffff80084cb6c0>] pstate: 800001c5
sp : ffffffc1f5ce3d00
x29: ffffffc1f5ce3d00 x28: 0000000000000140
x27: ffffffc1f5c530b0 x26: dead000000000100
x25: dead000000000200 x24: 0000000000418958
x23: 0000000000000001 x22: ffffffc1f5ccd668
x21: ffffffc1f5ccd590 x20: ffffffc1f5ccd418
x19: dead000000000060 x18: 0000000000000001
x17: 0000000000000007 x16: 0000000000000001
x15: ffffffffffffffff x14: ffffffffffffffff
x13: ffffffffffffffff x12: 0000000000000000
x11: 0000000000000001 x10: 0000000000000840
x9 : ffffffc1f5ce0000 x8 : ffffffc1f5cc3338
x7 : ffffff8008ce2020 x6 : 0000000000000000
x5 : 0000000000000000 x4 : 0000000000000001
x3 : dead000000000200 x2 : dead000000000100
x1 : 0000000000000140 x0 : ffffffc1f5ccd590
Process irq/59-66330000 (pid: 85, stack limit = 0xffffffc1f5ce0020)
Stack: (0xffffffc1f5ce3d00 to 0xffffffc1f5ce4000)
3d00: ffffffc1f5ce3d80 ffffff80080f09d0 ffffffc1f5ca0c00 ffffffc1f6f7c600
3d20: ffffffc1f5ce0000 ffffffc1f6f7c600 ffffffc1f5ca0c00 ffffff80080f0998
3d40: ffffffc1f5ce0000 ffffff80080f0000 0000000000000000 0000000000000000
3d60: ffffff8008ce202c ffffff8008ce2020 ffffffc1f5ccd668 ffffffc1f5c530b0
3d80: ffffffc1f5ce3db0 ffffff80080f0d70 ffffffc1f5ca0c40 0000000000000001
3da0: ffffffc1f5ce0000 ffffff80080f0cfc ffffffc1f5ce3e20 ffffff80080bf4f8
3dc0: ffffffc1f5ca0c80 ffffff8008bf3798 ffffff8008955528 ffffffc1f5ca0c00
3de0: ffffff80080f0c30 0000000000000000 0000000000000000 0000000000000000
3e00: 0000000000000000 0000000000000000 0000000000000000 ffffff80080f0b68
3e20: 0000000000000000 ffffff8008083690 ffffff80080bf420 ffffffc1f5ca0c80
3e40: 0000000000000000 0000000000000000 0000000000000000 ffffff80080cb648
3e60: ffffff8008b1c780 0000000000000000 0000000000000000 ffffffc1f5ca0c00
3e80: ffffffc100000000 ffffff8000000000 ffffffc1f5ce3e90 ffffffc1f5ce3e90
3ea0: 0000000000000000 ffffff8000000000 ffffffc1f5ce3eb0 ffffffc1f5ce3eb0
3ec0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3ee0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3f00: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3f20: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3f40: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3f60: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3f80: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3fa0: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
3fc0: 0000000000000000 0000000000000005 0000000000000000 0000000000000000
3fe0: 0000000000000000 0000000000000000 0000000275ce3ff0 0000000275ce3ff8
Call trace:
Exception stack(0xffffffc1f5ce3b30 to 0xffffffc1f5ce3c60)
3b20: dead000000000060 0000008000000000
3b40: ffffffc1f5ce3d00 ffffff80084cb694 0000000000000008 0000000000000e88
3b60: ffffffc1f5ce3bb0 ffffff80080dac68 ffffffc1f5ce3b90 ffffff8008826fe4
3b80: 00000000000001c0 00000000000001c0 ffffffc1f5ce3bb0 ffffff800848dfcc
3ba0: 0000000000020000 ffffff8008b15ae4 ffffffc1f5ce3c00 ffffff800808f000
3bc0: 0000000000000010 ffffff80088377f0 ffffffc1f5ccd590 0000000000000140
3be0: dead000000000100 dead000000000200 0000000000000001 0000000000000000
3c00: 0000000000000000 ffffff8008ce2020 ffffffc1f5cc3338 ffffffc1f5ce0000
3c20: 0000000000000840 0000000000000001 0000000000000000 ffffffffffffffff
3c40: ffffffffffffffff ffffffffffffffff 0000000000000001 0000000000000007
[<ffffff80084cb694>] pl330_irq_handler+0x27c/0x390
[<ffffff80080f09d0>] irq_forced_thread_fn+0x38/0x88
[<ffffff80080f0d70>] irq_thread+0x140/0x200
[<ffffff80080bf4f8>] kthread+0xd8/0xf0
[<ffffff8008083690>] ret_from_fork+0x10/0x40
Code: f2a00838 f9405763 aa1c03e1 aa1503e0 (f9000443)
---[ end trace f50005726d31199c ]---
Kernel panic - not syncing: Fatal exception in interrupt
SMP: stopping secondary CPUs
SMP: failed to stop secondary CPUs 0-1
Kernel Offset: disabled
Memory Limit: none
---[ end Kernel panic - not syncing: Fatal exception in interrupt
To fix this, re-start with the list-head after dropping the lock then
re-takeing it.
Reviewed-by: Frank Mori Hess <fmh6jj@gmail.com>
Tested-by: Frank Mori Hess <fmh6jj@gmail.com>
Signed-off-by: Qi Hou <qi.hou@windriver.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2018-03-06 09:13:37 +08:00
|
|
|
while (!list_empty(&pl330->req_done)) {
|
|
|
|
descdone = list_first_entry(&pl330->req_done,
|
|
|
|
struct dma_pl330_desc, rqd);
|
2014-07-07 02:32:30 +08:00
|
|
|
list_del(&descdone->rqd);
|
2011-12-26 17:49:52 +08:00
|
|
|
spin_unlock_irqrestore(&pl330->lock, flags);
|
2014-07-07 02:32:30 +08:00
|
|
|
dma_pl330_rqcb(descdone, PL330_ERR_NONE);
|
2011-12-26 17:49:52 +08:00
|
|
|
spin_lock_irqsave(&pl330->lock, flags);
|
|
|
|
}
|
|
|
|
|
|
|
|
updt_exit:
|
|
|
|
spin_unlock_irqrestore(&pl330->lock, flags);
|
|
|
|
|
|
|
|
if (pl330->dmac_tbd.reset_dmac
|
|
|
|
|| pl330->dmac_tbd.reset_mngr
|
|
|
|
|| pl330->dmac_tbd.reset_chan) {
|
|
|
|
ret = 1;
|
|
|
|
tasklet_schedule(&pl330->tasks);
|
|
|
|
}
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Reserve an event */
|
|
|
|
static inline int _alloc_event(struct pl330_thread *thrd)
|
|
|
|
{
|
|
|
|
struct pl330_dmac *pl330 = thrd->dmac;
|
|
|
|
int ev;
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
for (ev = 0; ev < pl330->pcfg.num_events; ev++)
|
2011-12-26 17:49:52 +08:00
|
|
|
if (pl330->events[ev] == -1) {
|
|
|
|
pl330->events[ev] = thrd->id;
|
|
|
|
return ev;
|
|
|
|
}
|
|
|
|
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
static bool _chan_ns(const struct pl330_dmac *pl330, int i)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
return pl330->pcfg.irq_ns & (1 << i);
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Upon success, returns IdentityToken for the
|
|
|
|
* allocated channel, NULL otherwise.
|
|
|
|
*/
|
2014-07-07 02:32:29 +08:00
|
|
|
static struct pl330_thread *pl330_request_channel(struct pl330_dmac *pl330)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
|
|
|
struct pl330_thread *thrd = NULL;
|
|
|
|
int chans, i;
|
|
|
|
|
|
|
|
if (pl330->state == DYING)
|
|
|
|
return NULL;
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
chans = pl330->pcfg.num_chan;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
for (i = 0; i < chans; i++) {
|
|
|
|
thrd = &pl330->channels[i];
|
|
|
|
if ((thrd->free) && (!_manager_ns(thrd) ||
|
2014-07-07 02:32:29 +08:00
|
|
|
_chan_ns(pl330, i))) {
|
2011-12-26 17:49:52 +08:00
|
|
|
thrd->ev = _alloc_event(thrd);
|
|
|
|
if (thrd->ev >= 0) {
|
|
|
|
thrd->free = false;
|
|
|
|
thrd->lstenq = 1;
|
2014-07-07 02:32:30 +08:00
|
|
|
thrd->req[0].desc = NULL;
|
|
|
|
thrd->req[1].desc = NULL;
|
2014-07-07 02:32:31 +08:00
|
|
|
thrd->req_running = -1;
|
2011-12-26 17:49:52 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
thrd = NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
return thrd;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Release an event */
|
|
|
|
static inline void _free_event(struct pl330_thread *thrd, int ev)
|
|
|
|
{
|
|
|
|
struct pl330_dmac *pl330 = thrd->dmac;
|
|
|
|
|
|
|
|
/* If the event is valid and was held by the thread */
|
2014-07-07 02:32:29 +08:00
|
|
|
if (ev >= 0 && ev < pl330->pcfg.num_events
|
2011-12-26 17:49:52 +08:00
|
|
|
&& pl330->events[ev] == thrd->id)
|
|
|
|
pl330->events[ev] = -1;
|
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:26 +08:00
|
|
|
static void pl330_release_channel(struct pl330_thread *thrd)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
|
|
|
struct pl330_dmac *pl330;
|
|
|
|
|
|
|
|
if (!thrd || thrd->free)
|
|
|
|
return;
|
|
|
|
|
|
|
|
_stop(thrd);
|
|
|
|
|
2014-07-07 02:32:30 +08:00
|
|
|
dma_pl330_rqcb(thrd->req[1 - thrd->lstenq].desc, PL330_ERR_ABORT);
|
|
|
|
dma_pl330_rqcb(thrd->req[thrd->lstenq].desc, PL330_ERR_ABORT);
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
pl330 = thrd->dmac;
|
|
|
|
|
|
|
|
_free_event(thrd, thrd->ev);
|
|
|
|
thrd->free = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Initialize the structure for PL330 configuration, that can be used
|
|
|
|
* by the client driver the make best use of the DMAC
|
|
|
|
*/
|
2014-07-07 02:32:29 +08:00
|
|
|
static void read_dmac_config(struct pl330_dmac *pl330)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
void __iomem *regs = pl330->base;
|
2011-12-26 17:49:52 +08:00
|
|
|
u32 val;
|
|
|
|
|
|
|
|
val = readl(regs + CRD) >> CRD_DATA_WIDTH_SHIFT;
|
|
|
|
val &= CRD_DATA_WIDTH_MASK;
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330->pcfg.data_bus_width = 8 * (1 << val);
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
val = readl(regs + CRD) >> CRD_DATA_BUFF_SHIFT;
|
|
|
|
val &= CRD_DATA_BUFF_MASK;
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330->pcfg.data_buf_dep = val + 1;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
val = readl(regs + CR0) >> CR0_NUM_CHANS_SHIFT;
|
|
|
|
val &= CR0_NUM_CHANS_MASK;
|
|
|
|
val += 1;
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330->pcfg.num_chan = val;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
val = readl(regs + CR0);
|
|
|
|
if (val & CR0_PERIPH_REQ_SET) {
|
|
|
|
val = (val >> CR0_NUM_PERIPH_SHIFT) & CR0_NUM_PERIPH_MASK;
|
|
|
|
val += 1;
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330->pcfg.num_peri = val;
|
|
|
|
pl330->pcfg.peri_ns = readl(regs + CR4);
|
2011-12-26 17:49:52 +08:00
|
|
|
} else {
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330->pcfg.num_peri = 0;
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
val = readl(regs + CR0);
|
|
|
|
if (val & CR0_BOOT_MAN_NS)
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330->pcfg.mode |= DMAC_MODE_NS;
|
2011-12-26 17:49:52 +08:00
|
|
|
else
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330->pcfg.mode &= ~DMAC_MODE_NS;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
val = readl(regs + CR0) >> CR0_NUM_EVENTS_SHIFT;
|
|
|
|
val &= CR0_NUM_EVENTS_MASK;
|
|
|
|
val += 1;
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330->pcfg.num_events = val;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330->pcfg.irq_ns = readl(regs + CR3);
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static inline void _reset_thread(struct pl330_thread *thrd)
|
|
|
|
{
|
|
|
|
struct pl330_dmac *pl330 = thrd->dmac;
|
|
|
|
|
|
|
|
thrd->req[0].mc_cpu = pl330->mcode_cpu
|
2014-07-07 02:32:29 +08:00
|
|
|
+ (thrd->id * pl330->mcbufsz);
|
2011-12-26 17:49:52 +08:00
|
|
|
thrd->req[0].mc_bus = pl330->mcode_bus
|
2014-07-07 02:32:29 +08:00
|
|
|
+ (thrd->id * pl330->mcbufsz);
|
2014-07-07 02:32:30 +08:00
|
|
|
thrd->req[0].desc = NULL;
|
2011-12-26 17:49:52 +08:00
|
|
|
|
|
|
|
thrd->req[1].mc_cpu = thrd->req[0].mc_cpu
|
2014-07-07 02:32:29 +08:00
|
|
|
+ pl330->mcbufsz / 2;
|
2011-12-26 17:49:52 +08:00
|
|
|
thrd->req[1].mc_bus = thrd->req[0].mc_bus
|
2014-07-07 02:32:29 +08:00
|
|
|
+ pl330->mcbufsz / 2;
|
2014-07-07 02:32:30 +08:00
|
|
|
thrd->req[1].desc = NULL;
|
2014-07-07 02:32:31 +08:00
|
|
|
|
|
|
|
thrd->req_running = -1;
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static int dmac_alloc_threads(struct pl330_dmac *pl330)
|
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
int chans = pl330->pcfg.num_chan;
|
2011-12-26 17:49:52 +08:00
|
|
|
struct pl330_thread *thrd;
|
|
|
|
int i;
|
|
|
|
|
|
|
|
/* Allocate 1 Manager and 'chans' Channel threads */
|
treewide: kzalloc() -> kcalloc()
The kzalloc() function has a 2-factor argument form, kcalloc(). This
patch replaces cases of:
kzalloc(a * b, gfp)
with:
kcalloc(a * b, gfp)
as well as handling cases of:
kzalloc(a * b * c, gfp)
with:
kzalloc(array3_size(a, b, c), gfp)
as it's slightly less ugly than:
kzalloc_array(array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
kzalloc(4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
type TYPE;
expression THING, E;
@@
(
kzalloc(
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
kzalloc(
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression COUNT;
typedef u8;
typedef __u8;
@@
(
kzalloc(
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
identifier SIZE, COUNT;
@@
- kzalloc
+ kcalloc
(
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
kzalloc(
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
kzalloc(
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
identifier STRIDE, SIZE, COUNT;
@@
(
kzalloc(
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
kzalloc(sizeof(THING) * C2, ...)
|
kzalloc(sizeof(TYPE) * C2, ...)
|
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(C1 * C2, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * E2
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * (E2)
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 05:03:40 +08:00
|
|
|
pl330->channels = kcalloc(1 + chans, sizeof(*thrd),
|
2011-12-26 17:49:52 +08:00
|
|
|
GFP_KERNEL);
|
|
|
|
if (!pl330->channels)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
|
|
|
/* Init Channel threads */
|
|
|
|
for (i = 0; i < chans; i++) {
|
|
|
|
thrd = &pl330->channels[i];
|
|
|
|
thrd->id = i;
|
|
|
|
thrd->dmac = pl330;
|
|
|
|
_reset_thread(thrd);
|
|
|
|
thrd->free = true;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* MANAGER is indexed at the end */
|
|
|
|
thrd = &pl330->channels[chans];
|
|
|
|
thrd->id = chans;
|
|
|
|
thrd->dmac = pl330;
|
|
|
|
thrd->free = false;
|
|
|
|
pl330->manager = thrd;
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int dmac_alloc_resources(struct pl330_dmac *pl330)
|
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
int chans = pl330->pcfg.num_chan;
|
2011-12-26 17:49:52 +08:00
|
|
|
int ret;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
/*
|
2011-12-26 17:49:52 +08:00
|
|
|
* Alloc MicroCode buffer for 'chans' Channel threads.
|
|
|
|
* A channel's buffer offset is (Channel_Id * MCODE_BUFF_PERCHAN)
|
2010-05-24 11:28:19 +08:00
|
|
|
*/
|
2017-01-06 21:28:14 +08:00
|
|
|
pl330->mcode_cpu = dma_alloc_attrs(pl330->ddma.dev,
|
2014-07-07 02:32:29 +08:00
|
|
|
chans * pl330->mcbufsz,
|
2017-01-06 21:28:14 +08:00
|
|
|
&pl330->mcode_bus, GFP_KERNEL,
|
|
|
|
DMA_ATTR_PRIVILEGED);
|
2011-12-26 17:49:52 +08:00
|
|
|
if (!pl330->mcode_cpu) {
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_err(pl330->ddma.dev, "%s:%d Can't allocate memory!\n",
|
2011-12-26 17:49:52 +08:00
|
|
|
__func__, __LINE__);
|
|
|
|
return -ENOMEM;
|
|
|
|
}
|
|
|
|
|
|
|
|
ret = dmac_alloc_threads(pl330);
|
|
|
|
if (ret) {
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_err(pl330->ddma.dev, "%s:%d Can't to create channels for DMAC!\n",
|
2011-12-26 17:49:52 +08:00
|
|
|
__func__, __LINE__);
|
2014-07-07 02:32:29 +08:00
|
|
|
dma_free_coherent(pl330->ddma.dev,
|
|
|
|
chans * pl330->mcbufsz,
|
2011-12-26 17:49:52 +08:00
|
|
|
pl330->mcode_cpu, pl330->mcode_bus);
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
static int pl330_add(struct pl330_dmac *pl330)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
|
|
|
int i, ret;
|
|
|
|
|
|
|
|
/* Check if we can handle this DMAC */
|
2014-07-07 02:32:29 +08:00
|
|
|
if ((pl330->pcfg.periph_id & 0xfffff) != PERIPH_ID_VAL) {
|
|
|
|
dev_err(pl330->ddma.dev, "PERIPH_ID 0x%x !\n",
|
|
|
|
pl330->pcfg.periph_id);
|
2011-12-26 17:49:52 +08:00
|
|
|
return -EINVAL;
|
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
/* Read the configuration of the DMAC */
|
2014-07-07 02:32:29 +08:00
|
|
|
read_dmac_config(pl330);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
if (pl330->pcfg.num_events == 0) {
|
|
|
|
dev_err(pl330->ddma.dev, "%s:%d Can't work without events!\n",
|
2011-12-26 17:49:52 +08:00
|
|
|
__func__, __LINE__);
|
|
|
|
return -EINVAL;
|
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
spin_lock_init(&pl330->lock);
|
2011-09-02 08:44:30 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
INIT_LIST_HEAD(&pl330->req_done);
|
2011-09-02 08:44:33 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
/* Use default MC buffer size if not provided */
|
2014-07-07 02:32:29 +08:00
|
|
|
if (!pl330->mcbufsz)
|
|
|
|
pl330->mcbufsz = MCODE_BUFF_PER_REQ * 2;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
/* Mark all events as free */
|
2014-07-07 02:32:29 +08:00
|
|
|
for (i = 0; i < pl330->pcfg.num_events; i++)
|
2011-12-26 17:49:52 +08:00
|
|
|
pl330->events[i] = -1;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
/* Allocate resources needed by the DMAC */
|
|
|
|
ret = dmac_alloc_resources(pl330);
|
|
|
|
if (ret) {
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_err(pl330->ddma.dev, "Unable to create channels for DMAC\n");
|
2011-12-26 17:49:52 +08:00
|
|
|
return ret;
|
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
tasklet_init(&pl330->tasks, pl330_dotask, (unsigned long) pl330);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
pl330->state = INIT;
|
2011-09-02 08:44:29 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
return 0;
|
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
static int dmac_free_threads(struct pl330_dmac *pl330)
|
|
|
|
{
|
|
|
|
struct pl330_thread *thrd;
|
|
|
|
int i;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
/* Release Channel threads */
|
2014-07-07 02:32:29 +08:00
|
|
|
for (i = 0; i < pl330->pcfg.num_chan; i++) {
|
2011-12-26 17:49:52 +08:00
|
|
|
thrd = &pl330->channels[i];
|
2014-07-07 02:32:26 +08:00
|
|
|
pl330_release_channel(thrd);
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
/* Free memory */
|
|
|
|
kfree(pl330->channels);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-12-26 17:49:52 +08:00
|
|
|
return 0;
|
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
static void pl330_del(struct pl330_dmac *pl330)
|
2011-12-26 17:49:52 +08:00
|
|
|
{
|
|
|
|
pl330->state = UNINIT;
|
|
|
|
|
|
|
|
tasklet_kill(&pl330->tasks);
|
|
|
|
|
|
|
|
/* Free DMAC resources */
|
2014-07-07 02:32:29 +08:00
|
|
|
dmac_free_threads(pl330);
|
2011-12-26 17:49:52 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
dma_free_coherent(pl330->ddma.dev,
|
|
|
|
pl330->pcfg.num_chan * pl330->mcbufsz, pl330->mcode_cpu,
|
|
|
|
pl330->mcode_bus);
|
2011-12-26 17:49:52 +08:00
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-10-24 17:43:02 +08:00
|
|
|
/* forward declaration */
|
|
|
|
static struct amba_driver pl330_driver;
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
static inline struct dma_pl330_chan *
|
|
|
|
to_pchan(struct dma_chan *ch)
|
|
|
|
{
|
|
|
|
if (!ch)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
return container_of(ch, struct dma_pl330_chan, chan);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline struct dma_pl330_desc *
|
|
|
|
to_desc(struct dma_async_tx_descriptor *tx)
|
|
|
|
{
|
|
|
|
return container_of(tx, struct dma_pl330_desc, txd);
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void fill_queue(struct dma_pl330_chan *pch)
|
|
|
|
{
|
|
|
|
struct dma_pl330_desc *desc;
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
list_for_each_entry(desc, &pch->work_list, node) {
|
|
|
|
|
|
|
|
/* If already submitted */
|
|
|
|
if (desc->status == BUSY)
|
2013-02-13 18:43:14 +08:00
|
|
|
continue;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-07-07 02:32:30 +08:00
|
|
|
ret = pl330_submit_req(pch->thread, desc);
|
2010-05-24 11:28:19 +08:00
|
|
|
if (!ret) {
|
|
|
|
desc->status = BUSY;
|
|
|
|
} else if (ret == -EAGAIN) {
|
|
|
|
/* QFull or DMAC Dying */
|
|
|
|
break;
|
|
|
|
} else {
|
|
|
|
/* Unacceptable request */
|
|
|
|
desc->status = DONE;
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_err(pch->dmac->ddma.dev, "%s:%d Bad Desc(%d)\n",
|
2010-05-24 11:28:19 +08:00
|
|
|
__func__, __LINE__, desc->txd.cookie);
|
|
|
|
tasklet_schedule(&pch->task);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void pl330_tasklet(unsigned long data)
|
|
|
|
{
|
|
|
|
struct dma_pl330_chan *pch = (struct dma_pl330_chan *)data;
|
|
|
|
struct dma_pl330_desc *desc, *_dt;
|
|
|
|
unsigned long flags;
|
2014-11-14 16:48:57 +08:00
|
|
|
bool power_down = false;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
spin_lock_irqsave(&pch->lock, flags);
|
|
|
|
|
|
|
|
/* Pick up ripe tomatoes */
|
|
|
|
list_for_each_entry_safe(desc, _dt, &pch->work_list, node)
|
|
|
|
if (desc->status == DONE) {
|
2012-05-23 19:17:31 +08:00
|
|
|
if (!pch->cyclic)
|
2012-05-11 13:54:41 +08:00
|
|
|
dma_cookie_complete(&desc->txd);
|
2013-08-28 02:34:05 +08:00
|
|
|
list_move_tail(&desc->node, &pch->completed_list);
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Try to submit a req imm. next to the last completed cookie */
|
|
|
|
fill_queue(pch);
|
|
|
|
|
2014-11-14 16:48:57 +08:00
|
|
|
if (list_empty(&pch->work_list)) {
|
|
|
|
spin_lock(&pch->thread->dmac->lock);
|
|
|
|
_stop(pch->thread);
|
|
|
|
spin_unlock(&pch->thread->dmac->lock);
|
|
|
|
power_down = true;
|
2016-12-16 18:39:11 +08:00
|
|
|
pch->active = false;
|
2014-11-14 16:48:57 +08:00
|
|
|
} else {
|
|
|
|
/* Make sure the PL330 Channel thread is active */
|
|
|
|
spin_lock(&pch->thread->dmac->lock);
|
|
|
|
_start(pch->thread);
|
|
|
|
spin_unlock(&pch->thread->dmac->lock);
|
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2013-08-28 02:34:05 +08:00
|
|
|
while (!list_empty(&pch->completed_list)) {
|
2016-07-21 04:12:35 +08:00
|
|
|
struct dmaengine_desc_callback cb;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2013-08-28 02:34:05 +08:00
|
|
|
desc = list_first_entry(&pch->completed_list,
|
|
|
|
struct dma_pl330_desc, node);
|
|
|
|
|
2016-07-21 04:12:35 +08:00
|
|
|
dmaengine_desc_get_callback(&desc->txd, &cb);
|
2013-08-28 02:34:05 +08:00
|
|
|
|
|
|
|
if (pch->cyclic) {
|
|
|
|
desc->status = PREP;
|
|
|
|
list_move_tail(&desc->node, &pch->work_list);
|
2014-11-14 16:48:57 +08:00
|
|
|
if (power_down) {
|
2016-12-16 18:39:11 +08:00
|
|
|
pch->active = true;
|
2014-11-14 16:48:57 +08:00
|
|
|
spin_lock(&pch->thread->dmac->lock);
|
|
|
|
_start(pch->thread);
|
|
|
|
spin_unlock(&pch->thread->dmac->lock);
|
|
|
|
power_down = false;
|
|
|
|
}
|
2013-08-28 02:34:05 +08:00
|
|
|
} else {
|
|
|
|
desc->status = FREE;
|
|
|
|
list_move_tail(&desc->node, &pch->dmac->desc_pool);
|
|
|
|
}
|
|
|
|
|
2013-10-19 01:35:23 +08:00
|
|
|
dma_descriptor_unmap(&desc->txd);
|
|
|
|
|
2016-07-21 04:12:35 +08:00
|
|
|
if (dmaengine_desc_callback_valid(&cb)) {
|
2013-08-28 02:34:05 +08:00
|
|
|
spin_unlock_irqrestore(&pch->lock, flags);
|
2016-07-21 04:12:35 +08:00
|
|
|
dmaengine_desc_callback_invoke(&cb, NULL);
|
2013-08-28 02:34:05 +08:00
|
|
|
spin_lock_irqsave(&pch->lock, flags);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
spin_unlock_irqrestore(&pch->lock, flags);
|
2014-11-14 16:48:57 +08:00
|
|
|
|
|
|
|
/* If work list empty, power down */
|
|
|
|
if (power_down) {
|
|
|
|
pm_runtime_mark_last_busy(pch->dmac->ddma.dev);
|
|
|
|
pm_runtime_put_autosuspend(pch->dmac->ddma.dev);
|
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
|
|
|
|
2013-02-14 11:40:06 +08:00
|
|
|
static struct dma_chan *of_dma_pl330_xlate(struct of_phandle_args *dma_spec,
|
|
|
|
struct of_dma *ofdma)
|
|
|
|
{
|
|
|
|
int count = dma_spec->args_count;
|
2014-07-07 02:32:29 +08:00
|
|
|
struct pl330_dmac *pl330 = ofdma->of_dma_data;
|
2014-01-12 03:08:39 +08:00
|
|
|
unsigned int chan_id;
|
2013-02-14 11:40:06 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
if (!pl330)
|
|
|
|
return NULL;
|
|
|
|
|
2013-02-14 11:40:06 +08:00
|
|
|
if (count != 1)
|
|
|
|
return NULL;
|
|
|
|
|
2014-01-12 03:08:39 +08:00
|
|
|
chan_id = dma_spec->args[0];
|
2014-07-07 02:32:29 +08:00
|
|
|
if (chan_id >= pl330->num_peripherals)
|
2014-01-12 03:08:39 +08:00
|
|
|
return NULL;
|
2013-02-14 11:40:06 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
return dma_get_slave_channel(&pl330->peripherals[chan_id].chan);
|
2013-02-14 11:40:06 +08:00
|
|
|
}
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
static int pl330_alloc_chan_resources(struct dma_chan *chan)
|
|
|
|
{
|
|
|
|
struct dma_pl330_chan *pch = to_pchan(chan);
|
2014-07-07 02:32:29 +08:00
|
|
|
struct pl330_dmac *pl330 = pch->dmac;
|
2010-05-24 11:28:19 +08:00
|
|
|
unsigned long flags;
|
|
|
|
|
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the
following double-lock bug:
Double lock:
1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236;
2. call to function `pl330_release_channel' immediately after;
3. call to function `dma_pl330_rqcb' in line 1753;
4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505.
I have fixed it as suggested by Marek Szyprowski.
First, I have replaced `pch->lock' with `pl330->lock' in functions
`pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids
the double-lock by acquiring a different lock than `dma_pl330_rqcb'.
NOTE that, as a result, `pl330_free_chan_resources' executes
`list_splice_tail_init' on `pch->work_list' under lock `pl330->lock',
whereas in the rest of the code `pch->work_list' is protected by
`pch->lock'. I don't know if this may cause race conditions. Similarly
`pch->cyclic' is written by `pl330_alloc_chan_resources' under
`pl330->lock' but read by `pl330_tx_submit' under `pch->lock'.
Second, I have removed locking from `pl330_request_channel' and
`pl330_release_channel' functions. Function `pl330_request_channel' is
only called from `pl330_alloc_chan_resources', so the lock is already
held. Function `pl330_release_channel' is called from
`pl330_free_chan_resources', which already holds the lock, and from
`pl330_del'. Function `pl330_del' is called in an error path of
`pl330_probe' and at the end of `pl330_remove', but I assume that there
cannot be concurrent accesses to the protected data at those points.
Signed-off-by: Iago Abal <mail@iagoabal.eu>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2017-01-11 21:00:21 +08:00
|
|
|
spin_lock_irqsave(&pl330->lock, flags);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2012-03-07 06:35:47 +08:00
|
|
|
dma_cookie_init(chan);
|
2011-09-02 08:44:33 +08:00
|
|
|
pch->cyclic = false;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
pch->thread = pl330_request_channel(pl330);
|
2014-07-07 02:32:26 +08:00
|
|
|
if (!pch->thread) {
|
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the
following double-lock bug:
Double lock:
1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236;
2. call to function `pl330_release_channel' immediately after;
3. call to function `dma_pl330_rqcb' in line 1753;
4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505.
I have fixed it as suggested by Marek Szyprowski.
First, I have replaced `pch->lock' with `pl330->lock' in functions
`pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids
the double-lock by acquiring a different lock than `dma_pl330_rqcb'.
NOTE that, as a result, `pl330_free_chan_resources' executes
`list_splice_tail_init' on `pch->work_list' under lock `pl330->lock',
whereas in the rest of the code `pch->work_list' is protected by
`pch->lock'. I don't know if this may cause race conditions. Similarly
`pch->cyclic' is written by `pl330_alloc_chan_resources' under
`pl330->lock' but read by `pl330_tx_submit' under `pch->lock'.
Second, I have removed locking from `pl330_request_channel' and
`pl330_release_channel' functions. Function `pl330_request_channel' is
only called from `pl330_alloc_chan_resources', so the lock is already
held. Function `pl330_release_channel' is called from
`pl330_free_chan_resources', which already holds the lock, and from
`pl330_del'. Function `pl330_del' is called in an error path of
`pl330_probe' and at the end of `pl330_remove', but I assume that there
cannot be concurrent accesses to the protected data at those points.
Signed-off-by: Iago Abal <mail@iagoabal.eu>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2017-01-11 21:00:21 +08:00
|
|
|
spin_unlock_irqrestore(&pl330->lock, flags);
|
2012-09-17 12:27:45 +08:00
|
|
|
return -ENOMEM;
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
tasklet_init(&pch->task, pl330_tasklet, (unsigned long) pch);
|
|
|
|
|
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the
following double-lock bug:
Double lock:
1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236;
2. call to function `pl330_release_channel' immediately after;
3. call to function `dma_pl330_rqcb' in line 1753;
4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505.
I have fixed it as suggested by Marek Szyprowski.
First, I have replaced `pch->lock' with `pl330->lock' in functions
`pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids
the double-lock by acquiring a different lock than `dma_pl330_rqcb'.
NOTE that, as a result, `pl330_free_chan_resources' executes
`list_splice_tail_init' on `pch->work_list' under lock `pl330->lock',
whereas in the rest of the code `pch->work_list' is protected by
`pch->lock'. I don't know if this may cause race conditions. Similarly
`pch->cyclic' is written by `pl330_alloc_chan_resources' under
`pl330->lock' but read by `pl330_tx_submit' under `pch->lock'.
Second, I have removed locking from `pl330_request_channel' and
`pl330_release_channel' functions. Function `pl330_request_channel' is
only called from `pl330_alloc_chan_resources', so the lock is already
held. Function `pl330_release_channel' is called from
`pl330_free_chan_resources', which already holds the lock, and from
`pl330_del'. Function `pl330_del' is called in an error path of
`pl330_probe' and at the end of `pl330_remove', but I assume that there
cannot be concurrent accesses to the protected data at those points.
Signed-off-by: Iago Abal <mail@iagoabal.eu>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2017-01-11 21:00:21 +08:00
|
|
|
spin_unlock_irqrestore(&pl330->lock, flags);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
return 1;
|
|
|
|
}
|
|
|
|
|
2017-05-19 22:06:44 +08:00
|
|
|
/*
|
|
|
|
* We need the data direction between the DMAC (the dma-mapping "device") and
|
|
|
|
* the FIFO (the dmaengine "dev"), from the FIFO's point of view. Confusing!
|
|
|
|
*/
|
|
|
|
static enum dma_data_direction
|
|
|
|
pl330_dma_slave_map_dir(enum dma_transfer_direction dir)
|
|
|
|
{
|
|
|
|
switch (dir) {
|
|
|
|
case DMA_MEM_TO_DEV:
|
|
|
|
return DMA_FROM_DEVICE;
|
|
|
|
case DMA_DEV_TO_MEM:
|
|
|
|
return DMA_TO_DEVICE;
|
|
|
|
case DMA_DEV_TO_DEV:
|
|
|
|
return DMA_BIDIRECTIONAL;
|
|
|
|
default:
|
|
|
|
return DMA_NONE;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
static void pl330_unprep_slave_fifo(struct dma_pl330_chan *pch)
|
|
|
|
{
|
|
|
|
if (pch->dir != DMA_NONE)
|
|
|
|
dma_unmap_resource(pch->chan.device->dev, pch->fifo_dma,
|
|
|
|
1 << pch->burst_sz, pch->dir, 0);
|
|
|
|
pch->dir = DMA_NONE;
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
static bool pl330_prep_slave_fifo(struct dma_pl330_chan *pch,
|
|
|
|
enum dma_transfer_direction dir)
|
|
|
|
{
|
|
|
|
struct device *dev = pch->chan.device->dev;
|
|
|
|
enum dma_data_direction dma_dir = pl330_dma_slave_map_dir(dir);
|
|
|
|
|
|
|
|
/* Already mapped for this config? */
|
|
|
|
if (pch->dir == dma_dir)
|
|
|
|
return true;
|
|
|
|
|
|
|
|
pl330_unprep_slave_fifo(pch);
|
|
|
|
pch->fifo_dma = dma_map_resource(dev, pch->fifo_addr,
|
|
|
|
1 << pch->burst_sz, dma_dir, 0);
|
|
|
|
if (dma_mapping_error(dev, pch->fifo_dma))
|
|
|
|
return false;
|
|
|
|
|
|
|
|
pch->dir = dma_dir;
|
|
|
|
return true;
|
|
|
|
}
|
|
|
|
|
2018-04-19 08:31:06 +08:00
|
|
|
static int fixup_burst_len(int max_burst_len, int quirks)
|
|
|
|
{
|
|
|
|
if (quirks & PL330_QUIRK_BROKEN_NO_FLUSHP)
|
|
|
|
return 1;
|
|
|
|
else if (max_burst_len > PL330_MAX_BURST)
|
|
|
|
return PL330_MAX_BURST;
|
|
|
|
else if (max_burst_len < 1)
|
|
|
|
return 1;
|
|
|
|
else
|
|
|
|
return max_burst_len;
|
|
|
|
}
|
|
|
|
|
2014-11-17 21:42:29 +08:00
|
|
|
static int pl330_config(struct dma_chan *chan,
|
|
|
|
struct dma_slave_config *slave_config)
|
|
|
|
{
|
|
|
|
struct dma_pl330_chan *pch = to_pchan(chan);
|
|
|
|
|
2017-05-19 22:06:44 +08:00
|
|
|
pl330_unprep_slave_fifo(pch);
|
2014-11-17 21:42:29 +08:00
|
|
|
if (slave_config->direction == DMA_MEM_TO_DEV) {
|
|
|
|
if (slave_config->dst_addr)
|
|
|
|
pch->fifo_addr = slave_config->dst_addr;
|
|
|
|
if (slave_config->dst_addr_width)
|
|
|
|
pch->burst_sz = __ffs(slave_config->dst_addr_width);
|
2018-04-19 08:31:06 +08:00
|
|
|
pch->burst_len = fixup_burst_len(slave_config->dst_maxburst,
|
|
|
|
pch->dmac->quirks);
|
2014-11-17 21:42:29 +08:00
|
|
|
} else if (slave_config->direction == DMA_DEV_TO_MEM) {
|
|
|
|
if (slave_config->src_addr)
|
|
|
|
pch->fifo_addr = slave_config->src_addr;
|
|
|
|
if (slave_config->src_addr_width)
|
|
|
|
pch->burst_sz = __ffs(slave_config->src_addr_width);
|
2018-04-19 08:31:06 +08:00
|
|
|
pch->burst_len = fixup_burst_len(slave_config->src_maxburst,
|
|
|
|
pch->dmac->quirks);
|
2014-11-17 21:42:29 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int pl330_terminate_all(struct dma_chan *chan)
|
2010-05-24 11:28:19 +08:00
|
|
|
{
|
|
|
|
struct dma_pl330_chan *pch = to_pchan(chan);
|
2013-08-28 02:34:05 +08:00
|
|
|
struct dma_pl330_desc *desc;
|
2010-05-24 11:28:19 +08:00
|
|
|
unsigned long flags;
|
2014-07-07 02:32:29 +08:00
|
|
|
struct pl330_dmac *pl330 = pch->dmac;
|
2011-09-02 08:44:32 +08:00
|
|
|
LIST_HEAD(list);
|
2016-12-16 18:39:11 +08:00
|
|
|
bool power_down = false;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2015-05-21 08:34:09 +08:00
|
|
|
pm_runtime_get_sync(pl330->ddma.dev);
|
2014-11-17 21:42:29 +08:00
|
|
|
spin_lock_irqsave(&pch->lock, flags);
|
|
|
|
spin_lock(&pl330->lock);
|
|
|
|
_stop(pch->thread);
|
|
|
|
spin_unlock(&pl330->lock);
|
|
|
|
|
|
|
|
pch->thread->req[0].desc = NULL;
|
|
|
|
pch->thread->req[1].desc = NULL;
|
|
|
|
pch->thread->req_running = -1;
|
2016-12-16 18:39:11 +08:00
|
|
|
power_down = pch->active;
|
|
|
|
pch->active = false;
|
2014-11-17 21:42:29 +08:00
|
|
|
|
|
|
|
/* Mark all desc done */
|
|
|
|
list_for_each_entry(desc, &pch->submitted_list, node) {
|
|
|
|
desc->status = FREE;
|
|
|
|
dma_cookie_complete(&desc->txd);
|
|
|
|
}
|
2014-11-14 16:48:57 +08:00
|
|
|
|
2014-11-17 21:42:29 +08:00
|
|
|
list_for_each_entry(desc, &pch->work_list , node) {
|
|
|
|
desc->status = FREE;
|
|
|
|
dma_cookie_complete(&desc->txd);
|
2011-09-02 08:44:31 +08:00
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-11-17 21:42:29 +08:00
|
|
|
list_splice_tail_init(&pch->submitted_list, &pl330->desc_pool);
|
|
|
|
list_splice_tail_init(&pch->work_list, &pl330->desc_pool);
|
|
|
|
list_splice_tail_init(&pch->completed_list, &pl330->desc_pool);
|
|
|
|
spin_unlock_irqrestore(&pch->lock, flags);
|
2015-05-21 08:34:09 +08:00
|
|
|
pm_runtime_mark_last_busy(pl330->ddma.dev);
|
2016-12-16 18:39:11 +08:00
|
|
|
if (power_down)
|
|
|
|
pm_runtime_put_autosuspend(pl330->ddma.dev);
|
2015-05-21 08:34:09 +08:00
|
|
|
pm_runtime_put_autosuspend(pl330->ddma.dev);
|
2014-11-17 21:42:29 +08:00
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2015-02-11 20:23:18 +08:00
|
|
|
/*
|
|
|
|
* We don't support DMA_RESUME command because of hardware
|
|
|
|
* limitations, so after pausing the channel we cannot restore
|
|
|
|
* it to active state. We have to terminate channel and setup
|
|
|
|
* DMA transfer again. This pause feature was implemented to
|
|
|
|
* allow safely read residue before channel termination.
|
|
|
|
*/
|
2015-03-16 19:52:44 +08:00
|
|
|
static int pl330_pause(struct dma_chan *chan)
|
2015-02-11 20:23:18 +08:00
|
|
|
{
|
|
|
|
struct dma_pl330_chan *pch = to_pchan(chan);
|
|
|
|
struct pl330_dmac *pl330 = pch->dmac;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
pm_runtime_get_sync(pl330->ddma.dev);
|
|
|
|
spin_lock_irqsave(&pch->lock, flags);
|
|
|
|
|
|
|
|
spin_lock(&pl330->lock);
|
|
|
|
_stop(pch->thread);
|
|
|
|
spin_unlock(&pl330->lock);
|
|
|
|
|
|
|
|
spin_unlock_irqrestore(&pch->lock, flags);
|
|
|
|
pm_runtime_mark_last_busy(pl330->ddma.dev);
|
|
|
|
pm_runtime_put_autosuspend(pl330->ddma.dev);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
static void pl330_free_chan_resources(struct dma_chan *chan)
|
|
|
|
{
|
|
|
|
struct dma_pl330_chan *pch = to_pchan(chan);
|
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the
following double-lock bug:
Double lock:
1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236;
2. call to function `pl330_release_channel' immediately after;
3. call to function `dma_pl330_rqcb' in line 1753;
4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505.
I have fixed it as suggested by Marek Szyprowski.
First, I have replaced `pch->lock' with `pl330->lock' in functions
`pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids
the double-lock by acquiring a different lock than `dma_pl330_rqcb'.
NOTE that, as a result, `pl330_free_chan_resources' executes
`list_splice_tail_init' on `pch->work_list' under lock `pl330->lock',
whereas in the rest of the code `pch->work_list' is protected by
`pch->lock'. I don't know if this may cause race conditions. Similarly
`pch->cyclic' is written by `pl330_alloc_chan_resources' under
`pl330->lock' but read by `pl330_tx_submit' under `pch->lock'.
Second, I have removed locking from `pl330_request_channel' and
`pl330_release_channel' functions. Function `pl330_request_channel' is
only called from `pl330_alloc_chan_resources', so the lock is already
held. Function `pl330_release_channel' is called from
`pl330_free_chan_resources', which already holds the lock, and from
`pl330_del'. Function `pl330_del' is called in an error path of
`pl330_probe' and at the end of `pl330_remove', but I assume that there
cannot be concurrent accesses to the protected data at those points.
Signed-off-by: Iago Abal <mail@iagoabal.eu>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2017-01-11 21:00:21 +08:00
|
|
|
struct pl330_dmac *pl330 = pch->dmac;
|
2010-05-24 11:28:19 +08:00
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
tasklet_kill(&pch->task);
|
|
|
|
|
2014-11-14 16:48:57 +08:00
|
|
|
pm_runtime_get_sync(pch->dmac->ddma.dev);
|
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the
following double-lock bug:
Double lock:
1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236;
2. call to function `pl330_release_channel' immediately after;
3. call to function `dma_pl330_rqcb' in line 1753;
4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505.
I have fixed it as suggested by Marek Szyprowski.
First, I have replaced `pch->lock' with `pl330->lock' in functions
`pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids
the double-lock by acquiring a different lock than `dma_pl330_rqcb'.
NOTE that, as a result, `pl330_free_chan_resources' executes
`list_splice_tail_init' on `pch->work_list' under lock `pl330->lock',
whereas in the rest of the code `pch->work_list' is protected by
`pch->lock'. I don't know if this may cause race conditions. Similarly
`pch->cyclic' is written by `pl330_alloc_chan_resources' under
`pl330->lock' but read by `pl330_tx_submit' under `pch->lock'.
Second, I have removed locking from `pl330_request_channel' and
`pl330_release_channel' functions. Function `pl330_request_channel' is
only called from `pl330_alloc_chan_resources', so the lock is already
held. Function `pl330_release_channel' is called from
`pl330_free_chan_resources', which already holds the lock, and from
`pl330_del'. Function `pl330_del' is called in an error path of
`pl330_probe' and at the end of `pl330_remove', but I assume that there
cannot be concurrent accesses to the protected data at those points.
Signed-off-by: Iago Abal <mail@iagoabal.eu>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2017-01-11 21:00:21 +08:00
|
|
|
spin_lock_irqsave(&pl330->lock, flags);
|
2013-07-04 06:00:43 +08:00
|
|
|
|
2014-07-07 02:32:26 +08:00
|
|
|
pl330_release_channel(pch->thread);
|
|
|
|
pch->thread = NULL;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-09-02 08:44:33 +08:00
|
|
|
if (pch->cyclic)
|
|
|
|
list_splice_tail_init(&pch->work_list, &pch->dmac->desc_pool);
|
|
|
|
|
dmaengine: pl330: fix double lock
The static bug finder EBA (http://www.iagoabal.eu/eba/) reported the
following double-lock bug:
Double lock:
1. spin_lock_irqsave(pch->lock, flags) at pl330_free_chan_resources:2236;
2. call to function `pl330_release_channel' immediately after;
3. call to function `dma_pl330_rqcb' in line 1753;
4. spin_lock_irqsave(pch->lock, flags) at dma_pl330_rqcb:1505.
I have fixed it as suggested by Marek Szyprowski.
First, I have replaced `pch->lock' with `pl330->lock' in functions
`pl330_alloc_chan_resources' and `pl330_free_chan_resources'. This avoids
the double-lock by acquiring a different lock than `dma_pl330_rqcb'.
NOTE that, as a result, `pl330_free_chan_resources' executes
`list_splice_tail_init' on `pch->work_list' under lock `pl330->lock',
whereas in the rest of the code `pch->work_list' is protected by
`pch->lock'. I don't know if this may cause race conditions. Similarly
`pch->cyclic' is written by `pl330_alloc_chan_resources' under
`pl330->lock' but read by `pl330_tx_submit' under `pch->lock'.
Second, I have removed locking from `pl330_request_channel' and
`pl330_release_channel' functions. Function `pl330_request_channel' is
only called from `pl330_alloc_chan_resources', so the lock is already
held. Function `pl330_release_channel' is called from
`pl330_free_chan_resources', which already holds the lock, and from
`pl330_del'. Function `pl330_del' is called in an error path of
`pl330_probe' and at the end of `pl330_remove', but I assume that there
cannot be concurrent accesses to the protected data at those points.
Signed-off-by: Iago Abal <mail@iagoabal.eu>
Reviewed-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
2017-01-11 21:00:21 +08:00
|
|
|
spin_unlock_irqrestore(&pl330->lock, flags);
|
2014-11-14 16:48:57 +08:00
|
|
|
pm_runtime_mark_last_busy(pch->dmac->ddma.dev);
|
|
|
|
pm_runtime_put_autosuspend(pch->dmac->ddma.dev);
|
2017-05-19 22:06:44 +08:00
|
|
|
pl330_unprep_slave_fifo(pch);
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
|
|
|
|
2015-03-16 19:52:44 +08:00
|
|
|
static int pl330_get_current_xferred_count(struct dma_pl330_chan *pch,
|
|
|
|
struct dma_pl330_desc *desc)
|
2015-02-11 20:23:17 +08:00
|
|
|
{
|
|
|
|
struct pl330_thread *thrd = pch->thread;
|
|
|
|
struct pl330_dmac *pl330 = pch->dmac;
|
|
|
|
void __iomem *regs = thrd->dmac->base;
|
|
|
|
u32 val, addr;
|
|
|
|
|
|
|
|
pm_runtime_get_sync(pl330->ddma.dev);
|
|
|
|
val = addr = 0;
|
|
|
|
if (desc->rqcfg.src_inc) {
|
|
|
|
val = readl(regs + SA(thrd->id));
|
|
|
|
addr = desc->px.src_addr;
|
|
|
|
} else {
|
|
|
|
val = readl(regs + DA(thrd->id));
|
|
|
|
addr = desc->px.dst_addr;
|
|
|
|
}
|
|
|
|
pm_runtime_mark_last_busy(pch->dmac->ddma.dev);
|
|
|
|
pm_runtime_put_autosuspend(pl330->ddma.dev);
|
2016-11-02 07:44:27 +08:00
|
|
|
|
|
|
|
/* If DMAMOV hasn't finished yet, SAR/DAR can be zero */
|
|
|
|
if (!val)
|
|
|
|
return 0;
|
|
|
|
|
2015-02-11 20:23:17 +08:00
|
|
|
return val - addr;
|
|
|
|
}
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
static enum dma_status
|
|
|
|
pl330_tx_status(struct dma_chan *chan, dma_cookie_t cookie,
|
|
|
|
struct dma_tx_state *txstate)
|
|
|
|
{
|
2015-02-11 20:23:17 +08:00
|
|
|
enum dma_status ret;
|
|
|
|
unsigned long flags;
|
2016-08-19 08:59:59 +08:00
|
|
|
struct dma_pl330_desc *desc, *running = NULL, *last_enq = NULL;
|
2015-02-11 20:23:17 +08:00
|
|
|
struct dma_pl330_chan *pch = to_pchan(chan);
|
|
|
|
unsigned int transferred, residual = 0;
|
|
|
|
|
|
|
|
ret = dma_cookie_status(chan, cookie, txstate);
|
|
|
|
|
|
|
|
if (!txstate)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
if (ret == DMA_COMPLETE)
|
|
|
|
goto out;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&pch->lock, flags);
|
2016-08-23 17:16:55 +08:00
|
|
|
spin_lock(&pch->thread->dmac->lock);
|
2015-02-11 20:23:17 +08:00
|
|
|
|
|
|
|
if (pch->thread->req_running != -1)
|
|
|
|
running = pch->thread->req[pch->thread->req_running].desc;
|
|
|
|
|
2016-08-19 08:59:59 +08:00
|
|
|
last_enq = pch->thread->req[pch->thread->lstenq].desc;
|
|
|
|
|
2015-02-11 20:23:17 +08:00
|
|
|
/* Check in pending list */
|
|
|
|
list_for_each_entry(desc, &pch->work_list, node) {
|
|
|
|
if (desc->status == DONE)
|
|
|
|
transferred = desc->bytes_requested;
|
|
|
|
else if (running && desc == running)
|
|
|
|
transferred =
|
|
|
|
pl330_get_current_xferred_count(pch, desc);
|
2016-08-19 08:59:59 +08:00
|
|
|
else if (desc->status == BUSY)
|
|
|
|
/*
|
|
|
|
* Busy but not running means either just enqueued,
|
|
|
|
* or finished and not yet marked done
|
|
|
|
*/
|
|
|
|
if (desc == last_enq)
|
|
|
|
transferred = 0;
|
|
|
|
else
|
|
|
|
transferred = desc->bytes_requested;
|
2015-02-11 20:23:17 +08:00
|
|
|
else
|
|
|
|
transferred = 0;
|
|
|
|
residual += desc->bytes_requested - transferred;
|
|
|
|
if (desc->txd.cookie == cookie) {
|
2015-03-16 19:52:45 +08:00
|
|
|
switch (desc->status) {
|
|
|
|
case DONE:
|
|
|
|
ret = DMA_COMPLETE;
|
|
|
|
break;
|
|
|
|
case PREP:
|
|
|
|
case BUSY:
|
|
|
|
ret = DMA_IN_PROGRESS;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
WARN_ON(1);
|
|
|
|
}
|
2015-02-11 20:23:17 +08:00
|
|
|
break;
|
|
|
|
}
|
|
|
|
if (desc->last)
|
|
|
|
residual = 0;
|
|
|
|
}
|
2016-08-23 17:16:55 +08:00
|
|
|
spin_unlock(&pch->thread->dmac->lock);
|
2015-02-11 20:23:17 +08:00
|
|
|
spin_unlock_irqrestore(&pch->lock, flags);
|
|
|
|
|
|
|
|
out:
|
|
|
|
dma_set_residue(txstate, residual);
|
|
|
|
|
|
|
|
return ret;
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
static void pl330_issue_pending(struct dma_chan *chan)
|
|
|
|
{
|
2014-01-12 03:08:38 +08:00
|
|
|
struct dma_pl330_chan *pch = to_pchan(chan);
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&pch->lock, flags);
|
2014-11-14 16:48:57 +08:00
|
|
|
if (list_empty(&pch->work_list)) {
|
|
|
|
/*
|
|
|
|
* Warn on nothing pending. Empty submitted_list may
|
|
|
|
* break our pm_runtime usage counter as it is
|
|
|
|
* updated on work_list emptiness status.
|
|
|
|
*/
|
|
|
|
WARN_ON(list_empty(&pch->submitted_list));
|
2016-12-16 18:39:11 +08:00
|
|
|
pch->active = true;
|
2014-11-14 16:48:57 +08:00
|
|
|
pm_runtime_get_sync(pch->dmac->ddma.dev);
|
|
|
|
}
|
2014-01-12 03:08:38 +08:00
|
|
|
list_splice_tail_init(&pch->submitted_list, &pch->work_list);
|
|
|
|
spin_unlock_irqrestore(&pch->lock, flags);
|
|
|
|
|
|
|
|
pl330_tasklet((unsigned long)pch);
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* We returned the last one of the circular list of descriptor(s)
|
|
|
|
* from prep_xxx, so the argument to submit corresponds to the last
|
|
|
|
* descriptor of the list.
|
|
|
|
*/
|
|
|
|
static dma_cookie_t pl330_tx_submit(struct dma_async_tx_descriptor *tx)
|
|
|
|
{
|
|
|
|
struct dma_pl330_desc *desc, *last = to_desc(tx);
|
|
|
|
struct dma_pl330_chan *pch = to_pchan(tx->chan);
|
|
|
|
dma_cookie_t cookie;
|
|
|
|
unsigned long flags;
|
|
|
|
|
|
|
|
spin_lock_irqsave(&pch->lock, flags);
|
|
|
|
|
|
|
|
/* Assign cookies to all nodes */
|
|
|
|
while (!list_empty(&last->node)) {
|
|
|
|
desc = list_entry(last->node.next, struct dma_pl330_desc, node);
|
2013-07-23 16:24:50 +08:00
|
|
|
if (pch->cyclic) {
|
|
|
|
desc->txd.callback = last->txd.callback;
|
|
|
|
desc->txd.callback_param = last->txd.callback_param;
|
|
|
|
}
|
2015-06-15 22:00:09 +08:00
|
|
|
desc->last = false;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2012-03-07 06:34:46 +08:00
|
|
|
dma_cookie_assign(&desc->txd);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-01-12 03:08:38 +08:00
|
|
|
list_move_tail(&desc->node, &pch->submitted_list);
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
|
|
|
|
2015-02-11 20:23:17 +08:00
|
|
|
last->last = true;
|
2012-03-07 06:34:46 +08:00
|
|
|
cookie = dma_cookie_assign(&last->txd);
|
2014-01-12 03:08:38 +08:00
|
|
|
list_add_tail(&last->node, &pch->submitted_list);
|
2010-05-24 11:28:19 +08:00
|
|
|
spin_unlock_irqrestore(&pch->lock, flags);
|
|
|
|
|
|
|
|
return cookie;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void _init_desc(struct dma_pl330_desc *desc)
|
|
|
|
{
|
|
|
|
desc->rqcfg.swap = SWAP_NO;
|
2014-07-07 02:32:19 +08:00
|
|
|
desc->rqcfg.scctl = CCTRL0;
|
|
|
|
desc->rqcfg.dcctl = CCTRL0;
|
2010-05-24 11:28:19 +08:00
|
|
|
desc->txd.tx_submit = pl330_tx_submit;
|
|
|
|
|
|
|
|
INIT_LIST_HEAD(&desc->node);
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Returns the number of descriptors added to the DMAC pool */
|
2017-10-04 19:37:23 +08:00
|
|
|
static int add_desc(struct list_head *pool, spinlock_t *lock,
|
|
|
|
gfp_t flg, int count)
|
2010-05-24 11:28:19 +08:00
|
|
|
{
|
|
|
|
struct dma_pl330_desc *desc;
|
|
|
|
unsigned long flags;
|
|
|
|
int i;
|
|
|
|
|
2013-12-03 02:01:30 +08:00
|
|
|
desc = kcalloc(count, sizeof(*desc), flg);
|
2010-05-24 11:28:19 +08:00
|
|
|
if (!desc)
|
|
|
|
return 0;
|
|
|
|
|
2017-10-04 19:37:23 +08:00
|
|
|
spin_lock_irqsave(lock, flags);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
for (i = 0; i < count; i++) {
|
|
|
|
_init_desc(&desc[i]);
|
2017-10-04 19:37:23 +08:00
|
|
|
list_add_tail(&desc[i].node, pool);
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
|
|
|
|
2017-10-04 19:37:23 +08:00
|
|
|
spin_unlock_irqrestore(lock, flags);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
return count;
|
|
|
|
}
|
|
|
|
|
2017-10-04 19:37:23 +08:00
|
|
|
static struct dma_pl330_desc *pluck_desc(struct list_head *pool,
|
|
|
|
spinlock_t *lock)
|
2010-05-24 11:28:19 +08:00
|
|
|
{
|
|
|
|
struct dma_pl330_desc *desc = NULL;
|
|
|
|
unsigned long flags;
|
|
|
|
|
2017-10-04 19:37:23 +08:00
|
|
|
spin_lock_irqsave(lock, flags);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2017-10-04 19:37:23 +08:00
|
|
|
if (!list_empty(pool)) {
|
|
|
|
desc = list_entry(pool->next,
|
2010-05-24 11:28:19 +08:00
|
|
|
struct dma_pl330_desc, node);
|
|
|
|
|
|
|
|
list_del_init(&desc->node);
|
|
|
|
|
|
|
|
desc->status = PREP;
|
|
|
|
desc->txd.callback = NULL;
|
|
|
|
}
|
|
|
|
|
2017-10-04 19:37:23 +08:00
|
|
|
spin_unlock_irqrestore(lock, flags);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
return desc;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct dma_pl330_desc *pl330_get_desc(struct dma_pl330_chan *pch)
|
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
struct pl330_dmac *pl330 = pch->dmac;
|
2011-10-24 17:43:11 +08:00
|
|
|
u8 *peri_id = pch->chan.private;
|
2010-05-24 11:28:19 +08:00
|
|
|
struct dma_pl330_desc *desc;
|
|
|
|
|
|
|
|
/* Pluck one desc from the pool of DMAC */
|
2017-10-04 19:37:23 +08:00
|
|
|
desc = pluck_desc(&pl330->desc_pool, &pl330->pool_lock);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
/* If the DMAC pool is empty, alloc new */
|
|
|
|
if (!desc) {
|
2017-10-04 19:37:23 +08:00
|
|
|
DEFINE_SPINLOCK(lock);
|
|
|
|
LIST_HEAD(pool);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2017-10-04 19:37:23 +08:00
|
|
|
if (!add_desc(&pool, &lock, GFP_ATOMIC, 1))
|
2010-05-24 11:28:19 +08:00
|
|
|
return NULL;
|
2017-10-04 19:37:23 +08:00
|
|
|
|
|
|
|
desc = pluck_desc(&pool, &lock);
|
|
|
|
WARN_ON(!desc || !list_empty(&pool));
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Initialize the descriptor */
|
|
|
|
desc->pchan = pch;
|
|
|
|
desc->txd.cookie = 0;
|
|
|
|
async_tx_ack(&desc->txd);
|
|
|
|
|
2014-07-07 02:32:30 +08:00
|
|
|
desc->peri = peri_id ? pch->chan.chan_id : 0;
|
2014-07-07 02:32:29 +08:00
|
|
|
desc->rqcfg.pcfg = &pch->dmac->pcfg;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
dma_async_tx_descriptor_init(&desc->txd, &pch->chan);
|
|
|
|
|
|
|
|
return desc;
|
|
|
|
}
|
|
|
|
|
|
|
|
static inline void fill_px(struct pl330_xfer *px,
|
|
|
|
dma_addr_t dst, dma_addr_t src, size_t len)
|
|
|
|
{
|
|
|
|
px->bytes = len;
|
|
|
|
px->dst_addr = dst;
|
|
|
|
px->src_addr = src;
|
|
|
|
}
|
|
|
|
|
|
|
|
static struct dma_pl330_desc *
|
|
|
|
__pl330_prep_dma_memcpy(struct dma_pl330_chan *pch, dma_addr_t dst,
|
|
|
|
dma_addr_t src, size_t len)
|
|
|
|
{
|
|
|
|
struct dma_pl330_desc *desc = pl330_get_desc(pch);
|
|
|
|
|
|
|
|
if (!desc) {
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_err(pch->dmac->ddma.dev, "%s:%d Unable to fetch desc\n",
|
2010-05-24 11:28:19 +08:00
|
|
|
__func__, __LINE__);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Ideally we should lookout for reqs bigger than
|
|
|
|
* those that can be programmed with 256 bytes of
|
|
|
|
* MC buffer, but considering a req size is seldom
|
|
|
|
* going to be word-unaligned and more than 200MB,
|
|
|
|
* we take it easy.
|
|
|
|
* Also, should the limit is reached we'd rather
|
|
|
|
* have the platform increase MC buffer size than
|
|
|
|
* complicating this API driver.
|
|
|
|
*/
|
|
|
|
fill_px(&desc->px, dst, src, len);
|
|
|
|
|
|
|
|
return desc;
|
|
|
|
}
|
|
|
|
|
|
|
|
/* Call after fixing burst size */
|
|
|
|
static inline int get_burst_len(struct dma_pl330_desc *desc, size_t len)
|
|
|
|
{
|
|
|
|
struct dma_pl330_chan *pch = desc->pchan;
|
2014-07-07 02:32:29 +08:00
|
|
|
struct pl330_dmac *pl330 = pch->dmac;
|
2010-05-24 11:28:19 +08:00
|
|
|
int burst_len;
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
burst_len = pl330->pcfg.data_bus_width / 8;
|
2014-11-08 02:05:18 +08:00
|
|
|
burst_len *= pl330->pcfg.data_buf_dep / pl330->pcfg.num_chan;
|
2010-05-24 11:28:19 +08:00
|
|
|
burst_len >>= desc->rqcfg.brst_size;
|
|
|
|
|
|
|
|
/* src/dst_burst_len can't be more than 16 */
|
2018-04-19 08:31:06 +08:00
|
|
|
if (burst_len > PL330_MAX_BURST)
|
|
|
|
burst_len = PL330_MAX_BURST;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
return burst_len;
|
|
|
|
}
|
|
|
|
|
2011-09-02 08:44:33 +08:00
|
|
|
static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic(
|
|
|
|
struct dma_chan *chan, dma_addr_t dma_addr, size_t len,
|
2012-03-09 04:35:13 +08:00
|
|
|
size_t period_len, enum dma_transfer_direction direction,
|
2014-08-01 18:20:10 +08:00
|
|
|
unsigned long flags)
|
2011-09-02 08:44:33 +08:00
|
|
|
{
|
2013-07-23 16:24:50 +08:00
|
|
|
struct dma_pl330_desc *desc = NULL, *first = NULL;
|
2011-09-02 08:44:33 +08:00
|
|
|
struct dma_pl330_chan *pch = to_pchan(chan);
|
2014-07-07 02:32:29 +08:00
|
|
|
struct pl330_dmac *pl330 = pch->dmac;
|
2013-07-23 16:24:50 +08:00
|
|
|
unsigned int i;
|
2011-09-02 08:44:33 +08:00
|
|
|
dma_addr_t dst;
|
|
|
|
dma_addr_t src;
|
|
|
|
|
2013-07-23 16:24:50 +08:00
|
|
|
if (len % period_len != 0)
|
2011-09-02 08:44:33 +08:00
|
|
|
return NULL;
|
|
|
|
|
2013-07-23 16:24:50 +08:00
|
|
|
if (!is_slave_direction(direction)) {
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_err(pch->dmac->ddma.dev, "%s:%d Invalid dma direction\n",
|
2011-09-02 08:44:33 +08:00
|
|
|
__func__, __LINE__);
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
2017-05-19 22:06:44 +08:00
|
|
|
if (!pl330_prep_slave_fifo(pch, direction))
|
|
|
|
return NULL;
|
|
|
|
|
2013-07-23 16:24:50 +08:00
|
|
|
for (i = 0; i < len / period_len; i++) {
|
|
|
|
desc = pl330_get_desc(pch);
|
|
|
|
if (!desc) {
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_err(pch->dmac->ddma.dev, "%s:%d Unable to fetch desc\n",
|
2013-07-23 16:24:50 +08:00
|
|
|
__func__, __LINE__);
|
2011-09-02 08:44:33 +08:00
|
|
|
|
2013-07-23 16:24:50 +08:00
|
|
|
if (!first)
|
|
|
|
return NULL;
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
spin_lock_irqsave(&pl330->pool_lock, flags);
|
2013-07-23 16:24:50 +08:00
|
|
|
|
|
|
|
while (!list_empty(&first->node)) {
|
|
|
|
desc = list_entry(first->node.next,
|
|
|
|
struct dma_pl330_desc, node);
|
2014-07-07 02:32:29 +08:00
|
|
|
list_move_tail(&desc->node, &pl330->desc_pool);
|
2013-07-23 16:24:50 +08:00
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
list_move_tail(&first->node, &pl330->desc_pool);
|
2013-07-23 16:24:50 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
spin_unlock_irqrestore(&pl330->pool_lock, flags);
|
2011-09-02 08:44:33 +08:00
|
|
|
|
2013-07-23 16:24:50 +08:00
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (direction) {
|
|
|
|
case DMA_MEM_TO_DEV:
|
|
|
|
desc->rqcfg.src_inc = 1;
|
|
|
|
desc->rqcfg.dst_inc = 0;
|
|
|
|
src = dma_addr;
|
2017-05-19 22:06:44 +08:00
|
|
|
dst = pch->fifo_dma;
|
2013-07-23 16:24:50 +08:00
|
|
|
break;
|
|
|
|
case DMA_DEV_TO_MEM:
|
|
|
|
desc->rqcfg.src_inc = 0;
|
|
|
|
desc->rqcfg.dst_inc = 1;
|
2017-05-19 22:06:44 +08:00
|
|
|
src = pch->fifo_dma;
|
2013-07-23 16:24:50 +08:00
|
|
|
dst = dma_addr;
|
|
|
|
break;
|
|
|
|
default:
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:30 +08:00
|
|
|
desc->rqtype = direction;
|
2013-07-23 16:24:50 +08:00
|
|
|
desc->rqcfg.brst_size = pch->burst_sz;
|
2018-04-19 08:31:06 +08:00
|
|
|
desc->rqcfg.brst_len = pch->burst_len;
|
2015-02-11 20:23:17 +08:00
|
|
|
desc->bytes_requested = period_len;
|
2013-07-23 16:24:50 +08:00
|
|
|
fill_px(&desc->px, dst, src, period_len);
|
|
|
|
|
|
|
|
if (!first)
|
|
|
|
first = desc;
|
|
|
|
else
|
|
|
|
list_add_tail(&desc->node, &first->node);
|
|
|
|
|
|
|
|
dma_addr += period_len;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!desc)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
pch->cyclic = true;
|
|
|
|
desc->txd.flags = flags;
|
2011-09-02 08:44:33 +08:00
|
|
|
|
|
|
|
return &desc->txd;
|
|
|
|
}
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
static struct dma_async_tx_descriptor *
|
|
|
|
pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
|
|
|
|
dma_addr_t src, size_t len, unsigned long flags)
|
|
|
|
{
|
|
|
|
struct dma_pl330_desc *desc;
|
|
|
|
struct dma_pl330_chan *pch = to_pchan(chan);
|
2015-05-26 03:10:05 +08:00
|
|
|
struct pl330_dmac *pl330;
|
2010-05-24 11:28:19 +08:00
|
|
|
int burst;
|
|
|
|
|
2011-07-26 05:05:04 +08:00
|
|
|
if (unlikely(!pch || !len))
|
2010-05-24 11:28:19 +08:00
|
|
|
return NULL;
|
|
|
|
|
2015-05-26 03:10:05 +08:00
|
|
|
pl330 = pch->dmac;
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
desc = __pl330_prep_dma_memcpy(pch, dst, src, len);
|
|
|
|
if (!desc)
|
|
|
|
return NULL;
|
|
|
|
|
|
|
|
desc->rqcfg.src_inc = 1;
|
|
|
|
desc->rqcfg.dst_inc = 1;
|
2014-07-07 02:32:30 +08:00
|
|
|
desc->rqtype = DMA_MEM_TO_MEM;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
/* Select max possible burst size */
|
2014-07-07 02:32:29 +08:00
|
|
|
burst = pl330->pcfg.data_bus_width / 8;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-11-08 02:05:17 +08:00
|
|
|
/*
|
|
|
|
* Make sure we use a burst size that aligns with all the memcpy
|
|
|
|
* parameters because our DMA programming algorithm doesn't cope with
|
|
|
|
* transfers which straddle an entry in the DMA device's MFIFO.
|
|
|
|
*/
|
|
|
|
while ((src | dst | len) & (burst - 1))
|
2010-05-24 11:28:19 +08:00
|
|
|
burst /= 2;
|
|
|
|
|
|
|
|
desc->rqcfg.brst_size = 0;
|
|
|
|
while (burst != (1 << desc->rqcfg.brst_size))
|
|
|
|
desc->rqcfg.brst_size++;
|
|
|
|
|
2014-11-08 02:05:17 +08:00
|
|
|
/*
|
|
|
|
* If burst size is smaller than bus width then make sure we only
|
|
|
|
* transfer one at a time to avoid a burst stradling an MFIFO entry.
|
|
|
|
*/
|
|
|
|
if (desc->rqcfg.brst_size * 8 < pl330->pcfg.data_bus_width)
|
|
|
|
desc->rqcfg.brst_len = 1;
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
desc->rqcfg.brst_len = get_burst_len(desc, len);
|
2015-06-15 16:25:16 +08:00
|
|
|
desc->bytes_requested = len;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
desc->txd.flags = flags;
|
|
|
|
|
|
|
|
return &desc->txd;
|
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
static void __pl330_giveback_desc(struct pl330_dmac *pl330,
|
2013-08-09 19:11:33 +08:00
|
|
|
struct dma_pl330_desc *first)
|
|
|
|
{
|
|
|
|
unsigned long flags;
|
|
|
|
struct dma_pl330_desc *desc;
|
|
|
|
|
|
|
|
if (!first)
|
|
|
|
return;
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
spin_lock_irqsave(&pl330->pool_lock, flags);
|
2013-08-09 19:11:33 +08:00
|
|
|
|
|
|
|
while (!list_empty(&first->node)) {
|
|
|
|
desc = list_entry(first->node.next,
|
|
|
|
struct dma_pl330_desc, node);
|
2014-07-07 02:32:29 +08:00
|
|
|
list_move_tail(&desc->node, &pl330->desc_pool);
|
2013-08-09 19:11:33 +08:00
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
list_move_tail(&first->node, &pl330->desc_pool);
|
2013-08-09 19:11:33 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
spin_unlock_irqrestore(&pl330->pool_lock, flags);
|
2013-08-09 19:11:33 +08:00
|
|
|
}
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
static struct dma_async_tx_descriptor *
|
|
|
|
pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
|
2011-10-14 01:04:23 +08:00
|
|
|
unsigned int sg_len, enum dma_transfer_direction direction,
|
2012-03-09 04:35:13 +08:00
|
|
|
unsigned long flg, void *context)
|
2010-05-24 11:28:19 +08:00
|
|
|
{
|
|
|
|
struct dma_pl330_desc *first, *desc = NULL;
|
|
|
|
struct dma_pl330_chan *pch = to_pchan(chan);
|
|
|
|
struct scatterlist *sg;
|
2011-09-02 08:44:30 +08:00
|
|
|
int i;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-10-24 17:43:11 +08:00
|
|
|
if (unlikely(!pch || !sgl || !sg_len))
|
2010-05-24 11:28:19 +08:00
|
|
|
return NULL;
|
|
|
|
|
2017-05-19 22:06:44 +08:00
|
|
|
if (!pl330_prep_slave_fifo(pch, direction))
|
|
|
|
return NULL;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
first = NULL;
|
|
|
|
|
|
|
|
for_each_sg(sgl, sg, sg_len, i) {
|
|
|
|
|
|
|
|
desc = pl330_get_desc(pch);
|
|
|
|
if (!desc) {
|
2014-07-07 02:32:29 +08:00
|
|
|
struct pl330_dmac *pl330 = pch->dmac;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_err(pch->dmac->ddma.dev,
|
2010-05-24 11:28:19 +08:00
|
|
|
"%s:%d Unable to fetch desc\n",
|
|
|
|
__func__, __LINE__);
|
2014-07-07 02:32:29 +08:00
|
|
|
__pl330_giveback_desc(pl330, first);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (!first)
|
|
|
|
first = desc;
|
|
|
|
else
|
|
|
|
list_add_tail(&desc->node, &first->node);
|
|
|
|
|
2011-10-14 01:04:23 +08:00
|
|
|
if (direction == DMA_MEM_TO_DEV) {
|
2010-05-24 11:28:19 +08:00
|
|
|
desc->rqcfg.src_inc = 1;
|
|
|
|
desc->rqcfg.dst_inc = 0;
|
2017-05-19 22:06:44 +08:00
|
|
|
fill_px(&desc->px, pch->fifo_dma, sg_dma_address(sg),
|
|
|
|
sg_dma_len(sg));
|
2010-05-24 11:28:19 +08:00
|
|
|
} else {
|
|
|
|
desc->rqcfg.src_inc = 0;
|
|
|
|
desc->rqcfg.dst_inc = 1;
|
2017-05-19 22:06:44 +08:00
|
|
|
fill_px(&desc->px, sg_dma_address(sg), pch->fifo_dma,
|
|
|
|
sg_dma_len(sg));
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
|
|
|
|
2011-09-02 08:44:30 +08:00
|
|
|
desc->rqcfg.brst_size = pch->burst_sz;
|
2018-04-19 08:31:06 +08:00
|
|
|
desc->rqcfg.brst_len = pch->burst_len;
|
2014-07-07 02:32:30 +08:00
|
|
|
desc->rqtype = direction;
|
2015-02-11 20:23:17 +08:00
|
|
|
desc->bytes_requested = sg_dma_len(sg);
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
|
|
|
|
|
|
|
/* Return the last desc in the chain */
|
|
|
|
desc->txd.flags = flg;
|
|
|
|
return &desc->txd;
|
|
|
|
}
|
|
|
|
|
|
|
|
static irqreturn_t pl330_irq_handler(int irq, void *data)
|
|
|
|
{
|
|
|
|
if (pl330_update(data))
|
|
|
|
return IRQ_HANDLED;
|
|
|
|
else
|
|
|
|
return IRQ_NONE;
|
|
|
|
}
|
|
|
|
|
2013-07-15 23:53:08 +08:00
|
|
|
#define PL330_DMA_BUSWIDTHS \
|
|
|
|
BIT(DMA_SLAVE_BUSWIDTH_UNDEFINED) | \
|
|
|
|
BIT(DMA_SLAVE_BUSWIDTH_1_BYTE) | \
|
|
|
|
BIT(DMA_SLAVE_BUSWIDTH_2_BYTES) | \
|
|
|
|
BIT(DMA_SLAVE_BUSWIDTH_4_BYTES) | \
|
|
|
|
BIT(DMA_SLAVE_BUSWIDTH_8_BYTES)
|
|
|
|
|
2014-11-18 19:17:56 +08:00
|
|
|
/*
|
|
|
|
* Runtime PM callbacks are provided by amba/bus.c driver.
|
|
|
|
*
|
|
|
|
* It is assumed here that IRQ safe runtime PM is chosen in probe and amba
|
|
|
|
* bus driver will only disable/enable the clock in runtime PM callbacks.
|
|
|
|
*/
|
|
|
|
static int __maybe_unused pl330_suspend(struct device *dev)
|
|
|
|
{
|
|
|
|
struct amba_device *pcdev = to_amba_device(dev);
|
|
|
|
|
|
|
|
pm_runtime_disable(dev);
|
|
|
|
|
|
|
|
if (!pm_runtime_status_suspended(dev)) {
|
|
|
|
/* amba did not disable the clock */
|
|
|
|
amba_pclk_disable(pcdev);
|
|
|
|
}
|
|
|
|
amba_pclk_unprepare(pcdev);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int __maybe_unused pl330_resume(struct device *dev)
|
|
|
|
{
|
|
|
|
struct amba_device *pcdev = to_amba_device(dev);
|
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = amba_pclk_prepare(pcdev);
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
|
|
|
if (!pm_runtime_status_suspended(dev))
|
|
|
|
ret = amba_pclk_enable(pcdev);
|
|
|
|
|
|
|
|
pm_runtime_enable(dev);
|
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
|
|
|
static SIMPLE_DEV_PM_OPS(pl330_pm, pl330_suspend, pl330_resume);
|
|
|
|
|
2012-11-20 02:22:55 +08:00
|
|
|
static int
|
2011-02-19 23:55:00 +08:00
|
|
|
pl330_probe(struct amba_device *adev, const struct amba_id *id)
|
2010-05-24 11:28:19 +08:00
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
struct pl330_config *pcfg;
|
|
|
|
struct pl330_dmac *pl330;
|
2013-03-05 17:25:31 +08:00
|
|
|
struct dma_pl330_chan *pch, *_p;
|
2010-05-24 11:28:19 +08:00
|
|
|
struct dma_device *pd;
|
|
|
|
struct resource *res;
|
|
|
|
int i, ret, irq;
|
2011-07-26 05:05:04 +08:00
|
|
|
int num_chan;
|
2016-01-22 19:06:46 +08:00
|
|
|
struct device_node *np = adev->dev.of_node;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2013-06-27 17:29:32 +08:00
|
|
|
ret = dma_set_mask_and_coherent(&adev->dev, DMA_BIT_MASK(32));
|
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
/* Allocate a new DMAC and its Channels */
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330 = devm_kzalloc(&adev->dev, sizeof(*pl330), GFP_KERNEL);
|
2016-06-08 01:38:41 +08:00
|
|
|
if (!pl330)
|
2010-05-24 11:28:19 +08:00
|
|
|
return -ENOMEM;
|
|
|
|
|
2014-11-06 19:39:47 +08:00
|
|
|
pd = &pl330->ddma;
|
|
|
|
pd->dev = &adev->dev;
|
|
|
|
|
2017-03-27 13:31:03 +08:00
|
|
|
pl330->mcbufsz = 0;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2016-01-22 19:06:46 +08:00
|
|
|
/* get quirk */
|
|
|
|
for (i = 0; i < ARRAY_SIZE(of_quirks); i++)
|
|
|
|
if (of_property_read_bool(np, of_quirks[i].quirk))
|
|
|
|
pl330->quirks |= of_quirks[i].id;
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
res = &adev->res;
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330->base = devm_ioremap_resource(&adev->dev, res);
|
|
|
|
if (IS_ERR(pl330->base))
|
|
|
|
return PTR_ERR(pl330->base);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
amba_set_drvdata(adev, pl330);
|
2011-09-02 08:44:29 +08:00
|
|
|
|
2013-11-08 17:50:24 +08:00
|
|
|
for (i = 0; i < AMBA_NR_IRQS; i++) {
|
2013-09-30 14:50:48 +08:00
|
|
|
irq = adev->irq[i];
|
|
|
|
if (irq) {
|
|
|
|
ret = devm_request_irq(&adev->dev, irq,
|
|
|
|
pl330_irq_handler, 0,
|
2014-07-07 02:32:29 +08:00
|
|
|
dev_name(&adev->dev), pl330);
|
2013-09-30 14:50:48 +08:00
|
|
|
if (ret)
|
|
|
|
return ret;
|
|
|
|
} else {
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
pcfg = &pl330->pcfg;
|
|
|
|
|
|
|
|
pcfg->periph_id = adev->periphid;
|
|
|
|
ret = pl330_add(pl330);
|
2010-05-24 11:28:19 +08:00
|
|
|
if (ret)
|
2013-09-04 22:40:17 +08:00
|
|
|
return ret;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
INIT_LIST_HEAD(&pl330->desc_pool);
|
|
|
|
spin_lock_init(&pl330->pool_lock);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
/* Create a descriptor pool of default size */
|
2017-10-04 19:37:23 +08:00
|
|
|
if (!add_desc(&pl330->desc_pool, &pl330->pool_lock,
|
|
|
|
GFP_KERNEL, NR_DEFAULT_DESC))
|
2010-05-24 11:28:19 +08:00
|
|
|
dev_warn(&adev->dev, "unable to allocate desc\n");
|
|
|
|
|
|
|
|
INIT_LIST_HEAD(&pd->channels);
|
|
|
|
|
|
|
|
/* Initialize channel parameters */
|
2017-03-27 13:31:03 +08:00
|
|
|
num_chan = max_t(int, pcfg->num_peri, pcfg->num_chan);
|
2012-04-09 07:26:19 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330->num_peripherals = num_chan;
|
2014-01-12 03:08:39 +08:00
|
|
|
|
treewide: kzalloc() -> kcalloc()
The kzalloc() function has a 2-factor argument form, kcalloc(). This
patch replaces cases of:
kzalloc(a * b, gfp)
with:
kcalloc(a * b, gfp)
as well as handling cases of:
kzalloc(a * b * c, gfp)
with:
kzalloc(array3_size(a, b, c), gfp)
as it's slightly less ugly than:
kzalloc_array(array_size(a, b), c, gfp)
This does, however, attempt to ignore constant size factors like:
kzalloc(4 * 1024, gfp)
though any constants defined via macros get caught up in the conversion.
Any factors with a sizeof() of "unsigned char", "char", and "u8" were
dropped, since they're redundant.
The Coccinelle script used for this was:
// Fix redundant parens around sizeof().
@@
type TYPE;
expression THING, E;
@@
(
kzalloc(
- (sizeof(TYPE)) * E
+ sizeof(TYPE) * E
, ...)
|
kzalloc(
- (sizeof(THING)) * E
+ sizeof(THING) * E
, ...)
)
// Drop single-byte sizes and redundant parens.
@@
expression COUNT;
typedef u8;
typedef __u8;
@@
(
kzalloc(
- sizeof(u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * (COUNT)
+ COUNT
, ...)
|
kzalloc(
- sizeof(u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(__u8) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(char) * COUNT
+ COUNT
, ...)
|
kzalloc(
- sizeof(unsigned char) * COUNT
+ COUNT
, ...)
)
// 2-factor product with sizeof(type/expression) and identifier or constant.
@@
type TYPE;
expression THING;
identifier COUNT_ID;
constant COUNT_CONST;
@@
(
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_ID)
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_ID
+ COUNT_ID, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (COUNT_CONST)
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * COUNT_CONST
+ COUNT_CONST, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_ID)
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_ID
+ COUNT_ID, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (COUNT_CONST)
+ COUNT_CONST, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * COUNT_CONST
+ COUNT_CONST, sizeof(THING)
, ...)
)
// 2-factor product, only identifiers.
@@
identifier SIZE, COUNT;
@@
- kzalloc
+ kcalloc
(
- SIZE * COUNT
+ COUNT, SIZE
, ...)
// 3-factor product with 1 sizeof(type) or sizeof(expression), with
// redundant parens removed.
@@
expression THING;
identifier STRIDE, COUNT;
type TYPE;
@@
(
kzalloc(
- sizeof(TYPE) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(TYPE) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(TYPE))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * (COUNT) * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * (STRIDE)
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
|
kzalloc(
- sizeof(THING) * COUNT * STRIDE
+ array3_size(COUNT, STRIDE, sizeof(THING))
, ...)
)
// 3-factor product with 2 sizeof(variable), with redundant parens removed.
@@
expression THING1, THING2;
identifier COUNT;
type TYPE1, TYPE2;
@@
(
kzalloc(
- sizeof(TYPE1) * sizeof(TYPE2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(TYPE2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(THING1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(THING1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * COUNT
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
|
kzalloc(
- sizeof(TYPE1) * sizeof(THING2) * (COUNT)
+ array3_size(COUNT, sizeof(TYPE1), sizeof(THING2))
, ...)
)
// 3-factor product, only identifiers, with redundant parens removed.
@@
identifier STRIDE, SIZE, COUNT;
@@
(
kzalloc(
- (COUNT) * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * STRIDE * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- (COUNT) * (STRIDE) * (SIZE)
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
|
kzalloc(
- COUNT * STRIDE * SIZE
+ array3_size(COUNT, STRIDE, SIZE)
, ...)
)
// Any remaining multi-factor products, first at least 3-factor products,
// when they're not all constants...
@@
expression E1, E2, E3;
constant C1, C2, C3;
@@
(
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(
- (E1) * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * E3
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- (E1) * (E2) * (E3)
+ array3_size(E1, E2, E3)
, ...)
|
kzalloc(
- E1 * E2 * E3
+ array3_size(E1, E2, E3)
, ...)
)
// And then all remaining 2 factors products when they're not all constants,
// keeping sizeof() as the second factor argument.
@@
expression THING, E1, E2;
type TYPE;
constant C1, C2, C3;
@@
(
kzalloc(sizeof(THING) * C2, ...)
|
kzalloc(sizeof(TYPE) * C2, ...)
|
kzalloc(C1 * C2 * C3, ...)
|
kzalloc(C1 * C2, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * (E2)
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(TYPE) * E2
+ E2, sizeof(TYPE)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * (E2)
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- sizeof(THING) * E2
+ E2, sizeof(THING)
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * E2
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- (E1) * (E2)
+ E1, E2
, ...)
|
- kzalloc
+ kcalloc
(
- E1 * E2
+ E1, E2
, ...)
)
Signed-off-by: Kees Cook <keescook@chromium.org>
2018-06-13 05:03:40 +08:00
|
|
|
pl330->peripherals = kcalloc(num_chan, sizeof(*pch), GFP_KERNEL);
|
2014-07-07 02:32:29 +08:00
|
|
|
if (!pl330->peripherals) {
|
2012-09-17 17:50:23 +08:00
|
|
|
ret = -ENOMEM;
|
2012-11-15 14:27:50 +08:00
|
|
|
goto probe_err2;
|
2012-09-17 17:50:23 +08:00
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2011-07-26 05:05:04 +08:00
|
|
|
for (i = 0; i < num_chan; i++) {
|
2014-07-07 02:32:29 +08:00
|
|
|
pch = &pl330->peripherals[i];
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2017-03-27 13:31:03 +08:00
|
|
|
pch->chan.private = adev->dev.of_node;
|
2014-01-12 03:08:38 +08:00
|
|
|
INIT_LIST_HEAD(&pch->submitted_list);
|
2010-05-24 11:28:19 +08:00
|
|
|
INIT_LIST_HEAD(&pch->work_list);
|
2013-08-28 02:34:05 +08:00
|
|
|
INIT_LIST_HEAD(&pch->completed_list);
|
2010-05-24 11:28:19 +08:00
|
|
|
spin_lock_init(&pch->lock);
|
2014-07-07 02:32:26 +08:00
|
|
|
pch->thread = NULL;
|
2010-05-24 11:28:19 +08:00
|
|
|
pch->chan.device = pd;
|
2014-07-07 02:32:29 +08:00
|
|
|
pch->dmac = pl330;
|
2017-05-19 22:06:44 +08:00
|
|
|
pch->dir = DMA_NONE;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
/* Add the channel to the DMAC list */
|
|
|
|
list_add_tail(&pch->chan.device_node, &pd->channels);
|
|
|
|
}
|
|
|
|
|
2017-03-27 13:31:03 +08:00
|
|
|
dma_cap_set(DMA_MEMCPY, pd->cap_mask);
|
|
|
|
if (pcfg->num_peri) {
|
|
|
|
dma_cap_set(DMA_SLAVE, pd->cap_mask);
|
|
|
|
dma_cap_set(DMA_CYCLIC, pd->cap_mask);
|
|
|
|
dma_cap_set(DMA_PRIVATE, pd->cap_mask);
|
2011-10-24 17:43:31 +08:00
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
pd->device_alloc_chan_resources = pl330_alloc_chan_resources;
|
|
|
|
pd->device_free_chan_resources = pl330_free_chan_resources;
|
|
|
|
pd->device_prep_dma_memcpy = pl330_prep_dma_memcpy;
|
2011-09-02 08:44:33 +08:00
|
|
|
pd->device_prep_dma_cyclic = pl330_prep_dma_cyclic;
|
2010-05-24 11:28:19 +08:00
|
|
|
pd->device_tx_status = pl330_tx_status;
|
|
|
|
pd->device_prep_slave_sg = pl330_prep_slave_sg;
|
2014-11-17 21:42:29 +08:00
|
|
|
pd->device_config = pl330_config;
|
2015-02-11 20:23:18 +08:00
|
|
|
pd->device_pause = pl330_pause;
|
2014-11-17 21:42:29 +08:00
|
|
|
pd->device_terminate_all = pl330_terminate_all;
|
2010-05-24 11:28:19 +08:00
|
|
|
pd->device_issue_pending = pl330_issue_pending;
|
2014-11-17 21:42:50 +08:00
|
|
|
pd->src_addr_widths = PL330_DMA_BUSWIDTHS;
|
|
|
|
pd->dst_addr_widths = PL330_DMA_BUSWIDTHS;
|
|
|
|
pd->directions = BIT(DMA_DEV_TO_MEM) | BIT(DMA_MEM_TO_DEV);
|
2015-02-11 20:23:17 +08:00
|
|
|
pd->residue_granularity = DMA_RESIDUE_GRANULARITY_SEGMENT;
|
2016-01-22 19:06:51 +08:00
|
|
|
pd->max_burst = ((pl330->quirks & PL330_QUIRK_BROKEN_NO_FLUSHP) ?
|
|
|
|
1 : PL330_MAX_BURST);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
ret = dma_async_device_register(pd);
|
|
|
|
if (ret) {
|
|
|
|
dev_err(&adev->dev, "unable to register DMAC\n");
|
2013-03-05 17:25:31 +08:00
|
|
|
goto probe_err3;
|
|
|
|
}
|
|
|
|
|
|
|
|
if (adev->dev.of_node) {
|
|
|
|
ret = of_dma_controller_register(adev->dev.of_node,
|
2014-07-07 02:32:29 +08:00
|
|
|
of_dma_pl330_xlate, pl330);
|
2013-03-05 17:25:31 +08:00
|
|
|
if (ret) {
|
|
|
|
dev_err(&adev->dev,
|
|
|
|
"unable to register DMA to the generic DT DMA helpers\n");
|
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
2013-11-25 23:07:46 +08:00
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
adev->dev.dma_parms = &pl330->dma_parms;
|
2013-11-25 23:07:46 +08:00
|
|
|
|
2013-09-03 00:24:48 +08:00
|
|
|
/*
|
|
|
|
* This is the limit for transfers with a buswidth of 1, larger
|
|
|
|
* buswidths will have larger limits.
|
|
|
|
*/
|
|
|
|
ret = dma_set_max_seg_size(&adev->dev, 1900800);
|
|
|
|
if (ret)
|
|
|
|
dev_err(&adev->dev, "unable to set the seg size\n");
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
dev_info(&adev->dev,
|
2014-11-07 01:20:12 +08:00
|
|
|
"Loaded driver for PL330 DMAC-%x\n", adev->periphid);
|
2010-05-24 11:28:19 +08:00
|
|
|
dev_info(&adev->dev,
|
|
|
|
"\tDBUFF-%ux%ubytes Num_Chans-%u Num_Peri-%u Num_Events-%u\n",
|
2014-07-07 02:32:29 +08:00
|
|
|
pcfg->data_buf_dep, pcfg->data_bus_width / 8, pcfg->num_chan,
|
|
|
|
pcfg->num_peri, pcfg->num_events);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-11-14 16:48:57 +08:00
|
|
|
pm_runtime_irq_safe(&adev->dev);
|
|
|
|
pm_runtime_use_autosuspend(&adev->dev);
|
|
|
|
pm_runtime_set_autosuspend_delay(&adev->dev, PL330_AUTOSUSPEND_DELAY);
|
|
|
|
pm_runtime_mark_last_busy(&adev->dev);
|
|
|
|
pm_runtime_put_autosuspend(&adev->dev);
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
return 0;
|
2013-03-05 17:25:31 +08:00
|
|
|
probe_err3:
|
|
|
|
/* Idle the DMAC */
|
2014-07-07 02:32:29 +08:00
|
|
|
list_for_each_entry_safe(pch, _p, &pl330->ddma.channels,
|
2013-03-05 17:25:31 +08:00
|
|
|
chan.device_node) {
|
|
|
|
|
|
|
|
/* Remove the channel */
|
|
|
|
list_del(&pch->chan.device_node);
|
|
|
|
|
|
|
|
/* Flush the channel */
|
2014-09-29 20:42:20 +08:00
|
|
|
if (pch->thread) {
|
2014-11-17 21:42:29 +08:00
|
|
|
pl330_terminate_all(&pch->chan);
|
2014-09-29 20:42:20 +08:00
|
|
|
pl330_free_chan_resources(&pch->chan);
|
|
|
|
}
|
2013-03-05 17:25:31 +08:00
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
probe_err2:
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330_del(pl330);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
return ret;
|
|
|
|
}
|
|
|
|
|
2012-12-22 07:09:59 +08:00
|
|
|
static int pl330_remove(struct amba_device *adev)
|
2010-05-24 11:28:19 +08:00
|
|
|
{
|
2014-07-07 02:32:29 +08:00
|
|
|
struct pl330_dmac *pl330 = amba_get_drvdata(adev);
|
2010-05-24 11:28:19 +08:00
|
|
|
struct dma_pl330_chan *pch, *_p;
|
2016-07-05 12:32:16 +08:00
|
|
|
int i, irq;
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-11-14 16:48:57 +08:00
|
|
|
pm_runtime_get_noresume(pl330->ddma.dev);
|
|
|
|
|
2013-03-05 17:25:31 +08:00
|
|
|
if (adev->dev.of_node)
|
|
|
|
of_dma_controller_free(adev->dev.of_node);
|
2013-02-14 11:40:07 +08:00
|
|
|
|
2016-07-05 12:32:16 +08:00
|
|
|
for (i = 0; i < AMBA_NR_IRQS; i++) {
|
|
|
|
irq = adev->irq[i];
|
2017-06-02 02:22:01 +08:00
|
|
|
if (irq)
|
|
|
|
devm_free_irq(&adev->dev, irq, pl330);
|
2016-07-05 12:32:16 +08:00
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
dma_async_device_unregister(&pl330->ddma);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
/* Idle the DMAC */
|
2014-07-07 02:32:29 +08:00
|
|
|
list_for_each_entry_safe(pch, _p, &pl330->ddma.channels,
|
2010-05-24 11:28:19 +08:00
|
|
|
chan.device_node) {
|
|
|
|
|
|
|
|
/* Remove the channel */
|
|
|
|
list_del(&pch->chan.device_node);
|
|
|
|
|
|
|
|
/* Flush the channel */
|
2014-09-29 20:42:21 +08:00
|
|
|
if (pch->thread) {
|
2014-11-17 21:42:29 +08:00
|
|
|
pl330_terminate_all(&pch->chan);
|
2014-09-29 20:42:21 +08:00
|
|
|
pl330_free_chan_resources(&pch->chan);
|
|
|
|
}
|
2010-05-24 11:28:19 +08:00
|
|
|
}
|
|
|
|
|
2014-07-07 02:32:29 +08:00
|
|
|
pl330_del(pl330);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2017-08-24 00:27:31 +08:00
|
|
|
static const struct amba_id pl330_ids[] = {
|
2010-05-24 11:28:19 +08:00
|
|
|
{
|
|
|
|
.id = 0x00041330,
|
|
|
|
.mask = 0x000fffff,
|
|
|
|
},
|
|
|
|
{ 0, 0 },
|
|
|
|
};
|
|
|
|
|
2011-10-05 22:15:20 +08:00
|
|
|
MODULE_DEVICE_TABLE(amba, pl330_ids);
|
|
|
|
|
2010-05-24 11:28:19 +08:00
|
|
|
static struct amba_driver pl330_driver = {
|
|
|
|
.drv = {
|
|
|
|
.owner = THIS_MODULE,
|
|
|
|
.name = "dma-pl330",
|
2014-11-18 19:17:56 +08:00
|
|
|
.pm = &pl330_pm,
|
2010-05-24 11:28:19 +08:00
|
|
|
},
|
|
|
|
.id_table = pl330_ids,
|
|
|
|
.probe = pl330_probe,
|
|
|
|
.remove = pl330_remove,
|
|
|
|
};
|
|
|
|
|
2012-03-15 17:40:38 +08:00
|
|
|
module_amba_driver(pl330_driver);
|
2010-05-24 11:28:19 +08:00
|
|
|
|
2014-12-05 21:37:49 +08:00
|
|
|
MODULE_AUTHOR("Jaswinder Singh <jassisinghbrar@gmail.com>");
|
2010-05-24 11:28:19 +08:00
|
|
|
MODULE_DESCRIPTION("API Driver for PL330 DMAC");
|
|
|
|
MODULE_LICENSE("GPL");
|