Message translation in scripts via $-prefix is bash-specific, but
check-rpaths is a /bin/sh script, drop the bashism. There are no
translations anyway so this is a no-op for all practial purposes.
Originally reported and fixed in Debian (DebBug:772404)
Prefer '[] && []' to '[ -a ]' and '[] || []' to '[ -o ]' in tests.
-a and -o to mean AND and OR in a [ .. ] test expression is not well
defined, and can cause incorrect results when arguments start with
dashes or contain !. Moreover binary -a and -o are inherently
ambiguous. test(1) man page recommends to use
'test EXPR1 && test EXPR2' or 'test EXPR1 || test EXPR2' instead.
It corrects warnings [SC2166] spotted by covscan.
- check-buildroot for checing buildroot files for references to $RPM_BUILD_ROOT
- check-rpaths* for checking buildroot files for broken rpaths
Scripts by Enrico Scholz, Ville Skyttä.
Michal Čihař