Roland McGrath
e6a0b0e566
Make debugedit -i recompute build ID only when any DWARF was actually changed.
2010-05-11 15:09:53 +03:00
Roland McGrath
c4b6362353
Whitespace fixups for tools/debugedit.c
2010-05-11 15:09:52 +03:00
Panu Matilainen
1d7e1f66e1
Plug dumb memleak in rpmpsMerge()
2010-05-07 20:24:01 +03:00
Panu Matilainen
6fc3cbefee
Fix breakage from removedPackages changing to hash
...
- tsmem->delta is still needed for tsmem->order reallocation,
zero delta causes funny effects on larger package sets (test suite
doesnt trigger this)
2010-05-07 20:22:53 +03:00
Panu Matilainen
775cbf8bf2
Revert back to rpmdbRemove() taking instance number instead of actual header
...
- On package reinstall (ie --replacepkgs) we only know the old header
by the instance number, and grabbing the header from the db in
psm as a special case for that is more trouble than just doing what
we always did.
- Reverts commit e16695e932
and unbreaks
the --replacepkgs test case
2010-05-07 15:25:38 +03:00
Panu Matilainen
f051801373
Convert rpmte internals to use the transaction pointer from element itself
2010-05-07 14:31:25 +03:00
Panu Matilainen
8f7c2d7063
Store pointer to transaction set in transaction elements
...
- unused now but allows various new things and more element "independency"
- eliminate the unused dboffset argument while at it
2010-05-07 14:16:18 +03:00
Florian Festi
0782ee6b71
Fix compiler warning in rpmhash Resize()
2010-05-07 13:06:40 +02:00
Florian Festi
fe6967d5a3
Remove no longer needed function intcmp()
2010-05-06 16:32:40 +02:00
Florian Festi
70e9b035ff
Convert tsmem->removedPackages to a hash table and remove rpmdbPruneIterator from the API
2010-05-06 16:07:56 +02:00
Florian Festi
9fad36f0ed
rpmhash: new Empty() function to remove all entries
2010-05-06 16:07:56 +02:00
Florian Festi
aafd8500d3
rpmhash: Accessor functions for the size and usage
2010-05-06 16:07:56 +02:00
Florian Festi
030f7dde13
rpmhash: Grow when hash table gets too full
...
Add some statistics to be able to find out how full the hash is
2010-05-06 16:07:56 +02:00
Panu Matilainen
869004e8fb
Move header filecount retrieve from addTE() to rpmfsNew()
2010-05-06 15:12:41 +03:00
Panu Matilainen
27869a5233
Tolerate NULL in rpmfsFree() and rpmfsFC()
...
- both are "can't happen" situations but easy to handle cleanly here...
2010-05-06 15:09:47 +03:00
Panu Matilainen
63dcd3d497
Minor cleanup to rpmfsNew()
...
- use xcalloc() to ensure clean state, no need to manually do it all
- group non-conditional and conditional operations together
2010-05-06 15:09:39 +03:00
Panu Matilainen
118fba2295
Move delTE() inline to rpmteFree()
...
- no point splitting this up, its just straightforward freeing of stuff
- dont bother with tonne of assigning everything to NULL, it gets
zeroed out by memset() anyway
2010-05-06 15:09:12 +03:00
Panu Matilainen
a9cb04fe1c
Unexport rpmteNew() and rpmteFree()
...
- the only meaningful way to create transaction elements is by adding things
to a transaction through rpmtsAddFooElement(), there's no need to
expose these and restrict our ability to change the API when needed
2010-05-06 14:09:41 +03:00
Panu Matilainen
d7c37d8a46
Minor cleanup to rpmReSign()
...
- headerNew() cannot fail, dont bother checking
- initialize variables on declaration
2010-05-06 12:32:08 +03:00
Panu Matilainen
834c838347
Fix minor header iterator leak in rpmReSign()
...
- fix dumb double-initialization error introduced somewhere between
4.4 and 4.6, also while-loop is more natural here than for-loop
2010-05-06 12:28:23 +03:00
Panu Matilainen
a592b14fe2
Clean up rpmcliImportPubkeys() a bit, no functional changes
...
- remove questionable rpmtsClean() call remnants from rpm 4.4.x days
when it used to clean the signature/digest data in ts but also
clean a pile of completely unrelated items
- rearrange the error code handling so we can get by with single place
of freeing the temp allocations
- move local variables to the scope where needed and eliminate unnecessary
ones
- remove redundant NULL check on argv, this is already done by caller
- remove unused qva argument (static function so no API implications)
2010-05-06 12:21:02 +03:00
Pavol Rusnak
3b96dfb29a
Don't process desktop files without Type=Application and Exec= line
2010-05-04 12:51:21 +03:00
Panu Matilainen
ed74161b7e
Rename python module version symbol to __version__, add __version_info__
...
- This seems to be a de-facto standard in python land, as rpm.version
hasn't been in any released version we can still change this easily.
Suggestion from James Antill.
2010-05-04 09:05:23 +03:00
Panu Matilainen
f2c4eebae0
Doh, dont shadow the rpmtsVerifyDB() return value
2010-04-29 15:51:41 +03:00
Giulio Eulisse
d131c3393a
Fixes missing __fxstat64 symbol on mac.
2010-04-29 10:30:43 +03:00
Panu Matilainen
40b275b4a7
Fix a few uninitialized variable cases found by clang-analyzer
2010-04-29 10:30:43 +03:00
Taylon Silmer
27086a3015
l10n: Updates to Portuguese (Brazilian) (pt_BR) translation
...
New status: 721 messages complete with 1 fuzzy and 0 untranslated.
Transmitted-via: Transifex (www.transifex.net).
2010-04-27 18:21:27 +00:00
Panu Matilainen
efe0ebcbc1
Protect rpmtsVerifyDB() with transaction lock
...
- BDB docs state that db->verify() doesn't perform any locking even
when used within an environment, and should only be used on files
that are not being modified by another thread of control. Grabbing
the transaction lock while verifying mostly ensures nobodys writing
to the db behind our back.
2010-04-22 13:48:58 +03:00
Panu Matilainen
a5f17bac34
Ditch "fcntl_locking" bdb config option
...
- This is an undocumented BDB interface (only documented in the db.h header),
and its not something users should be messing around with
2010-04-22 13:34:18 +03:00
Panu Matilainen
e7b0d96900
Make transaction lock path per-transaction
...
- Although it doesn't really happen in practise, rpm's API permits several
transactions with possibly differing roots within process lifetime.
Previously the lock path was calculated just once globally so we could
easily be locking in a completely wrong place (eg locking in a previously
accessed chroot when system rpmdb should be transaction-locked)
2010-04-22 12:23:24 +03:00
Panu Matilainen
1f625e69e9
Further generalize the rpmlock interface
...
- Move transaction lock path handling into rpmts.c, export new low
level rpmlockAcquire() function to actually grab a lock
- Rename rpmtsFreeLock() to rpmlockFree() and return NULL in the
general rpm style
2010-04-22 11:01:27 +03:00
Panu Matilainen
d2810bdc52
Generalize rpmlock_new() by moving transaction lock path calculation out
2010-04-22 10:44:38 +03:00
Panu Matilainen
35c563af8c
Make rpmlock type visible inside rpm, use instead of void*
2010-04-22 10:37:51 +03:00
Panu Matilainen
fb772e2cad
Lose the useless header refcounting debug junk
...
- one more of these still left behind.. pff
2010-04-21 13:00:43 +03:00
Rakesh Pandit
8cc740c43f
Eliminate unused "known problems" based filtering from rpmtsRun()
...
- This mechanism has never been used by anything at all, which suggests
its not a particularly useful feature
- Removing unused rpmpsTrim() from rpmps
- Marking okProbs parameter of rpmtsRun() function as unused to avoid
unnecessary breakage
2010-04-21 12:03:09 +03:00
Alexey Tourbin
c0ab315e71
rpmdb.c (dbiOpen): fix dbix condition
...
In the loop, dbix is always initialized to 0, so checking (dbix < 0)
is uselss. Insetead, we sould check (dbix >= dbiTagsMax).
2010-04-21 11:53:25 +03:00
Panu Matilainen
da6e66a9b2
Only check the type of dependency requested in checkInstDeps()
...
- This gets called separately for requires, conflicts and obsoletes,
wth should it loop over conflicts when looking for requires?
2010-04-21 11:53:19 +03:00
Panu Matilainen
a0ed26b894
Add a basic reinstall test to test-suite
...
- this currently fails due to commit e16695e932
,
on reinstall element header vs db header mismatch, adding this as
a reminder to fix it...
2010-04-21 11:52:24 +03:00
Panu Matilainen
97a8544322
...but make sure the pre-requisite isn't also an erasure-dependency
...
- fixes eg Requires(pre,postun) case which must not be filtered out here
2010-04-14 09:22:07 +03:00
Panu Matilainen
2e03c07db7
Pre-requisites of installed packages dont need to be verified (RhBug:223642)
2010-04-14 09:05:55 +03:00
Panu Matilainen
dcaec34d3f
Update a few tag descriptions + visibility
...
- RPMTAG_CAPABILITY and RPMTAG_RHNPLATFORM are truly obsolete and
should've been taken out a long time ago
2010-04-13 08:50:08 +03:00
Panu Matilainen
a761daa2f8
Use correct tag for NOPATCH
...
- dumb copy-paste error from commit a317eaadc3
2010-04-13 08:35:45 +03:00
Panu Matilainen
538ddff69c
RPMTAG_NOSOURCE and NOPATCH aren't internal, they end up in nosrc headers
2010-04-13 08:32:49 +03:00
Michael Schroeder
b2efc89d7d
Gnu tar sometimes prints a "tar: Record size = 16" message, breaking
...
rpmbuild -ta.
2010-04-12 12:12:46 +02:00
Michael Schroeder
dfa98e7a06
Adapt the Makefile as rpmdb_svc can no longer be built.
2010-04-12 12:11:56 +02:00
Michael Schroeder
18c3e1a37c
New gcc versions comlpain about undefined behaviour...
2010-04-12 12:11:05 +02:00
Michael Schroeder
daec6ebf58
readLineFromOFI may modify the fileStack, thus we have to re-set
...
ofi after calling it
2010-04-12 12:10:20 +02:00
Michael Schroeder
cad147070e
Do not load keyring if signature checking is disabled.
2010-04-12 12:09:04 +02:00
Michael Schroeder
64e7f2aeb4
Seems like a change was made to make %attr(-) go back to the
...
defattr setting. Unfortunatelly this broke %defattr(-).
2010-04-12 12:07:01 +02:00
Panu Matilainen
1b78a6974d
Clean up dbiOpen() a bit
...
- eliminate now redundant rc-condition, move local variables to the
scope their used in
2010-04-09 16:36:17 +03:00