Digests are not signatures even if they reside in "signature" header,
and signing a package must not affect the digests. So recalculating
digests on signing is not just wasteful, but also conceptually plain
wrong.
Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
- The sed-munger added in commit ccd6281e69
causes bigger breakage than it fixes, perhaps because the hammer
applied was disproportionally large. The only thing needing adjustment
is ${prefix} in case when localstatedir is not explicitly set, so
we fixup just that instead of "everything".
- Discovered via RhBug:921973 testing
- Overriding architecture default ABI is not something rpm upstream
should do, such decisions belong to distro level.
- -fsigned-char was originally added in back in 1997 with little
fanfare in commit 3cb5b141d5, for
whatever it is worth...
- Work around scoping "fun" wrt nested parametrized macro invocations
combined with macro manipulation from %{lua:...}
Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
- Similar to "%autosetup -S git", but assumes git-formatted patch files
and hence preserves authorship information and commit messages.
Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
- What was I thinking? Trying to be lazy in a way that only created
more work, and broke with rpmfiles addition in whats most certainly
a non-obvious way. Duh.
- These platform specific scripts haven't been properly maintained
in over ten years, its way past time to get rid of these scripts
that forever confuse packagers as they assume these are actually
being used for something.
- Sure there's theoretical portability loss here, but judging by the
number of updates to these platforms over the last 10+ years... its
indeed theoretical. Any such portability issues just need to be
brought into the world of the "internal" dependency generator finally.
- Replace platform specific find-{requires,provides} scripts with
trivial wrapper scripts that just call rpmdeps with suitable
arguments. This way the generated dependencies using the legacy
external dependency are at least roughly on par with the internal
depgen as, well, they're generated by the same thing.
- Changing from find-{requires,provides} scripts to rpmdeps could
be done by just changing __find_{requires,provides} macros, but
a lot of packages directly refer to the scripts instead so this
way we cover far more ground and in an backwards compatible way.
- In the current macro implementation the check is simply far too
expensive to leave on always. Its useful though, so enable it
when tracing macro expansion, in which case you're probably
troubleshooting some macro-issues...
- Installation of binaries and sources are very different types of
operations, this makes it more obvious when mixing binaries and
sources in -U/-i operation. The progress report for sources is
not identical to binaries but at least it doesn't exceed 100%.
- Combining src.rpm and binary install in the same command is more
likely a mistake than intended, but preserving the functionality
in case somebody relies on it.
- Without this, plugins wouldn't have the slightest clue which package
a %pretrans, %posttrans or %verify script belongs to.
- Whether everything is properly initialized in the %verifyscript context
remains to be seen...
- When the world changes underneath us (eg by %pretrans hackery)
between test-transaction and actual transaction, in some cases
the file action does not get recomputed if already set.
Always reset file actions to FA_UNKNOWN before disposition
calculations to ensure have a clean starting point.
- Perhaps not such a big deal, but this makes rpmPackageFilesInstall()
and rpmPackageFilesRemove() interfaces identical, which could be
useful. In any case there's no particular reason this code should
be in psm either..
- Split the remains into two separate install/erase functions where
the logic is actually far easier to follow. Funny that.
- Since the code heavily relies on using break statement, move it
into a one-shot while loop to avoid having to change it all at once.
- Supposedly no functional changes here.
- Since rc will always be RPMRC_OK from entry to rpmpsmNext(), the
error path can never happen. It might've been possible to activate
in the past where rc was taken from psm->rc but nobody has
missed this particular error in several years so... might as well
axe it.
- Like %pre- and %posttrans, %verifyscript has always been a bit of
an oddball and always received 0 as $1 script argument. It does
seem kinda reasonable to pass the number of installed instances
here too - another note in release notes needed as there are
compatibility implications.
- Test %verifyscript in the scripts argument testcase too
- $1 argument to both %pretrans and %posttrans has been broken (always 0)
since the introduction of these scriptlets. Make them behave like
other scripts, duh.
- In theory its possible this breaks somebody's scriptlets, although its
hard to imagine why anybody would be checking for $1 which always
has value of 0. Anyway, certainly needs mentioning in release notes.
- Update scriptlet test to match the new expectations.
Lubos Kardos