Commit Graph

6 Commits

Author SHA1 Message Date
Pavlina Moravcova Varekova e9c13c6565 Eliminate use of ambiguous logical operators in script conditionals
Prefer '[] && []' to '[ -a ]' and '[] || []' to '[ -o ]' in tests.
-a and -o to mean AND and OR in a [ .. ] test expression is not well
defined, and can cause incorrect results when arguments start with
dashes or contain !. Moreover binary -a and -o are inherently
ambiguous. test(1) man page recommends to use
'test EXPR1 && test EXPR2' or 'test EXPR1 || test EXPR2' instead.

It corrects warnings [SC2166] spotted by covscan.
2019-08-21 14:09:37 +03:00
Florian Festi f23af97c41 Make check-buildroot check the build files in parallel
Thanks to Denys Vlasenko for pointing this out in rhbz#1704353
2019-05-06 16:22:23 +03:00
Ville Skyttä 6331fec6e4 Honor $TMPDIR in various scripts.
Signed-off-by: Panu Matilainen <pmatilai@redhat.com>
2011-04-13 14:49:36 +03:00
Panu Matilainen f0f94cc9df Remove pointless message translation from check-buildroot
- these scripts aren't processed for translation and unlikely to ever be...
- fixes the remaining complaint from ticket #62
2009-11-27 15:13:43 +02:00
Panu Matilainen 21b6c0af17 Don't exempt *.jar.so.debug from buildroot checks (rhbz#442264)
- jar-kludge no longer necessary...

Patch from Ville Skyttä
2008-04-15 13:13:40 +03:00
Panu Matilainen b95a206f14 Include additional buildroot sanity check scripts (rhbz#245639)
- check-buildroot for checing buildroot files for references to $RPM_BUILD_ROOT
- check-rpaths* for checking buildroot files for broken rpaths

Scripts by Enrico Scholz, Ville Skyttä.
2007-07-04 15:06:20 +03:00