de00e073c8
Eliminate Yet Another temporary result variable
2009-03-10 13:38:26 +02:00
a526d10e4f
Further rpmVerifySignatures() cleanup
...
- initialize variables at declaration time
- split the formatting of the result spew into separate function
- if multiple missing/bad keys, report them all
2009-03-10 13:33:57 +02:00
24c14d0a2e
Assume failure in rpmVerifySignatures()
...
- simplifies the code a bit
2009-03-10 12:10:49 +02:00
4ffdc83282
Use rstrcat() instead of rasprintf(), less fuss involved
2009-03-10 11:09:35 +02:00
05e16d4154
Fix memleak on signature checking failure
...
- early exit from header iteration loop could previously leak from unfreed
buf and header iterator
2009-03-10 11:03:08 +02:00
493913ed41
Eliminate pointless {} block inflating indentation level
...
- no functional changes
2009-03-10 11:01:32 +02:00
65f3e55d35
Don't return data from headerGet() on regionSwab() failure
...
- callers dont expect to free data if headerGet() returns failure,
leaking memory
2009-03-10 10:17:13 +02:00
74c9a96c3c
Port XZ payload compression to xz-4.999.8 API
...
- use SHA256 digests for archive error detection
- use 100MiB peak memory usage for decoding
- use better XZ detection in configure.ac
2009-03-09 20:20:42 +01:00
f70830356f
Add test for _install_lang and status
2009-03-09 16:44:47 +02:00
cdcbd324fe
Unbreak %_install_langs handling (rhbz#489235)
...
- using rpmfiFLangs() in skipFiles() broke the %_install_langs logic,
causing all files to be skipped if install langs, eek
2009-03-09 14:57:46 +02:00
2b4507d852
Fix RPMTAG_FILESTATES in rpmdb
...
- sizeof(rpmfileState) != sizeof(char), and char is what goes to headers
resulting in some pretty weird states despite being correct on disk
- add rpm_fstate_t type for the header presentation of states and
use where appropriate
2009-03-09 14:48:47 +02:00
1c1faec7a3
Initialize on declaration, cosmetics only...
2009-03-09 10:45:03 +02:00
37f85b81bb
Dont bother retrieving colors unless actually needed
2009-03-09 10:44:57 +02:00
a526ff75f4
Dont bother retrieving ts problem set unless actually needed
2009-03-09 10:44:51 +02:00
90582c6103
Dont bother retrieving altNEVR unless actually needed
2009-03-09 10:44:45 +02:00
ac7c341227
Load macros before creating directories (rhbz#489104)
...
- %_sourcedir and friends can have things like %{name}, load macros
before trying to create any directories when installing src.rpms
2009-03-08 11:33:22 +02:00
e9cc481202
Document libcap, libacl in INSTALL
2009-03-06 13:43:17 +02:00
095e1ba71d
Condense "shut up gcc" switch-cases to just default no action case
2009-03-04 15:12:02 +02:00
dc5fa25458
Add internal helper to verify signature parse results
...
- eliminates bunch of copy-paste variants of the same thing
- additionally verify pgpPrtPkts() return code
2009-03-04 15:07:04 +02:00
c7fc09d585
Move the common part of DSA+RSA verification into helper function
2009-03-04 14:40:21 +02:00
5cb107b843
Dont leak memory from hdrmd5ctx
2009-03-04 13:41:27 +02:00
d50db40cee
Handle V4 signature trailer for RSA too (ticket #34 )
2009-03-04 13:08:30 +02:00
682b3d8aa9
verifySHA1Signature() doesn't need pgpDig at all
2009-03-04 12:20:44 +02:00
a54ab2c1b9
verifyMD5Signature() doesn't need pgpDig at all
2009-03-04 12:19:02 +02:00
baac9bd4f8
verifySizeSignature() only needs size, not all of pgpDig
2009-03-04 12:17:21 +02:00
30f60665bb
Eliminate unnecessary fields from pgpDig_s
...
- sha1(len) and md5(len) are only needed and used locally in
verify[DR]SASignature(), no point carrying them around in pgpDig
- use wrapper function to hide type differences between rpm and NSS
2009-03-04 11:49:29 +02:00
d39a6c7de5
Add ISA bits for alpha (Oliver Falk)
2009-03-03 08:49:00 +02:00
c45cfb9c04
Fix documentation and help for the md5 -> filedigest move
...
- add aliases for obsolete {RPM}VERIFY_MD5 flags to
not to break API
2009-03-02 10:29:05 +01:00
7acdfded4a
Add md5->filedigest aliases (rhbz#487597)
...
- add %verify(nofiledigest) as %verify(nomd5) file attribute alias
- reference digests as digests not checksums
- make old md5 related symbols obsolete and use newer reference
- update man page accordingly
2009-02-27 14:34:39 +01:00
299a7af7a8
Missing test material to tarballs, oops
2009-02-26 21:48:06 +02:00
fca96226f9
Permit python bytecompile to fail for now
...
- various things like python templates in packages, jython code etc
blow up on the syntax checking, only warn instead of failing the build
until parametrized with a spec override possibility
2009-02-26 17:07:39 +02:00
0e6c5e8904
Honor --nomanifest on install too
...
- bit of a kludge but works.. and fixes test case 39
2009-02-26 16:38:10 +02:00
caf759f8ca
Switch to libtool versioning, starting at 0:0:0
2009-02-26 16:09:51 +02:00
3448b55296
Handle empty argv passed to rpmdsDupArgv()
...
- same as 94552b9625
2009-02-26 10:49:38 +02:00
f698570574
Clean up runTransScripts() a bit
...
- move progtag figuring out of the loop, and return with error code
instead of asserting on invalid tag
2009-02-24 14:24:40 +02:00
493275977c
Single point of exit from rpmtsRun()
2009-02-24 13:55:27 +02:00
8fd5ed25b4
Split initialization of flags etc out of rpmtsRun()
2009-02-24 13:41:18 +02:00
8dff47155a
Formatting cosmetics only
2009-02-24 12:35:21 +02:00
690a297ec0
Calculate need to chroot just once
2009-02-24 12:31:22 +02:00
750a8e6562
Eliminate unnecessary variable
...
- per-fi filecount only used once per loop for stats
2009-02-24 12:22:21 +02:00
720a8ebe31
Push fingerprinting chroot in+out into rpmtsPrepare() too
...
- rpmtsPrepare() can now fail (for chroot), handle exit
2009-02-24 12:13:26 +02:00
a309664ba3
Push the rest of the prepare-calculations down to rpmtsPrepare()
...
- total file count only needed during prepare, pass around as necessary
- all fingerprinting related activity (skipping files, memory allocations
etc) are now handled locally from rpmtsPrepare()
- throw out some ancient no longer relevant comments
2009-02-24 11:50:23 +02:00
924a5d82f6
Eliminate fingerprint hash from ts struct
...
- only prepare stage needs, alloc+free locally and pass around to
helpers as necessary
2009-02-24 11:23:25 +02:00
9e90602693
Split fingerprinting stuff out of rpmtsRun()
...
- only prepare stage needs fingerprint associated caches and hashes,
push the allocations where needed
- do fingerprint additions in separate function
2009-02-24 11:15:53 +02:00
15f17c4b48
Split prepare phase out of rpmtsRun()
2009-02-24 10:40:43 +02:00
ddf1df4abf
File skipping only done for added packages, simplify
2009-02-24 10:28:27 +02:00
3bf701761e
Eliminate unused variables
...
- numAdded and numRemoved not used for anything at all
2009-02-24 10:24:10 +02:00
68995d5238
Split sanity checking out of rpmtsRun() to helper function
...
- with file counting done elsewhere, this becomes a clean and obvious split
- ensureOlder() doesn't need ts, just needs the problem set, simplifies
the problem set refcounting a bit
2009-02-24 10:13:43 +02:00
1cce1b2444
Fix memory leak from unused problem set
...
- checkInstalledFiles() doesn't need ps for anything, this just caused
a memleak due to refcount
2009-02-24 10:10:38 +02:00
62d27e0bd5
Calculate files in transaction just once
...
- move file counting from rpmtsRun() and rpmFindBaseNamesInDB() to single
helper, store result in rpmts struct
2009-02-24 09:21:20 +02:00
Panu Matilainen