folkslinux
/
rpm
mirror of https://github.com/rpm-software-management/rpm.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Blargh, more fdFree() braindamage 

- Commit 429b933b42 fixes the fd-leak
  regression in rpm 4.10, but we already have code which relies
  on the new behavior and segfaults with the former one. Adjust
  rpmcpioClose() to the old behavior to get master tree back to
  working shape. TODO: fix this properly some rainy day (oh and see
  http://geekandpoke.typepad.com/geekandpoke/2012/08/likelihood.html)
This commit is contained in:
Panu Matilainen 2012-08-17 13:09:19 +03:00
parent 429b933b42
commit d6b925342f
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
lib/cpio.c
View File

@ -335,7 +335,8 @@ int rpmcpioClose(rpmcpio_t cpio)
if ((cpio->mode & O_ACCMODE) == O_WRONLY) { if ((cpio->mode & O_ACCMODE) == O_WRONLY) {
rc = rpmcpioTrailerWrite(cpio); rc = rpmcpioTrailerWrite(cpio);
} }
cpio->fd = fdFree(cpio->fd); fdFree(cpio->fd);
cpio->fd = NULL;
return rc; return rc;
} }