Remove bunch of unnecessary misc.h includes, document others

build/files.c

@@ -30,7 +30,7 @@
 #include "buildio.h"
 
 #include "legacy.h"	/* XXX domd5, expandFileList, compressFileList */
-#include "misc.h"
+#include "misc.h"	/* for splitString, freeSplitString */
 #include "rpmerr.h"
 #include "debug.h"
 

lib/manifest.c

@@ -9,7 +9,6 @@
 
 #include "stringbuf.h"
 #include "manifest.h"
-#include "misc.h"
 #include "debug.h"
 
 

lib/package.c

@@ -11,7 +11,6 @@
 
 #include "rpmts.h"
 
-#include "misc.h"	/* XXX stripTrailingChar() */
 #include "legacy.h"	/* XXX legacyRetrofit() */
 #include "rpmlead.h"
 

lib/psm.c

@@ -29,7 +29,7 @@
 #include "rpmlead.h"		/* writeLead proto */
 #include "signature.h"		/* signature constants */
 #include "legacy.h"		/* XXX rpmfiBuildFNames() */
-#include "misc.h"		/* XXX stripTrailingChar() */
+#include "misc.h"		/* XXX rpmMkdirPath, makeTempFile, doputenv */
 #include "rpmdb.h"		/* XXX for db_chrootDone */
 #include "rpmerr.h"
 #include "debug.h"

lib/query.c

@@ -21,7 +21,7 @@
 #include "rpmerr.h"
 
 #include "debug.h"
-#include "misc.h"
+#include "misc.h"	/* XXX for currentDirectory */
 
 
 /**

lib/rpmps.c

@@ -8,7 +8,6 @@
 
 #include "rpmps.h"
 
-#include "misc.h"
 #include "debug.h"
 
 /**

lib/rpmrc.c

@@ -19,7 +19,6 @@
 #include "rpmlua.h"
 
 #include "rpmerr.h"
-#include "misc.h"
 #include "debug.h"
 
 static const char *defrcfiles = 

lib/transaction.c

@@ -28,7 +28,7 @@
 #include "cpio.h"
 #include "fprint.h"
 #include "legacy.h"	/* XXX domd5 */
-#include "misc.h" /* XXX stripTrailingChar, splitString, currentDirectory */
+#include "misc.h" /* XXX (free)splitString, currentDirectory */
 
 #include "debug.h"
 

lib/trb.c

@@ -1,6 +1,5 @@
 #include "system.h"
 #include "rpmcli.h"
-#include "misc.h"
 #include "rpmts.h"
 
 #include "debug.h"

python/header-py.c

@@ -7,7 +7,6 @@
 #include "rpmlib.h"
 
 #include "legacy.h"
-#include "misc.h"
 
 #include "rpmts.h"	/* XXX rpmtsCreate/rpmtsFree */
 

rpmdb/legacy.c

@@ -21,7 +21,7 @@
 #include "rpmlead.h"
 #include "rpmlib.h"
 #include "rpmmacro.h"
-#include "misc.h"
+#include "misc.h"	/* XXX stripTrailingChar */
 #include "legacy.h"
 #include "debug.h"
 

tools/rpmcache.c

@@ -15,8 +15,9 @@ const char *__progname;
 #include "rpmds.h"
 #include "rpmts.h"
 
+#include "misc.h"	/* for rpmMkdirPath */
+
 #include "debug.h"
-#include "misc.h"
 
 static int _debug = 0;
 

tools/rpmgraph.c

@@ -11,7 +11,6 @@ const char *__progname;
 #include "rpmts.h"
 
 #include "manifest.h"
-#include "misc.h"		/* rpmGlob */
 #include "rpmerr.h"
 #include "debug.h"
 

tools/rpmsort.c

@@ -11,7 +11,6 @@ const char *__progname;
 #include "rpmts.h"
 
 #include "manifest.h"
-#include "misc.h"
 #include "rpmerr.h"
 #include "debug.h"