folkslinux
/
rpm
mirror of https://github.com/rpm-software-management/rpm.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Change the default crypto implementation to libgcrypt (from NSS) 

libgcrypt is a much more straightforward and lightweight as a library,
doesn't come with a massive runtime library of its own, runtime which
messes with SIGPIPE and all, has a nice clearly compatible license (LGPL)
and is somewhat faster than NSS. What's not to like?

Change the default and add relevant documentation to INSTALL. Drop
the hopefully now unnecessary override from distcheck flags, and
switch CI over too. Note that in CI, openssl-devel is still needed
for ima-evm (missing dep in ima-evm-utils-devel?)
This commit is contained in:
Panu Matilainen 2019-09-10 11:05:03 +03:00
parent 22c26c7444
commit 5c0801a1a3
4 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
INSTALL
View File

@ -10,9 +10,12 @@ The source for the file utility + library is available from
ftp://ftp.astron.com/pub/file/ ftp://ftp.astron.com/pub/file/
You will need a cryptographic library to support digests and signatures. You will need a cryptographic library to support digests and signatures.
This library may be Mozilla NSS, OpenSSL or beecrypt. Which library to use This library may be libgcrypt, Mozilla NSS, OpenSSL or beecrypt.
must be specified with the --with-crypto=[beecrypt|nss|openssl] argument Which library to use can be specified with the
to configure. --with-crypto=[libgcrypt|beecrypt|nss|openssl] argument to configure,
libgcrypt is the default.
libgcrypt library is available from https://www.gnupg.org/software/libgcrypt/
If using the Mozilla NSS library for encyption (and NSPR library which If using the Mozilla NSS library for encyption (and NSPR library which
NSS uses) it must be version 3.12 or later. Both NSPR and NSS libraries and NSS uses) it must be version 3.12 or later. Both NSPR and NSS libraries and

1
Makefile.am
View File

@ -15,7 +15,6 @@ DISTCHECK_CONFIGURE_FLAGS = \
--with-audit \ --with-audit \
--with-selinux \ --with-selinux \
--with-imaevm \ --with-imaevm \
--with-crypto=openssl \
--disable-dependency-tracking --disable-dependency-tracking
include $(top_srcdir)/rpm.am include $(top_srcdir)/rpm.am

3
ci/Dockerfile
View File

@ -25,6 +25,7 @@ RUN dnf -y install \
elfutils-libelf-devel \ elfutils-libelf-devel \
elfutils-devel \ elfutils-devel \
openssl-devel \ openssl-devel \
libgcrypt-devel \
file-devel \ file-devel \
popt-devel \ popt-devel \
libarchive-devel \ libarchive-devel \
@ -48,7 +49,7 @@ RUN dnf -y install \
&& dnf clean all && dnf clean all
RUN autoreconf -vfi RUN autoreconf -vfi
RUN ./configure \ RUN ./configure \
--with-crypto=openssl \ --with-crypto=libgcrypt \
--with-selinux \ --with-selinux \
--with-cap \ --with-cap \
--with-acl \ --with-acl \

4
configure.ac
View File

@ -270,9 +270,9 @@ AM_CONDITIONAL(LIBDWARF,[test "$WITH_LIBDWARF" = yes])
# Select crypto library # Select crypto library
AC_ARG_WITH(crypto, AC_ARG_WITH(crypto,
[AC_HELP_STRING([--with-crypto=CRYPTO_LIB], [AC_HELP_STRING([--with-crypto=CRYPTO_LIB],
[The cryptographic library to use (nss|beecrypt|openssl|libgcrypt). The default is nss.]) [The cryptographic library to use (nss|beecrypt|openssl|libgcrypt). The default is libgcrypt.])
],[], ],[],
[with_crypto=nss]) [with_crypto=libgcrypt])
# Refuse to proceed if someone specified --with-beecrypt (removed) # Refuse to proceed if someone specified --with-beecrypt (removed)
AC_ARG_WITH(beecrypt, AC_ARG_WITH(beecrypt,