folkslinux
/
rpm
mirror of https://github.com/rpm-software-management/rpm.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Minor cleanup to rpmpsAppendProblem() 

- dont bother adding NULL problems
- avoid dumb pointer fiddles, ps->probs is just a bleeping array
This commit is contained in:
Panu Matilainen 2010-03-25 12:39:13 +02:00
parent 48d603e625
commit 0ad0e34550
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/rpmps.c
View File

@ -134,8 +134,7 @@ rpmps rpmpsFree(rpmps ps)
void rpmpsAppendProblem(rpmps ps, rpmProblem prob)
{
rpmProblem *p = NULL;
if (ps == NULL) return;
if (ps == NULL || prob == NULL) return;
if (ps->numProblems == ps->numProblemsAlloced) {
if (ps->numProblemsAlloced)
@ -146,9 +145,8 @@ void rpmpsAppendProblem(rpmps ps, rpmProblem prob)
ps->numProblemsAlloced * sizeof(ps->probs));
}
p = ps->probs + ps->numProblems;
ps->probs[ps->numProblems] = rpmProblemLink(prob);
ps->numProblems++;
*p = rpmProblemLink(prob);
}
void rpmpsAppend(rpmps ps, rpmProblemType type,