77 lines
2.7 KiB
Diff
77 lines
2.7 KiB
Diff
From 7314ebdc4e965359fba5cf19fbffb6af5e712d0e Mon Sep 17 00:00:00 2001
|
|
From: Balakumaran Kannan <kumaran.4353@gmail.com>
|
|
Date: Thu, 1 Aug 2024 12:21:11 +0000
|
|
Subject: [PATCH] Patch CVE-2024-6104
|
|
|
|
---
|
|
.../hashicorp/go-retryablehttp/client.go | 26 ++++++++++++++-----
|
|
1 file changed, 20 insertions(+), 6 deletions(-)
|
|
|
|
diff --git a/vendor/github.com/hashicorp/go-retryablehttp/client.go b/vendor/github.com/hashicorp/go-retryablehttp/client.go
|
|
index f1ccd3d..25d7ef5 100644
|
|
--- a/vendor/github.com/hashicorp/go-retryablehttp/client.go
|
|
+++ b/vendor/github.com/hashicorp/go-retryablehttp/client.go
|
|
@@ -499,9 +499,9 @@ func (c *Client) Do(req *Request) (*http.Response, error) {
|
|
if logger != nil {
|
|
switch v := logger.(type) {
|
|
case Logger:
|
|
- v.Printf("[DEBUG] %s %s", req.Method, req.URL)
|
|
+ v.Printf("[DEBUG] %s %s", req.Method, redactURL(req.URL))
|
|
case LeveledLogger:
|
|
- v.Debug("performing request", "method", req.Method, "url", req.URL)
|
|
+ v.Debug("performing request", "method", req.Method, "url", redactURL(req.URL))
|
|
}
|
|
}
|
|
|
|
@@ -548,9 +548,9 @@ func (c *Client) Do(req *Request) (*http.Response, error) {
|
|
if err != nil {
|
|
switch v := logger.(type) {
|
|
case Logger:
|
|
- v.Printf("[ERR] %s %s request failed: %v", req.Method, req.URL, err)
|
|
+ v.Printf("[ERR] %s %s request failed: %v", req.Method, redactURL(req.URL), err)
|
|
case LeveledLogger:
|
|
- v.Error("request failed", "error", err, "method", req.Method, "url", req.URL)
|
|
+ v.Error("request failed", "error", err, "method", req.Method, "url", redactURL(req.URL))
|
|
}
|
|
} else {
|
|
// Call this here to maintain the behavior of logging all requests,
|
|
@@ -590,7 +590,7 @@ func (c *Client) Do(req *Request) (*http.Response, error) {
|
|
}
|
|
|
|
wait := c.Backoff(c.RetryWaitMin, c.RetryWaitMax, i, resp)
|
|
- desc := fmt.Sprintf("%s %s", req.Method, req.URL)
|
|
+ desc := fmt.Sprintf("%s %s", req.Method, redactURL(req.URL))
|
|
if code > 0 {
|
|
desc = fmt.Sprintf("%s (status: %d)", desc, code)
|
|
}
|
|
@@ -622,7 +622,7 @@ func (c *Client) Do(req *Request) (*http.Response, error) {
|
|
}
|
|
c.HTTPClient.CloseIdleConnections()
|
|
return nil, fmt.Errorf("%s %s giving up after %d attempts",
|
|
- req.Method, req.URL, c.RetryMax+1)
|
|
+ req.Method, redactURL(req.URL), c.RetryMax+1)
|
|
}
|
|
|
|
// Try to read the response body so we can reuse this connection.
|
|
@@ -703,3 +703,17 @@ func (c *Client) StandardClient() *http.Client {
|
|
Transport: &RoundTripper{Client: c},
|
|
}
|
|
}
|
|
+
|
|
+
|
|
+// Taken from url.URL#Redacted() which was introduced in go 1.15.
|
|
+func redactURL(u *url.URL) string {
|
|
+ if u == nil {
|
|
+ return ""
|
|
+ }
|
|
+
|
|
+ ru := *u
|
|
+ if _, has := ru.User.Password(); has {
|
|
+ ru.User = url.UserPassword(ru.User.Username(), "xxxxx")
|
|
+ }
|
|
+ return ru.String()
|
|
+}
|
|
--
|
|
2.33.8
|
|
|