diff --git a/xds/src/main/java/io/grpc/xds/ServerXdsClient.java b/xds/src/main/java/io/grpc/xds/ServerXdsClient.java index 337fdb3838..c499ed7f24 100644 --- a/xds/src/main/java/io/grpc/xds/ServerXdsClient.java +++ b/xds/src/main/java/io/grpc/xds/ServerXdsClient.java @@ -70,11 +70,10 @@ final class ServerXdsClient extends AbstractXdsClient { ScheduledExecutorService timeService, BackoffPolicy.Provider backoffPolicyProvider, Supplier stopwatchSupplier, - boolean useNewApiForListenerQuery, String instanceIp, String grpcServerResourceId) { super(channel, useProtocolV3, node, timeService, backoffPolicyProvider, stopwatchSupplier); - this.useNewApiForListenerQuery = useProtocolV3 && useNewApiForListenerQuery; + this.useNewApiForListenerQuery = useProtocolV3; this.instanceIp = (instanceIp != null ? instanceIp : "0.0.0.0"); this.grpcServerResourceId = grpcServerResourceId; } diff --git a/xds/src/main/java/io/grpc/xds/XdsClientWrapperForServerSds.java b/xds/src/main/java/io/grpc/xds/XdsClientWrapperForServerSds.java index 135d0a17ef..ab6cba383b 100644 --- a/xds/src/main/java/io/grpc/xds/XdsClientWrapperForServerSds.java +++ b/xds/src/main/java/io/grpc/xds/XdsClientWrapperForServerSds.java @@ -70,10 +70,6 @@ public final class XdsClientWrapperForServerSds { private static final TimeServiceResource timeServiceResource = new TimeServiceResource("GrpcServerXdsClient"); - @VisibleForTesting - static boolean experimentalNewServerApiEnvVar = Boolean.parseBoolean( - System.getenv("GRPC_XDS_EXPERIMENTAL_NEW_SERVER_API")); - private EnvoyServerProtoData.Listener curListener; @SuppressWarnings("unused") @Nullable private XdsClient xdsClient; @@ -115,7 +111,7 @@ public final class XdsClientWrapperForServerSds { Grpc.newChannelBuilder(serverInfo.getTarget(), serverInfo.getChannelCredentials()) .keepAliveTime(5, TimeUnit.MINUTES).build(); timeService = SharedResourceHolder.get(timeServiceResource); - newServerApi = serverInfo.isUseProtocolV3() && experimentalNewServerApiEnvVar; + newServerApi = serverInfo.isUseProtocolV3(); String grpcServerResourceId = bootstrapInfo.getGrpcServerResourceId(); if (newServerApi && grpcServerResourceId == null) { throw new IOException("missing grpc_server_resource_name_id value in xds bootstrap"); @@ -128,7 +124,6 @@ public final class XdsClientWrapperForServerSds { timeService, new ExponentialBackoffPolicy.Provider(), GrpcUtil.STOPWATCH_SUPPLIER, - experimentalNewServerApiEnvVar, "0.0.0.0", grpcServerResourceId); start(xdsClientImpl); diff --git a/xds/src/test/java/io/grpc/xds/ServerXdsClientNewServerApiTest.java b/xds/src/test/java/io/grpc/xds/ServerXdsClientNewServerApiTest.java index 50f788fefe..32619d75ff 100644 --- a/xds/src/test/java/io/grpc/xds/ServerXdsClientNewServerApiTest.java +++ b/xds/src/test/java/io/grpc/xds/ServerXdsClientNewServerApiTest.java @@ -186,7 +186,7 @@ public class ServerXdsClientNewServerApiTest { xdsClient = new ServerXdsClient(channel, true, NODE, fakeClock.getScheduledExecutorService(), backoffPolicyProvider, - fakeClock.getStopwatchSupplier(), true, INSTANCE_IP, "test/value"); + fakeClock.getStopwatchSupplier(), INSTANCE_IP, "test/value"); // Only the connection to management server is established, no RPC request is sent until at // least one watcher is registered. assertThat(responseObservers).isEmpty(); diff --git a/xds/src/test/java/io/grpc/xds/ServerXdsClientTest.java b/xds/src/test/java/io/grpc/xds/ServerXdsClientTest.java index f503268ef5..a76aa321e0 100644 --- a/xds/src/test/java/io/grpc/xds/ServerXdsClientTest.java +++ b/xds/src/test/java/io/grpc/xds/ServerXdsClientTest.java @@ -189,7 +189,7 @@ public class ServerXdsClientTest { xdsClient = new ServerXdsClient(channel, /* useProtocolV3= */ false, NODE, fakeClock.getScheduledExecutorService(), backoffPolicyProvider, - fakeClock.getStopwatchSupplier(), false, INSTANCE_IP, "grpc/server"); + fakeClock.getStopwatchSupplier(), INSTANCE_IP, "grpc/server"); // Only the connection to management server is established, no RPC request is sent until at // least one watcher is registered. assertThat(responseObservers).isEmpty();