java_grpc_library.bzl: Work with proto_library rules using strip_import_prefix / import_prefix

In addition to this welcome functionality, this change also makes it
possible to fix http://github.com/bazelbuild/bazel/issues/7157 by
tolerating proto_library rules using a virtual import directory.
This commit is contained in:
Lukacs T. Berki 2019-07-08 13:54:36 -07:00 committed by Eric Anderson
parent cc13f74065
commit b220178515
1 changed files with 14 additions and 1 deletions

View File

@ -62,7 +62,20 @@ java_rpc_toolchain = rule(
def _path_ignoring_repository(f): def _path_ignoring_repository(f):
if len(f.owner.workspace_root) == 0: if len(f.owner.workspace_root) == 0:
return f.short_path return f.short_path
return f.path[f.path.find(f.owner.workspace_root) + len(f.owner.workspace_root) + 1:]
# Bazel creates a _virtual_imports directory in case the .proto source files
# need to a accessed at a path that's different from their source path:
# https://github.com/bazelbuild/bazel/blob/0.27.1/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoCommon.java#L289
#
# In that case, the import path of the .proto file is the path relative to
# the virtual imports directory of the rule in question.
virtual_imports = "/_virtual_imports/"
if virtual_imports in f.path:
return f.path.split(virtual_imports)[1].split("/", 1)[1]
else:
# If |f| is a generated file, it will have "bazel-out/*/genfiles" prefix
# before "external/workspace", so we need to add the starting index of "external/workspace"
return f.path[f.path.find(f.owner.workspace_root) + len(f.owner.workspace_root) + 1:]
def _java_rpc_library_impl(ctx): def _java_rpc_library_impl(ctx):
if len(ctx.attr.srcs) != 1: if len(ctx.attr.srcs) != 1: