flasn4nt
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

core: enable Census tags propagation by default. (#3294) 

According to Census team, the tag wire format is now stable.
This commit is contained in:
Kun Zhang 2017-07-31 14:55:48 -07:00 committed by GitHub
parent f54a2df67f
commit a3a306fd4e
1 changed files with 1 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
core/src/main/java/io/grpc/internal/AbstractManagedChannelImplBuilder.java
View File

@ -119,7 +119,6 @@ public abstract class AbstractManagedChannelImplBuilder
private int maxInboundMessageSize = GrpcUtil.DEFAULT_MAX_MESSAGE_SIZE; private int maxInboundMessageSize = GrpcUtil.DEFAULT_MAX_MESSAGE_SIZE;
private boolean enableStatsTagPropagation;
private boolean enableTracing; private boolean enableTracing;
/** /**
@ -300,15 +299,6 @@ public abstract class AbstractManagedChannelImplBuilder
return GrpcUtil.checkAuthority(authority); return GrpcUtil.checkAuthority(authority);
} }
/**
* Set it to true to propagate the stats tags on the wire. This will be deleted assuming always
* enabled once the instrumentation-java wire format is stabilized.
*/
@Deprecated
public void setEnableStatsTagPropagation(boolean enabled) {
this.enableStatsTagPropagation = enabled;
}
/** /**
* Set it to true to record traces and propagate tracing information on the wire. This will be * Set it to true to record traces and propagate tracing information on the wire. This will be
* deleted assuming always enabled once the instrumentation-java wire format is stabilized. * deleted assuming always enabled once the instrumentation-java wire format is stabilized.
@ -338,8 +328,7 @@ public abstract class AbstractManagedChannelImplBuilder
this.statsFactory != null ? this.statsFactory : Stats.getStatsContextFactory(); this.statsFactory != null ? this.statsFactory : Stats.getStatsContextFactory();
if (statsCtxFactory != null) { if (statsCtxFactory != null) {
CensusStatsModule censusStats = CensusStatsModule censusStats =
new CensusStatsModule( new CensusStatsModule(statsCtxFactory, GrpcUtil.STOPWATCH_SUPPLIER, true);
statsCtxFactory, GrpcUtil.STOPWATCH_SUPPLIER, enableStatsTagPropagation);
// First interceptor runs last (see ClientInterceptors.intercept()), so that no // First interceptor runs last (see ClientInterceptors.intercept()), so that no
// other interceptor can override the tracer factory we set in CallOptions. // other interceptor can override the tracer factory we set in CallOptions.
effectiveInterceptors.add(0, censusStats.getClientInterceptor()); effectiveInterceptors.add(0, censusStats.getClientInterceptor());