flasn4nt
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Address Android 11's package visibility rules. (#11551)

This commit is contained in:
John Cormie 2024-09-23 20:37:09 -07:00 committed by GitHub
parent d8f73e0456
commit 99be6e9852
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
documentation/android-binderchannel-status-codes.md
View File

@ -22,16 +22,24 @@ Consider the table that follows as an BinderChannel-specific addendum to the “
<td><strong>Expected Client Handling</strong> <td><strong>Expected Client Handling</strong>
</td> </td>
</tr> </tr>
<tr>
<td>0
</td>
<td><a href="https://developer.android.com/training/package-visibility">Server app not visible</a>.
</td>
<td rowspan="6" >bindService() returns false
</td>
<td rowspan="9" ><p>UNIMPLEMENTED<p>“The operation is not implemented or is not supported / enabled in this service.”
</td>
<td>Give up - This is an error in the client manifest.
</td>
</tr>
<tr> <tr>
<td>1 <td>1
</td> </td>
<td>Server app not installed <td>Server app not installed
</td> </td>
<td rowspan="5" >bindService() returns false <td rowspan="8" >Direct the user to install/reinstall the server app.
</td>
<td rowspan="8" ><p>UNIMPLEMENTED<p>“The operation is not implemented or is not supported / enabled in this service.”
</td>
<td rowspan="9" >Direct the user to install/reinstall the server app.
</td> </td>
</tr> </tr>
<tr> <tr>
@ -90,6 +98,8 @@ Consider the table that follows as an BinderChannel-specific addendum to the “
<td rowspan="5" ><p>PERMISSION_DENIED<p> <td rowspan="5" ><p>PERMISSION_DENIED<p>
“The caller does not have permission to execute the specified operation …” “The caller does not have permission to execute the specified operation …”
</td> </td>
<td>Direct the user to update the server app in the hopes that a newer version fixes this error in its manifest.
</td>
</tr> </tr>
<tr> <tr>
<td>10 <td>10
@ -315,6 +325,7 @@ According to a review of the AOSP source code, there are in fact several cases:
1. The target package is not installed 1. The target package is not installed
2. The target package is installed but does not declare the target Service in its manifest. 2. The target package is installed but does not declare the target Service in its manifest.
3. The target package requests dangerous permissions but targets sdk &lt;= M and therefore requires a permissions review, but the caller is not running in the foreground and so it would be inappropriate to launch the review UI. 3. The target package requests dangerous permissions but targets sdk &lt;= M and therefore requires a permissions review, but the caller is not running in the foreground and so it would be inappropriate to launch the review UI.
4. The target package is not visible to the client due to [Android 11 package visibility rules](https://developer.android.com/training/package-visibility).
Status code mapping: **UNIMPLEMENTED** Status code mapping: **UNIMPLEMENTED**
@ -322,6 +333,7 @@ Status code mapping: **UNIMPLEMENTED**
Unfortunately `UNIMPLEMENTED` doesn’t capture (3) but none of the other canonical status codes do either and we expect this case to be extremely rare. Unfortunately `UNIMPLEMENTED` doesn’t capture (3) but none of the other canonical status codes do either and we expect this case to be extremely rare.
(4) is intentially indistinguishable from (1) by Android design so we can't handle it differently. However, as a client manifest error, it's not something reasonable apps would handle at runtime anyway.
### bindService() throws SecurityException ### bindService() throws SecurityException
@ -382,4 +394,4 @@ Android’s Parcel class exposes a mechanism for marshalling certain types of `R
The calling Activity or Service Context might be destroyed with a gRPC request in flight. Apps should cease operations when the Context hosting it goes away and this includes cancelling any outstanding RPCs. The calling Activity or Service Context might be destroyed with a gRPC request in flight. Apps should cease operations when the Context hosting it goes away and this includes cancelling any outstanding RPCs.
Status code mapping: **CANCELLED** Status code mapping: **CANCELLED**