flasn4nt
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

all: Only depend on evaluation of enumerated subprojects 

Back in 10fb206 when this for loop was added, we didn't have the
subprojects list. That was added in 9bd7bab, but I failed to update one
reference to rootProject. So all has had an evaluation dependency on all
projects, even though it only needs a subset.

This should have little impact, but would prevent weird scenarios like
an issue in :grpc-gae-interop-testing-jdk8 preventing :all-all from
being loaded. Not to say things wouldn't still fail to load, but that
this bug could distract from the real problem. I noticed this
during #8049.
This commit is contained in:
Eric Anderson 2021-04-13 12:39:09 -07:00 committed by Eric Anderson
parent 84dc5642bc
commit 8a9aa41416
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
all/build.gradle
View File

@ -24,12 +24,13 @@ def subprojects = [
project(':grpc-xds'), project(':grpc-xds'),
] ]
for (subproject in rootProject.subprojects) { for (subproject in subprojects) {
if (subproject == project) { if (subproject == project) {
continue continue
} }
evaluationDependsOn(subproject.path) evaluationDependsOn(subproject.path)
} }
evaluationDependsOn(':grpc-interop-testing')
dependencies { dependencies {
api subprojects.minus([project(':grpc-protobuf-lite')]) api subprojects.minus([project(':grpc-protobuf-lite')])