flasn4nt
/
grpc-java
mirror of https://github.com/grpc/grpc-java.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

core: fix '@link: can't find...' build noise 

The build (jdk version jdk1.8.0_91) produces some noise

```
/usr/local/google/home/zdapeng/git/grpc-java/core/src/main/java/io/grpc/LoadBalancer.java:196: warning - Tag @link: can't find pickSubchannel(PickSubchannelArgs) in io.grpc.LoadBalancer.SubchannelPicker
/usr/local/google/home/zdapeng/git/grpc-java/core/src/main/java/io/grpc/LoadBalancer.java:388: warning - Tag @link: can't find pickSubchannel(
 PickSubchannelArgs) in io.grpc.LoadBalancer.SubchannelPicker
/usr/local/google/home/zdapeng/git/grpc-java/core/src/main/java/io/grpc/LoadBalancer.java:178: warning - Tag @link: can't find pickSubchannel(PickSubchannelArgs) in io.grpc.LoadBalancer.SubchannelPicker
3 warnings
:grpc-core:javadocJar
```

It seems nothing wrong with the javadoc and it could be a javac's bug, but here's a workaround.
This commit is contained in:
ZHANG Dapeng 2017-03-06 11:53:04 -08:00 committed by GitHub
parent 891581f14d
commit 1662a719e2
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
core/src/main/java/io/grpc/LoadBalancer.java
View File

@ -172,7 +172,7 @@ public abstract class LoadBalancer {
* @param affinity the affinity attributes provided via {@link CallOptions#withAffinity}
* @param headers the headers container of the RPC. It can be mutated within this method.
* @deprecated this signature is going to be removed in the next minor release. Implementations
* should instead override the {@link #pickSubchannel(PickSubchannelArgs)}.
* should instead override the {@link #pickSubchannel(LoadBalancer.PickSubchannelArgs)}.
*/
@Deprecated
public PickResult pickSubchannel(Attributes affinity, Metadata headers) {
@ -191,7 +191,8 @@ public abstract class LoadBalancer {
}
/**
* Provides arguments for a {@link SubchannelPicker#pickSubchannel(PickSubchannelArgs)}.
* Provides arguments for a {@link SubchannelPicker#pickSubchannel(
* LoadBalancer.PickSubchannelArgs)}.
*/
public abstract static class PickSubchannelArgs {
@ -379,7 +380,7 @@ public abstract class LoadBalancer {
*
* <p>When a new picker is provided via {@code updatePicker()}, the channel will apply the
* picker on all buffered RPCs, by calling {@link SubchannelPicker#pickSubchannel(
* PickSubchannelArgs)}.
* LoadBalancer.PickSubchannelArgs)}.
*
* <p>The channel will hold the picker and use it for all RPCs, until {@code updatePicker()} is
* called again and a new picker replaces the old one. If {@code updatePicker()} has never been