dnrops
/
xilem
mirror of https://github.com/linebender/xilem
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

xilem_web: Remove some comment artifacts, put `WithStyle` bound to `Element` interface and document `Element::style` (#667) 

I missed comment artifacts in #621, added doc-comment/test for
`SvgElement` and put the `WithStyle` on the `Element` interface bounds,
as it plays better with rust-analyzer and is more consistent with the
other API.
This commit is contained in:
Philipp Mildenberger 2024-10-11 00:57:17 +02:00 committed by GitHub
parent a4f88b7d5c
commit f5455d2686
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 17 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
xilem_web/src/interfaces.rs
View File

@ -54,7 +54,7 @@ pub trait Element<State, Action = ()>:
+ DomView<
State,
Action,
DomNode: DomNode<Props: WithAttributes + WithClasses> + AsRef<web_sys::Element>,
DomNode: DomNode<Props: WithAttributes + WithClasses + WithStyle> + AsRef<web_sys::Element>,
>
{
/// Set an attribute for an [`Element`]
@ -146,11 +146,20 @@ pub trait Element<State, Action = ()>:
Attr::new(self, Cow::from("id"), value.into_attr_value())
}
/// Set a style attribute
fn style(self, style: impl IntoStyles) -> Style<Self, State, Action>
where
<Self::DomNode as DomNode>::Props: WithStyle,
{
/// Set the [style](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/style) attribute
///
/// # Examples
///
/// ```
/// use xilem_web::{style as s, elements::html::div, interfaces::Element};
///
/// # fn component() -> impl Element<()> {
/// div(())
/// .style([s("display", "flex"), s("align-items", "center")])
/// .style(s("justify-content", "center"))
/// # }
/// ```
fn style(self, style: impl IntoStyles) -> Style<Self, State, Action> {
let mut styles = vec![];
style.into_styles(&mut styles);
Style::new(self, styles)
@ -170,10 +179,7 @@ pub trait Element<State, Action = ()>:
/// // <rect width="20" height="30" x="0.0" y="10.0" style="transform: translate(10px, 0) rotate(0.78539rad);"></rect>
/// # }
/// ```
fn rotate(self, radians: f64) -> Rotate<Self, State, Action>
where
<Self::DomNode as DomNode>::Props: WithStyle,
{
fn rotate(self, radians: f64) -> Rotate<Self, State, Action> {
Rotate::new(self, radians)
}
@ -328,7 +334,7 @@ pub trait Element<State, Action = ()>:
impl<State, Action, T> Element<State, Action> for T
where
T: DomView<State, Action>,
<T::DomNode as DomNode>::Props: WithAttributes + WithClasses,
<T::DomNode as DomNode>::Props: WithAttributes + WithClasses + WithStyle,
T::DomNode: AsRef<web_sys::Element>,
{
}
@ -551,19 +557,10 @@ where
{
}
// pub trait StyleExt {
// }
// /// Keep this shared code in sync between `HtmlElement` and `SvgElement`
// macro_rules! style_impls {
// () => {};
// }
// #[cfg(feature = "HtmlElement")]
pub trait HtmlElement<State, Action = ()>:
Element<State, Action, DomNode: DomNode<Props: WithStyle> + AsRef<web_sys::HtmlElement>>
{
// style_impls!();
}
// #[cfg(feature = "HtmlElement")]
@ -1535,7 +1532,6 @@ where
pub trait SvgElement<State, Action = ()>:
Element<State, Action, DomNode: DomNode<Props: WithStyle> + AsRef<web_sys::SvgElement>>
{
// style_impls!();
}
// #[cfg(feature = "SvgElement")]