From 77961611b64bd0cfea0df23154018048596ecfaa Mon Sep 17 00:00:00 2001 From: nothingismagick <35242872+nothingismagick@users.noreply.github.com> Date: Sat, 13 Jul 2019 19:36:23 +0200 Subject: [PATCH] feat(PR) add template --- .github/PULL_REQUEST_TEMPLATE.md | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 5d2140b9a..9e6bb8d9f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,34 +1,38 @@ **What kind of change does this PR introduce?** (check at least one) + - [ ] Bugfix - [ ] Feature +- [ ] New Binding Issue #___ - [ ] Code style update - [ ] Refactor - [ ] Build-related changes - [ ] Other, please describe: **Does this PR introduce a breaking change?** (check one) + -- [ ] Yes +- [ ] Yes. Issue #___ - [ ] No -If yes, please describe the impact and migration path for existing applications: **The PR fulfills these requirements:** - [ ] It's submitted to the `dev` branch and _not_ the `master` branch - [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. `fix: #xxx[,#xxx]`, where "xxx" is the issue number) -- [ ] It's been tested on a Cordova (iOS, Android) app -- [ ] It's been tested on a Electron app -- [ ] Any necessary documentation has been added or updated [in the docs](https://github.com/quasarframework/quasar/tree/dev/docs) (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description. +- [ ] Any necessary documentation has been added or updated [in the docs](https://github.com/quasarframework/proton/tree/dev/docs) (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description. If adding a **new feature**, the PR's description includes: - [ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)