Go to file
Miles Ziemer ad520b080a
Remove invalid defaults for some services (#3217)
## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here -->

Some services have generated types with properties that have a default
value of zero. This can cause invalid requests if the service expects a
value > 0.

## Description
<!--- Describe your changes in detail -->

Adds a customization that removes the default value for services with
this issue.

## Testing
<!--- Please describe in detail how you tested your changes -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
- Added a test for the customization to make sure defaults were removed.
- Generated clients for the impacted services and verified the expected
types had the default value removed.

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

Co-authored-by: Russell Cohen <rcoh@amazon.com>
2023-11-17 02:57:26 +00:00
.cargo Remove sparse registry config (#2990) 2023-09-19 13:50:11 +00:00
.github Add a job to release workflow that checks the current actor for prod run (#3207) 2023-11-16 20:19:50 +00:00
.pre-commit-hooks Run `--all` in precommit (#3048) 2023-10-10 16:02:13 +00:00
aws Remove invalid defaults for some services (#3217) 2023-11-17 02:57:26 +00:00
buildSrc Merge remote-tracking branch 'origin/smithy-rs-release-0.100.x' into merge-0.100.x-to-main 2023-11-16 13:58:55 -06:00
codegen-client Fix a bug where we aren't checking the URL (#3211) 2023-11-16 16:58:54 +00:00
codegen-client-test Fix AwsQuery target serialization (#3210) 2023-11-16 15:50:53 +00:00
codegen-core Only output dev preview warning messages for 0.x versions (#3219) 2023-11-17 01:11:42 +00:00
codegen-server Re-introduce default generic for server service struct (#3197) 2023-11-14 16:43:29 +00:00
codegen-server-test Fix repo org move issues (#3166) 2023-11-10 18:51:04 +00:00
design Rename behavior versions and associated functions (#3204) 2023-11-15 11:35:22 -08:00
examples Revise unhandled error variant according to RFC-39 (#3191) 2023-11-15 10:12:13 -08:00
gradle/wrapper Upgrade to Gradle 8.3 (#2984) 2023-09-14 19:34:55 +00:00
rust-runtime Assorted cleanups of stable runtime crates (#3205) 2023-11-16 18:33:42 +00:00
tools Only output dev preview warning messages for 0.x versions (#3219) 2023-11-17 01:11:42 +00:00
.cargo-deny-config.toml Update dependencies flagged by cargo audit (#2753) 2023-06-12 17:09:29 +00:00
.editorconfig Upgrade Kotlin and Ktlint (#2392) 2023-02-22 18:21:06 +00:00
.git-blame-ignore-revs Create initial `.git-blame-ignore-revs` (#1726) 2022-09-09 14:09:06 -07:00
.gitignore add Sigv4A support (#2939) 2023-09-28 17:50:33 +00:00
.pre-commit-config.yaml Clean up the pre-commit config (#2915) 2023-08-10 17:43:57 +00:00
CHANGELOG.md Update changelog 2023-11-16 23:32:31 +00:00
CHANGELOG.next.toml Remove invalid defaults for some services (#3217) 2023-11-17 02:57:26 +00:00
CODEOWNERS Fix repo org move issues (#3166) 2023-11-10 18:51:04 +00:00
CODE_OF_CONDUCT.md Initial commit 2020-10-28 06:37:45 -07:00
CONTRIBUTING.md Update security disclosure instructions (#1758) 2022-09-22 17:05:45 +00:00
LICENSE Initial commit 2020-10-28 06:37:45 -07:00
NOTICE Initial commit 2020-10-28 06:37:45 -07:00
README.md Fix repo org move issues (#3166) 2023-11-10 18:51:04 +00:00
build.gradle.kts fix various small issues (#3056) 2023-10-11 19:41:05 +00:00
ci Add release metadata to `versions.toml` (#1400) 2022-05-23 23:31:23 +00:00
ci.mk TLS tests in CI (#2886) 2023-08-09 14:21:55 +00:00
clippy-root.toml Add clippy.toml with forbidden methods & fix SystemTime usages (#2882) 2023-07-28 17:16:44 +00:00
gradle.properties Upgrade the smithy-rs runtime crates version to 0.101.0 2023-11-16 23:30:37 +00:00
gradlew Upgrade to Gradle 8.3 (#2984) 2023-09-14 19:34:55 +00:00
gradlew.bat Upgrade to Gradle 8.3 (#2984) 2023-09-14 19:34:55 +00:00
rust-toolchain.toml update MSRV to 1.70.0 (#2948) 2023-08-24 19:51:06 +00:00
settings.gradle.kts Make required context parameters required (#2964) 2023-08-31 19:26:07 +00:00

README.md

Smithy Rust CI on Branch main

Smithy code generators for Rust that generate clients, servers, and the entire AWS SDK. The latest unreleased SDK build can be found in aws-sdk-rust/next.

Design documentation

All internal and external interfaces are considered unstable and subject to change without notice.

Setup

  1. ./gradlew will setup gradle for you. JDK 17 is required.
  2. Running tests requires a working Rust installation. See Rust docs for installation instructions on your platform. The MSRV (Minimum Supported Rust Version) for the crates in this project is stable-2, i.e. the current stable Rust version and the prior two versions. Older versions may work.

Development

For development, pre-commit hooks make it easier to pass automated linting when opening a pull request. Setup:

brew install pre-commit # (or appropriate for your platform: https://pre-commit.com/)
pre-commit install

Project Layout

  • aws: AWS specific codegen & Rust code (signing, endpoints, customizations, etc.) Common commands:
    • ./gradlew :aws:sdk:assemble: Generate (but do not test / compile etc.) a fresh SDK into sdk/build/aws-sdk
    • ./gradlew :aws:sdk:test: Generate & run all tests for a fresh SDK
    • ./gradlew :aws:sdk:{cargoCheck, cargoTest, cargoDocs, cargoClippy}: Generate & run specified cargo command.
  • codegen-core: Common code generation logic useful for clients and servers
  • codegen-client: Whitelabel Smithy client code generation
  • codegen-client-test: Smithy protocol test generation & integration tests for Smithy client whitelabel code
  • design: Design documentation. See the design/README.md for details about building / viewing.
  • codegen-server: Whitelabel Smithy server code generation
  • codegen-server-test: Smithy protocol test generation & integration tests for Smithy server whitelabel code
  • examples: A collection of server implementation examples

Testing

Running all of smithy-rs's tests can take a very long time, so it's better to know which parts to test based on the changes being made, and allow continuous integration to find other issues when posting a pull request.

In general, the components of smithy-rs affect each other in the following order (with earlier affecting later):

  1. rust-runtime
  2. codegen and codegen-server
  3. aws/rust-runtime
  4. aws/sdk-codegen

Some components, such as codegen-client-test and codegen-server-test, are purely for testing other components.

Testing rust-runtime and aws/rust-runtime

To test the rust-runtime crates:

# Run all Rust tests for `rust-runtime/` (from repo root):
cargo test --manifest-path=rust-runtime/Cargo.toml
# Run clippy for `rust-runtime/` (from repo root):
cargo clippy --manifest-path=rust-runtime/Cargo.toml

# Or
cd rust-runtime
cargo test
cargo clippy

To test the aws/rust-runtime crates:

# Run all Rust tests for `aws/rust-runtime/` (from repo root):
cargo test --manifest-path=aws/rust-runtime/Cargo.toml
# Run clippy for `aws/rust-runtime/` (from repo root):
cargo clippy --manifest-path=aws/rust-runtime/Cargo.toml

# Or
cd aws/rust-runtime
cargo test
cargo clippy

Some runtime crates have a additional-ci script that can also be run. These scripts often require cargo-hack and cargo-udeps to be installed.

Testing Client/Server Codegen

To test the code generation, the following can be used:

# Run Kotlin codegen unit tests
./gradlew codegen-core:check
./gradlew codegen-client:check
./gradlew codegen-server:check
# Run client codegen tests
./gradlew codegen-client-test:check
# Run server codegen tests
./gradlew codegen-server-test:check

Several Kotlin unit tests generate Rust projects and compile them. When these fail, they typically output links to the location of the generated code so that it can be inspected.

To look at generated code when the codegen tests fail, check these paths depending on the test suite that's failing:

  • For codegen-client-test: codegen-client-test/build/smithyprojections/codegen-client-test
  • For codegen-server-test: codegen-server-test/build/smithyprojections/codegen-server-test

Testing SDK Codegen

See the readme in aws/sdk/ for more information about these targets as they can be configured to generate more or less AWS service clients.

# Run Kotlin codegen unit tests
./gradlew aws:sdk-codegen:check
# Generate an SDK, but do not attempt to compile / run tests. Useful for inspecting generated code
./gradlew :aws:sdk:assemble
# Run all the tests
./gradlew :aws:sdk:test
# Validate that the generated code compiles
./gradlew :aws:sdk:cargoCheck
# Validate that the generated code passes Clippy
./gradlew :aws:sdk:cargoClippy
# Validate the generated docs
./gradlew :aws:sdk:cargoDoc

The generated SDK will be placed in aws/sdk/build/aws-sdk.