Go to file
ysaito1001 10a92052b1
Switch to file-per-change changelog (#3774)
## Motivation and Context
Implements [RFC: File-per-change
changelog](https://smithy-lang.github.io/smithy-rs/design/rfcs/rfc0042_file_per_change_changelog.html#rfc-file-per-change-changelog)

## Description
When this PR is merged to `main`, it will impact developer workflow for
creating a changelog entry that goes with a PR.
Prior to this, one edited `CHANGELOG.next.toml` to enter a changelog
entry, but it often caused merge conflicts among us. With this PR, one
creates a `.md` file (any filename stem will do) under the
`smithy-rs/.changelog` directory. This Markdown file has the YAML front
matter, and it can be created manually or via the `ChangeLogger` CLI
(see [this
commit](83cda76608)
for more details).

Here are the highlights of the code changes:
- [The release
script](https://github.com/smithy-lang/smithy-rs/pull/3774/files#diff-162dc2b82eb3d72b105291d2fc5fc8d10c4fbc1e6f35862bc08ac0d6a7c53f76)
has been pointed to `smithy-rs/.changelog`. This is pretty much what it
takes to let the `smithy-rs` release infra switch to the new changelog
mode.
-
[sdk-lints](efcc772b37)
now disallows `CHANGELOG.next.toml`. It will complain if the file is
present.
- The `--source-to-truncate` option for the `changelogger`'s `render` is
now optional because our internal release infra code no longer needs to
specify that option (i.e. there is nothing to truncate there).
- Tests in `smithy-rs-tool-common` and `changelogger` have been updated
so TOML changelog entries used in tests have been re-written to Markdown
changelog entries. We want to avoid giving the false impression that
TOML changelog entries are still well-supported.

## Testing
- Existing tests & lints in CI
- Ran `smithy-rs` [dry-run
release](https://github.com/smithy-lang/smithy-rs/actions/runs/10100442953)
and confirmed the correctness of `CHANGELOG.md` and
`SDK_CHANGELOG.next.json` in the release artifacts
- Ran the internal release and confirmed `CHANGELOG.md` was rendered
correctly in `aws-sdk-rust`

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
2024-08-01 04:31:19 +00:00
.cargo Remove sparse registry config (#2990) 2023-09-19 13:50:11 +00:00
.changelog Switch to file-per-change changelog (#3774) 2024-08-01 04:31:19 +00:00
.github Switch to file-per-change changelog (#3774) 2024-08-01 04:31:19 +00:00
.pre-commit-hooks Run runtime crate version audit as part of pre-commit (#3450) 2024-02-28 22:10:02 +00:00
aws v2 Smoketest codegen (#3758) 2024-07-30 16:07:50 +00:00
buildSrc Add server RPC v2 CBOR support (#2544) 2024-07-17 09:50:52 +00:00
codegen-client Add client-support for RPC v2 CBOR (#3767) 2024-07-31 19:22:03 +00:00
codegen-client-test Add client-support for RPC v2 CBOR (#3767) 2024-07-31 19:22:03 +00:00
codegen-core Add client-support for RPC v2 CBOR (#3767) 2024-07-31 19:22:03 +00:00
codegen-server Add client-support for RPC v2 CBOR (#3767) 2024-07-31 19:22:03 +00:00
codegen-server-test Add server RPC v2 CBOR support (#2544) 2024-07-17 09:50:52 +00:00
design Switch to file-per-change changelog (#3774) 2024-08-01 04:31:19 +00:00
examples Add server RPC v2 CBOR support (#2544) 2024-07-17 09:50:52 +00:00
gradle/wrapper Upgrade to Gradle 8.3 (#2984) 2023-09-14 19:34:55 +00:00
rust-runtime Add client-support for RPC v2 CBOR (#3767) 2024-07-31 19:22:03 +00:00
tools Switch to file-per-change changelog (#3774) 2024-08-01 04:31:19 +00:00
.cargo-deny-config.toml Add server RPC v2 CBOR support (#2544) 2024-07-17 09:50:52 +00:00
.editorconfig Upgrade Kotlin to 1.9.20 and Ktlint to 1.0.1 (#3320) 2023-12-14 12:35:18 -08:00
.git-blame-ignore-revs Create initial `.git-blame-ignore-revs` (#1726) 2022-09-09 14:09:06 -07:00
.gitignore add Sigv4A support (#2939) 2023-09-28 17:50:33 +00:00
.pre-commit-config.yaml Run runtime crate version audit as part of pre-commit (#3450) 2024-02-28 22:10:02 +00:00
CHANGELOG.md Update changelog 2024-07-16 23:14:53 +00:00
CODEOWNERS Fix repo org move issues (#3166) 2023-11-10 18:51:04 +00:00
CODE_OF_CONDUCT.md Initial commit 2020-10-28 06:37:45 -07:00
CONTRIBUTING.md Switch to file-per-change changelog (#3774) 2024-08-01 04:31:19 +00:00
LICENSE Initial commit 2020-10-28 06:37:45 -07:00
NOTICE Initial commit 2020-10-28 06:37:45 -07:00
README.md Renaming gradle task `:aws:sdk:test` to `sdkTest` avoid task name collision (#3650) 2024-05-20 21:51:24 +00:00
build.gradle.kts Add server RPC v2 CBOR support (#2544) 2024-07-17 09:50:52 +00:00
ci Upgrade CI to use docker-compose v2 (#3543) 2024-04-02 16:12:02 +00:00
ci.mk TLS tests in CI (#2886) 2023-08-09 14:21:55 +00:00
clippy-root.toml Add clippy.toml with forbidden methods & fix SystemTime usages (#2882) 2023-07-28 17:16:44 +00:00
gradle.properties Upgrade Smithy to 1.50.0 (#3728) 2024-07-05 14:58:17 +00:00
gradlew Upgrade to Gradle 8.3 (#2984) 2023-09-14 19:34:55 +00:00
gradlew.bat Upgrade to Gradle 8.3 (#2984) 2023-09-14 19:34:55 +00:00
rust-toolchain.toml Bumping MSRV to 1.76.0 2024-05-20 11:58:10 -07:00
settings.gradle.kts Upgrade Smithy Gradle Plugin to 0.9 (#3394) 2024-02-07 22:18:49 +00:00

README.md

Smithy Rust CI on Branch main

Smithy code generators for Rust that generate clients, servers, and the entire AWS SDK. The latest unreleased SDK build can be found in aws-sdk-rust/next.

Design documentation

All internal and external interfaces are considered unstable and subject to change without notice.

Setup

  1. ./gradlew will setup gradle for you. JDK 17 is required.
  2. Running tests requires a working Rust installation. See Rust docs for installation instructions on your platform. The MSRV (Minimum Supported Rust Version) for the crates in this project is stable-2, i.e. the current stable Rust version and the prior two versions. Older versions may work.

Development

For development, pre-commit hooks make it easier to pass automated linting when opening a pull request. Setup:

brew install pre-commit # (or appropriate for your platform: https://pre-commit.com/)
pre-commit install

Project Layout

  • aws: AWS specific codegen & Rust code (signing, endpoints, customizations, etc.) Common commands:
    • ./gradlew :aws:sdk:assemble: Generate (but do not test / compile etc.) a fresh SDK into sdk/build/aws-sdk
    • ./gradlew :aws:sdk:sdkTest: Generate & run all tests for a fresh SDK. (Note that these tests require Go to be installed for FIP support to compile properly)
    • ./gradlew :aws:sdk:{cargoCheck, cargoTest, cargoDocs, cargoClippy}: Generate & run specified cargo command.
  • codegen-core: Common code generation logic useful for clients and servers
  • codegen-client: Whitelabel Smithy client code generation
  • codegen-client-test: Smithy protocol test generation & integration tests for Smithy client whitelabel code
  • design: Design documentation. See the design/README.md for details about building / viewing.
  • codegen-server: Whitelabel Smithy server code generation
  • codegen-server-test: Smithy protocol test generation & integration tests for Smithy server whitelabel code
  • examples: A collection of server implementation examples

Testing

Running all of smithy-rs's tests can take a very long time, so it's better to know which parts to test based on the changes being made, and allow continuous integration to find other issues when posting a pull request.

In general, the components of smithy-rs affect each other in the following order (with earlier affecting later):

  1. rust-runtime
  2. codegen and codegen-server
  3. aws/rust-runtime
  4. aws/sdk-codegen

Some components, such as codegen-client-test and codegen-server-test, are purely for testing other components.

Testing rust-runtime and aws/rust-runtime

To test the rust-runtime crates:

# Run all Rust tests for `rust-runtime/` (from repo root):
cargo test --manifest-path=rust-runtime/Cargo.toml
# Run clippy for `rust-runtime/` (from repo root):
cargo clippy --manifest-path=rust-runtime/Cargo.toml

# Or
cd rust-runtime
cargo test
cargo clippy

To test the aws/rust-runtime crates:

# Run all Rust tests for `aws/rust-runtime/` (from repo root):
cargo test --manifest-path=aws/rust-runtime/Cargo.toml
# Run clippy for `aws/rust-runtime/` (from repo root):
cargo clippy --manifest-path=aws/rust-runtime/Cargo.toml

# Or
cd aws/rust-runtime
cargo test
cargo clippy

Some runtime crates have a additional-ci script that can also be run. These scripts often require cargo-hack and cargo-udeps to be installed.

Testing Client/Server Codegen

To test the code generation, the following can be used:

# Run Kotlin codegen unit tests
./gradlew codegen-core:check
./gradlew codegen-client:check
./gradlew codegen-server:check
# Run client codegen tests
./gradlew codegen-client-test:check
# Run server codegen tests
./gradlew codegen-server-test:check

Several Kotlin unit tests generate Rust projects and compile them. When these fail, they typically output links to the location of the generated code so that it can be inspected.

To look at generated code when the codegen tests fail, check these paths depending on the test suite that's failing:

  • For codegen-client-test: codegen-client-test/build/smithyprojections/codegen-client-test
  • For codegen-server-test: codegen-server-test/build/smithyprojections/codegen-server-test

Testing SDK Codegen

See the readme in aws/sdk/ for more information about these targets as they can be configured to generate more or less AWS service clients.

# Run Kotlin codegen unit tests
./gradlew aws:sdk-codegen:check
# Generate an SDK, but do not attempt to compile / run tests. Useful for inspecting generated code
./gradlew :aws:sdk:assemble
# Run all the tests
./gradlew :aws:sdk:sdkTest
# Validate that the generated code compiles
./gradlew :aws:sdk:cargoCheck
# Validate that the generated code passes Clippy
./gradlew :aws:sdk:cargoClippy
# Validate the generated docs
./gradlew :aws:sdk:cargoDoc

The generated SDK will be placed in aws/sdk/build/aws-sdk.