Commit Graph

10 Commits

Author SHA1 Message Date
John DiSanti 557e4b3976
Run runtime crate version audit as part of pre-commit (#3450)
This PR makes the runtime-versioner run via pre-commit so that devs will
know if they need to version bump a runtime crate sooner than CI would
otherwise tell them.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
2024-02-28 22:10:02 +00:00
John DiSanti fe36727499
Upgrade Kotlin to 1.9.20 and Ktlint to 1.0.1 (#3320)
This PR upgrades Kotlin to 1.9.20, and Ktlint to 1.0.1.

I had to abandon the pretty-format-kotlin pre-commit hook since it was
ignoring our `.editorconfig`, which made it impossible to suppress some
of the newer lints that would be difficult and undesirable to fix. Now
all Ktlint runs go through gradle, so there isn't any way for
inconsistencies to creep in.

I recommend reviewing this PR commit by commit as the commit that runs
Ktlint against the entire repo has a very large diff. When reviewing the
Ktlint formatting changes, be sure to hide whitespace changes to reduce
how much needs to be examined.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
2023-12-14 12:35:18 -08:00
Russell Cohen 8bfc4c615e
Run `--all` in precommit (#3048)
## Motivation and Context
Some lint errors don't show up until CI, this fixes that issue.
----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
2023-10-10 16:02:13 +00:00
John DiSanti d7ffa89338
Clean up the pre-commit config (#2915)
Update the name of the `sdk-lints` check since it checks more than just
license headers now, and make it run at the end so that KTLint runs and
fixes files even if there's an invalid changelog entry.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
2023-08-10 17:43:57 +00:00
John DiSanti bed7b97ff8
Reduce Docker image rebuilds (#2269)
* Move `acquire-build-image` into `.github`
* Move the `tools-hash` script into `.github`
* Upload to ECR from PRs as well
* Move build tools into `tools/ci-build/`
* Move CI scripts out of `ci-build`
* Split CI for forks/non-forks
* Remove `fetch-depth: 0` from PR workflows
2023-02-01 18:41:31 +00:00
John DiSanti a0539e20b0
Fix `SPDX-License-Identifier` in header comments (#1377)
* Fix misc whitespace with pre-commit

* Revise copyright check in `sdk-lints`

* Fix `SPDX-License-Identifier` in header comments
2022-05-09 09:50:46 -05:00
Russell Cohen cbd61ab1ff
Add recursion detection middleware to the default middleware stack (#1003)
* Add recursion detection middleware to the default middleware stack

Side refactorings:
- move AWS retry logic into its own module
- small update to protocol test to make it a little easier to use

* fixups

* Fix clippy

* Add more tests and comments
2021-12-27 18:04:10 +00:00
Russell Cohen c22ec5812d
Add license header checker & missing headers (#917)
* Add license header checker & missing headers

Adds a license check pre-commit hook + adds license checking to CI

* Update tools/sdk-lints/src/copyright.rs

Co-authored-by: John DiSanti <jdisanti@amazon.com>

Co-authored-by: John DiSanti <jdisanti@amazon.com>
2021-12-02 13:39:30 +00:00
John DiSanti 2c1fe88dec
Fix indentation issue with block quote pre-commit script (#868) 2021-11-17 22:14:27 +00:00
John DiSanti d2aac6281a
Add pre-commit hook to fix code gen block quote indentation (#825)
* Write pre-commit hook to fix Kotlin block quote indentation

* Manually correct oddball cases

* Format the rest of the block quotes

* Fix comment
2021-11-02 19:02:57 +00:00