Commit Graph

175 Commits

Author SHA1 Message Date
Zelda Hessler d4a2308e94
update MSRV to 1.69.0 (#2893)
_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
2023-08-01 19:37:59 +00:00
John DiSanti 25abe5a842
Change the default runtime mode to orchestrator (#2847)
This PR changes the default runtime mode to orchestrator for generated
clients and the AWS SDK.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
2023-07-20 15:49:53 +00:00
John DiSanti 47718f9da3
Upgrade `aws-actions/configure-aws-credentials` (#2797)
_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
2023-06-21 14:48:31 +00:00
John DiSanti 3d0db5650c
Categorize orchestrator TODO comments into `Launch` and `Cleanup` (#2774)
This PR categorizes orchestrator TODO comments into `Launch` and
`Cleanup`:

- `enableNewSmithyRuntimeLaunch`: Comment needs to be addressed before
orchestrator launch
- `enableNewSmithyRuntimeCleanup`: Comment needs to be addressed after
launch when removing middleware

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
2023-06-15 17:06:28 +00:00
John DiSanti cfff41a883
Upgrade MSRV to 1.68.2 (#2745)
## Motivation and Context
This PR upgrades the MSRV to 1.68.2.

## Checklist
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: Zelda Hessler <zhessler@amazon.com>
Co-authored-by: 82marbag <69267416+82marbag@users.noreply.github.com>
2023-06-13 15:23:04 +00:00
Harry Barber ccbc9a1a91
Revert "RFC30: Compile time benchmark" (#2756)
## Motivation and Context

There seems to be some problem which causes this CI job to fail.
https://github.com/awslabs/smithy-rs/actions/runs/5209247728/jobs/9398874499

Reverting smithy-rs#2617 until we have a clearer picture of why and how
to fix.
2023-06-08 15:09:26 +00:00
Thomas Cameron a6c3aba5eb
RFC30: Compile time benchmark (#2617)
## Motivation and Context
This PR implements ci-script for bench marking compile time.
Results are turned into a markdown file and compile time is normalized
to a value relative to the compile time of S3's sdk on dev profile
without any features.

Benchmark is triggered for every PR.

I considered using AWS batch, however, I decided not to move forward
with for following reasons
- I do not have access to your AWS account, thus making the debugging
extremely difficult
- Fork's github action will always fail if you block access

## Testing
NA

## Checklist
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [ ] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: Zelda Hessler <zhessler@amazon.com>
2023-06-07 15:16:09 +00:00
Harry Barber 29a900e74d
Add CI to the book (#2027)
## Motivation and Context

Closes https://github.com/awslabs/smithy-rs/issues/2004

## Description

Run `mdbook test` over the `design` folder.

## TODO

- [x] Ignore the RFC sections using `ignore` tag on the code blocks.
- [ ] Fix the remaining examples.
- [x] Ensure local `rust-runtime` dependencies are being used.

---------

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Co-authored-by: 82marbag <69267416+82marbag@users.noreply.github.com>
2023-06-07 09:01:16 +00:00
John DiSanti 18aad5c66a
Fix bug in `update-sdk-next.yml` (#2746)
## Motivation and Context
The workflow is failing to update the aws-sdk-rust/next branch due to
the `tests/` folder in the repository root now.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
2023-06-05 18:27:15 +00:00
82marbag d083c6f271
remove native-tls (#2675)
* Show how to plug a connector
* For TLS: keep rustls, only

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [x] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
2023-05-26 10:18:29 +00:00
John DiSanti 3a9e64e504
Test the orchestrator against the SDK in CI (#2715)
## Motivation and Context
This PR adds the SDK smoke test with the orchestrator implementation to
CI, and excludes services that don't yet pass tests.

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
2023-05-19 17:28:37 +00:00
ysaito1001 982319ff5f
Switch to rust-toolchain@master in "Update GitHub Pages" (#2613)
## Motivation and Context
The previous attempt https://github.com/awslabs/smithy-rs/pull/2610 did
not work for properly running the workflow for `Update GitHub Pages`.
This PR reverts it and uses a different fix to address the issue.

## Description
Possibly with
[this](https://users.rust-lang.org/t/sparse-registry-breaking-my-ci-and-i-dont-understand-why/89976)
and `dtolnaly/rust-toolchain` having fixed a couple of issues [related
to the sparse
registry](https://github.com/dtolnay/rust-toolchain/issues?q=is%3Aissue+is%3Aclosed+sparse)
recently, this PR will use `dtolnaly/rust-toolchain@master` rather than
`stable` (most CIs in this repository have been using `master`).

## Testing
The workflow in question has been verified to run successfully with this
change
([link](https://github.com/awslabs/smithy-rs/actions/runs/4758820036)).

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: Yuki Saito <awsaito@amazon.com>
Co-authored-by: John DiSanti <jdisanti@amazon.com>
2023-04-21 17:44:49 +00:00
John DiSanti 1a65a44e53
Upgrade MSRV to Rust 1.67.1 (#2611)
_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._
2023-04-21 17:26:27 +00:00
ysaito1001 437ae5bc20
Allow "Update GitHub Pages" to opt-in to cargo sparse registry (#2610)
## Motivation and Context
Addresses a CI failure within `Update GitHub Pages` due to the use of
the cargo sparse registry
([example](https://github.com/awslabs/smithy-rs/actions/runs/4746548497/jobs/8430328515)).

## Description
The PR allows the action to configure whether the cargo sparse registry
is used via the environment variable
[CARGO_UNSTABLE_SPARSE_REGISTRY](https://blog.rust-lang.org/2022/06/22/sparse-registry-testing.html#overview):

<img width="800" alt="Screenshot 2023-04-20 at 11 55 06 AM"
src="https://user-images.githubusercontent.com/15333866/233435686-d24ceb2f-facf-45c9-b6cb-490b8ea2b085.png">

----

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

---------

Co-authored-by: Yuki Saito <awsaito@amazon.com>
Co-authored-by: Zelda Hessler <zhessler@amazon.com>
2023-04-20 18:02:42 +00:00
Russell Cohen 187918a0eb
Add semver-checks CI job (#2518)
* Add semver-checks CI job

* Add flag to skip generation

* Make it possible to suppress semver checks with label

* fix GitHub script

* Fix but in semver-checks python script

* Cleanup debug info

* Move to ci-pr
2023-04-06 16:42:13 +00:00
Matteo Bigoi 3862ca0a37
Initial implementation of Typescript server bindings (#2277)
* A barely working code generation in typescript

* Extract shared socket into feature inside aws-smithy-http-server

* Building a fully functional application, I think

* Add NAPI build.rs

* Refactor all names to use typescript instead of js

* Add (hopefully) the PR bot for TS

* Clippy fixes

* Fix documentation

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

* set_reuse_port in socket not on windows

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

* Add example implementation

* Allow the new application to build

* Remove all occurrences of Python

* Simplify README

* Fix issue with the codegen-diff-revision script

* Try to prevent the ci-lint to bother us with TODO at this stage of development

* Remove codegen-client from typescript dependencies

Signed-off-by: Bigo <1781140+crisidev@users.noreply.github.com>

* Add CODEOWNERS and fix some other linting issues

* Add license

* Prevent from running tests on typescript in Windows

Signed-off-by: Bigo <1781140+crisidev@users.noreply.github.com>

* Initial work to remove error from this PR

* Update to call_async

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

* types/node in package.json

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

* Generate app.ts

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>

* Improve makefile

* Adapting code to the latest changes and removing runtime dependency (for now).

* Removing rust-runtime/aws-smithy-http-server-typescript.

* Making CI happy.

* Restoring ServerCodegenDecorator to be like main.

* Adding back the aws-smithy-http-server-typescript crate back.

* Removing index.js file.

---------

Signed-off-by: Daniele Ahmed <ahmeddan@amazon.de>
Signed-off-by: Bigo <1781140+crisidev@users.noreply.github.com>
Co-authored-by: 82marbag <69267416+82marbag@users.noreply.github.com>
Co-authored-by: Alberto Pose <albepose@amazon.com>
2023-04-06 15:27:17 +00:00
Russell Cohen 92316f75e1
Add CI check for deterministic codegen (#2509)
* Add CI check for deterministic codegen

* Fix typo

* Mark files as executable

* Fix argument count from 1 to 0

* Fix diff script

* Fix error in generate_and_commit function

* Cleanup command output

* Fix codegen-diff script

* Sort member params to fix codegen non-determinism
2023-03-29 21:20:41 +00:00
Zelda Hessler 92952cbe51
Update MSRV to 1.66.1 (#2468)
* update: MSRV to 1.66.1

* add: CHANGELOG.next.toml entry

* update: Dockerfile too

* fix: clippy lints

* fix: sigv4 event_stream.rs clippy lint
update: codegen clippy lint allowlist

* fix: doc lint that's nightly only
add: docs for aws-smithy-http
add: docs for aws-smithy-client
add: docs for aws-smithy-async

* add: more missing docs.

* fix: add more missing docs

* remove: unnecessary & in HttpBindingGenerator
fix: lint name

* fix: another doc import

* fix: test broken by changing compiler error

* fix: even more lints\nadd: lint warns to all smithy runtime crates

* fix: broken doc links

* fix: clippy bug

* fix: don't use modules named lib in codegen tests

* fix: the paginator_canary.rs unnecessary cast
2023-03-16 21:58:14 +00:00
Russell Cohen d579c561c7
Fix docker image hash script to be contained to ci-build (#2404) 2023-02-22 19:25:52 +00:00
Julian Antonielli 181889dc80
Fix manifest path comma (#2369) 2023-02-14 16:23:31 +00:00
Luca Palmieri 18a26b6d63
Add quotes to get a valid Javascript string (#2367) 2023-02-14 15:36:28 +00:00
John DiSanti f7c550ee47
Fix CI for forks by moving merge queue runs into a separate workflow (#2359) 2023-02-13 19:38:57 +00:00
Luca Palmieri f705bde5ea
Idempotent release action (#2353)
* Do not require the released commit to be at the tip of the branch.

* Update comment.

* If you release an old commit, it must be ready to go as is.

* Tag the commit that updates gradle.properties.

* Check out the specific commit instead of the branch.

* Simplify.

* We need to set the release branch.

* You can't refer to outputs directly.

* Make sure to tag the right commit.

* Pass the commit SHA explicitly.
2023-02-13 17:33:14 +00:00
Luca Palmieri c060263f35
Do not run the PR bot on the merge queue (#2357)
* Do not run the PR bot on the merge queue

* Update ci-pr.yml
2023-02-13 17:32:26 +00:00
Luca Palmieri bfbe25e5db
Do not skip CI jobs for merge queue events. (#2356)
* Do not skip for merge queue events.

* Fix quotes.
2023-02-13 17:25:48 +00:00
Luca Palmieri b3b33932fd
Run CI on merge groups. (#2355) 2023-02-13 17:01:01 +00:00
Nugine de186678ee
Bump Rust MSRV to 1.63.0 (#2222)
Co-authored-by: Zelda Hessler <zhessler@amazon.com>
Co-authored-by: John DiSanti <jdisanti@amazon.com>
2023-02-10 12:59:31 -08:00
Luca Palmieri 12a66c2c03
Instruct the release script to tag the commit on the release branch. It was previously left unspecified, resulting on a tag on the `main` branch. (#2322) 2023-02-07 16:20:03 +00:00
Luca Palmieri 7fdb5c968c
Fetch history when cloning, otherwise git commands such as `rev-parse` could fail. (#2314) 2023-02-06 16:39:38 +00:00
Luca Palmieri 51047b1849
Use `refs/remote/<remote-name>/<branch-name>` to avoid a "Fatal: needed a single revision" error, as we have seen in https://github.com/awslabs/smithy-rs/actions/runs/4105169302/jobs/7082226485 (#2313) 2023-02-06 16:03:43 +00:00
John DiSanti a06f21b076
Fix image tagging in CI on main (#2301) 2023-02-03 17:39:56 +00:00
Luca Palmieri b9b80c3014
Retrieve the output from outside the Docker context (#2300)
Co-authored-by: AWS SDK Rust Bot <97246200+aws-sdk-rust-ci@users.noreply.github.com>
2023-02-03 13:58:40 +00:00
Luca Palmieri 85d8819e85
Collect more diagnostics. (#2297) 2023-02-03 11:33:34 +00:00
John DiSanti df5abcf5a8
Fix CI on main and don't acquire Docker login for forks (#2295)
* Fix CI on main and don't acquire Docker login for forks

* Convert empty env vars into `None`

* Optimize base image acquisition on main
2023-02-03 11:17:51 +00:00
Russell Cohen 17f9a873fe
Use docker login when possible (#2265)
Login to ECR when credentials are available to improve CI performance
2023-02-02 21:52:07 +00:00
Luca Palmieri 9b7c0650b7
[release-branches] Fix the reference that gets checked out (#2294)
* Fix the reference that gets checked out

* Fix
2023-02-02 18:34:24 +00:00
Luca Palmieri 97daba2ccb
Fix syntax error when grouping commands. (#2293) 2023-02-02 18:16:56 +00:00
Luca Palmieri 6d3445473e
Use curly braces to group together the commit and push action (#2292) 2023-02-02 18:09:26 +00:00
Luca Palmieri edb7158228
`git push origin` fails if there is nothing to push. (#2291) 2023-02-02 17:57:19 +00:00
Luca Palmieri 3ccb2d7910
Set user name and email when committing (#2290) 2023-02-02 17:20:18 +00:00
Luca Palmieri 27429c8b79
Fix paths. (#2288) 2023-02-02 15:53:19 +00:00
Luca Palmieri 20e12f663c
Use larger machines for the slowest CI jobs. (#2263)
* Use larger machines for the slowest CI jobs.

* Fix invocation.
2023-02-02 15:41:51 +00:00
Luca Palmieri bdabbf0835
Persist the modified gradle.properties outside of the Docker context (#2287)
* Fix if condition.

* Make sure that the changes are visible to the push step after the Docker action has executed by persisting the modified repository as an artifact.

* Give a name to the argument.
2023-02-02 14:42:49 +00:00
Luca Palmieri 649f758638
Fix if condition. (#2286) 2023-02-02 13:33:08 +00:00
Luca Palmieri 2682708e11
Use action-arguments for arguments. (#2285) 2023-02-02 13:26:56 +00:00
Luca Palmieri 20c4839cf4
We need to checkout in the `smithy-rs` folder because that's an assumption baked into the definition of the docker-build action. (#2284) 2023-02-02 12:43:26 +00:00
Luca Palmieri 344bf3ee48
Fix action paths. (#2283) 2023-02-02 12:31:03 +00:00
Luca Palmieri 1b87953483
Fix trigger for following jobs. (#2282) 2023-02-02 12:26:21 +00:00
Luca Palmieri 2695c7cffb
Get verbose logging from the branch script. (#2281) 2023-02-02 12:18:20 +00:00
Luca Palmieri 097f1ca6d0
Update gradle properties for dry runs as well. (#2280) 2023-02-02 12:06:38 +00:00