dnrops
/
smithy-rs
mirror of https://github.com/smithy-lang/smithy-rs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Define a function to return operation shapes that need a `ValidationException` (#3720) 

Refactor and define a separate function that returns a set of operation
shapes that must have a supported validation exception shape in their
associated errors list.

This helps identify which type of `ValidationException` has been added
to the operation shape's errors list.

Closes: [3722](https://github.com/smithy-lang/smithy-rs/issues/3722)

---------

Co-authored-by: Fahad Zubair <fahadzub@amazon.com>
Co-authored-by: david-perez <d@vidp.dev>
This commit is contained in:
Fahad Zubair 2024-06-28 12:32:19 +01:00 committed by GitHub
parent e56f0dd632
commit 5498a180cf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 21 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/ValidateUnsupportedConstraints.kt
View File

@ -175,6 +175,26 @@ data class LogMessage(val level: Level, val message: String)
data class ValidationResult(val shouldAbort: Boolean, val messages: List<LogMessage>) :
Throwable(message = messages.joinToString("\n") { it.message })
/*
* Returns the set of operation shapes that must have a supported validation exception shape
* in their associated errors list.
*/
fun operationShapesThatMustHaveValidationException(
model: Model,
service: ServiceShape,
): Set<OperationShape> {
val walker = DirectedWalker(model)
return walker.walkShapes(service)
.filterIsInstance<OperationShape>()
.asSequence()
.filter { operationShape ->
// Walk the shapes reachable via this operation input.
walker.walkShapes(operationShape.inputShape(model))
.any { it is SetShape || it is EnumShape || it.hasConstraintTrait() }
}
.toSet()
}
/**
* Validate that all constrained operations have the shape [validationExceptionShapeId] shape attached to their errors.
*/
@ -189,14 +209,7 @@ fun validateOperationsWithConstrainedInputHaveValidationExceptionAttached(
// `disableDefaultValidation` set to `true`, allowing service owners to map from constraint violations to operation errors.
val walker = DirectedWalker(model)
val operationsWithConstrainedInputWithoutValidationExceptionSet =
walker.walkShapes(service)
.filterIsInstance<OperationShape>()
.asSequence()
.filter { operationShape ->
// Walk the shapes reachable via this operation input.
walker.walkShapes(operationShape.inputShape(model))
.any { it is SetShape || it is EnumShape || it.hasConstraintTrait() }
}
operationShapesThatMustHaveValidationException(model, service)
.filter { !it.errors.contains(validationExceptionShapeId) }
.map { OperationWithConstrainedInputWithoutValidationException(it) }
.toSet()