7023988020
Use `utils::sugg` in `TOPLEVEL_REF_ARG`
2016-07-01 17:12:48 +02:00
7a1fc9fce5
Use `utils::sugg` in `MATCH_BOOL`
2016-07-01 17:12:48 +02:00
66808c1e77
Use `utils::sugg` in `COLLAPSIBLE_IF`
2016-07-01 17:12:48 +02:00
2e8edde6e9
Use `utils::sugg` in `FLOAT_CMP`
2016-07-01 17:12:48 +02:00
8d58a928e5
Use `utils::sugg` in `ASSIGN_OPS`
2016-07-01 17:12:48 +02:00
580ae5a879
Use `span_suggestion` in `FLOAT_CMP`
2016-07-01 17:12:48 +02:00
a12e8394d7
new lint: double_neg
2016-06-30 01:00:25 +02:00
9e76bcee5d
Improve `matches` tests
2016-06-29 17:10:21 +02:00
ea76ac5562
Make `COLLAPSIBLE_IF` consider `if let`
2016-06-29 17:09:39 +02:00
7fa38f6787
Fix FP with `mut_mut` and `for` loops
2016-06-29 17:09:39 +02:00
9ceb708727
Merge pull request #1053 from oli-obk/char_float_transmute
...
lint on unnecessary and plain wrong transmutes
2016-06-28 14:50:39 +02:00
e06bc37477
lint on unnecessary and plain wrong transmutes
2016-06-28 14:08:08 +02:00
cdce78a4be
Add parentheses when necessary in transmute suggestion ( fixes #1049 )
2016-06-28 14:03:46 +05:30
a469ee1061
lint transmuting references to pointers
2016-06-27 16:12:48 +02:00
60cc87baba
Merge pull request #1041 from oli-obk/procedural
...
don't depend on regex_macros anymore
2016-06-26 14:13:24 +02:00
2e86eb88f3
rename mini-macro to clippy-mini-macro-test
2016-06-26 13:26:30 +02:00
8c5e617c9a
don't lint on comparing `*const f32`s
2016-06-25 18:59:37 +02:00
d57192d5c1
don't depend on regex_macros anymore
2016-06-25 18:12:29 +02:00
f81d253c07
Merge pull request #995 from oli-obk/oh_the_horror
...
lint on `filter(x).map(y)`, `filter(x).flat_map(y)`, `filter_map(x).flat_map(y)`
2016-06-22 13:06:12 +02:00
5ccbf3d437
unify the lints
2016-06-22 10:44:46 +02:00
294aeaf4b3
Merge pull request #1012 from Manishearth/nohyg
...
Don't use identifier hygiene in HIR
2016-06-21 21:23:39 +02:00
ac6e7b2957
fix tests
2016-06-21 14:46:02 +02:00
eef439cb78
add tests
2016-06-21 13:48:56 +02:00
44c30ca543
fix tests
2016-06-21 12:35:49 +02:00
12bc90d457
Add tests for extend-iter-nth
2016-06-16 14:39:29 -07:00
f3397afacb
Merge pull request #994 from oli-obk/stuttter
...
Stuttter lint
2016-06-16 19:00:43 +02:00
4e8c87ad08
Merge pull request #1021 from Manishearth/issue1017
...
Fix FP with `WHILE_LET_LOOP` and break expressions
2016-06-16 16:30:44 +02:00
836554387a
Fix FP with `WHILE_LET_LOOP` and break expressions
2016-06-16 16:21:11 +02:00
32894d503e
lint enum variants names that start or end with their enum's name
2016-06-16 12:17:15 +02:00
74025be59d
Make iter_nth work for `Vec`s too
2016-06-16 02:04:32 -07:00
555e4555b1
Add tests for slice_iter_nth
2016-06-16 01:29:03 -07:00
e6cbe970c8
Don't use identifier hygiene in HIR
2016-06-15 16:36:22 +02:00
90453fd893
Run rustfmt
...
Only partially apply suggestions.
2016-06-10 00:08:14 +02:00
e6832317fa
Merge pull request #999 from Manishearth/whitelist
...
Some small fixes
2016-06-10 00:04:50 +02:00
e9360f7675
Fix suggestions for `REVERSE_RANGE_LOOP`
2016-06-09 23:34:19 +02:00
ce2b96abe9
Fix yet another FP in `USELESS_LET_IF_SEQ`
...
The block expression before the assignment must be `None`.
2016-06-09 23:33:38 +02:00
c5affa2efc
Whitelist Nan in `DOC_MARKDOWN`
2016-06-09 23:33:28 +02:00
8e1dc0481c
Include `consts` in the approx_consts lint for easier copypasting
...
If you try to use `f64::PI`, it won't work-- you need to use
`f64::consts::PI`, so suggest that in the lint message.
2016-06-08 19:58:29 -04:00
1f419a2986
Add missing suggestions and help message to tests
2016-06-07 18:33:24 +02:00
dd3fd41a03
Use `span_suggestion` for `WHILE_LET_ON_ITERATOR`
2016-06-07 18:32:40 +02:00
65c4e391ee
Fix wrong tests and improve some other
2016-06-07 17:32:36 +02:00
a7a6c0461d
Add environment variable to deactivate wiki links
2016-06-05 22:03:02 +02:00
158183adf5
Fix false-positive in `USELESS_LET_IF_SEQ`
2016-06-05 21:46:48 +02:00
9f70d04000
Fix wrong suggestion with `MANUAL_SWAP` and slices
2016-06-05 20:19:00 +02:00
66c03f980e
Merge pull request #962 from Manishearth/fix-doc
...
Fix DOC_MARKDOWN and multiline links and quotes
2016-06-04 09:24:39 +02:00
5c2a10d703
Correctly check for variable use in `useless_let_if_seq`
2016-06-03 19:35:39 +02:00
bf4ce86e9e
Make new_without_default ignore const fns; fixes #977
2016-06-03 20:17:39 +05:30
49982036fc
only lint `new_without_default` for public items
...
This fixes #953 .
2016-06-01 23:35:14 +02:00
2811dd64ec
added missing PatKind::Path + tests
2016-05-31 23:35:42 +02:00
1b112f96b8
added mcarton's test suggestion
2016-05-31 23:30:49 +02:00
ef5db37d9d
additional error in copies test annotated
2016-05-31 23:30:49 +02:00
80e81d351d
add version check to the unit tests
2016-05-30 12:47:04 +02:00
42879bcdcb
Add a `USELESS_LET_IF_SEQ` lint
2016-05-29 12:19:12 +02:00
a892a96eeb
Rustup to *1.10.0-nightly (7bddce693 2016-05-27)*
2016-05-28 16:35:38 +02:00
97c9930a3f
Fix `doc_markdown` and multiline quotes and links
2016-05-28 03:22:55 +02:00
ac0bb4126c
Improve markdown parsing for the doc lint
2016-05-28 02:08:01 +02:00
bf227f4729
split clippy into lints, plugin and cargo-clippy
2016-05-27 13:03:58 +02:00
5eca09793e
needless_borrow reported on &&T when only &T implements Trait and &Trait is required
2016-05-27 12:12:38 +02:00
4c347320be
Merge pull request #955 from Manishearth/regexes
...
Regexes
2016-05-26 00:00:07 +02:00
51d166f17a
Support `RegexBuilder`
2016-05-25 21:36:51 +02:00
4f11f84dee
Lint binary regexes
2016-05-25 21:14:14 +02:00
bb69e60b30
fix no_effect lint
2016-05-25 18:51:35 +02:00
9cfc42275d
Split `new_without_default` and `new_without_default_derive`.
...
This is still very slow, because we do a trait lookup for each field.
Perhaps storing the visited types in a set to reuse types would improve
performance somewhat. Also we may want to pre-decide some known types
(e.g. `Vec<T>`, `Option<T>`).
2016-05-24 18:22:18 +02:00
ac2e175c1b
Rustup to *1.10.0-nightly (476fe6eef 2016-05-21)*
2016-05-23 16:36:10 +02:00
6dd608e53e
Rustup to *1.10.0-nightly (764ef92ae 2016-05-19)*
2016-05-23 16:11:28 +02:00
2a5416d662
Rustup to *1.10.0-nightly (9c6904ca1 2016-05-18)*
2016-05-23 16:11:19 +02:00
ca05e93c10
Rustup to *1.10.0-nightly (cd6a40017 2016-05-16)*
2016-05-17 23:25:20 +02:00
4c4b1af03c
Merge pull request #928 from oli-obk/unnecessary_operation
...
add a companion lint to `no_effect` with suggestions for partially (in-)effective statements
2016-05-13 17:45:58 +02:00
1e897f1552
add a companion lint to `no_effect` with suggestions for partially effective statements
2016-05-13 16:43:47 +02:00
ecca55cd9f
Merge pull request #927 from oli-obk/german_windows_32bit
...
German windows 32bit
2016-05-13 15:41:49 +02:00
d4e11acc1f
make sure compiletest works on windows
2016-05-13 14:16:08 +02:00
c37300d899
ignore the portability test on 32 bit
...
it will fail in rustc
2016-05-13 13:45:53 +02:00
86e4216a56
don't check for an exact error message
...
the system might change it, especially if the system language is changed
2016-05-13 13:45:25 +02:00
87df6ae8cb
fix typos
2016-05-13 08:50:51 +03:00
610883b7aa
don't suggest closures over constants
...
fixes #917
2016-05-12 10:23:06 +02:00
8fa68f1e08
Merge pull request #913 from oli-obk/assign_ops
...
suggest `a op= b` over `a = a op b`
2016-05-11 23:36:10 +02:00
0bef7b5f74
merge struct similar_name test into the general test file
2016-05-11 17:01:34 +02:00
49e2570b77
don't lint at the use-site of bad struct field bindings if they're shorthand
...
fixes #899
2016-05-11 16:44:43 +02:00
c6b4b19a43
suggest `a op= b` over `a = a op b`
2016-05-11 15:32:20 +02:00
654154d8e7
`cargo clippy` subcommand
2016-05-09 16:47:32 +02:00
87faaec7a3
add needless_borrow lint
2016-05-09 13:07:43 +02:00
d70e7bb5fc
Merge pull request #906 from Manishearth/birkenfeld-master
...
Rustup to *rustc 1.10.0-nightly (62e2b2fb7 2016-05-06)*
2016-05-07 21:31:21 -07:00
aa10c93e8f
Fix tests
2016-05-08 01:13:05 +02:00
3ce60e9731
Don’t warn in titles in DOC_MARKDOWN
2016-05-05 21:49:57 +02:00
cc2774df60
Test previously reported false positive
2016-05-05 21:34:42 +02:00
e14e1a7148
Fix issue with `DOC_MARKDOWN` and punctuation
2016-05-05 21:33:46 +02:00
365644e9e6
doc markdown lint's span shows the line instead of the item
2016-05-02 14:36:33 +02:00
f6290b622c
Merge branch 'pr-890'
2016-05-02 14:43:11 +05:30
0b40ae178a
fixed tests, added clippy_restrictions lint group
2016-04-30 23:54:10 +02:00
a967440186
lint remainder, document test w/ half expr
2016-04-30 17:11:59 +02:00
9a99979cc4
fix #887 : New lints for integer/floating-point arithmetic
2016-04-30 04:01:47 +02:00
cf5c1ab0b6
Fix paths resolution
...
Put more paths into the `utils::paths` module.
2016-04-26 13:31:52 +02:00
bf4221c51a
cc: early returns are special
2016-04-23 14:30:05 +02:00
30f7651271
Merge pull request #867 from Manishearth/#830
...
Check type for `SINGLE_CHAR_PATTERN`
2016-04-23 10:54:22 +02:00
77427b6ead
Limited mem_forget error to only Drop types (fails)
2016-04-20 19:24:31 -07:00
5158a08c5b
Changed std::mem::forget errors to mem::forget
2016-04-20 18:55:41 -07:00
447940c889
Added lint for mem_forget
2016-04-20 13:10:23 -07:00
de9a80cd10
Check type for `SINGLE_CHAR_PATTERN`
...
It’d be nicer to actually check for `Pattern` bounds but in the meantime
this needs to be fixed.
2016-04-20 21:16:59 +02:00
84a480b02b
Expanded tests for unsafe_removed_from_name
2016-04-19 21:52:10 -07:00
038f528f45
Added lint for use imports which remove unsafe from name
2016-04-19 16:31:26 -07:00
mcarton