Commit Graph

631 Commits

Author SHA1 Message Date
Georg Brandl ffad9a8c8c Lint print!("...\n") (closes #455) 2016-08-16 20:52:48 +02:00
Oliver Schneider b6f320a495
address nits and improve docs 2016-08-16 14:36:48 +02:00
Oliver Schneider 7ee4a9a659
lint modules that have the same name as their parent module 2016-08-16 14:29:21 +02:00
scurest b0a96def09 Add lint for reads and writes that depend on evaluation order 2016-08-11 06:01:40 -05:00
llogiq ce3be22021 Merge pull request #1151 from oli-obk/clone_ref
add suggestions to clone_on_copy
2016-08-09 06:30:25 +02:00
llogiq 8ac99162ea Merge pull request #1152 from oli-obk/wrong_self_conv_fn_level
enable changing wrong_self_convention's lint level at the function level
2016-08-08 21:13:16 +02:00
Manish Goregaokar 4b8f6a0b0f Merge pull request #1154 from oli-obk/no_dogfood_for_travis
don't run clippy on itself twice in travis
2016-08-08 21:48:29 +05:30
Oliver Schneider dec3250ad6
don't run clippy on itself twice in travis 2016-08-08 17:33:41 +02:00
Oliver Schneider 331afc3246
extern fns often need to adhere to a specific api -> don't suggest api-changes 2016-08-08 17:21:47 +02:00
Oliver Schneider 49f276ec6f
enable changing wrong_self_convention's lint level at the function level 2016-08-08 17:09:36 +02:00
Oliver Schneider 7e67f447ce
add suggestions to clone_on_copy
also:

* don't report clone_on_copy when reporting clone_on_double_ref
* don't suggest `((x))`
2016-08-08 16:43:45 +02:00
Manish Goregaokar 74c7880597 Merge pull request #1145 from birkenfeld/issue-703-2
Lint literal suffixes not separated by underscores (idea also from #703)
2016-08-07 09:57:16 +05:30
Georg Brandl fa0df69a97 Add a configurable threshold for enum variants before name lints trigger (fixes #1138) 2016-08-06 20:59:27 +02:00
Georg Brandl 2f8247ada5 Lint literal suffixes not separated by underscores (see #703) 2016-08-05 18:50:23 +02:00
Georg Brandl ab58331f22 Lint inconsistent casing in hex literals (closes #703) 2016-08-05 18:30:49 +02:00
Oliver Schneider 81c5757f44
lint on by ref patterns for references 2016-08-01 16:59:14 +02:00
Oliver Schneider 100d381d2b
lint `a += a + b` (possible mis-refactoring of `a = a + b`) 2016-07-20 15:29:24 +02:00
llogiq a371558bdb Merge pull request #1093 from oli-obk/serde_specific_lint
lint on implementing `visit_string` without also implementing `visit_str`
2016-07-18 11:53:28 +02:00
Oliver Schneider 02c46f057f
add an internal lint that catches misordered paths 2016-07-18 11:19:33 +02:00
Manish Goregaokar b8c5e5a89c
Fix position of mut in toplevel-ref-arg (fixes #1100, again) 2016-07-15 19:02:41 +05:30
Manish Goregaokar 60f354880f
Suggest mutability and fix type in toplevel-ref-arg 2016-07-15 17:52:34 +05:30
llogiq b1becf41e4 Merge pull request #1099 from Manishearth/fix
Some small fixes
2016-07-14 21:32:45 +02:00
mcarton ea665c38f1
Fix FP with `USELESS_VEC` and non-copy types 2016-07-14 19:31:17 +02:00
mcarton c1eb5828fa
Fix suggestion spans for `NEEDLESS_RETURN` 2016-07-14 18:32:48 +02:00
Taylor Cramer 7450d842ea Fix different NaNs in if const expressions test 2016-07-13 10:02:28 -07:00
Taylor Cramer 61d1a9b030 Check for comparison of -0.0 and 0.0 in PartialOrd for Constant 2016-07-13 09:55:16 -07:00
Taylor Cramer 0c21a6b0c4 Add test for different NaNs 2016-07-13 09:35:31 -07:00
Taylor Cramer 8907cbc0b8 Added sign check on Constant f64 PartialEq implementation 2016-07-13 00:43:33 -07:00
Oliver Schneider 319c66a2a4
lint on implementing `visit_string` without also implementing `visit_str` 2016-07-12 17:36:11 +02:00
Manish Goregaokar c1421c6e82
Don't warn when boxing large arrays 2016-07-12 18:49:34 +05:30
mcarton b8b6b7fee6
Try to explain `MATCH_SAME_ARMS` better 2016-07-10 14:46:39 +02:00
mcarton eb75d4ee62
Fix suggestions for `NEW_WITHOUT_DEFAULT` 2016-07-10 14:20:38 +02:00
mcarton 3a7402a6d2
Fix FP with `for` loops and shadowed loop variable 2016-07-10 14:05:57 +02:00
llogiq ad1cd99054 Merge pull request #1060 from Manishearth/sugg
Improve suggestions
2016-07-10 00:06:30 +02:00
mcarton 56d3bc7008
Handle `/**` and `~~~` in `DOC_MARKDOWN` 2016-07-08 18:24:47 +02:00
mcarton c5e91e70d0
Use `sugg::Sugg` in transmute links 2016-07-04 02:22:57 +02:00
mcarton 9b79b1022c
Fix suggestions for `needless_bool` 2016-07-04 01:43:47 +02:00
mcarton 7778f314f2
Merge branch 'master' into sugg 2016-07-04 00:51:19 +02:00
mcarton 2f259b8cd3
Use `span_suggestion` in entry lints 2016-07-03 23:27:44 +02:00
mcarton ffa840d4f2
Use `utils::sugg` in `match` related lints
Also don't build suggestion when unnecessary.
2016-07-03 23:27:37 +02:00
James Lucas 10b545e30b Check for constant expression in useless_vec lint 2016-07-03 12:12:43 -07:00
mcarton 0e3dcd1376
Improve `NOT_UNSAFE_PTR_ARG_DEREF` with functions 2016-07-03 13:29:04 +05:30
mcarton 7781f1d7c5 Add a new `not_unsafe_ptr_arg_deref` lint 2016-07-03 13:28:34 +05:30
mcarton 2a45a2ab6b
Use `utils::sugg` in `FOR_KV_MAP` 2016-07-01 20:55:45 +02:00
mcarton f6c9490e65
Fix wrong suggestion with `...` and for loops 2016-07-01 19:31:14 +02:00
mcarton 9bd7fa05e0
Improve `NEEDLESS_RANGE_LOOP` error reporting 2016-07-01 18:53:04 +02:00
mcarton d6182b365c
Merge remote-tracking branch 'origin/rustup' into sugg 2016-07-01 17:48:57 +02:00
mcarton 55b78ae478
Rustup to ea0dc9297283daff6486807f43e190b4eb561412 II 2016-07-01 17:44:17 +02:00
mcarton 3c4af49662
Rustup to ea0dc9297283daff6486807f43e190b4eb561412 2016-07-01 17:44:17 +02:00
mcarton ebf72cb67f
Use `util::sugg` in `TRANSMUTE_PTR_TO_REF` 2016-07-01 17:12:48 +02:00