dnrops
/
rust-clippy
mirror of https://github.com/rust-lang/rust-clippy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
18,728 Commits 6 Branches 211 Tags 136 MiB
Commit Graph

288 Commits

Author SHA1 Message Date
Philipp Krones 46c5a5d234 Merge commit 'f4850f7292efa33759b4f7f9b7621268979e9914' into clippyup 2022-11-21 20:51:52 +01:00
Alex Macleod 637139d2ff Add `clippy_utils::msrv::Msrv` to keep track of the current MSRV 2022-11-21 18:16:40 +00:00
bors 634987b49e Auto merge of #9712 - Alexendoo:old-generated-files, r=flip1995 
Remove `lib.register_*` and `src/docs*` in `cargo dev update_lints`

Follow up to #9709 / #9541

There's a good number of PRs with some leftover `src/docs` files for example, and as a reviewer it's something we're used to ignoring so it can easily slip through

r? `@flip1995`

changelog: none
 2022-10-25 13:20:31 +00:00
Alex Macleod 22d435b266 Remove `lib.register_*` and `src/docs*` in `cargo dev update_lints` 2022-10-25 13:18:50 +00:00
Alex Macleod bd8369089c Track `clippy.toml` and `Cargo.toml` in `file_depinfo` 
Causes cargo to re-run clippy when those paths are modified

Also tracks the path to `clippy-driver` in debug mode to remove the
workarounds in `cargo dev lint` and `lintcheck`
 2022-10-25 11:32:49 +00:00
Alex Macleod a201518a8a Generate lint categories and explanations with `declare_clippy_lint` 
Changes it to be a proc_macro rather than macro_rules
 2022-10-23 20:32:26 +00:00
flip1995 cd0bb7de01 Merge commit '4f142aa1058f14f153f8bfd2d82f04ddb9982388' into clippyup 2022-10-23 15:18:45 +02:00
est31 f48d13f8d1 Replace manual let else patterns with let else 2022-10-11 00:12:16 +02:00
Samuel Moelius 9cc8da222b Fix adjacent code 2022-10-07 05:07:44 -04:00
Philipp Krones d75b25faab Merge commit 'ac0e10aa68325235069a842f47499852b2dee79e' into clippyup 2022-10-06 09:44:38 +02:00
bors cb8da67194 Auto merge of #9509 - schubart:fix_sorting, r=llogiq 
Fix sorting in ` cargo dev update_lints` script

changelog: none

The old code cloned and sorted `usable_lints` into `sorted_usable_lints`, but then failed to do anything with `sorted_usable_lints`.

This was discovered by my new `collection_is_never_read` lint (#9267) that I'm working on!

Fix: I renamed the sorted vector to `usable_lints`.  Therefore it now gets used where the unsorted one was used previously.
 2022-10-02 07:51:45 +00:00
Philipp Krones bbcde66685
Merge remote-tracking branch 'upstream/master' into rustup 2022-09-28 14:27:32 +02:00
Pietro Albini 06568fd6c7 remove cfg(bootstrap) 2022-09-26 10:14:45 +02:00
Yuri Astrakhan cc6b375cd3 fallout2: rework clippy_dev & _lints fmt inlining 
* Inline format args where possible
* simplify a few complex macros into format str
* use formatdoc!() instead format!(indoc!(...))
 2022-09-23 23:08:12 -04:00
Yuri Astrakhan 59d0e8caba and a few more from other dirs 2022-09-23 14:25:03 -04:00
Michael Schubart 033dae9ecc Actually use the sorted vector 2022-09-21 19:04:31 +01:00
David Koloski 4d015293d1 Merge commit '7248d06384c6a90de58c04c1f46be88821278d8b' into sync-from-clippy 2022-09-21 13:13:27 -04:00
Alex Macleod 6d8959ea83 Add `#[allow(unused)]` to test in `cargo dev new_lint` 2022-09-16 21:04:38 +00:00
est31 2be8b73328 Fix clippy 2022-09-15 21:21:18 +02:00
Philipp Krones 98bf99e2f8 Merge commit 'b52fb5234cd7c11ecfae51897a6f7fa52e8777fc' into clippyup 2022-09-09 13:36:26 +02:00
Philipp Krones 4ee55c5528
Merge remote-tracking branch 'upstream/auto' into rustup 2022-09-08 21:27:09 +02:00
Jason Newcomb abd3e7eabb Allow lint passes to be bound by `TyCtxt` 2022-09-06 14:23:03 -04:00
Andre Bogus ad72aee93c add `--explain` subcommand 2022-09-02 22:17:39 +02:00
Jason Newcomb d4a0785464 Correctly handle unescape warnings 2022-09-01 00:00:37 -04:00
Jason Newcomb fb41bfa774 Merge commit 'f51aade56f93175dde89177a92e3669ebd8e7592' into clippyup 2022-08-31 09:24:45 -04:00
Nilstrieb ce847beb47 Revert let_chains stabilization 
This reverts commit 326646074940222d602f3683d0559088690830f4.

This is the revert against master, the beta revert was already done in #100538.
 2022-08-29 19:34:11 +02:00
bors 868dba9f65 Auto merge of #9295 - Guilherme-Vasconcelos:manual-empty-string-creation, r=dswij 
Add `manual_empty_string_creations` lint

Closes #2972

- [x] Followed [lint naming conventions][lint_naming]
- [x] Added passing UI tests (including committed `.stderr` file)
- [x] `cargo test` passes locally
- [x] Executed `cargo dev update_lints`
- [x] Added lint documentation
- [x] Run `cargo dev fmt`

changelog: [`manual_empty_string_creations`]: Add lint for empty String not being created with `String::new()`
 2022-08-19 11:19:06 +00:00
Samuel E. Moelius III 032f112745 Fix adjacent code 2022-08-16 18:34:51 -04:00
Guilherme-Vasconcelos 1bf8841479 Update all tests to comply with clippy::manual_empty_string_creations 2022-08-14 12:53:15 -03:00
Mark Rousskov 1a3192a331 Adjust cfgs 2022-08-12 16:28:15 -04:00
Philipp Krones dc29cfb8d5 Merge commit '2b2190cb5667cdd276a24ef8b9f3692209c54a89' into clippyup 2022-08-11 19:42:16 +02:00
Philipp Krones 879855bbaf
Merge remote-tracking branch 'upstream/master' into rustup 2022-08-11 19:26:04 +02:00
Philipp Krones 67c405cc1d Merge commit '3c7e7dbc1583a0b06df5bd7623dd354a4debd23d' into clippyup 2022-07-28 19:08:22 +02:00
Philipp Krones 0905ec465d
Merge remote-tracking branch 'upstream/master' into rustup 2022-07-28 18:55:32 +02:00
Serial 1ed7bff32c Tell the user how to revert `dev setup intellij` 2022-07-28 03:40:21 -04:00
Serial f31937043d Implicitly set `--type=cargo` when using `--category=cargo` 2022-07-26 19:32:34 -04:00
Serial c8ee8c30f0 Give the user more information during creation 2022-07-26 19:18:10 -04:00
Serial 51cd5a8667 Add `--type` flag to `dev new_lint` 2022-07-25 22:35:28 -04:00
Philipp Krones 7d4daaa8fa Merge commit 'fdb84cbfd25908df5683f8f62388f663d9260e39' into clippyup 2022-07-18 09:39:37 +02:00
Caio f88a1399bb Stabilize `let_chains` 2022-07-16 20:17:58 -03:00
Josh Triplett b7230d4f44 Dogfood fixes to use `bool::then_some` 2022-07-06 02:03:56 -07:00
bors d4488a520a Auto merge of #9039 - Serial-ATA:dev-dogfood, r=giraffate 
Add `cargo dev dogfood`

changelog: Add `cargo dev dogfood`

Part of #5394
 2022-07-01 01:07:25 +00:00
Philipp Krones 09f5df5087 Merge commit '0cb0f7636851f9fcc57085cf80197a2ef6db098f' into clippyup 2022-06-30 10:50:09 +02:00
Philipp Krones f26cf11fe8
Merge remote-tracking branch 'upstream/master' into rustup 2022-06-30 10:27:25 +02:00
Jason Newcomb 5e2a2d3ac9 Fix dogfood 2022-06-28 13:02:08 -04:00
Serial d42af68e03 Add `cargo dev dogfood` 2022-06-23 12:16:34 -04:00
Serial ebf77f6d7e Fix ICE when deprecating lints in directories 2022-06-23 10:44:11 -04:00
Serial 2bd1581bbf Add `dev deprecate` 2022-06-21 13:43:47 -04:00
Matthias Krüger 4737e9e42b Rollup merge of #98165 - WaffleLapkin:once_things_renamings, r=m-ou-se 
once cell renamings

This PR does the renamings proposed in https://github.com/rust-lang/rust/issues/74465#issuecomment-1153703128

- Move/rename `lazy::{OnceCell, Lazy}` to `cell::{OnceCell, LazyCell}`
- Move/rename `lazy::{SyncOnceCell, SyncLazy}` to `sync::{OnceLock, LazyLock}`

(I used `Lazy...` instead of `...Lazy` as it seems to be more consistent, easier to pronounce, etc)

```@rustbot``` label +T-libs-api -T-libs
 2022-06-19 00:17:13 +02:00
Maybe Waffle f095f802dc Move/rename `lazy::Sync{OnceCell,Lazy}` to `sync::{Once,Lazy}Lock` 2022-06-16 19:54:42 +04:00
flip1995 f8f9d01c2a Merge commit 'd7b5cbf065b88830ca519adcb73fad4c0d24b1c7' into clippyup 2022-06-16 17:39:06 +02:00
Jason Newcomb cccc750046 Fix `clap` deprecation warnings 2022-06-13 21:57:17 -04:00
flip1995 b551928800
Auto update lint count in Clippy book 2022-06-06 16:17:58 +02:00
Philipp Krones f067783461 Merge commit 'd9ddce8a223cb9916389c039777b6966ea448dc8' into clippyup 2022-06-04 13:34:07 +02:00
Marcel Hellwig 9b55ea78c8 update dependencies 2022-05-23 09:28:49 +02:00
xFrednet 4587b6628d Merge 'rust-clippy/master' into clippyup 2022-05-21 13:24:00 +02:00
Jason Newcomb f7378daf71 Add renamed lints to the changelog link list 2022-05-15 17:10:48 -04:00
ydah 4e5f69cc86 Tweak some words improved representation 
This PR has implemented improved representation.

- Use "lib" instead of "lifb"
- Use "triggered" instead of "triggere"
- Use "blacklisted_name" instead of "blackisted_name"
- Use "stabilization" instead of "stabilisation"
- Use "behavior" instead of "behaviour"
- Use "target" instead of "tartet"
- Use "checked_add" instead of "chcked_add"
- Use "anti-pattern" instead of "antipattern"
- Use "suggestion" instead of "suggesttion"
- Use "example" instead of "exampel"
- Use "Cheat Sheet" instead of "Cheatsheet"
 2022-05-13 14:20:25 +09:00
nsunderland1 fe84ff3360 New lint: [`derive_partial_eq_without_eq`] 2022-05-09 22:13:39 -07:00
Alex Macleod 905a951718 Pass through extra args in `cargo dev lint` 2022-05-06 15:36:46 +01:00
flip1995 7cd86aa1be Merge commit '7c21f91b15b7604f818565646b686d90f99d1baf' into clippyup 2022-05-05 15:12:52 +01:00
flip1995 3b0c78d283
Merge remote-tracking branch 'upstream/master' into rustup 2022-05-05 13:32:06 +01:00
bors 32fe4762bf Auto merge of #8625 - Jarcho:rename_lint, r=xFrednet 
Add `cargo dev rename_lint`

fixes #7799

changelog: None
 2022-04-30 17:22:34 +00:00
Jason Newcomb b3de32ba3c Add `rename_lint` command 2022-04-24 09:15:26 -04:00
whodi 2be7ad5b39 initialization misspell 2022-04-15 14:19:00 -07:00
whodi 29ef80c78a adding spell checking 2022-04-15 14:18:09 -07:00
Peter Jaszkowiak 67badbeef6 New lint `format_add_strings` 2022-04-13 22:48:36 -06:00
Yoav Lavi ffde78b456 Allow passing --remove to `cargo dev setup <SUBCOMMAND>` 
add missing args

unque name not needed

more descriptive help

formatting fixes

missing quote
 2022-04-09 16:50:10 +02:00
flip1995 da26623d54 Update Cargo.lock 2022-04-08 10:41:55 +01:00
flip1995 71131351de Merge commit '984330a6ee3c4d15626685d6dc8b7b759ff630bd' into clippyup 2022-04-08 10:06:10 +01:00
flip1995 6ab4508350
Allow raw lint descriptions 
update_lints now understands raw strings in declare_clippy_lint
descriptions.

Co-authored-by: Alex Macleod <alex@macleod.io>
 2022-04-07 18:05:46 +01:00
bors 01ea6241ae Auto merge of #8607 - Alexendoo:cargo-dev-lint-dir, r=flip1995,giraffate 
Allow running `cargo dev lint` on a package directory

Allows you run the local clippy in a specified directory, e.g. allowing

```sh
# Lint a ui-cargo test
cargo dev lint tests/ui-cargo/wildcard_dependencies/fail

# Lint some other project
cargo dev lint ~/my-project
```

The `target` directory is set to a tempdir which isn't ideal for medium/large projects as it would be compiled from scratch. This is to avoid cached clippy messages where you `cargo dev lint dir`, change something in clippy, and run `cargo dev lint dir` again

changelog: Dev: `cargo dev lint` can now be run on a package directory
 2022-04-05 09:33:38 +00:00
Jason Newcomb d5ef542d37 Generate renamed lint test 2022-04-03 22:52:42 -04:00
Jason Newcomb 4227411513 Generate deprecated lints test 2022-04-03 08:54:37 -04:00
Jason Newcomb 7025283f3e Remove cargo_metadata dependency from clippy_dev 2022-04-01 23:18:47 -04:00
Jason Newcomb b3f8415032 Remove regex dependency from clippy_dev 2022-04-01 23:18:47 -04:00
Alex Macleod 9a02386fd8 Allow running `cargo dev lint` on a package directory 2022-03-29 19:03:36 +01:00
pierwill c8d6a55f6a Update `itertools` 
Update to 0.10.1
 2022-03-04 11:54:28 -06:00
flip1995 611d039814 Merge commit '57b3c4b90f4346b3990c1be387c3b3ca7b78412c' into clippyup 2022-02-10 18:40:06 +01:00
flip1995 bf66aeda0a Merge commit 'a98e7ab8b94485be6bd03e0c6b8682ecab5b52e6' into clippyup 2022-01-27 15:12:45 +01:00
flip1995 fb0142ae41 Merge commit '97a5daa65908e59744e2bc625b14849352231c75' into clippyup 2022-01-13 13:18:19 +01:00
flip1995 8fea1d94f3 Merge commit 'a5d597637dcb78dc73f93561ce474f23d4177c35' into clippyup 2021-12-06 12:33:31 +01:00
flip1995 e674d0a599 Merge commit 'e18101137866b79045fee0ef996e696e68c920b4' into clippyup 2021-11-04 12:52:36 +00:00
flip1995 7631fc5d82 Merge commit '91496c2ac6abf6454c413bb23e8becf6b6dc20ea' into clippyup 2021-10-21 13:11:36 +02:00
flip1995 5cf4984872 Merge commit 'b7f3f7f6082679da2da9a0b3faf1b5adef3afd3b' into clippyup 2021-10-07 11:21:30 +02:00
flip1995 23d5457e6d Merge commit 'cb7915b00c235e9b5861564f3be78dba330980ee' into clippyup 2021-09-28 18:03:12 +01:00
Samuel E. Moelius III 43ed2065cc Update dependencies 2021-09-09 07:47:16 -04:00
flip1995 091ed44b50 Merge commit '27afd6ade4bb1123a8bf82001629b69d23d62aff' into clippyup 2021-09-08 16:31:47 +02:00
Jade 6c2199ea9f rfc3052: Remove authors field from Cargo manifests 
Since RFC 3052 soft deprecated the authors field anyway, hiding it from
crates.io, docs.rs, and making Cargo not add it by default, and it is
not generally up to date/useful information, we should remove it from
crates in this repo.
 2021-07-29 14:56:05 -07:00
flip1995 2b20f49841 Merge commit '0cce3f643bfcbb92d5a1bb71858c9cbaff749d6b' into clippyup 2021-07-29 12:16:06 +02:00
flip1995 ebe52869a3 Merge commit '61eb38aeda6cb54b93b872bf503d70084c4d621c' into clippyup 2021-07-01 18:17:38 +02:00
flip1995 97705b7ea6 Merge commit '9e3cd88718cd1912a515d26dbd9c4019fd5a9577' into clippyup 2021-05-20 13:07:57 +02:00
Joshua Nelson af0dde24b9 Implement `x.py test src/tools/clippy --bless` 
- Add clippy_dev to the rust workspace

  Before, it would give an error that it wasn't either included or
  excluded from the workspace:

  ```
  error: current package believes it's in a workspace when it's not:
  current:   /home/joshua/rustc/src/tools/clippy/clippy_dev/Cargo.toml
  workspace: /home/joshua/rustc/Cargo.toml

  this may be fixable by adding `src/tools/clippy/clippy_dev` to the `workspace.members` array of the manifest located at: /home/joshua/rustc/Cargo.toml
  Alternatively, to keep it out of the workspace, add the package to the `workspace.exclude` array, or add an empty `[workspace]` table to the package's manifest.
  ```

- Change clippy's copy of compiletest not to special-case
  rust-lang/rust. Using OUT_DIR confused `clippy_dev` and it couldn't find
  the test outputs. This is one of the reasons why `cargo dev bless` used
  to silently do nothing (the others were that `CARGO_TARGET_DIR` and
  `PROFILE` weren't set appropriately).

- Run clippy_dev on test failure

I tested this by removing a couple lines from a stderr file, and they
were correctly replaced.

- Fix clippy_dev warnings
 2021-04-27 16:57:29 +00:00
flip1995 f6d1f368db Merge commit 'b40ea209e7f14c8193ddfc98143967b6a2f4f5c9' into clippyup 2021-04-08 17:50:13 +02:00
flip1995 9f6b5de7de Merge commit '0e87918536b9833bbc6c683d1f9d51ee2bf03ef1' into clippyup 2021-03-25 19:29:11 +01:00
flip1995 f2f2a005b4 Merge commit '6ed6f1e6a1a8f414ba7e6d9b8222e7e5a1686e42' into clippyup 2021-03-12 15:30:50 +01:00
flip1995 f64149dd04 Merge commit '928e72dd10749875cbd412f74bfbfd7765dbcd8a' into clippyup 2021-02-25 11:25:22 +01:00
flip1995 8b9f4a0d34 Merge commit '70c0f90453701e7d6d9b99aaa1fc6a765937b736' into clippyup 2021-02-11 15:04:38 +01:00
Manish Goregaokar c8cb90abbd Merge commit '3e4179766bcecd712824da04356621b8df012ea4' into sync-from-clippy 2021-02-02 20:43:30 -08:00
flip1995 ac912be984 Merge commit '95c0459217d1661edfa794c8bb122452b92fb485' into clippyup 2021-01-30 18:06:34 +01:00