Commit Graph

3701 Commits

Author SHA1 Message Date
Oliver Schneider 6662aa41f9
Merge branch 'master' into fix_cow 2018-03-05 08:42:19 +01:00
Oliver Schneider f071d1994f
Merge pull request #2504 from flip1995/lit_float_repr
Fix unreadable_literal lint for scientific float notation
2018-03-05 08:38:32 +01:00
Oliver Schneider 5b48b03375
Typo 2018-03-05 08:33:37 +01:00
Oliver Schneider 3138c7a8c4
Merge pull request #2506 from HMPerson1/fix_2496
Fix #2496
2018-03-05 08:32:32 +01:00
Hidehito Yabuuchi 7b59557dcd Don't lint range syntax with var name `start` and `end` 2018-03-05 14:31:37 +09:00
HMPerson1 3045f432c7
Fix #2496 2018-03-04 22:56:03 -05:00
flip1995 86ce897084
Fix unreadable_literal lint for scientific float notation 2018-03-04 16:28:34 +01:00
Martin Carton e5f2d62c46
Merge pull request #2502 from flip1995/compiletest_version
Use compiletest version v0.3.7
2018-03-04 16:17:50 +01:00
flip1995 926e8ff48a
Use compiletest version v0.3.7 2018-03-04 13:20:25 +01:00
bootandy e3c13da830 Change recomendation to: &[type] from Cow<type> 2018-03-03 12:25:20 -05:00
Alex Butler fc5b377cec Fix #2494 add suggestion for unreadable_literal
Add `rustc --explain E0308` line to relevant tests
2018-03-03 12:25:20 -05:00
Bruce Mitchener 769a1d9b6c Fix single_char_pattern for \n, \t, etc.
Single characters that are escaped weren't being searched / replaced
correctly in the hint string, so it was saying to replace, say,
`"\n"` with `"\n"` rather than `'\n'`.
2018-03-02 22:00:01 +07:00
Karim Snj 7d35fab304 lint: while loop: detect if no var from the condition is mutated 2018-03-02 00:01:08 +01:00
Karim Snj 37eca59438 lint: while immutable condition: refactor to use hir::Visitor 2018-03-01 22:00:43 +01:00
Martin Carton cb43feb4cc
Merge pull request #2495 from alexheretic/fix-2494
Fix #2494 add suggestion for unreadable_literal
2018-03-01 19:26:28 +01:00
Alex Butler 42000c6cf9
Fix #2494 add suggestion for unreadable_literal
Add `rustc --explain E0308` line to relevant tests
2018-03-01 15:26:39 +00:00
bootandy 9a002e52e5 Lint passing Cow by reference
Add lint for reference to Cow to the same place in the code where
lint for reference to String lives.

https://github.com/rust-lang-nursery/rust-clippy/issues/2405
2018-02-28 10:24:10 -05:00
Manish Goregaokar adb8f7ee4b
Merge pull request #2486 from ordovicia/fix
Fix for rustc 1.26.0-nightly (322d7f7b9 2018-02-25)
2018-02-26 12:33:45 -08:00
Manish Goregaokar 539b4b61ec Bump to 0.0.187 2018-02-26 12:32:18 -08:00
Manish Goregaokar a512fb265b oops 2018-02-26 12:31:29 -08:00
Manish Goregaokar b432f60afe
Merge pull request #2489 from rust-lang-nursery/rustup
Rustup to rustc 1.26.0-nightly (322d7f7b9 2018-02-25)
2018-02-26 12:26:35 -08:00
Manish Goregaokar 167d978372 Rustup to rustc 1.26.0-nightly (322d7f7b9 2018-02-25) 2018-02-26 11:57:14 -08:00
Hidehito Yabuuchi 0411843170 Fix for rustc 1.26.0-nightly (322d7f7b9 2018-02-25) 2018-02-26 18:01:10 +09:00
Karim Snj 5c1be4a4ba lint: immutable only vars in while condition 2018-02-25 18:25:31 +01:00
Oliver Schneider 6097b8240b
Merge pull request #2479 from gnieto/fix/authorLint
Fix author lint
2018-02-24 22:06:25 +01:00
Guillem Nieto 3ac84b2542 Remove explicit visit_qpath method
Instead of replacing the default behaviour of the visit_qpath method,
I've moved the printing code to private method of PrintVisitor
(print_qpath).
2018-02-24 19:34:51 +01:00
Guillem Nieto 8494f57c82 Fix author lint
The author lint was generating invalid code as shown on issue:
https://github.com/rust-lang-nursery/rust-clippy/issues/2442

I've changed the generated code to properly track cast
expressions.

Unfortunatelly, I've had to rewrite the `visit_decl` method, to
avoid that last if of the chain will be added. After looking at the code,
this last line was being added because of the `let x: char` part, but not
because of the `0x45df as char` expression.

It seems that let statements should not generate code on the author
lint, but I'm not sure that this is true or if I'm breaking
something on other code generation parts.

Finally, I've added a test for the author lint, but I'm not sure that
this needs to be added to the testsuite.
2018-02-24 02:19:47 +01:00
Manish Goregaokar d5e233a720 Merge branch 'rustup' 2018-02-23 09:03:18 -08:00
Manish Goregaokar f69fcc08d2 Update Rust to 063deba92e 2018-02-23 09:01:26 -08:00
Oliver Schneider 575c3c4b54
Merge pull request #2471 from bootandy/fix_span2
Fix: point to correct problem part of code, update test
2018-02-23 08:31:57 +01:00
bootandy aef07e3392 Do not pass Span by reference 2018-02-22 10:11:20 -05:00
Oliver Schneider 5e6342d4ae
Merge pull request #2473 from phansch/handle_multiline_attributes
Lint multiline attributes properly
2018-02-21 21:44:04 +01:00
Philipp Hansch d3d3d7d7be
Lint multiline attributes properly
This makes it so that the `empty_line_after_outer_attribute` lint only
checks for newlines between the end of the attribute and the beginning
of the following item.

We need to check for the empty line count being bigger than 2 because
now the snippet of valid code contains only `\n` and splitting it
produces `["", ""]`
Invalid code will contain more than 2 empty strings.
2018-02-21 21:29:05 +01:00
bootandy a7c97256dc Stop unwanted newlines being applied on unwrap_or 2018-02-21 11:29:08 -05:00
bootandy c708154c16 Simplify creation of span_replace_word
Part of unwrap_or test
2018-02-20 12:38:20 -05:00
bootandy f3d1a0cec2 Add newlines in unwrap_or ui test 2018-02-20 12:37:30 -05:00
Oliver Schneider a7407f9acc
Merge pull request #2459 from phansch/mention_how_to_run_single_test
Explain how to execute a single UI test
2018-02-20 08:33:47 +01:00
Oliver Schneider a149ec4b3c
Merge pull request #2458 from flip1995/suspicious_impl
Lint for suspicious implementations of arithmetic std::ops traits
2018-02-20 08:32:01 +01:00
Oliver Schneider e061261c48
Merge pull request #2470 from flip1995/doc_conf
Fix name of configuration parameters in documentation
2018-02-20 08:26:22 +01:00
bootandy 941e062fd4 Fix: point to correct problem part of code
Fix span so it no longer contains the whole train-wreck of code and only
points to the problem function (for the unwrap_or lint).

https://github.com/rust-lang-nursery/rust-clippy/issues/2422

Update ui test methods - it had several cases where the error message
span is now shorter
2018-02-19 12:14:53 -05:00
flip1995 339d2d5be0
Fix name of configuration parameters in documentation 2018-02-19 16:30:19 +01:00
Philipp Krones c43e053f3f
Merge branch 'master' into suspicious_impl 2018-02-19 13:04:14 +01:00
Oliver Schneider 038b17f3a6
Merge pull request #2451 from TomasKralCZ/rdn-fields
Implement redundant field names lint #2244
2018-02-19 09:56:55 +01:00
Philipp Hansch 0b4e0b82a9
Explain how to execute a single UI test 2018-02-13 22:33:42 +01:00
flip1995 aa20277a17 Lint for suspicious implementations of arithmetic std::ops traits 2018-02-13 15:40:17 +01:00
TomasKralCZ 42120141bd Suggestion fixed, simplified lint logic. 2018-02-12 11:26:00 +01:00
TomasKralCZ 85642ddd23 Implement redundant field names lint #2244 2018-02-10 22:52:31 +01:00
Oliver Schneider 6b3487a916
Merge pull request #2448 from rust-lang-nursery/fixes
Fixes
2018-02-09 18:32:23 +01:00
Oliver Schneider 6feb0dd982
Fixes #2426 (if_same_then_else false positive) 2018-02-09 15:31:55 +01:00
Oliver Schneider ff32d5f734
Fix #2427 2018-02-09 15:25:12 +01:00