Commit Graph

3792 Commits

Author SHA1 Message Date
Yusuf Simonson 7de706b34b Lint for multiple versions of dependencies 2018-04-30 06:20:39 +07:00
Oliver Schneider 1742229ebb
Merge pull request #2703 from phansch/rustup20180427
Rustup to latest nightly
2018-04-28 13:10:59 +02:00
Philipp Hansch 1712e18b77
Rustup to latest nightly
Due to https://github.com/rust-lang/rust/pull/48995 and
https://github.com/rust-lang/rust/pull/49894
2018-04-28 12:56:31 +02:00
Oliver Schneider d45612e606
Merge pull request #2696 from nathan/patch-1
Fix rustfmt-induced missing line comments in examples
2018-04-27 23:43:57 +02:00
Oliver Schneider ad899fe00a
Merge pull request #2697 from phansch/add_contributing_toc
Add TOC to contribution instructions
2018-04-27 23:38:29 +02:00
Philipp Hansch 6f47cb1102
Add TOC to contribution instructions
Also changed some headings and re-ordered the paragraphs in the testing
guide.

(I used [vim-markdown-toc](https://github.com/mzlogin/vim-markdown-toc) to
generate it automatically.)
2018-04-27 22:12:09 +02:00
Oliver Schneider 7de3a1d392
Merge pull request #2699 from mati865/rustup
rustup
2018-04-27 22:09:52 +02:00
Mateusz Mikuła cc7d66aa9c rustup 2018-04-27 14:00:43 +02:00
Nathan c9c649b315
Remove extraneous `'s in {wrong,crosspointer}_transmute examples 2018-04-27 02:43:16 -04:00
Nathan 78b141d937
Fix missing line comments in {drop,forget}_copy examples 2018-04-27 02:40:19 -04:00
Nathan 7f0f8acb42
Fix missing line comment in drop_ref example 2018-04-27 02:39:14 -04:00
Nathan 8ad5cb6170
Fix missing line comment in crosspointer_transmute example 2018-04-27 02:37:40 -04:00
Nathan f327f26113
Fix missing line comment in doc_markdown example
rustfmt [wrapped the line](b25b6b3355 (diff-561823671726302d969756ded53a13a7L22)), so we need a second `///`
2018-04-27 02:31:36 -04:00
Oliver Schneider 3b6440212d
Merge pull request #2673 from estk/excessive_precision
Excessive precision
2018-04-25 18:37:42 +02:00
Oliver Schneider 84385833d0
Merge pull request #2679 from devonhollowood/cast-alignment-cvoid
Make cast_ptr_alignment ignore c_void
2018-04-25 09:32:31 +02:00
Oliver Schneider 9a375668b4
Merge pull request #2687 from phansch/explain_how_lints_work
Explain how Clippy and lints work
2018-04-25 09:32:06 +02:00
Evan Simmons 9b14ad493b New excessive precision lint for floats 2018-04-24 15:18:23 -07:00
Philipp Hansch 36233789d4
Mention util/update_lints.py 2018-04-24 21:04:43 +02:00
Devon Hollowood f0e09d43c9 Make cast_ptr_alignment ignore c_void 2018-04-24 11:37:51 -07:00
Oliver Schneider faefb4f225
Merge pull request #2684 from 17cupsofcoffee/infallible-destructuring-match
Lint for destructuring tuple structs/variants with an infallible single-armed match
2018-04-24 19:08:27 +02:00
Joe Clay 3c38a36d5a Implement lint for destructuring tuple structs with a let and a match (closes #2671) 2018-04-24 17:56:13 +01:00
Oliver Schneider 841e467ec2
Merge pull request #2694 from humanenginuity/master
Fix for https://github.com/rust-lang-nursery/rust-clippy/issues/2693
2018-04-24 10:00:15 +02:00
Brad Gibson efdd00d2ae
Merge pull request #1 from humanenginuity/fix-strictly-aligned-types-cast-messages
Corrected messaging to warn against less- to more-strictly aligned
2018-04-23 11:03:27 -07:00
Brad Gibson 1969d423a7 Corrected messaging to warn against less- to more-strictly align types, rather than the other way around. No logic changes required. 2018-04-23 10:59:53 -07:00
Oliver Schneider 79e818267b
Merge pull request #2690 from mrecachinas/feature/print-string-literal
Fix alignment/precision/width false positives for print/write_literal
2018-04-23 10:36:48 +02:00
Michael Recachinas a317bc9d23 Update stderrs for print and write_literal 2018-04-21 19:51:58 +01:00
Michael Recachinas 54c0edcfe8 Add smaller check_unformatted to write.rs and fix precision,width,align false positive 2018-04-21 19:51:58 +01:00
Michael Recachinas 8ccaa83e90 Add more tests to print_ and write_literal
Also, move precision, width, and debug fmt tests to 'should pass'
2018-04-21 19:51:35 +01:00
Philipp Hansch 5bfb306b4b
Explain how Clippy works 2018-04-21 11:53:15 +02:00
Oliver Schneider c5b39a5917
Version bump 2018-04-19 08:36:22 +02:00
Oliver Schneider 475959d905
Merge pull request #2681 from phansch/fix_latest_nightly_breakage
Fix latest nightly breakage
2018-04-19 08:28:10 +02:00
Oliver Schneider f84cc2cc36
Merge pull request #2683 from rust-lang-nursery/rustup
Rustup
2018-04-19 06:46:41 +02:00
Philipp Hansch a854874e6a
Fix latest nightly breakage
I'm not sure if there are better ways to use the RwLock API, though. But
it seems to work.
2018-04-18 20:25:43 +02:00
Philipp Hansch 0c665f4a31
Merge pull request #2675 from phansch/mention_irc_in_contributing_md
Add intro and mention IRC in CONTRIBUTING.md
2018-04-17 22:26:01 +02:00
Oliver Schneider f786a36949
Rustup 2018-04-17 10:52:25 +02:00
Philipp Hansch fe426b7c51
Add intro and mention IRC in CONTRIBUTING.md
This is partly taken from the [rustfmt CONTRIBUTING.md][contrib].

[contrib]: https://github.com/rust-lang-nursery/rustfmt/blob/master/Contributing.md
2018-04-17 08:33:22 +02:00
Oliver Schneider ae3213747d
Merge pull request #1467 from philipturnbull/option_map_nil_fn
Lint `Option.map(f)` where f returns unit
2018-04-15 16:14:25 +02:00
Philipp Hansch 26b9911e07
Refactor out enum and address nits 2018-04-15 15:37:11 +02:00
Oliver Schneider 9dc9487567
Version bump 2018-04-15 15:01:48 +02:00
Oliver Schneider 486dc5c070
Merge pull request #2650 from thekidxp/fixEmptyPrintln
fixEmptyPrintln
2018-04-15 14:30:45 +02:00
MSI\Stew's Laptop d175c797e5
fixing error message for empty println macro 2018-04-15 14:00:28 +02:00
Philipp Hansch 4f4e20c561
Also lint Result.map for unit returns 2018-04-15 13:59:57 +02:00
Philipp Hansch 8307a899e9
Rename option_map_unit_fn to map_unit_fn 2018-04-15 13:01:10 +02:00
Philipp Hansch d54f70f1f6
Generate let binding variable name for some cases
Given a map call like `x.field.map ...` the suggestion will contain:
`if let Some(x_field) ...`

Given a map call like `x.map ...` the suggestion will contain:
`if let Some(_x) ...`

Otherwise it will suggest: `if let Some(_) ...`
2018-04-15 13:01:10 +02:00
Philipp Hansch d87385b406
Use approximate_suggestion for non-reducible closures 2018-04-15 13:01:10 +02:00
Philipp Hansch 7de707fdba
Remove further semicolon reduction 2018-04-15 13:01:10 +02:00
Philipp Hansch db60c67c5b
Allow new lint in ui/eta.rs 2018-04-15 13:01:09 +02:00
Philipp Hansch bcc335fc9c
Move test to new UI test system 2018-04-15 13:01:09 +02:00
Philipp Hansch a3ff21f4d6
Rename lint to option_map_unit_fn
Rust does not have nil.
2018-04-15 13:01:09 +02:00
Philipp Hansch fbd71f901f
Use declare_clippy_lint and 'complexity' category 2018-04-15 13:01:09 +02:00