Commit Graph

3999 Commits

Author SHA1 Message Date
Oliver Schneider 7d672888fe Version bump 2018-06-19 09:56:37 +02:00
Oliver Schneider d3b862f9d7 Bump min_version.txt 2018-06-18 10:48:24 +02:00
Oliver Schneider 1a6ae4e396
Merge pull request #2851 from mati865/master
Version bump
2018-06-18 01:43:42 -07:00
Mateusz Mikuła 8625cfb988 Version bump 2018-06-18 09:56:58 +02:00
Oliver Schneider 45bab501e1 Fix typo in lint dump script 2018-06-15 17:45:52 +02:00
Philipp Krones 3d3d3732c0
Merge pull request #2803 from Nemo157/trivially_copy_pass_by_ref
New Lint: Pass small trivially copyable objects by value
2018-06-15 17:44:44 +02:00
Wim Looman 621fdcc3bc Dogfood new trivially_copy_pass_by_ref lint 2018-06-15 16:53:34 +02:00
Wim Looman 700ece5648 Allow configuring the trivial copy size limit 2018-06-15 16:53:34 +02:00
Wim Looman 7547a4ddef New Lint: Pass small trivially copyable objects by value
Fixes #1680

Hardcoded for 64-bit "trivial" size for now
2018-06-15 16:53:34 +02:00
Manish Goregaokar 0c23112846 More doc fixes 2018-06-15 00:20:46 -07:00
Manish Goregaokar 00a0efc566 Doc fix syntax 2018-06-15 00:19:19 -07:00
Oliver Schneider e38c109ae7 Lint printing was broken 2018-06-14 22:50:07 +02:00
Oliver Schneider 26bc88d48c
Merge pull request #2839 from mikerite/duration_subsec_pr_2
Add duration_subsec lint
2018-06-12 06:30:20 -07:00
Michael Wright 725e9621d0 duration_subsec: Add check for `subsec_micros` 2018-06-12 08:25:10 +02:00
Oliver Schneider 8f0edba6e9
Merge pull request #2815 from darArch/master
Warn if non-trivial work is done inside .expect
2018-06-11 06:33:26 -07:00
Donald Robertson c6fb47331a Updating docs to reflect more recent changes to expect_fun_call lint 2018-06-11 14:17:40 +01:00
Michael Wright 2d427ea7ee Merge branch 'master' into duration_subsec_pr_2 2018-06-11 07:48:10 +02:00
Oliver Schneider 8fe90e41d0 Publish preparation 2018-06-10 06:22:07 +02:00
Michael Wright b0d364cb3e duration_subsec: fix declaration; correctly classify 2018-06-09 11:04:21 +02:00
Michael Wright 7b2fa2077f Add duration_subsec lint
Closes #2543
2018-06-09 10:21:26 +02:00
Oliver Schneider 91986fa933
Merge pull request #2836 from mati865/upcoming_breakage
Upcoming breakage
2018-06-09 06:56:39 +02:00
Oliver Schneider d68b8cea15
Merge pull request #2811 from fanzier/checked_unwrap
Implement lint that checks for unidiomatic unwrap() (closes #1770)
2018-06-08 07:15:02 +02:00
Fabian Zaiser 54826cf72e Address review comments. 2018-06-08 06:02:25 +02:00
Fabian Zaiser 81821acd59 Implement lint that checks for unidiomatic `unwrap()` (fixes #1770)
This checks for things like

    if x.is_some() {
        x.unwrap()
    }

which should be written using `if let` or `match` instead.

In the process I moved some logic to determine which variables are
mutated in an expression to utils/usage.rs.
2018-06-08 05:29:25 +02:00
Mateusz Mikuła b45fb35ec4 Cleanup of driver code 2018-06-07 22:13:24 +02:00
Mateusz Mikuła 3693a4ea53 Formatting 2018-06-07 22:01:46 +02:00
Philipp Hansch d0620ae4eb
Merge pull request #2835 from FauxFaux/patch-1
Tiny typo in rust-update script
2018-06-07 20:00:45 +02:00
Mateusz Mikuła 52deb3b086 Prepare for upcoming breakage 2018-06-07 19:16:41 +02:00
Chris West e3fd348cd4
Tiny typo in rust-update script 2018-06-07 17:47:11 +01:00
Oliver Schneider 2a2e602f2a
Merge pull request #2833 from phansch/cannot_relate_bound_region_without_ICE_cream
Fix cargo late bound region mismatch ICE
2018-06-07 11:52:32 +02:00
Philipp Hansch 17aff1d774
Fix cargo late bound region mismatch ICE 2018-06-07 07:42:45 +02:00
Donald Robertson e70632215e Combining if statements per lint warnings on build 2018-06-06 20:38:13 +01:00
Donald Robertson 9c73f7ff18 Amending use of Some with discarded value to use is_some 2018-06-06 17:13:31 +01:00
Donald Robertson e67d2b2663 Added check to ensure format macro only being handled, refactored extraction and checks to smaller functions. 2018-06-06 16:53:11 +01:00
Oliver Schneider 7563d8155b
Merge pull request #2804 from utaal/expr-call-author
Add support for ExprCall in clippy::author
2018-06-06 15:17:47 +02:00
Donald Robertson 451fd5feb9 Extracting arguments to format to pass directly to panic when appropriate 2018-06-05 21:15:08 +01:00
Oliver Schneider 1e1b4e26ea
Merge pull request #2814 from VKlayd/fn_to_int
WIP: Add lint on cast Fn to all numerical except usize.
2018-06-05 17:08:33 +02:00
Donald Robertson 32404741c6 Replacing match block with if block as conditional was boolean 2018-06-04 19:43:03 +01:00
Donald Robertson 1ead12c500 Adding handling and tests for custom type with implemented expect method 2018-06-04 19:43:03 +01:00
Donald Robertson fe8c9d5965 Ensuring correct lint message is output for Option and Result type 2018-06-04 19:43:03 +01:00
Donald Robertson 2b36017bad Removing unnecessary allow 2018-06-04 19:43:03 +01:00
Donald Robertson 05c1ccebaf Warn if non-trivial work is done inside .expect
- added tests for common usages of format and as_str arguments to expect
- added tests for usages of Option and Result types
- given performance impact of passing non literal expressions to expect, added to perf group
2018-06-04 19:43:03 +01:00
Oliver Schneider 3d7cdd4ac5
Merge pull request #2827 from 0ndorio/lint/cmp_operators_on_partial_cmp
Added lint to avoid negated comparisions on partially ordered types. (fixes #2626)
2018-06-03 23:23:59 +02:00
Bruno Kirschner 28f735bb26 Cleaned implements_ord helper function in boolean lint file. 2018-06-03 22:56:17 +02:00
Bruno Kirschner 80728a2201 Reduced scope of `nonminimal_bool` so that it doesn't evaluate only partially orded types. 2018-06-03 21:46:09 +02:00
Bruno Kirschner 09ea75bee9 Fixed spelling and indentation issues in neg_cmp_op_on_partial_ord related files. 2018-06-03 21:46:09 +02:00
Bruno Kirschner 86304d8dde Use declare_clippy_lint instead of declare_lint. 2018-06-03 21:46:09 +02:00
Bruno Kirschner 6d51559f62 Added lint to avoid negated comparisions on partially ordered types. 2018-06-03 21:46:09 +02:00
Oliver Schneider c6d53ad2c0
Merge pull request #2813 from terry90/master
unreadable_literal: Fills hexadecimal values with 0 to allow better grouping
2018-06-03 12:53:45 +02:00
Terry Raimondo 2c1451817c Compute digits vec only once 2018-06-03 12:26:50 +02:00