Commit Graph

3891 Commits

Author SHA1 Message Date
Philipp Hansch 991a30237a
Make it compile again 2018-04-15 13:01:09 +02:00
Phil Turnbull d0bdfe5ce3
Handle non-trivial nil closures
`reduce_nil_closure` mixed together a) 'is this a nil closure?' and b) 'can it
be reduced to a simple expression?'. Split the logic into two functions so we
can still generate a basic warning when the closure can't be simplified.
2018-04-15 13:01:09 +02:00
Phil Turnbull 2f52d1d568
Return Spans instead of Cow<&str>'s 2018-04-15 13:01:09 +02:00
Phil Turnbull 30f2480fd8
Lint closures that return nil 2018-04-15 13:01:09 +02:00
Phil Turnbull 302f5d05f5
Lint `Option.map(f)` where f never returns 2018-04-15 13:01:09 +02:00
Phil Turnbull e5ecbb55ee
Lint `Option.map(f)` where f returns nil 2018-04-15 13:01:09 +02:00
Oliver Schneider b2e4b88d18
Merge pull request #2662 from mikerite/issue_2546
Fix useless_format false negative
2018-04-15 11:57:57 +02:00
Oliver Schneider cefb7b0f58
Merge pull request #2670 from mikerite/fix_compilation_20180415
Fix compilation for nightly 2018-04-15
2018-04-15 11:57:01 +02:00
Michael Wright d171e8987e Fix clippy error 2018-04-15 05:20:30 +02:00
Michael Wright a9c8d1bd90 Fix compilation for nightly 2018-04-15
This only fixes compilation and the build. It's possible that the `author`
and `inspector` lints are broken but there are no failing tests.

Closes #2667
2018-04-15 05:01:43 +02:00
Oliver Schneider fc8e35884b
Merge pull request #2669 from senden9/patch-1
Fix Markdown link syntax in lint doc
2018-04-14 12:18:18 +02:00
Stefano Probst 01faa906d2
Fix Markdown link syntax in lint doc
Currently this link is wrong rendered. See https://rust-lang-nursery.github.io/rust-clippy/v0.0.193/index.html#iter_next_loop
2018-04-14 11:35:52 +02:00
Philipp Hansch 8c9ed704c6
Merge pull request #2668 from phansch/run_remark_on_all_markdown_files
Run remark-lint on all markdown files in root
2018-04-13 21:09:07 +02:00
Philipp Hansch 0995e923f0
Run remark-lint on all markdown files in root 2018-04-13 20:54:42 +02:00
Philipp Hansch a936b6d95d
Merge pull request #2664 from phansch/move_unnecessary_fold_ui_tests
Move unnecessary_fold UI tests to separate file
2018-04-12 22:32:45 +02:00
Philipp Hansch dfde407f0d
Move unnecessary_fold UI tests to separate file 2018-04-12 22:16:43 +02:00
Michael Wright c7ad71ccf2 Fix clippy warnings 2018-04-12 08:50:42 +02:00
Michael Wright 6ae617b313 Fix useless_format false negative
Closes #2546
2018-04-12 08:21:03 +02:00
Oliver Schneider 8ec61a613a
Merge pull request #2661 from devonhollowood/ptr-ptr-casts
Replace `misaligned_transmute` lint
2018-04-11 13:23:15 +02:00
Devon Hollowood b77d74030b Deprecate misaligned_transmute 2018-04-11 02:50:04 -07:00
Devon Hollowood c6bc682325 Fix misaligned_transmute lint
This is done by adding two new lints: cast_ptr_alignment and
transmute_ptr_to_ptr. These will replace misaligned_transmute.
2018-04-11 02:17:59 -07:00
Oliver Schneider c5f31077e8
Merge pull request #2660 from phansch/fix_travis
Fix travis.yml
2018-04-11 09:06:24 +02:00
Philipp Hansch d8cf11cdf2
Fix travis.yml
For some reason #2659 was an invalid .travis.yml and this reverts that
part of the commit that changes the .travis.yml.

It resulted in travis not starting jobs. There should be a travis build
again for this PR.
2018-04-11 08:47:40 +02:00
Philipp Hansch 498d862062
Merge pull request #2659 from phansch/debug_deployment_issues
Debug deployment script issues
2018-04-11 08:40:42 +02:00
Philipp Hansch bdba9c14e7
Add set -x for debugging 2018-04-11 08:23:02 +02:00
Philipp Hansch 8fbeaa81d8
Debug deployment script issues
This prints some more information during the docs deployment.
2018-04-11 08:13:59 +02:00
Oliver Schneider c067bc3cd0
Merge pull request #2655 from rust-lang-nursery/oli-obk-patch-1
Explain nursery lints
2018-04-10 19:44:43 +02:00
Oliver Schneider ba1be0d53b
Explain nursery lints
fixes #2652
2018-04-10 13:50:44 +02:00
Oliver Schneider 94e897851b
Merge pull request #2654 from killercup/feature/lint-groups-in-docs
Show/Filter by lint groups in docs
2018-04-10 13:09:27 +02:00
Pascal Hertleif c43a8921bb Docs: Reorganize layout a bit and show lint groups 2018-04-10 12:25:53 +02:00
Pascal Hertleif b46a3e5324 Add lint groups to doc export 2018-04-10 12:23:41 +02:00
Oliver Schneider 4015395888
Version bump 2018-04-08 11:13:46 +02:00
Oliver Schneider 0692b2bb92
Temporarily disable the needless_borrow lint 2018-04-08 11:13:46 +02:00
Oliver Schneider d247d9c690
Merge pull request #2645 from TimNN/regex-bytes-utf8
Allow invalid UTF-8 in bytes Regexes
2018-04-08 08:58:38 +02:00
Oliver Schneider a1486af7c1
Merge pull request #2630 from estk/fix-2613
Add rules for write!() / writeln!() similar to those in print!() / println!()
2018-04-08 08:57:24 +02:00
Evan Simmons d712991917 New lints for write! / writeln! macros. 2018-04-07 22:45:26 -07:00
Tim Neumann fad826f966 allow invalid UTF-8 in bytes Regexes 2018-04-07 22:18:51 +02:00
Oliver Schneider 22df45f1ac
Merge pull request #2644 from phansch/fix_nonminimal_bool_false_positive
Fix nonminimal_bool false positive
2018-04-07 13:17:04 +02:00
Philipp Hansch 90e7d93d6c
Fix nonminimal_bool false positive
It was checking any is_ok, is_err, is_some, is_none method for negation
but it should only perform the check for the built-in types, not custom
types.
2018-04-07 12:52:59 +02:00
Oliver Schneider 1ce5ec8d13
Merge pull request #2643 from phansch/split_up_match_bool_ui_tests
Split up match_bool UI tests
2018-04-07 10:40:40 +02:00
Philipp Hansch 5abe34832d
Split up match_bool UI tests 2018-04-07 10:23:27 +02:00
Oliver Schneider fbb5050d82
Merge pull request #2641 from rcoh/patch-2
Update hash_xor_eq docs to match behavior
2018-04-07 09:42:54 +02:00
Oliver Schneider a863ba16e1
Merge pull request #2640 from mikerite/fix_compilation_20180406
Fix compilation for nightly 2018-04-06
2018-04-07 09:42:26 +02:00
Russell Cohen 4b3326efd0
Fix docs to match behavior 2018-04-06 22:44:25 -07:00
Michael Wright fe8068c41b Fix compilation for nightly 2018-04-06
Breakages for introduced by rust pull request
'AST: Give spans to all identifies' - rust-lang/rust/pull#49154

Closes #2639
2018-04-07 07:32:30 +02:00
Oliver Schneider 044b3d90c3
Merge pull request #2633 from mikerite/ref_cow_tests
Move ref cow tests
2018-04-06 12:15:33 +02:00
Oliver Schneider 71a15bf264
Merge pull request #2635 from phansch/split_up_some_match_ui_tests
Split up some single_match UI tests
2018-04-06 12:13:38 +02:00
Philipp Hansch 641f0685d0
Split up some single_match UI tests
This moves only the single_match tests over to the new file.
2018-04-05 22:45:36 +02:00
Michael Wright 2fd671e4bd Move ref cow tests
This commit moves the ref cow tests from needless_borrow.rs to ptr_arg.rs
where all the other PTR_ARG tests are.
2018-04-05 18:13:39 +02:00
Oliver Schneider 62d595b3dc
Merge pull request #2632 from phansch/fix_useless_format_false_positive
Fix useless_format false positive with macros
2018-04-05 09:59:12 +02:00