Commit Graph

44 Commits

Author SHA1 Message Date
beetrees 6f13a37499
Add spans to `clippy.toml` error messages 2023-06-02 00:56:27 +01:00
bors a7335cbf90 Auto merge of #10712 - blyxyas:fix-fixflag_implies_all_targets, r=llogiq
Document that `cargo clippy --fix` implies `--all-targets`

In [`cargo fix`'s documentation](https://doc.rust-lang.org/cargo/commands/cargo-fix.html) they indicate that `fix` implies `--all-targets` if no target is supplied. As Clippy uses Cargo under the hood, this also applies to Clippy, but we didn't document that behaviour.

This PR changes that

Fixes #10690
changelog: Add to documentation that `--fix` implies `--all-targets`
2023-04-25 17:11:52 +00:00
blyxyas 4a76b6f04f
Add the warning to all documentation. 2023-04-25 02:05:32 +02:00
Josh Soref d2061faf9e Spelling
* applying
* binding
* complex
* constituent
* demonstrate
* desugaring
* exact
* expression
* for
* functionalities
* github
* implementation
* infers
* multiple conflicting traits
* mutable
* necessarily
* nightly
* nonexistent
* optional
* parameter
* reassignments
* resources
* substitution
* suggestion
* that
* that array is
* using the

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2023-04-23 10:52:27 -04:00
Yuri Astrakhan 41b367fa5f Gramar, and spelin kleanup
A few minor cleanups in various markdown files, mostly focusing on spelling and ignoring non-compilable codeblocks.
2023-03-30 15:31:14 -04:00
bors a45f71265c Auto merge of #10458 - samueltardieu:multithreading-lintcheck, r=llogiq
lintcheck: use multithreading unless --fix or --recursive is used

Use multithreading unless there is a reason not to.

changelog: none
2023-03-09 17:01:20 +00:00
Samuel Tardieu a701af45cb lintcheck: use multithreading unless --fix or --recursive is used 2023-03-08 22:29:57 +01:00
Samuel "Sam" Tardieu ce3415e87b Add the `popular-crates` binary
This program downloads crates info from https://crates.io/ and builds
a TOML file that can be fed to `lintcheck`.
2023-03-08 09:43:28 +01:00
Samuel Tardieu 79829d8718 lintcheck: use clap's derive interface
This makes the code shorter and clearer.

The only incompatible change is that an explicit command-line argument
`--crates-toml=` will take precedence over the `LINTCHECK_TOML`
environment variable.
2023-03-04 23:17:27 +01:00
Samuel Tardieu 446ae429a6 lintcheck: fix parallel processing handling
Using `rayon::current_num_threads()` causes a bug:

```
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value:
  ThreadPoolBuildError { kind: GlobalPoolAlreadyInitialized }',
  src/main.rs:632:10
```

Moreover, using the number of threads and dividing it by 2 wouldn't
return the number of physical threads on modern processors which have
a varying number of threads per core.

It makes little sense to restrict ourselves to physical threads,
especially when, in modern architectures, cores with multiple threads
are often faster (performance) while cores with a unique threads are
often slower (efficient). The Rust runtime will make a better choice.
2023-03-04 17:29:58 +01:00
Jirka Vebr 0b1ae20365
Fix dogfood tests by adding type annotations 2023-02-16 13:29:38 +01:00
Samuel Tardieu aeaa1cc342 lintcheck: fix clap panic 2023-02-12 14:54:14 +01:00
KaDiWa ef2596155d
update some dependencies 2023-01-31 23:31:12 +01:00
kraktus 2fd10bc59b dogfood with expanded `uninlined_format_args` 2022-11-25 16:49:05 +01:00
Alex Macleod bd8369089c Track `clippy.toml` and `Cargo.toml` in `file_depinfo`
Causes cargo to re-run clippy when those paths are modified

Also tracks the path to `clippy-driver` in debug mode to remove the
workarounds in `cargo dev lint` and `lintcheck`
2022-10-25 11:32:49 +00:00
Alex Macleod ff893366c1 Mark `let_underscore_drop` as uplifted 2022-10-23 14:06:51 +00:00
Samuel Moelius bbee1c9d1f Apply manual fixes 2022-10-22 07:42:41 -04:00
Samuel Moelius e38bb1a963 Apply `--fix` fixes 2022-10-22 07:42:35 -04:00
Samuel Moelius 9cc8da222b Fix adjacent code 2022-10-07 05:07:44 -04:00
Alex Macleod fc77d91469 Add `cargo lintcheck --recursive` to check dependencies of crates 2022-09-24 12:01:08 +00:00
Alex Macleod 2c5524f835 Update cargo in lintcheck_crates.toml 2022-09-08 15:29:26 +00:00
Takayuki Nakata 7fbaf8113b Fix the minimal version for `clap` 2022-07-14 09:46:46 +09:00
alex-semenyuk 9015884325 Fix small mistakes 2022-07-09 13:00:24 +03:00
Jason Newcomb cccc750046 Fix `clap` deprecation warnings 2022-06-13 21:57:17 -04:00
Marcel Hellwig 9b55ea78c8 update dependencies 2022-05-23 09:28:49 +02:00
Alex Macleod 8708a261a1 Some lintcheck cleanup 2022-05-12 13:46:58 +01:00
Matthias Krüger 5b35bd9c3e lintcheck: fix --fix
looks like --allow-no-vcs does no longer exist(?)
2022-04-16 00:56:28 +02:00
whodi 73b7cb9c49 shound -> should 2022-04-15 14:19:01 -07:00
Peter Jaszkowiak 67badbeef6 New lint `format_add_strings` 2022-04-13 22:48:36 -06:00
bors 938b4c321b Auto merge of #92740 - cuviper:update-rayons, r=Mark-Simulacrum
Update rayon and rustc-rayon

This updates rayon for various tools and rustc-rayon for the compiler's parallel mode.

- rayon v1.3.1 -> v1.5.1
- rayon-core v1.7.1 -> v1.9.1
- rustc-rayon v0.3.1 -> v0.3.2
- rustc-rayon-core v0.3.1 -> v0.3.2

... and indirectly, this updates all of crossbeam-* to their latest versions.

Fixes #92677 by removing crossbeam-queue, but there's still a lingering question about how tidy discovers "runtime" dependencies. None of this is truly in the standard library's dependency tree at all.
2022-01-16 08:12:23 +00:00
flip1995 fb0142ae41 Merge commit '97a5daa65908e59744e2bc625b14849352231c75' into clippyup 2022-01-13 13:18:19 +01:00
Josh Stone 8f9b158df3 Update rayon and rustc-rayon 2022-01-10 11:34:07 -08:00
flip1995 ece0946d7f Merge commit '23d11428de3e973b34a5090a78d62887f821c90e' into clippyup 2021-12-17 13:40:22 +01:00
flip1995 8fea1d94f3 Merge commit 'a5d597637dcb78dc73f93561ce474f23d4177c35' into clippyup 2021-12-06 12:33:31 +01:00
flip1995 23d5457e6d Merge commit 'cb7915b00c235e9b5861564f3be78dba330980ee' into clippyup 2021-09-28 18:03:12 +01:00
Samuel E. Moelius III 43ed2065cc Update dependencies 2021-09-09 07:47:16 -04:00
flip1995 091ed44b50 Merge commit '27afd6ade4bb1123a8bf82001629b69d23d62aff' into clippyup 2021-09-08 16:31:47 +02:00
Jade 6c2199ea9f rfc3052: Remove authors field from Cargo manifests
Since RFC 3052 soft deprecated the authors field anyway, hiding it from
crates.io, docs.rs, and making Cargo not add it by default, and it is
not generally up to date/useful information, we should remove it from
crates in this repo.
2021-07-29 14:56:05 -07:00
flip1995 ebe52869a3 Merge commit '61eb38aeda6cb54b93b872bf503d70084c4d621c' into clippyup 2021-07-01 18:17:38 +02:00
Alexander Melentyev dab42cff02 Delete spaces 2021-06-21 12:11:37 +03:00
flip1995 ae72f1adb9 Merge commit '7c7683c8efe447b251d6c5ca6cce51233060f6e8' into clippyup 2021-04-27 16:55:11 +02:00
flip1995 02bf692169 Merge commit '98e2b9f25b6db4b2680a3d388456d9f95cb28344' into clippyup 2021-04-22 11:31:13 +02:00
flip1995 f6d1f368db Merge commit 'b40ea209e7f14c8193ddfc98143967b6a2f4f5c9' into clippyup 2021-04-08 17:50:13 +02:00
flip1995 f2f2a005b4 Merge commit '6ed6f1e6a1a8f414ba7e6d9b8222e7e5a1686e42' into clippyup 2021-03-12 15:30:50 +01:00