dnrops
/
rust-clippy
mirror of https://github.com/rust-lang/rust-clippy.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

check for `_` instead

This commit is contained in:
Centri3 2023-06-06 21:01:14 -05:00
parent 143ff2dfc3
commit ba1fb74bf1
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
clippy_lints/src/let_with_type_underscore.rs
View File

@ -26,19 +26,16 @@ declare_clippy_lint! {
declare_lint_pass!(UnderscoreTyped => [LET_WITH_TYPE_UNDERSCORE]);
impl LateLintPass<'_> for UnderscoreTyped {
fn check_local<'tcx>(&mut self, cx: &LateContext<'tcx>, local: &'tcx Local<'tcx>) {
fn check_local(&mut self, cx: &LateContext<'_>, local: &Local<'_>) {
if_chain! {
if !in_external_macro(cx.tcx.sess, local.span);
if let Some(ty) = local.ty; // Ensure that it has a type defined
if let TyKind::Infer = &ty.kind; // that type is '_'
if local.span.ctxt() == ty.span.ctxt();
then {
let underscore_span = ty.span.with_lo(local.pat.span.hi());
let snippet = snippet(cx, underscore_span, ": _");
// NOTE: Using `is_from_proc_macro` on `init` will require that it's initialized,
// this doesn't. Alternatively, `WithSearchPat` can be implemented for `Ty`
if !snippet.trim().starts_with(':') && !snippet.trim().ends_with('_') {
if snippet(cx, ty.span, "_").trim() != "_" {
return;
}
@ -47,7 +44,7 @@ impl LateLintPass<'_> for UnderscoreTyped {
LET_WITH_TYPE_UNDERSCORE,
local.span,
"variable declared with type underscore",
Some(underscore_span),
Some(ty.span.with_lo(local.pat.span.hi())),
"remove the explicit type `_` declaration"
)
}