Auto merge of #10904 - lochetti:fix_10273, r=Centri3

`suspicious_else_formatting`: Don't warn if there is a comment between else and curly bracket

This PR fixes https://github.com/rust-lang/rust-clippy/issues/10273

The idea is that if the only thing after `else` and before `{` is a comment, we will not warn because, probably, the line break was "made" by rustfmt.

changelog: [`suspicious_else_formatting`]: Don't warn if the only thing between `else` and curly bracket is a comment
This commit is contained in:
bors 2023-06-08 04:18:08 +00:00
commit 9ca1344d9a
2 changed files with 13 additions and 0 deletions

View File

@ -236,6 +236,12 @@ fn check_else(cx: &EarlyContext<'_>, expr: &Expr) {
}
}
// Don't warn if the only thing inside post_else_post_eol is a comment block.
let trimmed_post_else_post_eol = post_else_post_eol.trim();
if trimmed_post_else_post_eol.starts_with("/*") && trimmed_post_else_post_eol.ends_with("*/") {
return
}
let else_desc = if is_if(else_) { "if" } else { "{..}" };
span_lint_and_note(
cx,

View File

@ -108,6 +108,13 @@ fn main() {
else
{
}
//#10273 This is fine. Don't warn
if foo() {
} else
/* whelp */
{
}
}
// #7650 - Don't lint. Proc-macro using bad spans for `if` expressions.