2019-04-16 17:04:42 +08:00
|
|
|
Thank you for making Clippy better!
|
|
|
|
|
|
|
|
We're collecting our changelog from pull request descriptions.
|
2020-11-08 23:14:38 +08:00
|
|
|
If your PR only includes internal changes, you can just write
|
|
|
|
`changelog: none`. Otherwise, please write a short comment
|
2022-07-12 17:17:30 +08:00
|
|
|
explaining your change.
|
2019-04-16 17:04:42 +08:00
|
|
|
|
2022-07-12 17:17:30 +08:00
|
|
|
It's also helpful for us that the lint name is put within backticks (`` ` ` ``),
|
|
|
|
and then encapsulated by square brackets (`[]`), for example:
|
|
|
|
```
|
|
|
|
changelog: [`lint_name`]: your change
|
|
|
|
```
|
|
|
|
|
|
|
|
If your PR fixes an issue, you can add `fixes #issue_number` into this
|
2019-04-16 17:04:42 +08:00
|
|
|
PR description. This way the issue will be automatically closed when
|
|
|
|
your PR is merged.
|
|
|
|
|
2019-04-16 19:30:46 +08:00
|
|
|
If you added a new lint, here's a checklist for things that will be
|
|
|
|
checked during review or continuous integration.
|
|
|
|
|
2020-10-15 05:26:48 +08:00
|
|
|
- \[ ] Followed [lint naming conventions][lint_naming]
|
|
|
|
- \[ ] Added passing UI tests (including committed `.stderr` file)
|
|
|
|
- \[ ] `cargo test` passes locally
|
|
|
|
- \[ ] Executed `cargo dev update_lints`
|
|
|
|
- \[ ] Added lint documentation
|
|
|
|
- \[ ] Run `cargo dev fmt`
|
2019-08-08 22:37:19 +08:00
|
|
|
|
|
|
|
[lint_naming]: https://rust-lang.github.io/rfcs/0344-conventions-galore.html#lints
|
2019-04-16 21:15:19 +08:00
|
|
|
|
|
|
|
Note that you can skip the above if you are just opening a WIP PR in
|
|
|
|
order to get feedback.
|
2019-04-16 19:30:46 +08:00
|
|
|
|
2019-10-10 01:57:57 +08:00
|
|
|
Delete this line and everything above before opening your PR.
|
|
|
|
|
|
|
|
---
|
2019-04-16 17:04:42 +08:00
|
|
|
|
2020-11-08 23:14:38 +08:00
|
|
|
*Please write a short comment explaining your change (or "none" for internal only changes)*
|
2021-04-19 22:02:41 +08:00
|
|
|
|
2020-11-08 23:14:38 +08:00
|
|
|
changelog:
|